From: K. Y. Srinivasan Date: Sat, 10 Jan 2015 07:54:33 +0000 (-0800) Subject: Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl() X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=9f52a1630922bcdab75fc72e59ed58db8e164314;p=deliverable%2Flinux.git Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl() Correctly compute the local (gpadl) handle. I would like to thank Michael Brown for seeing this bug. Signed-off-by: K. Y. Srinivasan Reported-by: Michael Brown Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index 433f72a1c006..c76ffbe59f65 100644 --- a/drivers/hv/channel.c +++ b/drivers/hv/channel.c @@ -366,8 +366,8 @@ int vmbus_establish_gpadl(struct vmbus_channel *channel, void *kbuffer, unsigned long flags; int ret = 0; - next_gpadl_handle = atomic_read(&vmbus_connection.next_gpadl_handle); - atomic_inc(&vmbus_connection.next_gpadl_handle); + next_gpadl_handle = + (atomic_inc_return(&vmbus_connection.next_gpadl_handle) - 1); ret = create_gpadl_header(kbuffer, size, &msginfo, &msgcount); if (ret)