From: Jayachandran C <jchandra@digeo.com>
Date: Thu, 27 Oct 2005 22:10:01 +0000 (-0700)
Subject: [IPV4]: Fix issue reported by Coverity in ipv4/fib_frontend.c
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=9fcc2e8a752f7d3d889114221b67c459557823e9;p=deliverable%2Flinux.git

[IPV4]: Fix issue reported by Coverity in ipv4/fib_frontend.c

fib_del_ifaddr() dereferences ifa->ifa_dev, so the code already assumes that
ifa->ifa_dev is non-NULL, the check is unnecessary.

Signed-off-by: Jayachandran C. <c.jayachandran at gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
---

diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
index e61bc7177eb1..990633c09dfe 100644
--- a/net/ipv4/fib_frontend.c
+++ b/net/ipv4/fib_frontend.c
@@ -591,7 +591,7 @@ static int fib_inetaddr_event(struct notifier_block *this, unsigned long event,
 		break;
 	case NETDEV_DOWN:
 		fib_del_ifaddr(ifa);
-		if (ifa->ifa_dev && ifa->ifa_dev->ifa_list == NULL) {
+		if (ifa->ifa_dev->ifa_list == NULL) {
 			/* Last address was deleted from this interface.
 			   Disable IP.
 			 */