From: Nicholas Bellinger Date: Tue, 6 Nov 2012 20:36:12 +0000 (-0800) Subject: target: Fix incorrect inversion of TPGS_EXPLICT_ALUA check X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=a2e85d18146857ffddea4dfe3b245055af8e3db3;p=deliverable%2Flinux.git target: Fix incorrect inversion of TPGS_EXPLICT_ALUA check Fix a bug introduced with patch "target: pass sense_reason as a return value" in for-3.8 code where only target port groups with TPGS_EXPLICT_ALUA set need to be allowed to perform explictly ALUA. Cc: Christoph Hellwig Signed-off-by: Nicholas Bellinger --- diff --git a/drivers/target/target_core_alua.c b/drivers/target/target_core_alua.c index e62dc529e516..4c8eea270d16 100644 --- a/drivers/target/target_core_alua.c +++ b/drivers/target/target_core_alua.c @@ -251,7 +251,7 @@ target_emulate_set_target_port_groups(struct se_cmd *cmd) } spin_unlock(&l_tg_pt_gp_mem->tg_pt_gp_mem_lock); - if (l_tg_pt_gp->tg_pt_gp_alua_access_type & TPGS_EXPLICT_ALUA) { + if (!(l_tg_pt_gp->tg_pt_gp_alua_access_type & TPGS_EXPLICT_ALUA)) { pr_debug("Unable to process SET_TARGET_PORT_GROUPS" " while TPGS_EXPLICT_ALUA is disabled\n"); rc = TCM_UNSUPPORTED_SCSI_OPCODE;