From: Bjorn Helgaas <bhelgaas@google.com>
Date: Fri, 17 Aug 2012 03:12:38 +0000 (-0600)
Subject: PCI: Leave normal LIST_POISON in deleted list entries
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=a7479d74460a4873b73534aa89cb82ab70ff8a32;p=deliverable%2Flinux.git

PCI: Leave normal LIST_POISON in deleted list entries

list_del() already sets next/prev to LIST_POISON1/LIST_POISON2, so we
don't need to do anything special here to prevent further list accesses.

Tested-by: Yijing Wang <wangyijing@huawei.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Yinghai Lu <yinghai@kernel.org>
---

diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c
index c01bacad9fd9..4f9ca9162895 100644
--- a/drivers/pci/remove.c
+++ b/drivers/pci/remove.c
@@ -32,11 +32,8 @@ static void pci_stop_dev(struct pci_dev *dev)
 
 static void pci_destroy_dev(struct pci_dev *dev)
 {
-	/* Remove the device from the device lists, and prevent any further
-	 * list accesses from this device */
 	down_write(&pci_bus_sem);
 	list_del(&dev->bus_list);
-	dev->bus_list.next = dev->bus_list.prev = NULL;
 	up_write(&pci_bus_sem);
 
 	pci_free_resources(dev);