From: Sven Eckelmann <sven.eckelmann@gmx.de>
Date: Sat, 2 Jan 2010 10:30:36 +0000 (+0100)
Subject: Staging: batman-adv: Remove NULL pointer check
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=acdfd0e088502dc225f594b5a5598cab53ffd375;p=deliverable%2Flinux.git

Staging: batman-adv: Remove NULL pointer check

It is safe to call kfree(NULL) which makes this extra check unneeded. It
was found using checkpatch.pl from linux-2.6

Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Acked-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/staging/batman-adv/hard-interface.c b/drivers/staging/batman-adv/hard-interface.c
index e9cb977d0016..28d02f68a3f8 100644
--- a/drivers/staging/batman-adv/hard-interface.c
+++ b/drivers/staging/batman-adv/hard-interface.c
@@ -399,8 +399,7 @@ int hardif_add_interface(char *dev, int if_num)
 	return 1;
 
 out:
-	if (batman_if->packet_buff)
-		kfree(batman_if->packet_buff);
+	kfree(batman_if->packet_buff);
 	kfree(batman_if);
 	kfree(dev);
 	return -1;