From: Lars Ellenberg Date: Wed, 8 Feb 2012 14:32:51 +0000 (+0100) Subject: drbd: explicitly clear unused dp_flags in drbd_send_block X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=b17f33cb0abe61942083444fa6d218d7ca147773;p=deliverable%2Flinux.git drbd: explicitly clear unused dp_flags in drbd_send_block We send left-over garbage from the previous packet in P_DATA_REPLY and P_RS_DATA_REPLY packets. That's bad behaviour. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index 8b99f4e28ccc..c312a3bb9367 100644 --- a/drivers/block/drbd/drbd_main.c +++ b/drivers/block/drbd/drbd_main.c @@ -1882,6 +1882,7 @@ int drbd_send_block(struct drbd_conf *mdev, enum drbd_packet cmd, p->sector = cpu_to_be64(peer_req->i.sector); p->block_id = peer_req->block_id; p->seq_num = 0; /* unused */ + p->dp_flags = 0; if (dgs) drbd_csum_ee(mdev, mdev->tconn->integrity_tfm, peer_req, p + 1); err = __send_command(mdev->tconn, mdev->vnr, sock, cmd, sizeof(*p) + dgs, NULL, peer_req->i.size);