From: Matthew Khouzam <matthew.khouzam@ericsson.com>
Date: Tue, 22 Nov 2016 20:46:46 +0000 (-0500)
Subject: graph.ui: Add Apache Commons Lang3 to use EmptyString
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=b3c8181f4692505505d559c1f03fe50759b40bf6;p=deliverable%2Ftracecompass.git

graph.ui: Add Apache Commons Lang3 to use EmptyString

This removes some ""; //NLS...

Change-Id: I3217d3d9bacc8123507ebd25c1095e3bb14a32e6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/85548
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
---

diff --git a/analysis/org.eclipse.tracecompass.analysis.graph.ui/META-INF/MANIFEST.MF b/analysis/org.eclipse.tracecompass.analysis.graph.ui/META-INF/MANIFEST.MF
index 1c927e4160..b862d88462 100644
--- a/analysis/org.eclipse.tracecompass.analysis.graph.ui/META-INF/MANIFEST.MF
+++ b/analysis/org.eclipse.tracecompass.analysis.graph.ui/META-INF/MANIFEST.MF
@@ -19,3 +19,4 @@ Require-Bundle: org.eclipse.ui,
  org.eclipse.core.resources
 Export-Package: org.eclipse.tracecompass.internal.analysis.graph.ui;x-internal:=true,
  org.eclipse.tracecompass.internal.analysis.graph.ui.criticalpath.view;x-friends:="org.eclipse.tracecompass.lttng2.kernel.ui"
+Import-Package: org.apache.commons.lang3
diff --git a/analysis/org.eclipse.tracecompass.analysis.graph.ui/src/org/eclipse/tracecompass/internal/analysis/graph/ui/criticalpath/view/CriticalPathView.java b/analysis/org.eclipse.tracecompass.analysis.graph.ui/src/org/eclipse/tracecompass/internal/analysis/graph/ui/criticalpath/view/CriticalPathView.java
index ce4cff904a..b1b16d4435 100644
--- a/analysis/org.eclipse.tracecompass.analysis.graph.ui/src/org/eclipse/tracecompass/internal/analysis/graph/ui/criticalpath/view/CriticalPathView.java
+++ b/analysis/org.eclipse.tracecompass.analysis.graph.ui/src/org/eclipse/tracecompass/internal/analysis/graph/ui/criticalpath/view/CriticalPathView.java
@@ -20,6 +20,7 @@ import java.util.Map;
 import java.util.concurrent.locks.Lock;
 import java.util.concurrent.locks.ReentrantLock;
 
+import org.apache.commons.lang3.StringUtils;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.NullProgressMonitor;
 import org.eclipse.jdt.annotation.NonNull;
@@ -461,7 +462,7 @@ public class CriticalPathView extends AbstractTimeGraphView {
         @Override
         public String getColumnText(@Nullable Object element, int columnIndex) {
             if (element == null) {
-                return ""; //$NON-NLS-1$
+                return StringUtils.EMPTY;
             }
             CriticalPathEntry entry = (CriticalPathEntry) element;
             if (columnIndex == 0) {
@@ -475,7 +476,7 @@ public class CriticalPathView extends AbstractTimeGraphView {
                 String value = String.format("%.2f", percent * 100); //$NON-NLS-1$
                 return NonNullUtils.nullToEmptyString(value);
             }
-            return ""; //$NON-NLS-1$
+            return StringUtils.EMPTY;
         }
 
     }