From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Date: Wed, 22 May 2013 02:55:41 +0000 (+0800)
Subject: spi: topcliff-pch: fix error return code in pch_spi_probe()
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=bac902d505220544824829affcf9c1b17b57b8ca;hp=-c;p=deliverable%2Flinux.git

spi: topcliff-pch: fix error return code in pch_spi_probe()

Fix to return -ENOMEM in the platform_device_alloc() error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---

bac902d505220544824829affcf9c1b17b57b8ca
diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
index 963e0f358507..637d728fbeb5 100644
--- a/drivers/spi/spi-topcliff-pch.c
+++ b/drivers/spi/spi-topcliff-pch.c
@@ -1667,6 +1667,7 @@ static int pch_spi_probe(struct pci_dev *pdev,
 		pd_dev = platform_device_alloc("pch-spi", i);
 		if (!pd_dev) {
 			dev_err(&pdev->dev, "platform_device_alloc failed\n");
+			retval = -ENOMEM;
 			goto err_platform_device;
 		}
 		pd_dev_save->pd_save[i] = pd_dev;