From: Richard Sandiford <richard.sandiford@arm.com>
Date: Wed, 21 Sep 2016 15:48:06 +0000 (+0100)
Subject: [AArch64][SVE 02/32] Avoid hard-coded limit in indented_print
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=bd11d5d83775e6d05c8e49f2233fb1cf883ff5b4;p=deliverable%2Fbinutils-gdb.git

[AArch64][SVE 02/32] Avoid hard-coded limit in indented_print

The maximum indentation needed by aarch64-gen.c grows as more
instructions are added to aarch64-tbl.h.  Rather than having to
increase the indentation limit to a higher value, it seemed better
to replace it with "%*s".

opcodes/
	* aarch64-gen.c (indented_print): Avoid hard-coded indentation limit.
---

diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 4208ba1bd2..b47f034144 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,7 @@
+2016-09-21  Richard Sandiford  <richard.sandiford@arm.com>
+
+	* aarch64-gen.c (indented_print): Avoid hard-coded indentation limit.
+
 2016-09-15  Claudiu Zissulescu  <claziss@synopsys.com>
 
 	* arc-dis.c (find_format): Walk the linked list pointed by einsn.
diff --git a/opcodes/aarch64-gen.c b/opcodes/aarch64-gen.c
index ed0834a7ac..a62f6c8e00 100644
--- a/opcodes/aarch64-gen.c
+++ b/opcodes/aarch64-gen.c
@@ -378,13 +378,9 @@ initialize_decoder_tree (void)
 static void __attribute__ ((format (printf, 2, 3)))
 indented_print (unsigned int indent, const char *format, ...)
 {
-  /* 80 number of spaces pluc a NULL terminator.  */
-  static const char spaces[81] =
-    "                                                                                ";
   va_list ap;
   va_start (ap, format);
-  assert (indent <= 80);
-  printf ("%s", &spaces[80 - indent]);
+  printf ("%*s", (int) indent, "");
   vprintf (format, ap);
   va_end (ap);
 }