From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon, 17 Nov 2008 14:55:48 +0000 (+0100)
Subject: netfilter: ctnetlink: use EOPNOTSUPP instead of EINVAL if the conntrack	has no helper
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=bfe2967735e0e0f650bf698a5683db2b6cf4cfd7;p=deliverable%2Flinux.git

netfilter: ctnetlink: use EOPNOTSUPP instead of EINVAL if the conntrack	has no helper

This patch changes the return value if the conntrack has no helper assigned.
Instead of EINVAL, which is reserved for malformed messages, it returns
EOPNOTSUPP.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
---

diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
index 80a3f1308152..d87a9398a781 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -1652,7 +1652,7 @@ ctnetlink_create_expect(struct nlattr *cda[], u_int8_t u3)
 
 	if (!help || !help->helper) {
 		/* such conntrack hasn't got any helper, abort */
-		err = -EINVAL;
+		err = -EOPNOTSUPP;
 		goto out;
 	}