From: Paul Kot Date: Sat, 10 Dec 2011 14:28:34 +0000 (+0100) Subject: batman-adv: bat_socket_read missing checks X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=c00b6856fc642b234895cfabd15b289e76726430;p=deliverable%2Flinux.git batman-adv: bat_socket_read missing checks Writing a icmp_packet_rr and then reading icmp_packet can lead to kernel memory corruption, if __user *buf is just below TASK_SIZE. Signed-off-by: Paul Kot [sven@narfation.org: made it checkpatch clean] Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner --- diff --git a/net/batman-adv/icmp_socket.c b/net/batman-adv/icmp_socket.c index defd6929ceae..88ab26f5f726 100644 --- a/net/batman-adv/icmp_socket.c +++ b/net/batman-adv/icmp_socket.c @@ -136,8 +136,8 @@ static ssize_t bat_socket_read(struct file *file, char __user *buf, spin_unlock_bh(&socket_client->lock); - error = __copy_to_user(buf, &socket_packet->icmp_packet, - socket_packet->icmp_len); + error = copy_to_user(buf, &socket_packet->icmp_packet, + socket_packet->icmp_len); packet_len = socket_packet->icmp_len; kfree(socket_packet);