From: Doug Anderson Date: Thu, 1 May 2014 18:50:16 +0000 (-0700) Subject: regulator: tps65090: Fix tps65090 crash on Tegra Dalmore X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=c122c5b68273cf0153d1dc510889728cf71e8ce3;p=deliverable%2Flinux.git regulator: tps65090: Fix tps65090 crash on Tegra Dalmore The patch (60e91b5 regulator: tps65090: Allow setting the overcurrent wait time) introduced a crash on Tegra Dalmore. On Dalmore the device tree doesn't have an entry for all of the FETs so it leaves tps_pdata NULL in some cases. Add a check for NULL like the rest of the code does. Reported-by: Olof Johansson Signed-off-by: Doug Anderson Tested-by: Stephen Warren Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/tps65090-regulator.c b/drivers/regulator/tps65090-regulator.c index 2057e2e311de..2064b3fd45f7 100644 --- a/drivers/regulator/tps65090-regulator.c +++ b/drivers/regulator/tps65090-regulator.c @@ -431,8 +431,11 @@ static int tps65090_regulator_probe(struct platform_device *pdev) ri = &pmic[num]; ri->dev = &pdev->dev; ri->desc = &tps65090_regulator_desc[num]; - ri->overcurrent_wait_valid = tps_pdata->overcurrent_wait_valid; - ri->overcurrent_wait = tps_pdata->overcurrent_wait; + if (tps_pdata) { + ri->overcurrent_wait_valid = + tps_pdata->overcurrent_wait_valid; + ri->overcurrent_wait = tps_pdata->overcurrent_wait; + } /* * TPS5090 DCDC support the control from external digital input.