From: Alexey Khoroshilov Date: Fri, 5 Dec 2014 21:28:01 +0000 (+0300) Subject: uio/uio_pci_generic: don't return zero on failure path in probe() X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=c4277e9ea70431aea0fecebb8bb9a3fbc27d074e;p=deliverable%2Flinux.git uio/uio_pci_generic: don't return zero on failure path in probe() If uio_register_device() fails in probe(), it breaks off initialization, deallocates all resources, but returns zero. The patch adds proper error code propagation. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Acked-by: Michael S. Tsirkin Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c index 077ae12269ce..d0b508b68f3c 100644 --- a/drivers/uio/uio_pci_generic.c +++ b/drivers/uio/uio_pci_generic.c @@ -91,7 +91,8 @@ static int probe(struct pci_dev *pdev, gdev->info.handler = irqhandler; gdev->pdev = pdev; - if (uio_register_device(&pdev->dev, &gdev->info)) + err = uio_register_device(&pdev->dev, &gdev->info); + if (err) goto err_register; pci_set_drvdata(pdev, gdev);