From: Richard Kennedy <richard@rsk.demon.co.uk>
Date: Wed, 18 Mar 2009 17:26:44 +0000 (+0000)
Subject: drm: reorder struct drm_ioctl_desc to save space on 64 bit builds
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=c972d750e4fa3bfee6e7d3635729bf8c9cbb8f0a;p=deliverable%2Flinux.git

drm: reorder struct drm_ioctl_desc to save space on 64 bit builds

shrinks drm_ioctl_desc from 24 bytes to 16 bytes by reordering members
to remove padding.

updates DRM_IOCTL_DEF macro to initialise structure members by name to
handle the structure reorder.

The applied patch reduces data used in drm.ko from 10440 to 9032

Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: Dave Airlie <airlied@redhat.com>
---

diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index ccbcd13b6ed3..c8c422151431 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -281,16 +281,16 @@ typedef int drm_ioctl_compat_t(struct file *filp, unsigned int cmd,
 
 struct drm_ioctl_desc {
 	unsigned int cmd;
-	drm_ioctl_t *func;
 	int flags;
+	drm_ioctl_t *func;
 };
 
 /**
  * Creates a driver or general drm_ioctl_desc array entry for the given
  * ioctl, for use by drm_ioctl().
  */
-#define DRM_IOCTL_DEF(ioctl, func, flags) \
-	[DRM_IOCTL_NR(ioctl)] = {ioctl, func, flags}
+#define DRM_IOCTL_DEF(ioctl, _func, _flags) \
+	[DRM_IOCTL_NR(ioctl)] = {.cmd = ioctl, .func = _func, .flags = _flags}
 
 struct drm_magic_entry {
 	struct list_head head;