From: Shivani Bhardwaj Date: Thu, 1 Oct 2015 21:27:03 +0000 (+0530) Subject: Staging: xgifb: vb_util: Fixed sparse warning of bit truncation due to cast X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=d1e9aef604da38a4963998922ed0ffff675e3ede;p=deliverable%2Flinux.git Staging: xgifb: vb_util: Fixed sparse warning of bit truncation due to cast Fixed the warning generated by sparse that 'cast truncates bits from constant value' by typecasting unsigned values to u8 as their logical operation is being performed with and stored in a u8 type variable. Signed-off-by: Shivani Bhardwaj Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/xgifb/vb_util.h b/drivers/staging/xgifb/vb_util.h index 7bd395fb31b2..f613f54d522f 100644 --- a/drivers/staging/xgifb/vb_util.h +++ b/drivers/staging/xgifb/vb_util.h @@ -18,7 +18,7 @@ static inline void xgifb_reg_and_or(unsigned long port, u8 index, u8 temp; temp = xgifb_reg_get(port, index); - temp = (temp & data_and) | data_or; + temp = (u8) ((temp & data_and) | data_or); xgifb_reg_set(port, index, temp); } @@ -27,7 +27,7 @@ static inline void xgifb_reg_and(unsigned long port, u8 index, unsigned data_and u8 temp; temp = xgifb_reg_get(port, index); - temp &= data_and; + temp = (u8) (temp & data_and); xgifb_reg_set(port, index, temp); }