From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Date: Thu, 25 Oct 2012 14:55:04 +0000 (+0800)
Subject: crypto: tegra-aes - fix error-valued pointer dereference
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=d48e366e6efe46e0a6744980c18582fb0919a727;p=deliverable%2Flinux.git

crypto: tegra-aes - fix error-valued pointer dereference

clk_put(dd->aes_clk) will dereference an error-valued pointer since the
dd->aes_clk is a ERR_PTR() value. The correct check is call clk_put()
if !IS_ERR(dd->aes_clk).

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/drivers/crypto/tegra-aes.c b/drivers/crypto/tegra-aes.c
index 19adf1c7faa2..93059dc591aa 100644
--- a/drivers/crypto/tegra-aes.c
+++ b/drivers/crypto/tegra-aes.c
@@ -1035,7 +1035,7 @@ out:
 	if (dd->buf_out)
 		dma_free_coherent(dev, AES_HW_DMA_BUFFER_SIZE_BYTES,
 			dd->buf_out, dd->dma_buf_out);
-	if (IS_ERR(dd->aes_clk))
+	if (!IS_ERR(dd->aes_clk))
 		clk_put(dd->aes_clk);
 	if (aes_wq)
 		destroy_workqueue(aes_wq);