From: H Hartley Sweeten Date: Mon, 25 Aug 2014 22:23:46 +0000 (-0700) Subject: staging: comedi: usbduxsigma: fix kcalloc 'size' argument X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=d77ac2c487a37da53e9dd4554a0d6ff1a210fdeb;p=deliverable%2Flinux.git staging: comedi: usbduxsigma: fix kcalloc 'size' argument This code wants to allocate two arrays of struct urb pointers not two arrays of struct urb objects. The size argument for both kcalloc calls should be sizeof(urb) not sizeof(*urb). Reported by: coverity Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c index da33b8c38d2e..a418be0aa822 100644 --- a/drivers/staging/comedi/drivers/usbduxsigma.c +++ b/drivers/staging/comedi/drivers/usbduxsigma.c @@ -1437,10 +1437,8 @@ static int usbduxsigma_alloc_usb_buffers(struct comedi_device *dev) devpriv->dux_commands = kzalloc(SIZEOFDUXBUFFER, GFP_KERNEL); devpriv->in_buf = kzalloc(SIZEINBUF, GFP_KERNEL); devpriv->insn_buf = kzalloc(SIZEINSNBUF, GFP_KERNEL); - devpriv->ai_urbs = kcalloc(devpriv->n_ai_urbs, sizeof(*urb), - GFP_KERNEL); - devpriv->ao_urbs = kcalloc(devpriv->n_ao_urbs, sizeof(*urb), - GFP_KERNEL); + devpriv->ai_urbs = kcalloc(devpriv->n_ai_urbs, sizeof(urb), GFP_KERNEL); + devpriv->ao_urbs = kcalloc(devpriv->n_ao_urbs, sizeof(urb), GFP_KERNEL); if (!devpriv->dux_commands || !devpriv->in_buf || !devpriv->insn_buf || !devpriv->ai_urbs || !devpriv->ao_urbs) return -ENOMEM;