From: Sage Weil <sage@newdream.net>
Date: Thu, 12 May 2011 22:28:11 +0000 (-0700)
Subject: ceph: fix broken comparison in readdir loop
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=da39822c6565095a0151ccf9d6b95e2ae5612885;p=deliverable%2Flinux.git

ceph: fix broken comparison in readdir loop

Both off and fi->offset are unsigned, so the difference is always >= 0.
Compare them directly instead of the sign of the difference.

Signed-off-by: Sage Weil <sage@newdream.net>
---

diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c
index 53a5eb417856..33729e822bb9 100644
--- a/fs/ceph/dir.c
+++ b/fs/ceph/dir.c
@@ -360,7 +360,7 @@ more:
 	rinfo = &fi->last_readdir->r_reply_info;
 	dout("readdir frag %x num %d off %d chunkoff %d\n", frag,
 	     rinfo->dir_nr, off, fi->offset);
-	while (off - fi->offset >= 0 && off - fi->offset < rinfo->dir_nr) {
+	while (off >= fi->offset && off - fi->offset < rinfo->dir_nr) {
 		u64 pos = ceph_make_fpos(frag, off);
 		struct ceph_mds_reply_inode *in =
 			rinfo->dir_in[off - fi->offset].in;