From: Andrey Tsyvarev <tsyvarev@ispras.ru>
Date: Fri, 6 Feb 2015 04:39:57 +0000 (+1030)
Subject: kernel/module.c: Free lock-classes if parse_args failed
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=de96d79f343321d26ff920af25fcefe6895ca544;p=deliverable%2Flinux.git

kernel/module.c: Free lock-classes if parse_args failed

parse_args call module parameters' .set handlers, which may use locks defined in the module.
So, these classes should be freed in case parse_args returns error(e.g. due to incorrect parameter passed).

Signed-off-by: Andrey Tsyvarev <tsyvarev@ispras.ru>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---

diff --git a/kernel/module.c b/kernel/module.c
index d856e96a3cce..441ed3fc9c89 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -3356,6 +3356,9 @@ static int load_module(struct load_info *info, const char __user *uargs,
 	module_bug_cleanup(mod);
 	mutex_unlock(&module_mutex);
 
+	/* Free lock-classes: */
+	lockdep_free_key_range(mod->module_core, mod->core_size);
+
 	/* we can't deallocate the module until we clear memory protection */
 	unset_module_init_ro_nx(mod);
 	unset_module_core_ro_nx(mod);