From: Jesper Juhl <jj@chaosbits.net>
Date: Mon, 9 Apr 2012 20:50:15 +0000 (+0200)
Subject: tg3: remove redundant NULL test before release_firmware() call
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=e3c5530b96b9c5994cfb2544a037161790c4f7c3;p=deliverable%2Flinux.git

tg3: remove redundant NULL test before release_firmware() call

There is no need to test for a NULL pointer before calling
release_firmware - the function does that on its own.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---

diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index 062ac333fde6..9fbf73e41e30 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -15842,8 +15842,7 @@ static void __devexit tg3_remove_one(struct pci_dev *pdev)
 	if (dev) {
 		struct tg3 *tp = netdev_priv(dev);
 
-		if (tp->fw)
-			release_firmware(tp->fw);
+		release_firmware(tp->fw);
 
 		tg3_reset_task_cancel(tp);