From: H Hartley Sweeten <hartleys@visionengravers.com>
Date: Tue, 26 Jun 2012 17:08:52 +0000 (-0700)
Subject: staging: comedi: cb_das16_cs: remove unneeded default case in analog in read
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=e8abca1f30239f6c979f60df49305a602672cb94;p=deliverable%2Flinux.git

staging: comedi: cb_das16_cs: remove unneeded default case in analog in read

The default (return -EINVAL) case is not needed when working
out the correct value to set the analog input range. As pointed
out by Ian Abbott, the comedi core checks the range in
comedi_check_chanlist() before calling the insn_read() function.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reported-by: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/comedi/drivers/cb_das16_cs.c b/drivers/staging/comedi/drivers/cb_das16_cs.c
index 95fa7e2fea9d..58d45299bf85 100644
--- a/drivers/staging/comedi/drivers/cb_das16_cs.c
+++ b/drivers/staging/comedi/drivers/cb_das16_cs.c
@@ -136,8 +136,6 @@ static int das16cs_ai_rinsn(struct comedi_device *dev,
 	case 3:
 		devpriv->status2 |= 0x200;
 		break;
-	default:
-		return -EINVAL;
 	}
 	outw(devpriv->status2, dev->iobase + DAS16CS_MISC2);