From: H Hartley Sweeten Date: Fri, 20 Jun 2014 20:12:40 +0000 (-0700) Subject: staging: comedi: dt282x: remove 'volatile' on private data variables X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=ebf86ea9a68e2ebb366dc7640f916e233d614db1;p=deliverable%2Flinux.git staging: comedi: dt282x: remove 'volatile' on private data variables As indicated by checkpatch.pl, "WARNING: Use of volatile is usually wrong: ...". The variables in the private data that are marked volatile don't need to be. Remove the volatile. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/dt282x.c b/drivers/staging/comedi/drivers/dt282x.c index dcc4055bee71..5ae15bcccb5e 100644 --- a/drivers/staging/comedi/drivers/dt282x.c +++ b/drivers/staging/comedi/drivers/dt282x.c @@ -330,21 +330,21 @@ struct dt282x_private { unsigned short ao[2]; - volatile int dacsr; /* software copies of registers */ - volatile int adcsr; - volatile int supcsr; + int dacsr; /* software copies of registers */ + int adcsr; + int supcsr; - volatile int ntrig; - volatile int nread; + int ntrig; + int nread; struct { int chan; unsigned short *buf; /* DMA buffer */ - volatile int size; /* size of current transfer */ + int size; /* size of current transfer */ } dma[2]; int dma_maxsize; /* max size of DMA transfer (in bytes) */ int usedma; /* driver uses DMA */ - volatile int current_dma_index; + int current_dma_index; int dma_dir; };