From: Dan Carpenter Date: Wed, 13 Apr 2016 06:41:26 +0000 (+0300) Subject: UBI: Clean up return in ubi_remove_volume() X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=fadb3665bad96be8f696e4899ee0f618536d54c7;p=deliverable%2Flinux.git UBI: Clean up return in ubi_remove_volume() My static checker says that "err" can be uninitialized if "vol->reserved_pebs" is <= 0. I don't think that can happen but returning a literal is cleaner anyway. Signed-off-by: Dan Carpenter Signed-off-by: Richard Weinberger --- diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c index 1ae17bb9b889..10059dfdc1b6 100644 --- a/drivers/mtd/ubi/vmt.c +++ b/drivers/mtd/ubi/vmt.c @@ -405,7 +405,7 @@ int ubi_remove_volume(struct ubi_volume_desc *desc, int no_vtbl) if (!no_vtbl) self_check_volumes(ubi); - return err; + return 0; out_err: ubi_err(ubi, "cannot remove volume %d, error %d", vol_id, err);