From: Suresh Gupta <suresh.gupta@freescale.com>
Date: Wed, 2 Apr 2014 16:56:46 +0000 (+0530)
Subject: usb : gadget : fsl: fix the fault issue on rmmod
X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=fc696881c6ec991f39a2f93d41f9ae841c6ace38;p=deliverable%2Flinux.git

usb : gadget : fsl: fix the fault issue on rmmod

completion in udc_controller->done should be assign with proper
value before complete called. The complete called in fsl_udc_release
which intern called from usb_del_gadget_udc, so moving assignment
before calling usb_del_gadget_udc

Signed-off-by: Suresh Gupta <suresh.gupta@freescale.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
---

diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c
index 15960af0f67e..dcd0b07ae3a0 100644
--- a/drivers/usb/gadget/fsl_udc_core.c
+++ b/drivers/usb/gadget/fsl_udc_core.c
@@ -2532,8 +2532,8 @@ static int __exit fsl_udc_remove(struct platform_device *pdev)
 	if (!udc_controller)
 		return -ENODEV;
 
-	usb_del_gadget_udc(&udc_controller->gadget);
 	udc_controller->done = &done;
+	usb_del_gadget_udc(&udc_controller->gadget);
 
 	fsl_udc_clk_release();