From: Eric W. Biederman Date: Mon, 26 Jun 2006 07:25:42 +0000 (-0700) Subject: [PATCH] proc: Remove useless BKL in proc_pid_readlink X-Git-Url: http://drtracing.org/?a=commitdiff_plain;h=ff9724a3f7a69f7b443c05981f84e28017c2fc5a;p=deliverable%2Flinux.git [PATCH] proc: Remove useless BKL in proc_pid_readlink We already call everything except do_proc_readlink outside of the BKL in proc_pid_followlink, and there appears to be nothing in do_proc_readlink that needs any special protection. So remove this leftover from one of the BKL cleanup efforts. Signed-off-by: Eric W. Biederman Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/proc/base.c b/fs/proc/base.c index 13e3ab99eb74..7169a713da1b 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -1167,7 +1167,6 @@ static int proc_pid_readlink(struct dentry * dentry, char __user * buffer, int b struct dentry *de; struct vfsmount *mnt = NULL; - lock_kernel(); if (current->fsuid != inode->i_uid && !capable(CAP_DAC_OVERRIDE)) goto out; @@ -1183,7 +1182,6 @@ static int proc_pid_readlink(struct dentry * dentry, char __user * buffer, int b dput(de); mntput(mnt); out: - unlock_kernel(); return error; }