lttng: Fix more Sonar warnings in LTTng Tracer Control

Change-Id: Id605ea90f7714e3662c207d2c2ad83dbbd29c5fc
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13343
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix more Sonar warnings in Sequence Diagram Framework

Change-Id: I235bca865940386735cf9f9823da6ce9d1b0721d
Reviewed-on: https://git.eclipse.org/r/13342
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf/lttng: Refresh compiler settings for Kepler

Change-Id: I1493ecf94b64f51105b5b9a7b2353f20ee808010
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/13373
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Remove profile lttngTests from lttng's pom.xml

This profile used to be there for conditional execution of
LTTng test cases. This is not needed anymore because these tests
are now automated and work on Hudson.

Change-Id: I83e72fdd57845e9c09145e79857c88908d43a507
Reviewed-on: https://git.eclipse.org/r/13047
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: update wiki for batch import trace wizard.

Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Change-Id: Id605d0f628fa306dc87c5414161304ed5859326e
Reviewed-on: https://git.eclipse.org/r/13230
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Fix Sonar warnings in custom parser wizard package

Change-Id: Icd54d92d645633208bdd337e320753e57cdc5023
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/13371
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix some Sonar warnings in the state system code

Change-Id: I796bad9720a2fd6bc2be2b2d27bc8d52e70afbb0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/13357
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: fix potential bug when selecting trace types in import wizard

Change-Id: I963b47cf18caba9d0ae215f74bd8861c2ea29175
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13347
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: fix bug where batch import trace does not show scan progress

Change-Id: I1fae04177d694264a02d0fb09679245478b1b668
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13341
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Fix Sonar warnings in timegraph package

Change-Id: If20ef00dba5ac104f76a7f0b0e8a0095c7916652
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/13294
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Fix NPE on trace with obsolete persistent properties

Change-Id: Ic867f89b2446e60f5aca75e7fb563045950334fc
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/13302
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>

Tmf: fix missing titles to import wizard pages

improve comments
remove some lingering " "s and replace them with ' 's

Change-Id: Id100f8fb074f3ea69d6908ef9057efa9e23a25f5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13301
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: fix bug when importing and no project is selected

fix importing custom text and xml traces
fix importing single files in copy mode when one file is imported
several times, sometimes renamed after importing non-renamed versions of
the same trace

Change-Id: I70a13fdfd800bc46475040e6d73a86e19a6bbdc2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13289
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

ctf: Fix some Sonar warnings

Change-Id: I6414bc064c4ab55ec574f582d7901c20b906b404
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/13239
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Make TmfLostEvent immutable

TmfEvent is now immutable, all its extensions should be too.

Change-Id: Ic01107c032c8a01271614934b0eb9dc182fc6b66
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12957
Tested-by: Hudson CI

tmf: fix import trace wizard changing trace types after directory

Change-Id: I20af2fc56cb58ba8caebf5af13acf5b16ad7eb00
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13280
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Tmf: externalize a string

Change-Id: I59c4ca9ff7b8b0e0c5f8974e151c7e4693b44fb3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13274
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Update import if a trace type is added after a directory

replace other occurance of " " by ' '

Change-Id: I5cf66324903236a4fd8c78c57dde81a3d8198a4b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13271
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI

tmf: Bug fixes for batch import

Remove non-standard non-modal wizard.
Add cancelability to the directory add.
clean up some code, remove " " strings
merge a job that only calls a job into the top job

Change-Id: I18beb4a6054092388b180f42e91be6b8e598d728
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13246

lttng: Update Control Flow and Resources view user guide

Change-Id: Idcde718294d0307ed3805ebf6f084ef7bb504bf6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13140
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Tmf: Expand trace type list in batch import

Change-Id: Ia4bfa1e39dbb71532da9ec776c6f674876f38c83
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12843
Tested-by: Hudson CI
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: More trace manager unit tests

Also added a method in the manager to retrieve all the
currently opened traces.

Change-Id: Iaf69a89b0b5214a66e45e02d6388e97985eea549
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/13099
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf-tests: Handle NullPointerException in TmfEventParserStub

With commit 7e670c5, any exception in the TmfEventThread
will be logged in the plug-in's error log. There is a
NullPointerException in the TmfEventParserStub which was was
silently handled. With this commit the NPE will be prevented.

Change-Id: I1c5d34a5869d8f071847a0d3f23fde2de1b3867e
Reviewed-on: https://git.eclipse.org/r/13121
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Generate trace in IOstructgenTest

Modification to be able to generate trace

Change-Id: I79e5100122f2be137da32625c0973f9418ae42e0
Signed-off-by: Simon Delisle <simon.delisle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12680
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Change SDView.isNeedInit() to protected

Change-Id: Ie0872f4bbdf00c56b2dbe3bfb42be4d369cb6b03
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/13054
Tested-by: Hudson CI
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Add Link with Editor section to LTTng User Guide

Change-Id: Ifb80dcbdb4405633e81cbcdb67746c2c3612404c
Reviewed-on: https://git.eclipse.org/r/13082
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Fix mouse wheel zoom and text control value handling in histogram view

Partial fix for bug 384423.

Add focus gained listener to child text controls of Histogram composite
that gives focus to canvas which handles mouse wheel events.

Provide the HistogramZoom instance owned by the full trace histogram as
a mouse wheel listener to the time range text control.

Update time range text control to prevent unnecessary reloading of the
time range histogram model when focus is lost without changing value.

Update current time control to prevent resetting of current event on
parsing error.

Fix possible SWT exception in histogram text control during Eclipse
shutdown.

Change-Id: Iefd4db5eafbe54e9386a9ec23b4ac1ecd2ce2a1b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/12902
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Close editors when experiment composition is changed

Fix for bug 325380.

Change-Id: I38115ff2e34b381001dd12840c217d13e6cc1b69
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/13061
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Update Add Bookmark handler activation conditions

Change-Id: I4623de25017d58759f37bc4a18ca1b63b71ea17f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/12797
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: API clean-up of sequence diagram framework

Throughout the sequence diagram framework, most member variables
were declared protected. However, in many cases getter and setter
methods exists and the member could have been declared private.
In some other cases, some of the attributes are internal data
and should not be be protected. This commit changes the modifier
of attributes to private. Getter and setter methods were added
where needed.

Change-Id: I7bf18335ff487c7a89b0d521e41b51e0bc3d1ad0
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12880
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng ui: Fix minor sonar warnings

Mainly fixes the ordering of modifiers, removes commented-out code
and change class with constants to an interface.

Change-Id: I6c5b6d7698c92640b4661720e190b77d7c3a7787
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12888
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Update TMF Sequence Diagram content in TMF help plug-in

With this commit the tutorials comply with the TMF 2.0 APIs.

Change-Id: I8466f63c1acd1fd2035f11891da83070d1b55d23
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12879
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Log exceptions in event thread

Fix for bug 343740.

Change-Id: I554f74bdeb4b2c5de1706798633ff702d6493bbc
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/13030
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>

Fix update of fully visible row count on table column resize in Linux

Change-Id: I23215506eb0493f98e8b4ac46dbee1f7b13635a3
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/12955
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>

Fix infinite paint loop introduced by commit 866cb82

Change-Id: I60bc075b3fe8c7ddef082aba8fe86e8433ea7f94
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/12948
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: fix comments about ITmfTrace.validate() return value

Change-Id: Ieb686dd9a776372a84115d79b5f7b5a5000b2bb6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12946
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

ctf: fix sonar warnings about redundant modifier in interfaces

Change-Id: I753bc49a37d8396b3f9a56f79c31866658422668
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12893
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: fix sonar warnings about redundant modifier in interfaces

Change-Id: I5eee2adfad2e2592212fc3d612a404d525c111ad
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12894
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Add TMF Help plug-in to TMF feature

Change-Id: I2b993ea0fd23bd7346ae0bb185fb9faeecf3822a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12878
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: fix sonar warnings about redundant modifier in interfaces

Change-Id: I96081e313453e12fd30c0f6d14b60aca6d74ec4b
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12895
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Specify extended trace properties with an interface

Introduce a new ITmfTraceProperties that traces can implement when
they can provide additional trace properties. Also make the the
Enviornment Variables view use this interface, so it is not specific
to CTF traces.

Change-Id: I9a6901f720bc028f28ce5c180b778701a8ec0f5b
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12789
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Consolidate all enviornment-related methods in CtfTmfTrace

Change-Id: I90d8fbdfb132533a26c8911982c6e77b505a6913
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12788
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Fix hiding of event table header row when selection is partially visible

Change-Id: I52843974153921737b2a1115f040dd69853d400e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/12848
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Remove UI dependencies in tmf.core.

Change-Id: I6b031a39e519b6347c8ae1dede967aad4eb069e3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12844
Tested-by: Hudson CI
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Fix IllegalArgumentException in Colors view

The return value of ColorDialog.getRGB can return null.

Bug: 408074
Change-Id: I40277621ba3e63b610e1ad2e012263850c74f26e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12856
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Formatting IOstructgenTest

Change-Id: I70589e68bd55808e3530fce25ce13f06219ae2b3
Signed-off-by: Simon Delisle <simon.delisle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12847
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Sort file system elements in import trace wizard

Change-Id: I4e1eb3487c97f081c0a6322aba29d3bae9254f30
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/12794
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: fix unused message warning for sequence diagram view

Change-Id: I8778e95957addf8f53f4c1507de7e6f681d29c1a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12792
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Fix trace validation in the classic Trace Import

fix Bug 407571

Change-Id: Id916cce4e6b8b21c92460d3d09bd85ab4b72e947
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12653

Fix for experiment location hashCode and equals

Change-Id: Ib3456002492de585c53986c5c8384e227d5b9880
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/12769
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Move project creation method to TmfProjectRegistry

This change will allow other classes to create a tracing project,
for example, creating a project (default) at startup or during
trace import.

Change-Id: I87c8dffc6f2fbfc9f20cca3913c663d4f247a1a2
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12750
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add missing selected trace signal (fix #404682)

Change-Id: I7352b4d60c4362c6f3dd830583ce9346303d072c
Signed-off-by: Simon Delisle <simon.delisle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12556
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Close editors to release supplementary file resources

Change-Id: I4dc9af5b6af557c29969412f7ac0ae7752c3a12d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/12685
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Handle the supplementary files dir in the trace manager

This centralizes the directory-getting logic in one place.

Change-Id: Icc512a7f70c8023837b0cf690be95a53fe649f52
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12658
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

TMF : Bug 385217 - Display 64 unsigned integers correctly

Change-Id: I80709ff4c7404b8201ee144e0e98ecaa7438651b
Signed-off-by: Jean-Christian Kouamé
Reviewed-on: https://git.eclipse.org/r/12711
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Tmf: improve validation in GDB traces and externalize strings

Change-Id: Id5f9bb30d6b617543a5feef8418509f19c6d8da3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12717
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ctf: Read and display custom event attributes

Fixes bug #391055.

Change-Id: Ie4a1b672201dbcec9e9b147348844a8d18ea7789
Signed-off-by: Simon Delisle <simon.delisle@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12678
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Use the signal's trace set in signal handlers

In relevant signal handlers (like traceOpened, traceSelected,...),
to verify if the trace is the target of the signal, use the new
TmfTraceManager.getTraceSet() method instead of relying on the
currently-active trace set.

In practice, the behavior should be the same, but it's a bit clearer
and cleaner this way.

Change-Id: Ied4405e5d3cfc051dcb43cc60837752c1f8889ea
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12649
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

TMF: change callsite action text

this commit change the word "callsite" for "source code" when we are
looking for the source of a trace event.

Change-Id: Ib5e467b9b7795cddba54114f9855c2e2fff8145b
Reviewed-on: https://git.eclipse.org/r/12591
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Jean-christian Kouamé <kadjo.gwandy.jean-christian.kouame@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Bug 407474 - Exceptions thrown when opening/closing trace with no event

Change-Id: I54f618692fba19c07eec436227b1428cddc3a87d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12604
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Give proper names to SD messages variables

This should please Sonar.

Change-Id: I0de8cc4e541d966d7b3c8483c30f9d9cc2d4bd4a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12663
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add a getTraceSet() method to the trace manager

This allows getting the trace set (ie, encapsulating the TmfExperiment
instance check, etc.) for any trace, and not only the active one.

Change-Id: I876e8fb9956b10be6259341f49b54f3e9706be1f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12648
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

lttng/tmf: Set line delimiters and encoding for help plugins

Change-Id: Ic9b467771b5e341d32e9452e657f43f64df8ad83
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12603
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

lttng2: Fix version handling for older eclipse platforms

Older implementation of org.osgi.framework.Version have different
API for the compareTo method which causes a NoSuchMethodException.
This commit is to fix the version handling so that it is possible
to run it on older Eclipse versions (e.g. 3.6).

Change-Id: I968aec9f4fda5ff8cf2f05b23e1b544d3f8e28c8
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12420
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Tmf: Batch Trace Import

Added a batch trace import wizard

Change-Id: I32bfa9c8f49e00d7e6741500c914f2816f4d7834
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/11125
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix exception throwing in Sequence Diagram tests

Because of the new trace manager, the tests now have to send
"dummy" signals when traces are opened or selected, to register
them in the manager.

Also removed the RuntimeException when receiving a signal that
says to close a trace that is not currently open. We will simply
ignore it in this case.

Change-Id: I6ca345fb817a8a5691b41430b0062dbf5dc0812f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12441
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Use the trace manager instead of ITmfTrace.getTraces()

Planned revert of 18991e1, now views can call the trace manager
to get the list of active traces, no matter if it's inside an
experiment or not.

Change-Id: I592de26a5edb4a8b8ed82a4442cb2b59d488f0f1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12424
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng2: Update lttng2 feature dependency to require RSE feature

The lttng2 feature now requires the feature Remote System Explorer
End-User Runtime (org.eclipse.rse) instead of certain RSE plug-ins.
This causes p2 to automatically install the all necessary RSE
features (e.g. ssh shell) features needed by lttng2. Before this
commit the RSE runtime feature had to be installed manually.

Change-Id: I39dc6baaf161047cbd44b7a87bbd78e8631caad7
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12413
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Disallow opening of experiments with no traces

This commit considers all 3 open procedures:
- context-sensitive menu
- double-click
- accelerator (CTRL+SHIFT+R)

Change-Id: I3d37155b970425f68208066100dc10d89e65b4eb
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12402
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Switch views to the trace manager

Remove getCurrentTime() and getCurrentRange() from ITmfTrace,
and transition its callers to the central trace manager.

Change-Id: Ib5138acb7cd252b40be07d0c0536bc73b60491bd
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12354
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Introduce a central trace manager

This manager will track all currently opened traces and their
currently selected timestamps and time ranges.

This will also give both views and *.core analysis plugins
a centralized way to get the current active trace/experiment.
This was not an easy thing to do reliably if you were not an
instance of TmfView.

Basic unit tests are included, more complete tests will be added
later.

Change-Id: Ie0056252908ae8bb9e5da33242c3141665eb161c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12079
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Expose the indexTrace() method in the interface

Some trace types could decide to do their indexing manually
and such, so expose the already-existing indexTrace() method
up to the ITmfTrace interface.

Change-Id: I1f9724f3cb20b8bbf19b8a5120cc16155b7de173
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12078
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Delete supplementary files when changing trace type

After changing the trace type of a trace the supplementary files
e.g. statistics might have some information that are not
corresponding to the newly selected trace type. By deleting
the supplementary file some stale data will be avoided.

Change-Id: I6672810ea2fa4b363a96f42e26fd8647eba38d71
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12396
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Rename CtfKernelTrace to LttngKernelTrace

Change-Id: I8375a32844988e3a1667e3197e112f1ded17a248
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12369
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Rename StateSystemManager to TmfStateSystemFactory

After a couple rewrites, this class is now more a factory than
a manager. Now we just need a manager factory...

Change-Id: I22eb4f158e39b1c1ebd86414960e41a3fb8e5707
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12260
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Rename IStateChangeInput to ITmfStateProvider

The nomenclature "state provider" was being used more and more
instead of "state change input", so clarify this before the Kepler
API freeze and use "state provider" everywhere. It just sounds
better anyway.

Change-Id: I88fbc4f8f867754fef41dc35b99a823dbea3683c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12259
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Integrate Babeltrace CTF tests and fix parsing problems

Change-Id: I1bde488b99a6e29cfc5bcf4191e00b317d8c737f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12160
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Introduce Call Stack view and state system

Change-Id: I794b6ea9758614e7a595705d9728ca8f5a588975
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/12222
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ctf: Put Antlr-specific exceptions in a separate class

Since CTFReaderException is in the public API, any external
plugin using it would have had to import the antlr-runtime
packages.

By isolating the Antlr-specific stuff in a separate, non-API
class, external plugins can happily continue to use
CTFReaderException without fear of leaking dependencies.

Change-Id: I27cccd60dd0ad1ca51a91c10b067a19b07c24f2e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12224
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

Update user guide icons

Some icons were converted to PNG but were named with a .gif extension.
On Windows these icons do not display correctly.
Replacing the icons to their original GIF format from the .ui plugin.

Change-Id: If8a9798c3470265609e4a1ebb1e1f57347af0d8a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/12256
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Time Graph improvements and bug fixes

- Add NullTimeEvent that inhibits tool tip on mouse hover
- Fix possible ArithmeticException with Zoom In button
- Preserve selected entry in time graph control refresh
- Expose time graph control and scale through time graph viewer API
- Prevent reset of top index on time graph viewer refresh

Change-Id: I438e5848d901656f550ecac0781a44f7148ea919
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/12221
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Move EventsIterator to timegraph package

Change-Id: I83df2ca0a9a5f74be8814e3c204b5a871629d500
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/12220
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

tmf: Remove the serialization logic from TmfStateValue

Serializing the state values is the history backend's job (as in,
each backend could do it differently). Move the existing logic
to HTInterval.

This also fixes a very bad bug where the stringsEntrySize of intervals
containing a Long state value would be incorrectly reported as 0.
This would mean that nodes could try inserting a value that wouldn't
fit, which would end up corrupting the interval data.

Change-Id: I6c54ef905b45b06b69ed21ce59c70d2eaa16b7f8
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12254
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Remove ITmfStateSystem#isLastAttribute()

This method was meant to be used as a kind of
"wasThisAttributeJustCreated()". But, if no new attrbiutes are
created, the last attribute would still return true, even if
it has been existing for a while!

So remove this potentially confusing method from the API
completely.

Change-Id: I8ac873ba18193e875806d4645e03dd228acd846c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12250
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Insert null values for newly-created attributes

Instead of requiring every state provider to explicitely insert
a value when creating a new attribute, we can have the attribute
tree do it for them. Then, if the provider wants to set it to
something else, it's just changing a variable in memory.

This fixes a potential problem in the LTTng-kernel state provider,
where a value could get reset to null if no new attributes are
created between two sched_switch events.

Change-Id: I600125f560f0362671379848c572359be2f74cc7
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12249
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

ctf: Add copyright headers to scripts and properties files

Change-Id: Id15775ed4674cd9e5494c36a20988856d254e8fa
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12161
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Refresh the state provider's test values

The order of attributes changed with 456f31e and 5a4f693.
The expected test values had to be updated. Should fix the
recent unit test failures.

Change-Id: I9e0d3c0573825ebdf0923030ec8792a6ada62aa3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12170
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Make GenerateTestValues output a valid Java file

This way we can just copy-paste the output on top of the previous
TestValues.java file (which contains expected values for tests).

Java code that writes Java code, what can possibly go wrong...

Change-Id: I234959238d2c645ce40f4a9b5ed49d4399e08d4d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12169
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

gdbtrace: Add copyright headers to properties files

Change-Id: Ie333a85bad6e86666d8f005f65fd568709e90c78
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12162
Tested-by: Hudson CI
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add copyright headers to properties files

Change-Id: I3ca1ece1513599fbb8f01614d1ca9f025729538f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12164
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Add copyright headers to properties files

Change-Id: If65f4920bf2177d135208759d9a6158c9d4d6fd1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12163
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf/lttng: Remove unneeded (non-Javadoc) comments

Those comments are not needed anymore. With Java >= 6,
overriding classes marked with @Override also inherit
the Javadoc from the base class.

Also:
- Some auto-formatter actions, to remove those pesky tabs.
- Ran the copyright tool. Might have updated unrelated files.

Change-Id: I93f699efa075a5629f31f478b7045247388f58fe
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12141
Tested-by: Hudson CI

Fix NLS-related Javadoc warnings

Some new warnings slipped through in 9a9673c.

It was also externalizing strings in a test plugin, which is
not needed.

Change-Id: I8c9b309363c022b2072a701099e1f79c435737a0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12140
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: add support for kernel-only in tracer control (bug406120)

This commit allows the user to connect to a remote LTTng node
where UST is disabled and only the kernel tracer is available.
For LTTng tools 2.0.x, the command lttng list -u causes a
segmentation fault on the remote side. This segmentation fault
makes it impossible to use the kernel-only mode. This bug is fixed
in later versions of LTTng tools starting from 2.1.0.

Change-Id: I2862ccce68c575706722eea89fdd4b450797d5d6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12139
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Support for port number in lttng control (bug 406122)

Change-Id: I38ce9ea1e84f3a57c28cb9877d2033cf42b0af57
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12135
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Handle the sched_wakeup event

This event should put the relevant process (indicated in the
event's payload) in the "wait for cpu" state.

Change-Id: I5cf6a617f0558ff98cfc007fc10a688dab292f6b
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11998
Tested-by: Hudson CI

lttng: Correctly assign syscall state for new processes

If a process is already in kernel mode ("syscall" state) at
the beginning of a trace, all its children created via fork/clone
would be wrongly assigned to a user mode state once they get
scheduled on a CPU. This is because the parent's sycall name was
not set (since we never saw that syscall entry event).

This is actually a common case with LTTng traces: the lttng-consumerd
process is always already in kernel mode at the start of a trace,
and forks another process soon after.

Fixes bug #405221.

Change-Id: Iffdfb3277c1fa3fb9316c2ef9c8e6f04f539bb43
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11756
Tested-by: Hudson CI

lttng2: Use ReadOnlyTextPropertyDescriptor in control model

Change-Id: I78e68d4c4d53ca753c09a807498204676ebb2dc3
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12107
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: use ReadOnlyTextPropertyDescriptor in project model

Change-Id: I4edd75e5dd4796e3196105ddb274b15033b0cdfd
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12106
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

[Tmf][Ctf] Add descriptive fail to import messages.

This patch proposes a way of showing more error details.
The ctf modifications use reflexion since the parser and lexer are
auto-generated. Now with number format exceptions for ints
Messages.java now have suppress warnings javadoc

Change-Id: I74cbbd4aaff29f458786ffc96e88b5416b49beed
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/11788