tmf: Make TmfTrace implement IAdaptable

This is useful to be able to use adapter interface for traces, either by
direct implementation or by registering an adapter factory.

Change-Id: Iec23a2e3025771966f3467c56843711698b03331
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/84819
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add configurable marker event source

Change-Id: I1c8f9b2ebc833063d8fa7b9b4a469b722b8bb41c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/83645
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add method to filter-out periodic markers by index

The method isApplicable(long index) can be overridden to filter-out
markers by index, by returning false. The default implementation returns
true, filtering-out nothing.

Change-Id: Ib37043facf10aef4369f1a3701d94b975c68c9e5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/83644
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add method to get marker list for all categories at once

This can be useful for marker event sources that provide multiple
categories and for which it is easier to compute all the markers at the
same time.

Change-Id: I5efcfe4444f70ef879fb6a33aa4e28b844d08095
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/83643
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix Mars build

In Eclipse 4.5, StructuredViewer had
public void setFilters(ViewerFilter[] filters)
It became in 4.6
public void setFilters(ViewerFilter... filters)

So passing an array of ViewerFilter will work for both.

Change-Id: I1f3e188a78f1b738f9d41bbc05f692141f02b1bb
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/92392
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

xml: Use java.nio.Path instead or o.e.core.runtime

This is what is was meant to be from the start, but a wrong import went
unnoticed.

Change-Id: Iecf4794c9ed9e59a83ebd5e92af9b7ef7ef72b12
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/92112
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

lttng: bug 513013: fix invalid thread access

Change-Id: I019497d3cc776b8872c6600bd7c3aa4a5d331c3e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/92204
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI

releng: Use baseline target file instead of zip for Oomph

Instead of having to create a zip and pointing to it, use the
existing .target file. This requires to resolve the target first
then set it, as suggested here:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=500097#c7

Change-Id: I4e7b7d9b8ea8b013e24ba8c0ef760066c86251a2
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77201
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

datastore: Fast return to for classic node children

When selecting next children of classic nodes, once the node's
end time is past the maximum of the range, it is no use searching
the rest of the children.

Change-Id: I7a1aba410718ea33a84b6a0b109121b0512fd284
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91758
Reviewed-by: Hudson CI
Reviewed-by: Loic Prieur-Drevon <loic.prieur.drevon@ericsson.com>

datastore: Rewrite some stream and list manipulations

This patch rewrites some list and stream manipulations to plain
java. It has a non-negligeable impact on performance.

Change-Id: I11881780d30f27592765140edda1af04b1a2c1e5
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91757
Reviewed-by: Hudson CI
Reviewed-by: Loic Prieur-Drevon <loic.prieur.drevon@ericsson.com>

datastore: Add intervals without check for node read

When nodes are read from disk, we know the intervals fit into it, there
is no need to go through the code path that checks if the interval can
go in the node.

This change alone greatly reduces the performance impact of both single
and full queries for large state system, when nodes are often read from
disk.

Change-Id: If653611b00d56b604d23ddd1f6e62bb22f822da0
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91756
Reviewed-by: Hudson CI
Reviewed-by: Loic Prieur-Drevon <loic.prieur.drevon@ericsson.com>

datastore: Keep a snapshot of the latest branch

This avoids making immutable copies of the same branch over and over.

Also use the latest branch directly in the node insertion instead of
the getter.

This change alone removes all performance impact of the datastore
when building.

Change-Id: If85ae9bded364cfd6f1243416d025df6307cf909
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91755
Reviewed-by: Hudson CI
Reviewed-by: Loic Prieur-Drevon <loic.prieur.drevon@ericsson.com>

datastore: Use time conditions with long

Using primitive type long instead of a generic Long for range conditions
reduces the need for boxing and unboxing time values.

This change alone reduces the performance impact of the datastore by ~2
in use cases of small size for both single and full queries. Coupled with
the patch with single queries API, it reduces the performance impact of
single queries to < 100%

Change-Id: I63ebb20b2441aff1345b733f1ffc25314e63ffd2
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91754
Reviewed-by: Hudson CI
Reviewed-by: Loic Prieur-Drevon <loic.prieur.drevon@ericsson.com>

datastore: Add API for single queries

When what we want is only one interval, there is no need to get them
all, we can just fast return when the one interval is found.

This change alones reduces the performance impact of the datastore by
~2x for single queries in the case of smallish traces.

This patch also adds a binary search to find the first interval to
look at.

Change-Id: I77d0ac9818f272f7d160f92666445ce2d8b3200a
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91753
Reviewed-by: Hudson CI
Reviewed-by: Loic Prieur-Drevon <loic.prieur.drevon@ericsson.com>

charts: Add interactivity and signals

This patch adds a basic signal that is sent when the
selection inside a chart is updated.

Change-Id: I31e66701dfb2cf495fea4d948fe90e545485d30c
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/78348
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

charts: Add dialog for making a custom chart

This patch adds a dialog that allow to configure a chart
based on the possible data descriptors of a data
provider.

Change-Id: Ia790b11083ef07b49953cf9f3578eeaea7785495
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77162
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

charts: Add custom bar charts

Change-Id: I050dff9ad39e269c4b890aadc4fb403689ada09a
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77161
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

charts: Add custom scatter chart

Change-Id: I1ced02d5e7bb6f34bfa11a58d7dacbe2ba00f6d8
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77160
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

charts: Add abstract class for XY charts

Change-Id: I4b1ada5be47da16e4942ead2f28f0b8b5c084f30
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77159
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

doc: Update the link to XML analysis example

secretaire.dorsal.polymtl.ca is now available only in https

Change-Id: I9bc44eea31847d2d16f8f2f249e717a19a14fd48
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/92159
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

doc: Document Optimize button

Fixes Bug 508946.

Change-Id: Iead742de3152c81136dc8283a00926372174e95c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91830
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

releng: update some maven plugin versions

Change-Id: I73929804a93004eef63f1cd24851a90c4a89720e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91362
Reviewed-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

Remove some extra lines by using SWTBotUtils

Change-Id: Iad76c781d32bd33ff4d3162d6866030db5ffcd29
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81835
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

releng: Add additional arguments to the command line

This will allow for instance to add arguments to enable logging for a
custom test suite

Change-Id: I149ee22e8d4843f596d45e476021b8ad0fba0008
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91811
Reviewed-by: Hudson CI
Reviewed-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>

releng: Add a test suite for all SWTbot perf tests

These tests can be run with JUL enabled to get data for UI
responsiveness.

Change-Id: I87cf69155262089dfe017db5ad4980951308224e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/80262
Reviewed-by: Hudson CI
Reviewed-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>

analysis: Add a few missing @RunWith(SWTBotJunit4ClassRunner.class)

So we can get screen shots when the tests fails.

Change-Id: I8e53f8767ed1c42ecfeeaa15fcd47ae7ac60fe1d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91714
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

releng: Add missing javax.xml dependency for staging target

This fixes the missing javax.xml dependency for org.apache.xerces.
javax.xml is no longer packaged with the Eclipse RCP features but
apache.xerces still depend on it (for XML editor, etc).
If Orbit updates the dependency then we'll be able to remove it but
it might not be worth the effort at this time.

See also
https://bugs.eclipse.org/bugs/show_bug.cgi?id=467028

Change-Id: I9c1fa21efb5fa992464cae2af08641c80dde23f3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/90886
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

releng: Use Eclipse 4.6 milestone builds

This will allow us to test and build using the Eclipse 4.6.3 RCs.
Also, derby can now be used from Orbit because test.performance was
updated to use “import package” instead of require-plugin. It is better
to use the one in Orbit because it is on download servers instead of
build.eclipse.org which has proven to be unreliable.

Change-Id: Ie61da4b0cec68e5071ef529993e8d9815a85b523
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91153
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix TmfTestTrace.getFullPath in Windows

The path passed as argument to Bundle.getResource(String) should not use
the backslash as separator.

Change-Id: I8efbe18b5c3f4b1a325b05d788902ae6c2e6cfde
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/91655
Reviewed-by: Hudson CI
Reviewed-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>

tmf: Fix deletion of supplementary files in unit tests

The trace should be disposed before attempting to delete supplementary
files, otherwise the checkpoint indexer could still be holding a file
handle to the index, and file deletion fails in Windows.

Change-Id: I81f04dfd198c9a49f1dfdce36673e532bdf8b54d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/91576
Reviewed-by: Hudson CI
Reviewed-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>

segStore: Introduce IContentSegment

Make TmfXmlSegment implement an IContentSegment

Change-Id: Ie6126f88fadc4c32c997b4d568b77e50ea39ec36
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/86294
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

tmf: Add public trace import operation

Change-Id: Ic0f84ec5648abf8591a31042da513b35f3c927d2
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/90320
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fix TmfTestTrace.getFullPath()

Change getFullPath() to return an absolute path and update callers
accordingly. The internal directory is no longer a relative path from
the plug-in installation location, which allows getTrace() to work
properly when called from another plug-in.

Change-Id: I761ce633da8a64e33fe83e062478da566d5c795c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/91408
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Bug 512509: Time graph viewer initial layout is incorrect

Set an initial width hint on the Tree layout data at construction.

Change-Id: I7c7e1fe219e5b53fb0830111ea9a1d0511efe9f7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/91552
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Add more checking to UstKernelSyncTest

The testOneEvent() fails spuriously. Either the wrong event is
retrieved from the trace, or the analysis module is somehow not
ready when it should be.

This extra check will allow us to determine which one of those
two causes is the problem.

Refs bug 506868.

Change-Id: Ie6646a734fcf07a21c810d15c708db3a460c8765
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/85187
Reviewed-by: Hudson CI
Reviewed-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

segStore: Add a INamedSegment interface

This interface is to be implemented by any segment that has a name. This
name can be used in statistics, and other segment store views

Change-Id: Idc1ff17d9725b6ac0b1d79c04c61fedd96366278
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/82284
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

tmf: Deadlock closing a trace as a signal is calling getAnalysisModules

When a trace is opened, a traceRangeUpdated signal is sent
asynchronously. Depending on when this thread starts running, the trace
might open and the user might close the trace before it starts.

-The trace cannot finish disposing before the signal is finished because
when it tries to dispose its analysis, they unregister themselves from
the signal manager, but TmfSignalManager.unregister is synchronized
-The signal cannot finish because it is waiting for the lock on the
analysis map (being iterated in the dispose thread).

Here is an illustration of it:
Thread 1 (dispose): > analysis map lock > waiting on signal manager lock
Thread 2 (signal) > signal manager lock > waiting on analysis map lock

Bug: 512394
Change-Id: I0f27aa6c976a54368f79cd885a561c6ce8ac3dba
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91427
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

analysis.ui: Fix Export to TSV action in segment store statistics view

This adds the style SWT.SAVE to the dialog and asks the user to override
an existing file before the save. Test will be added in a subsequent
patch.

Change-Id: I4b97197c94e46cfb7f6894902012f1ef242c0ceb
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91508
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fix timeouts wrongly set to 2 secs

Change-Id: I371c6a51fa6aec82d7f9d35e7cfbca8b9d23902c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91500
Reviewed-by: Hudson CI

releng: Fix doc index build failure

By default, the eclipserun plugin uses Java 7 execution environment.
But we need Java 8 now for Neon.

Change-Id: Icb3592397b84ccc7cb7d0bfa4c4881bdbb1dfee4
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91428
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

timing: Cancel previous flame graph build job

Fixes bug 512195

The flame graph view was previously waiting for the previous job to
finish, waiting to acquire the lock, often in the UI thread. Now the
previous job is cancelled before acquiring the view's lock.

Change-Id: I36562822628e93560eefd26fc89cbf02d9469557
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91086
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Add onFail() method for analysis

This method is executed upon failure so that analyses can make their
state coherent when failure occurs.

Change-Id: Iad689d83ffb3c508160a3a099119f8a6c11dc2a6
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/90668
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Catch exceptions and gracefully fail state providers

Partially fixes 504078.

When a runtime exception occurs in a state provider, it enters
sink mode, does not read more events and fails gracefully.

Change-Id: I9c8bde9561cc2fd6d49b699b7632a4594e4ec744
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/83277
Reviewed-by: Hudson CI

os.linux: Have the I/O analysis depend on TID

It uses this dependency through the aspect, but the aspect uses TID
analysis now, not the kernel analysis anymore.

Change-Id: I028a7ea98ead5023aea3113148332f837391ca54
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91054
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

releng: Add more script documentation, examples

Change-Id: I87b8ee328055ce464c762555a5cf011fa8f70db5
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/88910
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

releng: Update eclipserun update site and test-traces to latest

This helps not downloading multiple versions and saves time.

Change-Id: I71bd110d8bbbc7843670f4b48e030badca133729
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/80136
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Fix some API errors with Eclipse 4.7

Adding fields is now an error but we probably want to ignore this
because it is quite restrictive

Change-Id: I0b4cea6a13a7db09e072a40f98bb91eefe718f9d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/90757
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

releng: upgrade to tycho 1.0.0

useProjectSettings is now true by default so it can be removed.

See https://wiki.eclipse.org/Tycho/Release_Notes/1.0.0

Change-Id: Iff20634fe883effbfaf7575063870470316df5c9
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/90453
Reviewed-by: Hudson CI
Reviewed-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>

rcp: update copyright year to 2017

Change-Id: I428e6c5a63eb4b7f0470816bc7739950113ea5a1
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91209
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

xml: Use the base trace for provider's invalid tests

This should fix the Hudson job failing sometimes

Change-Id: I72b3fd76d1a4d09c633a7bf79c934787c240eeb6
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91159
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

releng: Fix TmfPerspectiveManagerTest on Mac

Preferences should be opened with the util method.

Change-Id: I572d74c9335b1e26c24d8a797ccc2d6b63bbfe9d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/90758
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf.core: add new constructor to AbstractTmfStateProvider

This allows state providers with custom buffered blocking queues.

Change-Id: Id462f50b8cc48c96303d6d69e6143ab1e04b0ed8
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/83276
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf.xml: Throw an exception if element not found

This should not happen, so it's better to throw an exception and
recover at this point. Otherwise, exceptions end up being thrown
somewhere else and are harder to recover from.

Change-Id: I043a59d7ab040bb6da6cd087d6f10645207672fe
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/90667
Reviewed-by: Hudson CI

releng: update versions to reflect changes since 2.2 release

Change-Id: Ib419f448d0c7dc65f7602ebd568b7580e345037b
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/90970
Reviewed-by: Hudson CI
Reviewed-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>

linux.ui: make CpuUsageComposite use iteratorOverQuark and optQuark

We directly retrieve the quark for the thread's name.
By using optQuark instead of getQuark, we stop relying on exceptions.
By using QuarkIterator instead of QueryHistoryRange, we make the
query "lazier" and stop querying the state system once the process
name is found.

Change-Id: I211fe74a69352233038cc737e1df728221dccd13
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Reviewed-on: https://git.eclipse.org/r/85793
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fix leaked traces/event providers

A recent test added is not disposing the traces.

Change-Id: I90e53ef339c4e6ec921c08fbdfe8650c210a18c5
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/90995
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>

datastore: Be less strict on the query range of children

Just return an empty list when the time range does not intersect with the
node's range instead of throwing an exception.

Change-Id: I7f9aaa78cb410d26e713ea966efb74648d95b920
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/90602
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ss: Add javadoc to StateSystem#waitUntilBuilt(long)

If the timeout specified less or equal to 0, then there will no waiting and
this can be used as a "isBuilt" method for the state system.

Change-Id: I6110622071249cd456801fc220500740ba72d6b4
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/90309
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

Update MAINTAINERS

Remove myself from maintainer of various components, reflecting the
fact that EfficiOS will unfortunately reduce their involvement into
Trace Compass.

I have marked the relevant components as "Open", since current
co-maintainers may not want or be ready to become main committers on
those.

Change-Id: I042ff07fb28548367846abf628802fc9214504d6
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/90858

tmf.core: Move the analysis cancel log message

The analysis cancellation should be logged only if it was running
and is really cancelled. Otherwise, it produces confusing messages
where the analysis was previously finished and then cancelled.

Change-Id: I1704f2a29312b6c1a2a9b15e4869bcb646ab1204
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/90577
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

os.linux: Fix NPE in input/output analysis

The block rq sector field is not present in the block_bio_frontmerge
event, but can easily be computed from the other field data.

Change-Id: Ib5b056d97cffac82a8bcfa1be80bc713504091a1
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/90555
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: catch exception for coalesced requests

When an event request that is coalesced causes a runtime exception,
it should not cause the failure of all the other requests coalesced
with it. This fails only the faulty one.

Change-Id: Ie339775fef23210f72fcf93e882b37e2ea8ce646
Signed-off-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/83141
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: bug 487976: Add null checks for traces/exp. folders getters

This avoids NPE when Traces or Experiment folder have been deleted.
Handle gracefully the case when these folders don't exist on disk.

Change-Id: I5be56609be138dc22f6917e5da2a9638d140fb0c
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/89142
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

ss: Revert "Switch the statesystem to the datastore HT"

This reverts commit cf8efcef276dab1aff04b8ddbfedb50ae8a09dab.

The new code path seems to introduce performance issues, especially with
benchmarks. Some investigation is needed, but reverting it is the safest
route for now.

Change-Id: I54dc7c4e297e9b633115145770648145030cc39b
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/90640
Reviewed-by: Hudson CI

xml: XML modules should not be automatic

Those modules may require a lot of processing and there may be many of
them, so it is better to execute them on demand only.

Change-Id: Ide7819fe286c290be1c4aabda0c4283d6b6db788
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/89134
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

ss: Switch the statesystem to the datastore HT

Change-Id: Ie7b57928c610172241584578494cb242905596af
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/85163
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

charts: Make the custom chart formatters immutable

Change-Id: I44885b7bb00a9bd198e9c111f9511b157def390e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/89470
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

common: Annotate BigDecimal

Also remove checkNonNull where necessary and add annotations where
possible in the timestamp transforms

Change-Id: I2582595d6993df19725e1b2d50e72e492739ebd5
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/90452
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

charts: Add unit tests for the .ui plugin

Add tests for the ChartRange class

Change-Id: Ic0e1e4bd9ff170a2b5d831c1f1ffdf86e01588c1
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/89901
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.core: Partial ss API should not expose restricted classes

Since the callers of the partial state system do not have access to the
StateSystem class, it should not be required. It is replace by an
internal validation of the input.

Change-Id: Id2c345fa36ce048990419feba4898b64e7a14823
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/90308
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

common: Annotate some methods of ImmutableBiMap

Change-Id: Iae85a8036eb16843d82b4b0c5b0ad90d404ea688
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/90191
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: Fix Perf event layout error

IRQ entries and exits were inverted.

Change-Id: I38b6ca07fb7bd26d8447d6eb47c786fb7522293b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/90269
Reviewed-by: Hudson CI

common: Annotate the HashBiMap.create([...]) methods

Change-Id: I5e5c8f5a8e51569828d69241d5695d4eefee331b
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/89767
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf.core: Make TmfTimestampFormat#toPattern NonNull

And all the changes required for this to work.

Change-Id: Ie07326346cf187f37011d5c624665186440f4517
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/90189
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Add perspective manager

The perspective manager handles switching perspective when a trace is
opened which has an associated perspective and the preference allows it.

Change-Id: I284c4aad6141717d101325871e58c0c114aac6a7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/89631
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: Add Switch to Perspective preference

The Switch to Perspective preference is added. A new Perspectives
preference page is added to manage the preference.

Change-Id: I3fdc49f1c2436fbfca52d664e5a386ff0229b122
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/89630
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Add perspective element to trace type UI extension point

The 'perspective' element is added to the tracetypeui extension point.

The method TmfTraceTypeUIUtils.getPerspectiveId(ITmfTrace) is added.

The associated perspective is set for some plug-in extensions.

Change-Id: Ib62add83a99cd50a6b56b4e0099705ec0f88d168
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/89629
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

charts: Better protect ChartRange to avoid null ranges

Also:

* Add toString methods to chart range and range map
* Remove setMinimum and setMaximum mutators (they are not used)
* Add methods to get the pattern of the timestamp formatter

Change-Id: I4ea0fd34c06af8e09194cd6bfb5d256b334d0993
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/89468
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

datastore: Have RangeCondition extend Predicate

The contains method is replaced by the Predicate's test method. This will
allow to use the RangeCondition as a Predicate in some situations.

Change-Id: I85ab49a5663c5179f22d094b0a8e11568c1b90db
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/89119
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI

datastore: Add an overlapping history tree

This adds a generic implementation of an history tree where children
nodes are allowed to overlap their ranges.

Change-Id: Ie5f8de62924361430c5d5b38e8ed1fbbc6d755dc
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/85801
Reviewed-by: Hudson CI

datastore: Add a classic history tree implementation

This adds a basic generic implementation of the classic history tree, ie
a tree where children start at the end time of its previous sibling + 1
and children nodes cover the full range of the parent node.

Change-Id: I92f988a8f83c11d25f35070c59d4c4d38eb9e3aa
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/85800
Reviewed-by: Hudson CI

datastore: Add unit tests for the generic history tree

Change-Id: I05fbc90b9845f8f6a703da4a3e9ae0733d9d6ad4
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/85161
Reviewed-by: Hudson CI

datastore: Add generic history tree

Adds an history interface and abstract implementation as well as some
classes needed to serialize data to the tree and exceptions.

Change-Id: I8bd100cc9c6a0f586b3ab6ae32999a4086ea3640
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/84478
Reviewed-by: Hudson CI

datastore: Test the discrete and continuous range conditions

Change-Id: I6d56fd97c5d315d0b4173b006ec15565aa3053ae
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Reviewed-on: https://git.eclipse.org/r/87393
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

datastore: Add RangeConditions to datastore

This will be used by history tree queries.

Change-Id: I6bf6c5dfe1c215ac49afaf42f603326502ebf937
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/87174
Reviewed-by: Hudson CI
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

releng: add checks to python scripts

This will helps the ux of the scripts.

Change-Id: Ifd5375f13328c415d406afbee4436b12c2563178
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/89899
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

tmf.xml: Fix XML analysis manager dialog

The Edit button is now disable just after a delete file.

Change-Id: I8b1e6c0607d3049f5e4dac79f2232e9ec1d09f13
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/87178
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

charts: Add units to numerical descriptors

Like durations, any numerical descriptor could have units. Duration can
now inherit more of its parent behavior.

Change-Id: I151936bf5700dd6bb9b60b2d60a51350b5ec8083
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/89467
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lami: bug 510984: allocate new formatter for each axis

When two axis show the same data type both have
the same formatter with the Y-axis internal and external ranges.

Allocate a new formatter each time with the corresponding internal and
external ranges.

Formatters are now immutable.

Change-Id: If01d5cb4f9a396fa37fad8295ad2a41cc6401e3c
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/89465
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

charts: Fix numerical data that can be null

The numerical consumer assumed the data received could not be null, but
it can be null.

If the test predicate passes, null values are mapped to zero.

Change-Id: If819bf29044a207581b36be1d35e846948c20650
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/89466
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

custom charts: Add unit tests for core classes

Change-Id: Ib5d4e40d031beb38f8bf4d543b3c1ca95a450eed
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/88122
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

charts: Move a few classes from .ui to .core

Some interfaces for the consumers and aggregators that were previously in
the .ui package can be moved to core as they do not depend on anything ui.
The data can be consumed in the core plugin and only displayed in the
.ui.

Change-Id: I50e2f73407bc912a6236df04012d7f9468945ea5
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/89881
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lami: add toString method to lami aspects

This makes debugging the lami code much easier

Change-Id: I958a7f6594620802299862f5aa8d99a629d42075
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/89544
Reviewed-by: Hudson CI
Reviewed-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@efficios.com>

custom charts: Have chart data return a collection

It is read-only, so returning a list does not make sense, it cannot be
modified anyway.

Change-Id: I458dcd83b60f9a2d7960746ff370dc63d94c0332
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/88121
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.core: Add failure causes to analyses

And state system analyses can fail when their event requests failed.

Change-Id: Id3bcaf88378cd16e8f0f7ac7aa4d2f0c7c574392
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/84037
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

timing: Deprecate SegmentStoreStatistics

Change-Id: Ib2fbea317cfc8e561a524c56d03ab1eef54eedc1
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/88905
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

timing.ui: Update callgraph density viewer test to Statistics

Change-Id: I564d48cbcd692c68e612f7872aa65f633bc07a4e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/88904
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

timing: Update callgraph to use Statistics

The aggregated function statistics have one statistics object for
durations, one for self times.

Change-Id: I6f36f653bb082915d7cc7a03a09e9bcc4947aa48
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/88903
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

timing: ss statistics use the common statistics

This patch has the SegmentStoreStatistics class use a Statistics object
instead of calculating the statistics themselves (it will later be
deprecated entirely, but there are too many things to fix for one patch)

It deprecates the methods of the AbstractSegmentStoreAnalysis that used
the SegmentStoreStatistics class.

It also deprecates the current abstract statistics view and viewer in
the UI and replaces them with one using the new statistics class.

Change-Id: Idfdeed3198d70d0eae7b75b90453f67ddb138809
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/88901
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

timing: Add/update some toString methods in callgraph

It makes it easier to debug the callgraph code without having to deeply
inspect each object.

Change-Id: I9c35d570e13f1d4b506df4d83450e83a1c1dfd64
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/88902
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>