Mathieu Desnoyers [Thu, 22 Aug 2013 21:48:59 +0000 (17:48 -0400)]
Fix: improve error message when UST support is disabled
Fixes #583
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Thu, 22 Aug 2013 21:04:08 +0000 (17:04 -0400)]
Fix: add missing short filter option in help
Fixes #587
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 22 Aug 2013 20:59:21 +0000 (16:59 -0400)]
Fix: typo in configure.ac for version check
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 22 Aug 2013 20:56:22 +0000 (16:56 -0400)]
Fix: remove calibrate syscall option from code
Fixes #586
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 22 Aug 2013 20:46:58 +0000 (16:46 -0400)]
Fix: snapshot should fail if no successful snapshot is taken
Fixes #606, #608
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 22 Aug 2013 20:05:58 +0000 (16:05 -0400)]
Fix: check UST float field mantissa length
Fixes #473
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 21 Aug 2013 16:04:02 +0000 (12:04 -0400)]
Fix: add UST context in the same order the user enabled them
This is to avoid having different field order in different traces for
the same contexts enabled in the same order by the user.
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Mon, 19 Aug 2013 19:03:27 +0000 (15:03 -0400)]
Introduce configure --with-lttng-system-rundir
Allow overriding the path where the system-wide sessiond keeps its
runtime files.
It does _not_ allow multiple instances of system-wide sessiond to run in
parallel though, because the wait shm files still requires having only
one single system-wide sessiond at any given time.
Fixes #521
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Mon, 19 Aug 2013 16:09:40 +0000 (12:09 -0400)]
Add .dirstamp to gitignore file
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 19 Aug 2013 16:08:06 +0000 (12:08 -0400)]
Fix: snapshot with multiple UIDs
This commit refs #615. Waiting on the confirmation of the author to
close it.
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Fri, 16 Aug 2013 21:35:38 +0000 (17:35 -0400)]
Prepare for automake deprecation of missing subdir-objects
Ensure old and new automake will behave in the same way.
Fixes #594
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 16 Aug 2013 21:18:12 +0000 (17:18 -0400)]
Fix: typos in --help and manpage
Fixes #604
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 16 Aug 2013 21:10:52 +0000 (17:10 -0400)]
Fix: add-context without -c apply to all channels
Fixes #618
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 16 Aug 2013 20:58:02 +0000 (16:58 -0400)]
Fix: channels can be _enabled_ after tracing is started, but not created
Fixes #619
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Zifei Tong [Fri, 16 Aug 2013 20:52:21 +0000 (16:52 -0400)]
Fix filter parser segmentation fault with bison 3.0
Replace deprecated YYLEX_PARAM with %lex-param
Tested with bison 2.4, 2.5, 2.7 and 3.0.
Signed-off-by: Zifei Tong <soariez@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 16 Aug 2013 20:50:43 +0000 (16:50 -0400)]
Fix: typo in error msg
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 16 Aug 2013 20:48:08 +0000 (16:48 -0400)]
Fix: imprecise error message about root sessiond/tracing group
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 16 Aug 2013 20:07:54 +0000 (16:07 -0400)]
Fix: don't skip chmod if tracing group is not found
Fixes #620
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 15 Aug 2013 18:11:16 +0000 (14:11 -0400)]
Tracepoint probes don't need extern C
tracepoint.h has the proper extern C guards, so every liblttng-ust API
called from the probe has the proper linkage.
The rest of the symbols are only meaningful within the probe, so we
don't care if they are mangled or not.
This fixes all UST applications in tests/
Fixes #597
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Christian Babeux [Thu, 15 Aug 2013 17:03:36 +0000 (13:03 -0400)]
Fix: Snapshot should be taken asap in core handler script
Taking a snapshot should be the first thing the core handler does.
An enormous core file write to disk could potentially discard a lot
of tracing data if done before the snapshot.
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Tue, 13 Aug 2013 21:40:28 +0000 (17:40 -0400)]
Fix: reset out_fd_offset when we rotate the trace file
This value is only used for the sync_file_range, but it has to be set
to 0 when we start to write in a new trace file, otherwise the values
passed to this call are bogus.
Applied to 2.3, but could probably be backported to 2.2.
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Wed, 7 Aug 2013 18:58:05 +0000 (14:58 -0400)]
Fix: LTTNG_ERR_NEED_ROOT_SESSIOND error message
A root session daemon _and_ "tracing" group user membership are required
to trace the kernel.
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 8 Aug 2013 09:02:30 +0000 (05:02 -0400)]
inet/inet6 sockets: apply timeout
Close #546
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 8 Aug 2013 09:01:53 +0000 (05:01 -0400)]
Implement timeout for connect ipv4/ipv6
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Wed, 7 Aug 2013 09:26:51 +0000 (05:26 -0400)]
Introduce LTTNG_NETWORK_SOCKET_TIMEOUT env. var
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Simon Marchi [Mon, 29 Jul 2013 19:22:45 +0000 (15:22 -0400)]
bash completion: add calls to _lttng_complete_sessions
Improve a little bit the dummy implementation of
_lttng_complete_sessions and add two calls where it can be useful.
Reported-by: Daniel U. Thibault <daniel.thibault@drdc-rddc.gc.ca>
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Simon Marchi [Mon, 29 Jul 2013 19:22:44 +0000 (15:22 -0400)]
bash completion: Fix copy-paste typo
Reported-by: Daniel U. Thibault <daniel.thibault@drdc-rddc.gc.ca>
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Simon Marchi [Mon, 29 Jul 2013 19:22:43 +0000 (15:22 -0400)]
Extras: Remove deprecated consumer commands in bash completion
enable/disable consumer were removed a while ago. Remove autocomplete
for them to discourage people of using them.
Reported-by: Daniel U. Thibault <daniel.thibault@drdc-rddc.gc.ca>
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Simon Marchi [Mon, 29 Jul 2013 19:22:42 +0000 (15:22 -0400)]
bash completion: Remove underscores in handler function names
If the command name contains a dash, it is removed to derive the
function name that will handle completion. For example, add-context
becomes _lttng_cmd_addcontext. The functions with erroneous names
were not getting called.
Reported-by: Daniel U. Thibault <daniel.thibault@drdc-rddc.gc.ca>
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Simon Marchi [Mon, 29 Jul 2013 19:22:41 +0000 (15:22 -0400)]
bash completion: Remove --event for add-context
--event has been remove in
601d5acf42ebdb05ff8aa19f12fd9bdad3602781.
Reported-by: Daniel U. Thibault <daniel.thibault@drdc-rddc.gc.ca>
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
David Goulet [Tue, 6 Aug 2013 10:34:28 +0000 (06:34 -0400)]
Update gitignore
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Mon, 5 Aug 2013 19:26:41 +0000 (15:26 -0400)]
relayd: use version macros from build rather than scanf
Acked-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 5 Aug 2013 19:24:31 +0000 (15:24 -0400)]
sessiond: use version major/minor from build for communication with relayd
Acked-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 5 Aug 2013 19:23:27 +0000 (15:23 -0400)]
build: export major/minor/patchlevel numbers
Acked-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Christian Babeux [Mon, 5 Aug 2013 19:11:30 +0000 (15:11 -0400)]
Fix: Dead code when checking return value from (ust_app|kernel)_snapshot_record
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Mon, 5 Aug 2013 19:04:04 +0000 (15:04 -0400)]
Test: enable kernel events after start
This test detects if we actually append new metadata when enabling a
kernel event after a start.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 5 Aug 2013 17:46:58 +0000 (13:46 -0400)]
Fix: kernel ctl error codes are based on errno
ioctl returns -1, and error codes are based on -errno.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sun, 21 Jul 2013 23:58:09 +0000 (19:58 -0400)]
Fix: format string mismatch
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sun, 21 Jul 2013 23:22:06 +0000 (19:22 -0400)]
test: test_periodical_metadata_flush shrink timer period, kill app
Decrease the switch timer period to 100ms (instead of 1s), since we're
only getting 2s worth of app run. If the system is busy, nothing really
guarantee that the timer will indeed fire during this time-frame (so
strictly speaking, this test could still fail).
Also, kill the application before trying to read the trace: this should
ensure that the trace is not appended to concurrently with validation.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sun, 21 Jul 2013 23:08:06 +0000 (19:08 -0400)]
Fix: format string type mismatch
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sun, 21 Jul 2013 18:26:45 +0000 (14:26 -0400)]
snapshot howto: update text
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sun, 21 Jul 2013 18:23:42 +0000 (14:23 -0400)]
Add snapshot howto
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 19 Jul 2013 22:47:10 +0000 (18:47 -0400)]
Version 2.3.0-rc2
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 19 Jul 2013 22:10:29 +0000 (18:10 -0400)]
Add core-handler README to dist tarball
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 19 Jul 2013 21:55:00 +0000 (17:55 -0400)]
extras: core-handler: simplify, allow usage from tracing group
Allow managing the coredump handler tracing session from the tracing
group. Use create --snapshot.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 19 Jul 2013 21:05:09 +0000 (17:05 -0400)]
Cleanup: add missing dot
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 19 Jul 2013 20:56:16 +0000 (16:56 -0400)]
Fix: documentation: create name and options
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Christian Babeux [Fri, 19 Jul 2013 20:12:49 +0000 (16:12 -0400)]
Add core dump snapshot handler script
This is a custom core dump program that will be called when a core dump
occurs. The program will save the core data in CORE_PATH and also, if a
root session daemon is running, will record a snapshot of tracing data
using the lttng command line utility.
Refer to README for installation and testing instructions.
Sample output of test script:
Setup...
Spawning a session daemon
Session auto-
20130626-224838 created.
Kernel channel chan enabled for session auto-
20130626-224838
kernel event sched_switch created in channel chan
Tracing started for session auto-
20130626-224838
Sleeping...
Crashing...
./test.sh: line 35: 16980 Segmentation fault (core dumped)
$(dirname $0)/crash
Waiting for data availability
Tracing stopped for session auto-
20130626-224838
Session auto-
20130626-224838 destroyed
Core dump and snapshot will be available in /tmp/lttng/{core,snapshot}.
/tmp/lttng
|-- core
| `-- core.16980
`-- snapshot
`-- snapshot
|-- chan_0
|-- chan_1
|-- chan_2
|-- chan_3
|-- chan_4
|-- chan_5
|-- chan_6
|-- chan_7
`-- metadata
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 19 Jul 2013 18:43:05 +0000 (14:43 -0400)]
Fix: sym name len (kernel)
Use kernel and not UST sym name len for kernel tracing. Fixed build when
UST is disabled.
Fix bug introduced in 2.3-rc dev cycle by:
commit
850767541647c102a299d7fbc39c97555ac70224
Author: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Fri Jul 19 09:04:29 2013 -0400
Fix: (slight UI change) refuse missing -c if non-default channel exists
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 19 Jul 2013 18:06:14 +0000 (14:06 -0400)]
Fix: tests: provide channel name when a non-default channel exists: per-pid
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 19 Jul 2013 17:59:39 +0000 (13:59 -0400)]
Fix: tests: provide channel name when a non-default channel exists
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 19 Jul 2013 17:28:13 +0000 (13:28 -0400)]
Fix: data pending race
There is a data pending race involving late population of the streams in
the stream hash table, and applying flush on streams that are not yet
globally visible.
This is caused by the fact that streams are added to the hash table only
when received by the data-handling consumer thread.
This results in data_pending() incorrectly returning that there is no
data pending in some cases.
This has been discovered by adding 1s delay in read subbuffer function
for testing.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Fri, 19 Jul 2013 16:36:15 +0000 (12:36 -0400)]
Fix hang in make check snapshots/test_ust
Missing a kill of the test app at the end of
test_ust_1000_local_snapshots.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 19 Jul 2013 15:29:14 +0000 (11:29 -0400)]
Cleanup: ust-consumer: wrong indentation
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 19 Jul 2013 14:36:52 +0000 (10:36 -0400)]
Fix: print dots while waiting for data availability
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 19 Jul 2013 14:04:12 +0000 (10:04 -0400)]
Fix: remove sleep(1) added by "Fix: (slight UI change) refuse missing -c if non-default channel exists"
For debugging, added by mistake.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 19 Jul 2013 13:04:29 +0000 (09:04 -0400)]
Fix: (slight UI change) refuse missing -c if non-default channel exists
After a user creates a channel within a session, creating a "default"
channel if a user forgets to put "-c channel_name" in the following
add-context, enable-event, disable-event commands is misleading. The
natural expected behavior would be that the command would apply the the
last enabled channel (notion of a "current" channel, like we have for
sessions), but certainly not that it creates a new channel with default
attributes behind the user's back.
An intermediate fix that would not require to keep a notion of current
channel is to refuse creation of a default channel if at least one
non-default channel has already been created in the session.
This commit affects enable-event, disable-event and add-context
commands.
This fix belongs to the 2.3-rc cycle, and cannot be backported, since
it:
a) changes the user interface of lttng (returns an error in the case
where -c name is missing and the session contains an non-default
channel)
b) changes the ABI between lttng-ctl and sessiond: a default channel is
now expressed as an empty string ('\0') rather than by "channel0",
which allows making the difference between an explicit "channel0"
channel and a default channel in the session daemon.
Fixes #522
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 19 Jul 2013 12:59:12 +0000 (08:59 -0400)]
Fix: push metadata on stop for per-UID buffers
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 15:17:26 +0000 (11:17 -0400)]
README: update python documentation
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 14:41:51 +0000 (10:41 -0400)]
Manpage: other layout cleanups
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 14:38:31 +0000 (10:38 -0400)]
Manpage: cleanup layout of view
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 14:37:01 +0000 (10:37 -0400)]
Manpage: cleanup layout of version
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 14:35:59 +0000 (10:35 -0400)]
Manpage: cleanup layout of stop
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 14:34:48 +0000 (10:34 -0400)]
Manpage: cleanup layout of start
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 14:33:17 +0000 (10:33 -0400)]
Manpage: cleanup layout of snapshot
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 14:25:43 +0000 (10:25 -0400)]
Manpage: cleanup layout of set-session
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 14:23:47 +0000 (10:23 -0400)]
Manpage: cleanup layout of list
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 14:19:38 +0000 (10:19 -0400)]
Manpage: cleanup layout of disable-event
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 14:17:24 +0000 (10:17 -0400)]
Manpage: cleanup layout of disable-channel
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 14:15:02 +0000 (10:15 -0400)]
Manpage: cleanup layout of enable-event
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 14:05:52 +0000 (10:05 -0400)]
Manpage: cleanup layout of enable-channel
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 13:50:39 +0000 (09:50 -0400)]
Manpage: cleanup layout of destroy
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 13:44:53 +0000 (09:44 -0400)]
Manpage: cleanup layout of create
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 13:34:51 +0000 (09:34 -0400)]
Manpage: cleanup layout of calibrate
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 13:25:33 +0000 (09:25 -0400)]
Manpage: cleanup layout of add-context
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 13:11:29 +0000 (09:11 -0400)]
Documentation: create --snapshot in manpage
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 02:23:27 +0000 (22:23 -0400)]
Version 2.3.0-rc1
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 02:22:51 +0000 (22:22 -0400)]
Fix: add missing snapshot header to dist tarball
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 18 Jul 2013 02:02:02 +0000 (22:02 -0400)]
Documentation: fix thread quit pipe comment
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Yannick Brosseau [Wed, 17 Jul 2013 18:00:34 +0000 (14:00 -0400)]
Test for presence of bison and flex when building from git
[ Update by Mathieu Desnoyers: handle VPATH build from tarball
by prefixing path with $srcdir. ]
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Wed, 17 Jul 2013 17:44:47 +0000 (13:44 -0400)]
Test UST snapshot with large metadata
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Wed, 17 Jul 2013 17:43:18 +0000 (13:43 -0400)]
Add test application with large metadata
This application generates 5 tracepoints with a lot of parameters. The
resulting metadata is >12kB which is useful to test the behaviour of the
UST metadata cache and the flushing mechanism when there is more than
one metadata packet.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 17 Jul 2013 17:40:15 +0000 (13:40 -0400)]
Cleanup: remove redundant assignment
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 17:29:30 +0000 (13:29 -0400)]
Fix: use per-uid buffer registry for UID buffer snapshots
Fixes empty traces when doing a snapshot after killing a single traced
application.
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 16:44:08 +0000 (12:44 -0400)]
cmd.c: fix typos in snapshot commands
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Tue, 16 Jul 2013 15:07:01 +0000 (11:07 -0400)]
Test snapshot per-uid post-mortem
Test to check if we can take a snapshot after a traced application
exited when using per-uid buffers.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 14:50:34 +0000 (10:50 -0400)]
Remove leftover fprintf
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 13:53:33 +0000 (09:53 -0400)]
Fix deadlock: don't take channel lock in timer
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 13:36:59 +0000 (09:36 -0400)]
Introduce channel timer lock
Currently a shadow of the channel lock. Will eventually be used to
protect channel timer handler from concurrent channel updates without
being held when the timer is stopped (future commit).
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 01:47:21 +0000 (21:47 -0400)]
document lttng_ustconsumer_request_metadata locking constraints
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 01:28:23 +0000 (21:28 -0400)]
consumer: remove unused lttng_ustconsumer_push_metadata
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 01:19:19 +0000 (21:19 -0400)]
Document metadata_socket_lock nesting
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 01:17:06 +0000 (21:17 -0400)]
lttng_ustconsumer_recv_metadata does not need all those locks
Since lttng_ustconsumer_recv_metadata() does not push data into the
stream anymore, it only needs the metadata cache lock.
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 01:15:05 +0000 (21:15 -0400)]
document metadata_switch_timer() deadlock
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 01:06:07 +0000 (21:06 -0400)]
Fix: add missing metadata socket lock
Protect metadata socket, which can be accessed concurrently by the
metadata timer and by snapshot.
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 00:56:51 +0000 (20:56 -0400)]
document metadata_switch_timer() locking constraints
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 00:53:04 +0000 (20:53 -0400)]
consumer: remove timeout for UST metadata
Remove time out for UST metadata by generating metadata packets whenever
they are about to be read from the ring buffer rather than filling them
when the metadata cache is updated, which requires a time out, and
therefore may fail.
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 00:22:48 +0000 (20:22 -0400)]
Introduce pipe for UST metadata cache and stream
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 00:18:13 +0000 (20:18 -0400)]
consumer: replace DBG2() instances by DBG()
The consumer daemon does not currently support DBG2() printout.
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 16 Jul 2013 00:16:07 +0000 (20:16 -0400)]
Introduce utils_create_pipe_cloexec_nonblock()
Reviewed-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
This page took 0.077235 seconds and 5 git commands to generate.