Joe Perches [Thu, 29 Aug 2013 21:08:18 +0000 (14:08 -0700)]
hvc_xen: Remove unnecessary __GFP_ZERO from kzalloc
kzalloc already adds this __GFP_ZERO.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Huang Shijie [Thu, 29 Aug 2013 08:29:25 +0000 (16:29 +0800)]
serial: imx: initialize the local variable
The slave_config is not initialized, so some of its fields may
be set with random data which may causes the failure in the following
dmaengine_prep_slave_sg().
This patch fixes this issue.
Signed-off-by: Huang Shijie <b32955@freescale.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gabor Juhos [Thu, 29 Aug 2013 06:44:01 +0000 (08:44 +0200)]
tty: ar933x_uart: add device tree support and binding documentation
Modify the probe routine to get the port line number
from device tree if the 'of_node' is populated in the
platform device. The driver can be built as module,
thus add an OF specific module device table as well
to support module auto loading.
This makes it possible to use the driver for AR9330
UART devices specified in device tree.
Cc: devicetree@vger.kernel.org
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gabor Juhos [Thu, 29 Aug 2013 09:37:19 +0000 (11:37 +0200)]
tty: ar933x_uart: allow to build the driver as a module
Change the SERIAL_AR933X Kconfig option from
'bool' to 'tristate' in order to allow to build
the driver as a module. Also extend the help text
of the option to reflect that.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stephen Boyd [Wed, 28 Aug 2013 20:32:41 +0000 (13:32 -0700)]
ARM: dts: msm: Update uartdm compatible strings
Let's follow the ratified DT binding and use uartdm instead of
hsuart. This does break backwards compatibility but this
shouldn't be a problem because the uart driver isn't probing on
these devices without adding clock support (which isn't merged so
far).
Cc: David Brown <davidb@codeaurora.org>
Acked-by: Kumar Gala <galak@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stephen Boyd [Wed, 28 Aug 2013 20:32:40 +0000 (13:32 -0700)]
devicetree: serial: Document msm_serial bindings
Let's fix up the msm serial device bindings so that it's clearer
what hardware is supported. Instead of using hsuart (for high
speed uart) let's use uartdm because that matches the actual name
of the hardware. Also, let's add the version information in case
we need to differentiate between different versions of the
hardware in the future. Finally, lets specify that clocks are
required (the clock bindings didn't exist when the original
binding was written) and also specify dma bindings just in case
we want to use it in software. We split the binding into two
files to make it clearer what's required and not required.
Cc: David Brown <davidb@codeaurora.org>
Cc: <devicetree@vger.kernel.org>
Acked-by: Kumar Gala <galak@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kumar Gala [Wed, 28 Aug 2013 19:08:23 +0000 (14:08 -0500)]
serial: unify serial bindings into a single dir
Move all bindings in bindings/tty/serial into bindings/serial so we only
have one place dir with serial/uart related bindings in it.
Signed-off-by: Kumar Gala <galak@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kumar Gala [Wed, 28 Aug 2013 19:08:22 +0000 (14:08 -0500)]
serial: fsl-imx-uart: Cleanup duplicate device tree binding
We had two bindings for the same serial device, it looks like the one in
tty/serial/fsl-imx-uart.txt is the more up to date one so go with it and
merge a few things about the use/need for aliases in from
serial/fsl-imx-uart.txt.
Signed-off-by: Kumar Gala <galak@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gabor Juhos [Wed, 28 Aug 2013 15:08:39 +0000 (17:08 +0200)]
tty: ar933x_uart: use config_enabled() macro to clean up ifdefs
Add a new ar933x_uart_console_enabled() helper function
which uses the config_enable(CONFIG_SERIAL_AR933X_CONSOLE)
macro to decide if the console support is enabled or not.
Remove the 'ifdef CONFIG_SERIAL_AR933X_CONSOLE' statements
and use the new helper function to conditionally enable
console support instead.
If CONFIG_SERIAL_AR933X_CONSOLE is not enabled, the new
helper function will become a null stub which allows the
compiler to optimize out the unused console specific
functions/variables.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gabor Juhos [Wed, 28 Aug 2013 12:21:10 +0000 (14:21 +0200)]
tty: ar933x_uart: remove superfluous assignment of ar933x_uart_driver.nr
The 'nr' field of the 'ar933x_uart_driver' structure
is already initialized with the same value in the static
declaration. Remove the superfluous assignment in the
module init routine.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gabor Juhos [Wed, 28 Aug 2013 08:09:28 +0000 (10:09 +0200)]
tty: ar933x_uart: use the clk API to get the uart clock
The AR933x UARTs are only used on the Atheros AR933x
SoCs. The base clock frequency of the UART is passed
to the driver via platform data. The SoC support code
implements the generic clock API, and the clock rate
can be retrieved via that.
Update the code to get the clock rate via the generic
clock API instead of using the platform data.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christophe Leroy [Wed, 21 Aug 2013 15:59:24 +0000 (17:59 +0200)]
tty: serial: cpm_uart: Adding proper request of GPIO used by cpm_uart driver
cpm_uart serial driver uses GPIO for control signals. In order to be used
properly, GPIOs have to be reserved. Comment in gpiolib.c considers illegal
the use of GPIOs without requesting them. In addition, the direction of the
GPIO has to be set properly.
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Qipan Li [Sun, 25 Aug 2013 12:18:41 +0000 (20:18 +0800)]
serial: sirf: fix the amount of serial ports
SiRFprimaII has three uart ports and three USP-based ports, so there
are totally six lines instead of five.
Signed-off-by: Qipan Li <Qipan.Li@csr.com>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Qipan Li [Sun, 25 Aug 2013 12:18:40 +0000 (20:18 +0800)]
serial: sirf: define macro for some magic numbers of USP
this patch clears some magic numbers for offset and bitshift
of USP registers.
Signed-off-by: Qipan Li <Qipan.Li@csr.com>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter [Mon, 26 Aug 2013 15:10:01 +0000 (18:10 +0300)]
serial: icom: move array overflow checks earlier
This code does an annoying thing where it writes to the array and then
checks later for array overflows. I don't know if it's actually
possible to overflow but let's check before using the array index.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jingoo Han [Thu, 22 Aug 2013 02:08:04 +0000 (11:08 +0900)]
TTY: amiserial, remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jingoo Han [Thu, 22 Aug 2013 02:06:47 +0000 (11:06 +0900)]
serial: st-asc: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stephen Boyd [Wed, 21 Aug 2013 06:48:06 +0000 (23:48 -0700)]
msm_serial: Send more than 1 character on the console w/ UARTDM
We recently added support to send more than one character at a
time for UARTDM hardware but we didn't add the same support in
the console code path. Add support here to speed up console
messages on UARTDM hardware.
Cc: David Brown <davidb@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stephen Boyd [Wed, 21 Aug 2013 06:48:04 +0000 (23:48 -0700)]
msm_serial: Add support for non-GSBI UARTDM devices
Not all UARTDM hardware is part of a GSBI complex. Add support
for these devices and fix a bug where we assumed uartdm meant the
hardware was part of a GSBI complex.
Cc: David Brown <davidb@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stephen Boyd [Wed, 21 Aug 2013 06:48:02 +0000 (23:48 -0700)]
msm_serial: Switch clock consumer strings and simplify code
In downstream kernel we've standardized the clock consumer names
that MSM device drivers use. Replace the uart specific clock
names in this driver with the more standard 'core' and 'iface'
names. Also simplify the code by assuming that clk_prepare_enable
and clk_disable_unprepare() will properly check for NULL pointers
(it will because MSM uses the common clock framework).
Cc: David Brown <davidb@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:29 +0000 (20:14 +0530)]
tty: serial: vt8500: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Cc: Tony Prisk <linux@prisktech.co.nz>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:28 +0000 (20:14 +0530)]
tty: serial: sirfsoc: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:27 +0000 (20:14 +0530)]
tty: serial: tegra: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Cc: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:26 +0000 (20:14 +0530)]
tty: serial: samsung: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:25 +0000 (20:14 +0530)]
tty: serial: sa1100: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:24 +0000 (20:14 +0530)]
tty: serial: rp2: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:23 +0000 (20:14 +0530)]
tty: serial: pnx8xxx: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:22 +0000 (20:14 +0530)]
tty: serial: nwpserial: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:21 +0000 (20:14 +0530)]
tty: serial: netx: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:20 +0000 (20:14 +0530)]
tty: serial: msm: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Cc: David Brown <davidb@codeaurora.org> (maintainer:ARM/QUALCOMM MSM...)
Cc: Daniel Walker <dwalker@fifo99.com> (maintainer:ARM/QUALCOMM MSM...)
Cc: Bryan Huntsman <bryanh@codeaurora.org> (maintainer:ARM/QUALCOMM MSM...)
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:19 +0000 (20:14 +0530)]
tty: serial: mpsc: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:18 +0000 (20:14 +0530)]
tty: serial: mfd: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:17 +0000 (20:14 +0530)]
tty: serial: mcf: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:16 +0000 (20:14 +0530)]
tty: serial: m32r_sio: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:15 +0000 (20:14 +0530)]
tty: serial: lpc32xx_hs: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:14 +0000 (20:14 +0530)]
tty: serial: lpc32xx_hs: don't call tty_flip_buffer_push() twice
serial_lpc32xx_interrupt() calls __serial_lpc32xx_rx() first and then
tty_flip_buffer_push() immediately after that. But last statement of
__serial_lpc32xx_rx() already called tty_flip_buffer_push()..
So, probably its not required to be called twice. Lets remove one of them.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:13 +0000 (20:14 +0530)]
tty: serial: icom: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:12 +0000 (20:14 +0530)]
tty: serial: efm32: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:11 +0000 (20:14 +0530)]
tty: serial: bfin_sport: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:10 +0000 (20:14 +0530)]
tty: serial: bcm63xx: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:09 +0000 (20:14 +0530)]
tty: serial: arc: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:08 +0000 (20:14 +0530)]
tty: serial: ar933x: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:07 +0000 (20:14 +0530)]
tty: serial: apbuart: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:06 +0000 (20:14 +0530)]
tty: serial: altera: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Cc: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Viresh Kumar [Mon, 19 Aug 2013 14:44:05 +0000 (20:14 +0530)]
tty: serial: altera_jtag: drop uart_port->lock before calling tty_flip_buffer_push()
The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.
Crash looks like this (produced with samsung.c driver):
-----
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8)
[<
c01b59ac>] (do_raw_spin_unlock+0xc4/0xd8) from [<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0)
[<
c03627e4>] (_raw_spin_unlock_irqrestore+0xc/0x38) from [<
c020a1a8>] (s3c24xx_serial_rx_chars+0)
[<
c020a1a8>] (s3c24xx_serial_rx_chars+0x12c/0x260) from [<
c020aae8>] (s3c64xx_serial_handle_irq+)
[<
c020aae8>] (s3c64xx_serial_handle_irq+0x48/0x60) from [<
c006aaa0>] (handle_irq_event_percpu+0x)
[<
c006aaa0>] (handle_irq_event_percpu+0x50/0x194) from [<
c006ac20>] (handle_irq_event+0x3c/0x5c)
[<
c006ac20>] (handle_irq_event+0x3c/0x5c) from [<
c006d864>] (handle_fasteoi_irq+0x80/0x13c)
[<
c006d864>] (handle_fasteoi_irq+0x80/0x13c) from [<
c006a4a4>] (generic_handle_irq+0x20/0x30)
[<
c006a4a4>] (generic_handle_irq+0x20/0x30) from [<
c000f454>] (handle_IRQ+0x38/0x94)
[<
c000f454>] (handle_IRQ+0x38/0x94) from [<
c0008538>] (gic_handle_irq+0x34/0x68)
[<
c0008538>] (gic_handle_irq+0x34/0x68) from [<
c00123c0>] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:
00000000 00000000 0000166e 00000000
df80:
c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0:
00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[<
c00123c0>] (__irq_svc+0x40/0x70) from [<
c000f75c>] (arch_cpu_idle+0x28/0x30)
[<
c000f75c>] (arch_cpu_idle+0x28/0x30) from [<
c0054888>] (cpu_startup_entry+0x5c/0x148)
[<
c0054888>] (cpu_startup_entry+0x5c/0x148) from [<
c0497aa4>] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
lock: s3c24xx_serial_ports+0x1d8/0x370, .magic:
dead4ead, .owner: <none>/-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted
3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[<
c0014d58>] (unwind_backtrace+0x0/0xf8) from [<
c0011908>] (show_stack+0x10/0x14)
[<
c0011908>] (show_stack+0x10/0x14) from [<
c035da34>] (dump_stack+0x6c/0xac)
[<
c035da34>] (dump_stack+0x6c/0xac) from [<
c01b581c>] (do_raw_spin_lock+0x100/0x17c)
[<
c01b581c>] (do_raw_spin_lock+0x100/0x17c) from [<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28)
[<
c03628a0>] (_raw_spin_lock_irqsave+0x20/0x28) from [<
c0203224>] (uart_start+0x18/0x34)
[<
c0203224>] (uart_start+0x18/0x34) from [<
c01ef890>] (__receive_buf+0x4b4/0x738)
[<
c01ef890>] (__receive_buf+0x4b4/0x738) from [<
c01efb44>] (n_tty_receive_buf2+0x30/0x98)
[<
c01efb44>] (n_tty_receive_buf2+0x30/0x98) from [<
c01f2ba8>] (flush_to_ldisc+0xec/0x138)
[<
c01f2ba8>] (flush_to_ldisc+0xec/0x138) from [<
c0031af0>] (process_one_work+0xfc/0x348)
[<
c0031af0>] (process_one_work+0xfc/0x348) from [<
c0032138>] (worker_thread+0x138/0x37c)
[<
c0032138>] (worker_thread+0x138/0x37c) from [<
c0037a7c>] (kthread+0xa4/0xb0)
[<
c0037a7c>] (kthread+0xa4/0xb0) from [<
c000e5f8>] (ret_from_fork+0x14/0x3c)
-----
Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.
Similar stuff was already done for few other drivers in the past, like:
commit
2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Tue May 29 21:53:50 2007 +0100
[ARM] 4417/1: Serial: Fix AMBA drivers locking
Cc: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Tue, 27 Aug 2013 23:02:18 +0000 (16:02 -0700)]
Revert "OMAP: UART: Keep the TX fifo full when possible"
This reverts commit
c4415084218c68c5ee2fc583431e89a78d896b19.
Kevin writes:
Hmm, another OMAP serial patch that wasn't Cc'd to linux-omap
where OMAP users might have seen it. :(
I just bisected a strange problem in linux-next on OMAP3 down to
this patch. Reverting it fixes the problem.
On OMAP3530 Beagle and Overo, after boot, doing a 'cat
/proc/cpuinfo' was not returning to a prompt, suggesting
something strange with the FIFO. Hitting return gets me back to
a prompt.
Greg, this one should also be dropped from tty-next until it can
be further investgated and the problem solved.
Reported-by: Kevin Hilman <khilman@linaro.org>
Cc: Dmitry Fink <finik@ti.com>
Cc: Alexander Savchenko <oleksandr.savchenko@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Tue, 27 Aug 2013 22:59:53 +0000 (15:59 -0700)]
Revert "serial: omap: Fix IRQ handling return value"
This reverts commit
908fd7e566b4c12e36e4487d2d5946de5e5ea30f.
Kevin writes:
Greg, without a better justification in the changelog, I think
this patch should be dropped from tty-next.
Reported-by: Kevin Hilman <khilman@linaro.org>
Cc: Ruchika Kharwar <ruchika@ti.com>
Cc: Alexander Savchenko <oleksandr.savchenko@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Qipan Li [Mon, 19 Aug 2013 03:47:53 +0000 (11:47 +0800)]
serial: sirf: add DMA support using dmaengine APIs
if we get the valid dma channels from dts, move to use dmaengine to do
rx/tx. because the dma hardware requires dma address and length to be
4bytes aligned, in this driver, we will still use PIO for non-aligned
bytes, and use dma for aligned bytes.
for rx, to keep the dmaengine always active, we use double-buffer, so
we issue two dma_desc at first, and maintain the status of both
1. dma transfer done: update in rx dma finish callback
2. dma buffer is inserted into tty: update in rx dma finish tasklet and
rx timeout tasklet
so we re-issue the dma_desc only if both 1&2 are finished.
for tx, as we know the actual length for every transfer, we don't need
the above double buffering.
Signed-off-by: Qipan Li <Qipan.Li@csr.com>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Qipan Li [Mon, 19 Aug 2013 03:47:52 +0000 (11:47 +0800)]
serial: sirf: fix the namespace of startup_uart entry
startup_uart_controller() loses namespace, this patch
drops the function directly and move the content into
sirfsoc_uart_startup().
Signed-off-by: Qipan Li <Qipan.Li@csr.com>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Qipan Li [Mon, 19 Aug 2013 03:47:51 +0000 (11:47 +0800)]
serial: sirf: fix the typo for rts/cts gpio
fix the typo in commit
2eb5618de87927e54 which uses two
gpios for rts/cts.
Signed-off-by: Qipan Li <Qipan.Li@csr.com>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Julia Lawall [Mon, 19 Aug 2013 11:20:36 +0000 (13:20 +0200)]
serial: st-asc: replace devm_request_and_ioremap by devm_ioremap_resource
Use devm_ioremap_resource instead of devm_request_and_ioremap.
This was done using the semantic patch
scripts/coccinelle/api/devm_ioremap_resource.cocci
and various manual modifications to move associated calls to
platform_get_resource closer to the resulting call to devm_ioremap_resource
and to remove the associated error handling code.
The initialization of port->mapbase is also moved lower, to take advantage
of the NULL test on res performed by devm_ioremap_resource.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Kryger [Fri, 16 Aug 2013 20:50:15 +0000 (13:50 -0700)]
serial: 8250_dw: Report CTS asserted for auto flow
When a serial port is configured for RTS/CTS flow control, serial core
will disable the transmitter if it observes CTS is de-asserted. This is
perfectly reasonable and appropriate when the UART lacks the ability to
automatically perform CTS flow control.
However, if the UART hardware can manage flow control automatically, it
is important that software not get involved. When the DesignWare UART
enables 16C750 style auto-RTS/CTS it stops generating interrupts for
changes in CTS state so software mostly stays out of the way. However,
it does report the true state of CTS in the MSR so software may notice
it is de-asserted and respond by improperly disabling the transmitter.
Once this happens the transmitter will be blocked forever.
To avoid this situation, we simply lie to the 8250 and serial core by
reporting that CTS is asserted whenever auto-RTS/CTS mode is enabled.
Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
Reviewed-by: Matt Porter <matt.porter@linaro.org>
Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Jackson [Thu, 15 Aug 2013 07:53:44 +0000 (08:53 +0100)]
OMAP: serial: Remove incorrect disabling of IER interrupt
The recent patch to add RS485 contained a bug whereby the IER
interrupt was cleared down incorrectly.
This patch fixes the problem.
Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luis Henriques [Wed, 14 Aug 2013 22:18:37 +0000 (23:18 +0100)]
serial: pch_uart: fix compilation warning
Function wait_for_xmitr is invoked only on functions that either depend
on CONFIG_CONSOLE_POLL or CONFIG_SERIAL_PCH_UART_CONSOLE.
This patch fixes the following warning:
drivers/tty/serial/pch_uart.c:1504:13: warning: ‘wait_for_xmitr’ defined but not used [-Wunused-function]
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Qipan Li [Wed, 14 Aug 2013 22:52:16 +0000 (06:52 +0800)]
serial: sirf: add DT-binding document to describle detailed properties
we defined some special properties for hardware flow control, document them
for DT-binding.
Signed-off-by: Qipan Li <Qipan.Li@csr.com>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Qipan Li [Wed, 14 Aug 2013 22:52:15 +0000 (06:52 +0800)]
serial: sirf: fix the hardware-flow-ctrl for USP-based UART
for USP-based UART, we use two gpios as RTS and CST pins.
Signed-off-by: Qipan Li <Qipan.Li@csr.com>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Barry Song [Wed, 14 Aug 2013 22:52:14 +0000 (06:52 +0800)]
serial: sirf: drop redundant pinctrl_get_select_default as pinctrl core does it
pinctrl core will get default pinmux, so drop it in the sirfsoc serial driver.
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Jackson [Wed, 14 Aug 2013 10:29:38 +0000 (11:29 +0100)]
OMAP: add RS485 support
This patch adds RS485 support to the OMAP serial driver, as
defined in:-
Documentation/devicetree/bindings/serial/rs485.txt
When a UART transmitter is connected to (eg) a RS485 driver, it is
necessary to turn the driver on/off as quickly as possible. This is
best achieved in the serial driver itself (rather than in userspace
where the latency can be quite large).
This patch allows a GPIO pin to be defined (via DT) that controls
the enabling of the driver at the start of a message, and disables
the driver when the message has been completed.
When RS485 is disabled, the RTS pin is set to on.
Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Julia Lawall [Wed, 14 Aug 2013 09:11:22 +0000 (11:11 +0200)]
tty: ar933x_uart: simplify use of devm_ioremap_resource
Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to devm_ioremap_resource.
Move the call to platform_get_resource adjacent to the call to
devm_ioremap_resource to make the connection between them more clear.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@
- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
e = devm_ioremap_resource(e1, res);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Estevam [Fri, 9 Aug 2013 20:58:51 +0000 (17:58 -0300)]
serial: amba-pl011: Use __releases/__acquires annotations
Fix the following sparse warnings:
drivers/tty/serial/amba-pl011.c:687:20: warning: context imbalance in 'pl011_dma_flush_buffer' - unexpected unlock
drivers/tty/serial/amba-pl011.c:1200:13: warning: context imbalance in 'pl011_rx_chars' - unexpected unlock
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
John Crispin [Fri, 9 Aug 2013 18:54:31 +0000 (20:54 +0200)]
serial: MIPS: lantiq: fix clock error check
The clock should be checked with the proper IS_ERR() api before using it.
Signed-off-by: John Crispin <blogic@openwrt.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thomas Langer [Fri, 9 Aug 2013 18:54:30 +0000 (20:54 +0200)]
serial: MIPS: lantiq: add clk_enable() call to driver
Enable the clock if one is present when setting up the console.
Signed-off-by: Thomas Langer <thomas.langer@lantiq.com>
Acked-by: John Crispin <blogic@openwrt.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sachin Kamat [Thu, 8 Aug 2013 11:40:51 +0000 (17:10 +0530)]
serial: bfin_uart: Fix incorrect placement of __initdata
__initdata should be placed between the variable name and equal
sign for the variable to be placed in the intended section.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sachin Kamat [Thu, 8 Aug 2013 11:40:50 +0000 (17:10 +0530)]
serial: bfin_sport_uart: Fix incorrect placement of __initdata
__initdata should be placed between the variable name and equal
sign for the variable to be placed in the intended section.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Sonic Zhang <sonic.zhang@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jingoo Han [Thu, 8 Aug 2013 08:40:55 +0000 (17:40 +0900)]
serial: tegra: use NULL instead of 0
'cons' is a pointer; thus NULL should be used instead of 0.
Also, local symbols are staticized.
Fix the following sparse warnings:
drivers/tty/serial/serial-tegra.c:1209:27: warning: Using plain integer as NULL pointer
drivers/tty/serial/serial-tegra.c:1240:29: warning: symbol 'tegra20_uart_chip_data' was not declared. Should it be static?
drivers/tty/serial/serial-tegra.c:1246:29: warning: symbol 'tegra30_uart_chip_data' was not declared. Should it be static?
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jingoo Han [Thu, 8 Aug 2013 08:38:20 +0000 (17:38 +0900)]
serial: msm_serial: fix comparison of different types
Fix the following sparse warning:
drivers/tty/serial/msm_serial.c:237:37: error: incompatible types in comparison expression (different type sizes)
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jingoo Han [Thu, 8 Aug 2013 08:36:27 +0000 (17:36 +0900)]
serial: ioc4_serial: Staticize ioc4_serial_attach_one()
ioc4_serial_attach_one() is used only in this file.
Also, ioc4_serial is not used; it can be removed.
Fix the following sparse warnings:
drivers/tty/serial/ioc4_serial.c:300:3: warning: symbol 'ioc4_serial' was not declared. Should it be static?
drivers/tty/serial/ioc4_serial.c:2771:1: warning: symbol 'ioc4_serial_attach_one' was not declared. Should it be static?
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Patrick Gefre <pfg@sgi.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jingoo Han [Thu, 8 Aug 2013 08:34:03 +0000 (17:34 +0900)]
serial: icom: fix casting warning
icom_port->uart_port.membase is (unsigned char __iomem *); thus,
casting (unsigned char __iomem *) is necessary to fix the
following warning. Also, local symbols are staticized.
drivers/tty/serial/icom.c:108:26: warning: symbol 'start_proc' was not declared. Should it be static?
drivers/tty/serial/icom.c:116:26: warning: symbol 'stop_proc' was not declared. Should it be static?
drivers/tty/serial/icom.c:123:25: warning: symbol 'int_mask_tbl' was not declared. Should it be static?
drivers/tty/serial/icom.c:1569:54: warning: incorrect type in assignment (different address spaces)
drivers/tty/serial/icom.c:1569:54: expected unsigned char [noderef] <asn:2>*membase
drivers/tty/serial/icom.c:1569:54: got char *<noident>
drivers/tty/serial/icom.c:1090:9: warning: cast truncates bits from constant value (
ffffff7f becomes 7f)
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jingoo Han [Thu, 8 Aug 2013 08:33:27 +0000 (17:33 +0900)]
serial: timbuart: Staticize local symbols
These local symbols are used only in this file.
Fix the following sparse warnings:
drivers/tty/serial/timbuart.c:165:6: warning: symbol 'timbuart_handle_rx_port' was not declared. Should it be static?
drivers/tty/serial/timbuart.c:187:6: warning: symbol 'timbuart_tasklet' was not declared. Should it be static?
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jingoo Han [Thu, 8 Aug 2013 08:32:52 +0000 (17:32 +0900)]
serial: mrst_max3110: fix casting warning
max->port.membase is (unsigned char __iomem *); thus,
casting (unsigned char __iomem *) is necessary to fix
the following warning. Also, serial_m3110_ops() is staticized.
drivers/tty/serial/mrst_max3110.c:716:17: warning: symbol 'serial_m3110_ops' was not declared. Should it be static?
drivers/tty/serial/mrst_max3110.c:847:27: warning: incorrect type in assignment (different address spaces)
drivers/tty/serial/mrst_max3110.c:847:27: expected unsigned char [noderef] <asn:2>*membase
drivers/tty/serial/mrst_max3110.c:847:27: got void *<noident>
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jingoo Han [Thu, 8 Aug 2013 08:32:04 +0000 (17:32 +0900)]
serial: 8250_early: fix comparison of different types
Fix the following sparse warning:
drivers/tty/serial/8250/8250_early.c:196:26: error: incompatible types in comparison expression (different type sizes)
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jingoo Han [Thu, 8 Aug 2013 08:29:48 +0000 (17:29 +0900)]
serial: samsung: fix casting warning
port->membase is (unsigned char __iomem *), not (unsigned long *)
__set_bit() uses (unsigned long *) as the second argument.
Thus, casting (unsigned long *)(unsigned long) is necessary
to fix the following sparse warnings.
drivers/tty/serial/samsung.c:142:33: warning: cast removes address space of expression
drivers/tty/serial/samsung.c:161:33: warning: cast removes address space of expression
drivers/tty/serial/samsung.c:176:33: warning: cast removes address space of expression
drivers/tty/serial/samsung.c:526:40: warning: cast removes address space of expression
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jingoo Han [Thu, 8 Aug 2013 08:41:43 +0000 (17:41 +0900)]
serial: sirf: Staticize local symbols
These local symbols are used only in this file.
Fix the following sparse warnings:
drivers/tty/serial/sirfsoc_uart.c:147:6: warning: symbol 'sirfsoc_uart_start_tx' was not declared. Should it be static?
drivers/tty/serial/sirfsoc_uart.c:636:5: warning: symbol 'sirfsoc_uart_probe' was not declared. Should it be static?
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Barry Song <Baohua.Song@csr.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Qipan Li [Mon, 12 Aug 2013 10:15:35 +0000 (18:15 +0800)]
serial: sirf: make the driver also support USP-based UART
Universal Serial Ports (USP) can be used as PCM, UART, SPI,
I2S etc. this makes the USP work as UART. the basic work
flow is same with UART controller, the main difference will
be offset of registers and bits.
this patch makes the old sirfsoc uart driver support both
sirf UART and USP-based UART by making their differences
become private data.
Signed-off-by: Qipan Li <Qipan.Li@csr.com>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Barry Song [Wed, 7 Aug 2013 05:35:38 +0000 (13:35 +0800)]
serial: sirf: add support for Marco chip
the marco and coming new CSR multiple SoCs have SET/CLR pair for
INTEN registers to avoid some read-modify-write.
this patch adds support for this and make the driver support current
up and coming mp SoCs.
Signed-off-by: Barry Song <Baohua.Song@csr.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sascha Hauer [Mon, 5 Aug 2013 12:40:45 +0000 (14:40 +0200)]
serial: i.MX: evaluate linux,stdout-path property
devicetrees may have the linux,stdout-path property to specify the
console. This patch adds support to the i.MX serial driver for this.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sascha Hauer [Mon, 5 Aug 2013 12:40:44 +0000 (14:40 +0200)]
OF: Add helper for matching against linux,stdout-path
devicetrees may have a linux,stdout-path property in the chosen
node describing the console device. This adds a helper function
to match a device against this property so a driver can call
add_preferred_console for a matching device.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gabor Juhos [Sat, 10 Aug 2013 07:32:15 +0000 (09:32 +0200)]
tty: ar933x_uart: convert to use devm_* functions
Use devm_* functions in order to simplify cleanup
paths.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peter Hurley [Sun, 11 Aug 2013 12:04:23 +0000 (08:04 -0400)]
n_tty: Fix termios_rwsem lockdep false positive
Lockdep reports a circular lock dependency between
atomic_read_lock and termios_rwsem [1]. However, a lock
order deadlock is not possible since CPU1 only holds a
read lock which cannot prevent CPU0 from also acquiring
a read lock on the same r/w semaphore.
Unfortunately, lockdep cannot currently distinguish whether
the locks are read or write for any particular lock graph,
merely that the locks _were_ previously read and/or write.
Until lockdep is fixed, re-order atomic_read_lock so
termios_rwsem can be dropped and reacquired without
triggering lockdep.
Patch based on original posted here https://lkml.org/lkml/2013/8/1/510
by Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
[1] Initial lockdep report from Artem Savkov <artem.savkov@gmail.com>
======================================================
[ INFO: possible circular locking dependency detected ]
3.11.0-rc3-next-
20130730+ #140 Tainted: G W
-------------------------------------------------------
bash/1198 is trying to acquire lock:
(&tty->termios_rwsem){++++..}, at: [<
ffffffff816aa3bb>] n_tty_read+0x49b/0x660
but task is already holding lock:
(&ldata->atomic_read_lock){+.+...}, at: [<
ffffffff816aa0f0>] n_tty_read+0x1d0/0x660
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&ldata->atomic_read_lock){+.+...}:
[<
ffffffff811111cc>] validate_chain+0x73c/0x850
[<
ffffffff811117e0>] __lock_acquire+0x500/0x5d0
[<
ffffffff81111a29>] lock_acquire+0x179/0x1d0
[<
ffffffff81d34b9c>] mutex_lock_interruptible_nested+0x7c/0x540
[<
ffffffff816aa0f0>] n_tty_read+0x1d0/0x660
[<
ffffffff816a3bb6>] tty_read+0x86/0xf0
[<
ffffffff811f21d3>] vfs_read+0xc3/0x130
[<
ffffffff811f2702>] SyS_read+0x62/0xa0
[<
ffffffff81d45259>] system_call_fastpath+0x16/0x1b
-> #0 (&tty->termios_rwsem){++++..}:
[<
ffffffff8111064f>] check_prev_add+0x14f/0x590
[<
ffffffff811111cc>] validate_chain+0x73c/0x850
[<
ffffffff811117e0>] __lock_acquire+0x500/0x5d0
[<
ffffffff81111a29>] lock_acquire+0x179/0x1d0
[<
ffffffff81d372c1>] down_read+0x51/0xa0
[<
ffffffff816aa3bb>] n_tty_read+0x49b/0x660
[<
ffffffff816a3bb6>] tty_read+0x86/0xf0
[<
ffffffff811f21d3>] vfs_read+0xc3/0x130
[<
ffffffff811f2702>] SyS_read+0x62/0xa0
[<
ffffffff81d45259>] system_call_fastpath+0x16/0x1b
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&ldata->atomic_read_lock);
lock(&tty->termios_rwsem);
lock(&ldata->atomic_read_lock);
lock(&tty->termios_rwsem);
*** DEADLOCK ***
2 locks held by bash/1198:
#0: (&tty->ldisc_sem){.+.+.+}, at: [<
ffffffff816ade04>] tty_ldisc_ref_wait+0x24/0x60
#1: (&ldata->atomic_read_lock){+.+...}, at: [<
ffffffff816aa0f0>] n_tty_read+0x1d0/0x660
stack backtrace:
CPU: 1 PID: 1198 Comm: bash Tainted: G W 3.11.0-rc3-next-
20130730+ #140
Hardware name: Bochs Bochs, BIOS Bochs 01/01/2007
0000000000000000 ffff880019acdb28 ffffffff81d34074 0000000000000002
0000000000000000 ffff880019acdb78 ffffffff8110ed75 ffff880019acdb98
ffff880019fd0000 ffff880019acdb78 ffff880019fd0638 ffff880019fd0670
Call Trace:
[<
ffffffff81d34074>] dump_stack+0x59/0x7d
[<
ffffffff8110ed75>] print_circular_bug+0x105/0x120
[<
ffffffff8111064f>] check_prev_add+0x14f/0x590
[<
ffffffff81d3ab5f>] ? _raw_spin_unlock_irq+0x4f/0x70
[<
ffffffff811111cc>] validate_chain+0x73c/0x850
[<
ffffffff8110ae0f>] ? trace_hardirqs_off_caller+0x1f/0x190
[<
ffffffff811117e0>] __lock_acquire+0x500/0x5d0
[<
ffffffff81111a29>] lock_acquire+0x179/0x1d0
[<
ffffffff816aa3bb>] ? n_tty_read+0x49b/0x660
[<
ffffffff81d372c1>] down_read+0x51/0xa0
[<
ffffffff816aa3bb>] ? n_tty_read+0x49b/0x660
[<
ffffffff816aa3bb>] n_tty_read+0x49b/0x660
[<
ffffffff810e4130>] ? try_to_wake_up+0x210/0x210
[<
ffffffff816a3bb6>] tty_read+0x86/0xf0
[<
ffffffff811f21d3>] vfs_read+0xc3/0x130
[<
ffffffff811f2702>] SyS_read+0x62/0xa0
[<
ffffffff815e24ee>] ? trace_hardirqs_on_thunk+0x3a/0x3f
[<
ffffffff81d45259>] system_call_fastpath+0x16/0x1b
Reported-by: Artem Savkov <artem.savkov@gmail.com>
Reported-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jingoo Han [Thu, 8 Aug 2013 08:39:51 +0000 (17:39 +0900)]
serial: pxa: Staticize local symbols
These local symbols are used only in this file.
Fix the following sparse warnings:
drivers/tty/serial/pxa.c:793:17: warning: symbol 'serial_pxa_pops' was not declared. Should it be static?
drivers/tty/serial/pxa.c:971:12: warning: symbol 'serial_pxa_init' was not declared. Should it be static?
drivers/tty/serial/pxa.c:986:13: warning: symbol 'serial_pxa_exit' was not declared. Should it be static?
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniel Mack [Wed, 7 Aug 2013 15:33:55 +0000 (17:33 +0200)]
tty: serial: pxa: remove old cruft
This #if-0'd block wouldn't compile, so let's dispose it.
Signed-off-by: Daniel Mack <zonque@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andreas Bießmann [Fri, 2 Aug 2013 10:23:34 +0000 (12:23 +0200)]
register_console: prevent adding the same console twice
This patch guards the console_drivers list to be corrupted. The
for_each_console() macro insist on a strictly forward list ended by NULL:
con0->next->con1->next->NULL
Without this patch it may happen easily to destroy this list for example by
adding 'earlyprintk' twice, especially on embedded devices where the early
console is often a single static instance. This will result in the following
list:
con0->next->con0
This in turn will result in an endless loop in console_unlock() later on by
printing the first __log_buf line endlessly.
Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
Cc: Kay Sievers <kay@vrfy.org>
Cc: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Clemens Ladisch [Sun, 4 Aug 2013 11:09:50 +0000 (13:09 +0200)]
vt: make the default color configurable
The virtual console has (undocumented) module parameters to set the
colors for italic and underlined text, but the default text color was
hardcoded for some reason. This made it impossible to change the color
for startup messages, or to set the default for new virtual consoles.
Add a module parameter for that, and document the entire bunch.
Any hacker who thinks that a command prompt on a "black screen with
white font" is not supicious enough can now use the kernel parameter
vt.color=10 to get a nice, evil green.
Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Huang Shijie [Sat, 3 Aug 2013 14:09:16 +0000 (10:09 -0400)]
ARM: dts: imx28-evk: add the RTS/CTS property for auart0
Add the RTS/CTS property for auart0 which means we enable the
DMA support for it.
Signed-off-by: Huang Shijie <b32955@freescale.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Huang Shijie [Sat, 3 Aug 2013 14:09:15 +0000 (10:09 -0400)]
serial: mxs: remove the MXS_AUART_DMA_CONFIG
The MXS_AUART_DMA_CONFIG is originally used to check if the DT node
is configured with the DMA property.
But now, the MXS_AUART_DMA_CONFIG is set unconditionally in the
serial_mxs_probe_dt(), so the check in the mxs_auart_settermios() is
not necessary anymore. This patch removes this macro.
Signed-off-by: Huang Shijie <shijie8@gmail.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Huang Shijie [Sat, 3 Aug 2013 14:09:14 +0000 (10:09 -0400)]
serial: mxs: enable the DMA only when the RTS/CTS is valid
The original DMA support works only when RTS/CTS is enabled.
(see the "
e800163 serial: mxs-auart: add the DMA support for mx28")
But after several patches, DMA support has lost this limit.
(see the "
bcc20f9 serial: mxs-auart: move to use generic DMA helper")
So an UART without the RTS/CTS lines may also enables the DMA support,
in which case the UART may gets unpredictable results.
This patch adds an optional property for the UART DT node
which indicates the UART has RTS and CTS lines, and it also means you
enable the DMA support for this UART.
This patch also adds a macro MXS_AUART_RTSCTS, and uses it to check
RTS/CTS before we enable the DMA for the UART.
Signed-off-by: Huang Shijie <b32955@freescale.com>
Signed-off-by: Huang Shijie <shijie8@gmail.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sun, 4 Aug 2013 21:41:03 +0000 (05:41 +0800)]
Merge 3.11-rc4 into tty-next
We want the tty fixes in here as well.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Linus Torvalds [Sun, 4 Aug 2013 20:46:46 +0000 (13:46 -0700)]
Linux 3.11-rc4
Linus Torvalds [Sun, 4 Aug 2013 18:46:07 +0000 (11:46 -0700)]
Merge branch 'fixes' of git://git.infradead.org/users/vkoul/slave-dma
Pull dmaengine fixes from Vinod Koul:
"Two fixes for slave dmaengine. The first fixes cyclic dma transfers
for pl330 and the second one makes us return the correct error code on
probe"
* 'fixes' of git://git.infradead.org/users/vkoul/slave-dma:
dma: pl330: Fix cyclic transfers
pch_dma: fix error return code in pch_dma_probe()
Linus Torvalds [Sun, 4 Aug 2013 18:44:18 +0000 (11:44 -0700)]
Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux
Pull drm fix from Dave Airlie:
"Just a quick fix that a few people have reported, be nice to have in
asap"
The drm tree seems to be very confused about 64-bit divides. Here it
uses a slow 64-by-64 bit divide to divide by a small constant. Oh well.
Doesn't look performance-critical, just stupid.
* 'drm-fixes' of git://people.freedesktop.org/~airlied/linux:
drm/radeon: fix 64 bit divide in SI spm code
Hugh Dickins [Sun, 4 Aug 2013 18:30:25 +0000 (11:30 -0700)]
tmpfs: fix SEEK_DATA/SEEK_HOLE regression
Commit
46a1c2c7ae53 ("vfs: export lseek_execute() to modules") broke the
tmpfs SEEK_DATA/SEEK_HOLE implementation, because vfs_setpos() converts
the carefully prepared -ENXIO to -EINVAL. Other filesystems avoid it in
error cases: do the same in tmpfs.
Signed-off-by: Hugh Dickins <hughd@google.com>
Cc: Jie Liu <jeff.liu@oracle.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Linus Torvalds [Sun, 4 Aug 2013 18:00:43 +0000 (11:00 -0700)]
Merge tag 'sound-3.11' of git://git./linux/kernel/git/tiwai/sound
Pull sound fixes from Takashi Iwai:
"All small regression or small fixes, nothing surprising at this stage.
- regression fix for intel Mac Mini quirk
- compress ioctl error fix
- ASoC fixes for control change notifications, some UI fixes,
driver-specific fixes (resource leak, build errors, etc)"
* tag 'sound-3.11' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound:
ALSA: hda - Fix missing fixup for Mac Mini with STAC9221
ASoC: wm0010: Fix resource leak
ASoC: au1x: Fix build
ASoC: bf5xx-ac97: Fix compile error with SND_BF5XX_HAVE_COLD_RESET
ASoC: bfin-ac97: Fix prototype error following AC'97 refactoring
ALSA: compress: fix the return value for SNDRV_COMPRESS_VERSION
ASoC: dapm: Fix return value of snd_soc_dapm_put_{volsw,enum_virt}()
Alex Deucher [Thu, 1 Aug 2013 13:03:29 +0000 (09:03 -0400)]
drm/radeon: fix 64 bit divide in SI spm code
Forgot to use the appropriate math64 function.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Dave Airlie <airlied@gmail.com>
Linus Torvalds [Sat, 3 Aug 2013 22:00:23 +0000 (15:00 -0700)]
Merge git://git./linux/kernel/git/davem/net
Pull networking fixes from David Miller:
1) Don't ignore user initiated wireless regulatory settings on cards
with custom regulatory domains, from Arik Nemtsov.
2) Fix length check of bluetooth information responses, from Jaganath
Kanakkassery.
3) Fix misuse of PTR_ERR in btusb, from Adam Lee.
4) Handle rfkill properly while iwlwifi devices are offline, from
Emmanuel Grumbach.
5) Fix r815x devices DMA'ing to stack buffers, from Hayes Wang.
6) Kernel info leak in ATM packet scheduler, from Dan Carpenter.
7) 8139cp doesn't check for DMA mapping errors, from Neil Horman.
8) Fix bridge multicast code to not snoop when no querier exists,
otherwise mutlicast traffic is lost. From Linus Lüssing.
9) Avoid soft lockups in fib6_run_gc(), from Michal Kubecek.
10) Fix races in automatic address asignment on ipv6, which can result
in incorrect lifetime assignments. From Jiri Benc.
11) Cure build bustage when CONFIG_NET_LL_RX_POLL is not set and rename
it CONFIG_NET_RX_BUSY_POLL to eliminate the last reference to the
original naming of this feature. From Cong Wang.
12) Fix crash in TIPC when server socket creation fails, from Ying Xue.
13) macvlan_changelink() silently succeeds when it shouldn't, from
Michael S Tsirkin.
14) HTB packet scheduler can crash due to sign extension, fix from
Stephen Hemminger.
15) With the cable unplugged, r8169 prints out a message every 10
seconds, make it netif_dbg() instead of netif_warn(). From Peter
Wu.
16) Fix memory leak in rtm_to_ifaddr(), from Daniel Borkmann.
17) sis900 gets spurious TX queue timeouts due to mismanagement of link
carrier state, from Denis Kirjanov.
18) Validate somaxconn sysctl to make sure it fits inside of a u16.
From Roman Gushchin.
19) Fix MAC address filtering on qlcnic, from Shahed Shaikh.
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net: (68 commits)
qlcnic: Fix for flash update failure on 83xx adapter
qlcnic: Fix link speed and duplex display for 83xx adapter
qlcnic: Fix link speed display for 82xx adapter
qlcnic: Fix external loopback test.
qlcnic: Removed adapter series name from warning messages.
qlcnic: Free up memory in error path.
qlcnic: Fix ingress MAC learning
qlcnic: Fix MAC address filter issue on 82xx adapter
net: ethernet: davinci_emac: drop IRQF_DISABLED
netlabel: use domain based selectors when address based selectors are not available
net: check net.core.somaxconn sysctl values
sis900: Fix the tx queue timeout issue
net: rtm_to_ifaddr: free ifa if ifa_cacheinfo processing fails
r8169: remove "PHY reset until link up" log spam
net: ethernet: cpsw: drop IRQF_DISABLED
htb: fix sign extension bug
macvlan: handle set_promiscuity failures
macvlan: better mode validation
tipc: fix oops when creating server socket fails
net: rename CONFIG_NET_LL_RX_POLL to CONFIG_NET_RX_BUSY_POLL
...
Himanshu Madhani [Sat, 3 Aug 2013 03:16:01 +0000 (23:16 -0400)]
qlcnic: Fix for flash update failure on 83xx adapter
Flash update routine was improperly checking register read API return value.
Modify register read API and perform proper error check.
Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Rajesh Borundia [Sat, 3 Aug 2013 03:16:00 +0000 (23:16 -0400)]
qlcnic: Fix link speed and duplex display for 83xx adapter
o Set link speed and duplex to unknown when link is not up.
Signed-off-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
Signed-off-by: Shahed Shaikh <shahed.shaikh@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Rajesh Borundia [Sat, 3 Aug 2013 03:15:59 +0000 (23:15 -0400)]
qlcnic: Fix link speed display for 82xx adapter
o Do not obtain link speed from register when adapter
link is down.
Signed-off-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
Signed-off-by: Shahed Shaikh <shahed.shaikh@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Shahed Shaikh [Sat, 3 Aug 2013 03:15:58 +0000 (23:15 -0400)]
qlcnic: Fix external loopback test.
Driver was not handling external loopback diagnostic
test request.
Signed-off-by: Shahed Shaikh <shahed.shaikh@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Pratik Pujar [Sat, 3 Aug 2013 03:15:57 +0000 (23:15 -0400)]
qlcnic: Removed adapter series name from warning messages.
Signed-off-by: Pratik Pujar <pratik.pujar@qlogic.com>
Signed-off-by: Shahed Shaikh <shahed.shaikh@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Himanshu Madhani [Sat, 3 Aug 2013 03:15:56 +0000 (23:15 -0400)]
qlcnic: Free up memory in error path.
Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: Shahed Shaikh <shahed.shaikh@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This page took 0.088476 seconds and 5 git commands to generate.