deliverable/tracecompass.git
11 years agoMerge branch 'master' into lttng-kepler
Bernd Hufmann [Tue, 20 Nov 2012 12:36:03 +0000 (07:36 -0500)] 
Merge branch 'master' into lttng-kepler

11 years agoRemove LTTng specific sonar and JaCoCo settings
Bernd Hufmann [Mon, 19 Nov 2012 17:48:19 +0000 (12:48 -0500)] 
Remove LTTng specific sonar and JaCoCo settings

Change-Id: I7e9b6523b16b0342ba427f60fb265c23996e7343
Reviewed-on: https://git.eclipse.org/r/8766
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>

11 years agoMerge branch 'master' into lttng-kepler
Alexandre Montplaisir [Mon, 19 Nov 2012 19:03:08 +0000 (14:03 -0500)] 
Merge branch 'master' into lttng-kepler

Conflicts:
lttng/org.eclipse.linuxtools.ctf.core.tests/pom.xml
lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/StreamInputPacketReader.java
lttng/org.eclipse.linuxtools.lttng.releng-site/pom.xml
lttng/org.eclipse.linuxtools.lttng/feature.xml
lttng/org.eclipse.linuxtools.lttng/pom.xml
lttng/org.eclipse.linuxtools.lttng2.kernel/feature.xml
lttng/org.eclipse.linuxtools.lttng2.kernel/pom.xml
lttng/org.eclipse.linuxtools.lttng2/feature.xml
lttng/org.eclipse.linuxtools.lttng2/pom.xml
lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/ctfadaptor/CtfTmfEvent.java
lttng/org.eclipse.linuxtools.tmf/feature.xml
lttng/org.eclipse.linuxtools.tmf/pom.xml

Change-Id: I5f85d26a7d5d4008cae9a5ed3ed6ebce7f1bd527

11 years agoensure bytes returned as int are never negative
Xavier Raynaud [Fri, 12 Oct 2012 07:51:21 +0000 (09:51 +0200)] 
ensure bytes returned as int are never negative

Change-Id: I173304573594c66d1d4eccaa9827ce6ac8154b94
Reviewed-on: https://git.eclipse.org/r/8203
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
11 years agoFix time range synchronization issues
Patrick Tasse [Fri, 16 Nov 2012 23:11:39 +0000 (18:11 -0500)] 
Fix time range synchronization issues

- ResourcesView is unnecessarily refreshing with initial window offset
on setFocus(). This is removed.

- TimeGraphViewer method resetStartFinishTime() causes time range
notification callback. The method is changed to call
setStartFinishTime() instead of setStartFinishTimeNotify().

- TimeGraphScale handling of mouse double-click is calling
resetStartFinishTime() expecting the notification. The notification is
now triggered explicitly by calling notifyStartFinishTime().

- HistogramView initial window span can be clipped if it is set early
when not enough events have been indexed in the trace. The full trace
histogram time range is now re-set on reception of TmfTraceUpdated
signal.

- The full trace histogram uses the zoom's duration in updateTimeRange()
on mouse up, and this duration could have been clipped. The method now
used the stored range duration, which does not get clipped.

Change-Id: Id480340933494855330fc6d4fae9429155efa88f
Reviewed-on: https://git.eclipse.org/r/8745
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
11 years agoImplement simultaneously opened traces in TMF
Patrick Tasse [Thu, 15 Nov 2012 22:27:42 +0000 (17:27 -0500)] 
Implement simultaneously opened traces in TMF

- Change all supporting views to use a generic ITmfTrace instead of a
TmfExperiment.
- TmfExperiment* signals removed, replaced by generic TmfTrace* signals.
- TmfTraceOpened signal is sent when opening a trace. Views should get
ready to receive TmfTraceRangeUpdated if they need to coalesce requests.
It is too early to access any state system.
- TmfTraceRangeUpdated signal is sent from the TmfTrace after receiving
TmfTraceOpened. Request coalescing can happen handling this signal.
- TmfTrace base class triggers its indexing on receiving
TmfTraceRangeUpdated.
- Removed indexing of custom traces in initTrace, now triggered by
TmfTraceOpened in TmfTrace base class.
- TmfExperiment initializes the streaming monitor on reception of
TmfTraceOpened.
- TmfTraceSelected signal is sent when the trace is initially brought to
top or any time it becomes the active trace. Any component can also
broadcast the signal to trigger bringing the trace to top.
- TmfTraceClosed signal is sent when the trace is closed. All
jobs/threads/requests related to this trace should be canceled. The
trace will be disposed after the signal has been broadcast.
- These signals can contain a TmfExperiment as the affected trace. Any
view which needs to check or handle individual trace should specially
handle an instance of TmfExperiment and examine its underlying traces.
- Building of state system and statistics moved from initTrace to
reception of TmfTraceOpenedSignal. This allows, in the case of a
reopened trace, for the previous trace to be disposed and its files
closed before the new instance initializes the state system.
- All supporting views cancel running jobs/threads/requests on
TmfTraceClosedSignal.
- ControlFlow/Resources view store entry list of all opened traces in
hash map.
- ControlFlow/Resources view use cancelable BuildThread.
- Cleanup the state system when disposing a CtfKernelTrace.
- Dispose of CtfTmfTrace clears reference to CTFTrace and this is used
to prevent NPE on getNext of disposed trace.
- Replace Events view with editor area in LTTng Kernel and Tracing
perspectives.
- Updated definition of traceType extension for defaultEditor element.
- OpenExperimentHandler opens the experiment in events editor. Default
editor is used unless all underlying traces share a common defaultEditor
in their respective traceType definition.
- OpenTraceHandler opens the trace in default or specified events
editor. It no longer uses a dummy experiment to wrap the trace.
- Removed methods and variables related to current experiment.
- Removed EventsViewEditor previously used as a workaround to open
bookmarks in Events view.
- Removed Clears Views command, made obsolete by closing all traces
(Close All on any tab).
- ITmfEventsFilterListener/Provider interfaces removed and replaces with
signal handling. This removes complexity of handling multiple listeners
and providers being added and removed.
- Fixed missing scaling to nanoseconds of timestamps in
AbstractStateChangeInput.
- Fixed synchronization issue with armRequest in TmfTrace when trace is
disposed (executor is shutdown).
- TmfEditorInput modified to prevent lingering reference in platform.
- TmfEventsEditor implements IPartListener to trigger broadcast of
TmfTraceSelectedSignal, instead of at setFocus which was sometimes
called twice by the platform.
- TmfEventsEditor no longer needs to use inner TmfExperiment subclass to
trigger indexing when experiment opened from bookmark.
- UnsortedPropertySheetPage class created instead of inner class in
TmfEventsEditor which was causing lingering reference to editor in
platform.
- Remove unused TmfTraceParserUpdatedSignal.
- TmfEnvironmentView refactored to update its table on
TmfTraceSelectedSignal.
- Use nanosecond timestamp scale constant where appropriate.
- Add interface to HistogramView to allow its controls to retrieve the
current trace.
- Implement synchronization of time range in TimeChartView.
- Fix lingering reference to completed requests in TmfUml2SDSyncLoader.
- Fix TmfVirtualTable setSelection allowing top rank to be too large
when selecting near end of table.
- Fix hanging wait cursor in sequence diagram view for traces without
any sequence events.

Change-Id: I357accc8fc7ea96544d32db758abff4760682304
Reviewed-on: https://git.eclipse.org/r/8554
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
11 years agotmf: Add the Histogram query API to ITmfStatistics
Alexandre Montplaisir [Thu, 8 Nov 2012 16:15:35 +0000 (11:15 -0500)] 
tmf: Add the Histogram query API to ITmfStatistics

See the added Javadoc for the complete description. This will
allow the Histogram view to easily plug into the trace's
ITmfStatistics object to get its information (so it can be
optimized for each trace type, etc.)

Change-Id: Ib94aeaa369a8bf40da5246825152e26326a45e92
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8675
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
11 years agoFix bug when contexts are enabled but there are no contexts
Matthew Khouzam [Fri, 16 Nov 2012 15:21:13 +0000 (10:21 -0500)] 
Fix bug when contexts are enabled but there are no contexts

Change-Id: Iad9f0f9456e4d1e2ee3db6b56e0cd2a30c620bd5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/8737
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

11 years agoFix benchmark to use ctftmflightweightcontexts
Matthew Khouzam [Thu, 12 Jul 2012 13:59:41 +0000 (09:59 -0400)] 
Fix benchmark to use ctftmflightweightcontexts

Change-Id: I64ff93f6564aec865370d4f166f7dcadf58a3295
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/6769
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
11 years agoIOStructGen cleanup
Matthew Khouzam [Fri, 2 Nov 2012 17:21:16 +0000 (13:21 -0400)] 
IOStructGen cleanup

Change-Id: If159227f14366770e64c4db494cb986a86bc2a0b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/8548
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

11 years agoAdd support for older Eclipse version (e.g. 3.6) than 3.8
Bernd Hufmann [Tue, 13 Nov 2012 14:25:39 +0000 (09:25 -0500)] 
Add support for older Eclipse version (e.g. 3.6) than 3.8

Change-Id: I67ec91e26e608ddb4b243eb9f21261b070ae6d03
Reviewed-on: https://git.eclipse.org/r/8654
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

11 years agoFix unintended black background in HistogramTextControls
Bernd Hufmann [Tue, 13 Nov 2012 13:41:42 +0000 (08:41 -0500)] 
Fix unintended black background in HistogramTextControls

This problem is caused by a style bit which is not applicable
for the Group class. The problem is only shown in Eclipse 4.2.0

Change-Id: I11416e8a9642c0d9637d696b2a72c04b1150a5f4
Reviewed-on: https://git.eclipse.org/r/8652
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

11 years agoFix initial trace time range.
Patrick Tasse [Thu, 8 Nov 2012 16:30:13 +0000 (11:30 -0500)] 
Fix initial trace time range.

The initial start time of TmfTrace is set to BIG_BANG so that the
initial time range is equal to NULL_RANGE. This allows to prevent
unnecessary histogram requests when a trace is opened.

Since its base class defaults to NULL_RANGE, it is no longer necessary
to explicitly set it in the TmfExperiment constructor.

Unit tests updated accordingly.

A fix is implemented in custom traces for possible NullPointerException
that uncovered this issue.

Change-Id: Ib1e49f372e1c5b1eaa3aecb972cc2b3830b3fbe3
Reviewed-on: https://git.eclipse.org/r/8603
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
11 years agoRemove seek(time) from CtfTmfTrace and use parent implementation
Bernd Hufmann [Tue, 13 Nov 2012 15:17:17 +0000 (10:17 -0500)] 
Remove seek(time) from CtfTmfTrace and use parent implementation

The implementation of CtfTmfTrace of seek by timestamp worked
correctly to seek within the CTF trace. However, the returned
context contains an incorrect rank of always 0.

This incorrect rank will cause a wrong selected event in the
TmfEventsTable if the trace is used directly and not through an
experiment.

The solution is to use the TmfTrace implementation of seek(time)
instead which is handling the rank correctly.

Change-Id: Ie28c88c8e3263cbcb42349bb033cc61f69634a72
Reviewed-on: https://git.eclipse.org/r/8719
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
11 years agotmf: Replace ITmfTimestamp by long in ITmfStatistics API
Alexandre Montplaisir [Mon, 12 Nov 2012 22:23:31 +0000 (17:23 -0500)] 
tmf: Replace ITmfTimestamp by long in ITmfStatistics API

Some methods in the statistics imlementations can call each
other, and having to create new wrapper objects every event
is not very interesting... The normalization already happens
in the Statistics view anyway.

Change-Id: I9769a867953d8f38dd2816ca7931b35dc22898a3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8650
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>

11 years agoImplement MultiLineInputDialog for Add Bookmark action.
Patrick Tasse [Fri, 9 Nov 2012 22:38:56 +0000 (17:38 -0500)] 
Implement MultiLineInputDialog for Add Bookmark action.

Supports multiple line description.
Tool tip position calculation is corrected.

Change-Id: I1bf7fc4b32a507b90475f321a054ee4ab7ced823
Reviewed-on: https://git.eclipse.org/r/8615
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

11 years agoFix default Content column in events table.
Patrick Tasse [Wed, 7 Nov 2012 16:33:48 +0000 (11:33 -0500)] 
Fix default Content column in events table.

The default Content column in TmfEventsTable was being populated using
the event content value's toString if available, or the event content's
toString otherwise.

This was preventing the possibility to show different information in the
Content column and in the raw viewer. The raw viewer is populated using
the event content value's toString.

Therefore if an event's root content had a value defined for use in the
raw viewer, the root content's toString was ignored for use in the table
column, and the column always showed the same data as the raw viewer.

The Content column is now always populated using the event content's
toString. The (optional) event content value's toString is only used by
the raw viewer.

The filter base class implementation is modified to use the same data as
is displayed by the table when filtering on the default Content
column.

Change-Id: Ic976104743eb8850d8176ce232ca84e0574badd3
Reviewed-on: https://git.eclipse.org/r/8570
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
11 years agoUpdate Grammar and Add support for callsites
Matthew Khouzam [Tue, 23 Oct 2012 20:05:57 +0000 (16:05 -0400)] 
Update Grammar and Add support for callsites

A new feature in CTF v1.9
Add test cases for callsites
Improve other test cases

Change-Id: I10d28768ee267001638c7d5c94452e6eb26b311c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/8373
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

11 years agoFix incorrect seek by timestamp in CtfIterator.
Patrick Tasse [Tue, 6 Nov 2012 18:42:52 +0000 (13:42 -0500)] 
Fix incorrect seek by timestamp in CtfIterator.

Change-Id: I7902dead3d15dda15e692738bed227669d49b7e4
Reviewed-on: https://git.eclipse.org/r/8541
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
11 years agotmf/lttng: Fix newly-introduced Javadoc warnings
Alexandre Montplaisir [Thu, 1 Nov 2012 18:28:35 +0000 (14:28 -0400)] 
tmf/lttng: Fix newly-introduced Javadoc warnings

Change-Id: Ic0562e0dbc8538603f9749c8dfe402b5cf34fc01
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8474

11 years agoUpdate project settings for CTF/LTTng/TMF
Alexandre Montplaisir [Thu, 1 Nov 2012 17:54:11 +0000 (13:54 -0400)] 
Update project settings for CTF/LTTng/TMF

Remove the automatic line wrapping and unwrapping for code
lines. It had the tendency to absolutely destroy the formatting
if used on a complete file. The auto-wrapping of comments
remains at 80 columns.

Also enabled Javadoc warnings for protected fields and methods.
Since protected members in exported packages are part of the API,
those should be Javadoc-umented too.

Change-Id: Iab722d674e1f209f1e2b937ead9f058b9b09cab1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8473
Tested-by: Hudson CI
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>
11 years agotmf: Handle race between state system queries and diposal
Alexandre Montplaisir [Mon, 5 Nov 2012 16:54:12 +0000 (11:54 -0500)] 
tmf: Handle race between state system queries and diposal

It's possible that a state system gets disposed while a query
is ongoing (happens between two successive .getNextChild()
calls, for example).

Instead of implementing a convoluted reader-writer-lock, we can
just catch the ClosedChannelException and rethrow a
StateSystemDisposed exception.

Change-Id: I93f72860bbb94a63e86e7c6f51682af659599fe3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8520
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

11 years agotmf: Add a StateSystemDisposedException
Alexandre Montplaisir [Fri, 2 Nov 2012 20:57:29 +0000 (16:57 -0400)] 
tmf: Add a StateSystemDisposedException

Once a state system is diposed, no future queries should be run on
it. If such a thing happens, the new StateSystemDisposedException
will be thrown. This can help views know that they should stop
doing queries.

Change-Id: I1a887cd322a1ac1ee6ffb1705c0c7e794f848f1f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8497
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

11 years agotmf: Add dispose methods to the state and stats backends
Alexandre Montplaisir [Thu, 1 Nov 2012 21:15:03 +0000 (17:15 -0400)] 
tmf: Add dispose methods to the state and stats backends

When a trace/experiment is closed while a state history is
being built (either for storing kernel states or statistics),
the build should be cancelled as part of the trace's dispose().
This means the threads should be stopped cleanly, the files
should be closed, and any ongoing requests should be cancelled.

Change-Id: I0313ed37a927330a46b68024d1926922ddcaefb8
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8491
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
11 years agotmf: Add some unit tests to the ITmfStatistics
Alexandre Montplaisir [Wed, 31 Oct 2012 19:43:29 +0000 (15:43 -0400)] 
tmf: Add some unit tests to the ITmfStatistics

Also fixed some bugs that those tests exposed:
- Time ranges are now inclusive (both at the beginning and end)
  for all implementations.
- All methods in TmfStateStatistics will now wait for the history
  construction to be complete, so hopefully no more hundreds of
  AttributeNotFoundException's.
- State system queries at the end time should now work correctly
  (the work-around was removed).
- A time range beginning at the trace's start time should now
  return the correct values. I couldn't test with the edge case
  where you have more than 1 event exactly at the start time, but
  I assume it should work correctly too.

Change-Id: Ia4268eeb1c04033a41b4e8ea011a6007bc90187e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8463
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

11 years agotmf: Drop the Type in CtfTmfTimestamp
Alexandre Montplaisir [Thu, 1 Nov 2012 17:34:00 +0000 (13:34 -0400)] 
tmf: Drop the Type in CtfTmfTimestamp

Also removed all redundant methods in the class and the test.
This brings CtfTmfTimestamp much closer to TmfTimestamp, now
it's simply a wrapper that ensures the scale is set to nanoseconds.

Change-Id: I8242434af7221ae1d6dd964d5c8d80cd0f4e60bc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8047
Tested-by: Hudson CI
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>
11 years agoFix for LTTng/TMF version IDs for R1.2
Francois Chouinard [Thu, 1 Nov 2012 18:17:56 +0000 (14:17 -0400)] 
Fix for LTTng/TMF version IDs for R1.2

Change-Id: I933e12a6d0eaef2d8e64baa690d13598b7ebd398
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8471

11 years agotmf: Make TmfTimestamp and TmfTimeRange immutable
Alexandre Montplaisir [Mon, 1 Oct 2012 21:45:51 +0000 (17:45 -0400)] 
tmf: Make TmfTimestamp and TmfTimeRange immutable

Mark the fields in TmfTimestamp/TmfTimeRange final, to ensure they
do not get modified after the object is created. The setter methods
didn't seem to be used anywhere so the impacts are minimal.

Change-Id: I693ffef78588e9e68fa3b22516cf93b3f98c6613
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7278
Tested-by: Hudson CI
11 years agoUpdate minor version number for plug-in and relevant features.
Bernd Hufmann [Wed, 31 Oct 2012 21:33:28 +0000 (17:33 -0400)] 
Update minor version number for plug-in and relevant features.

Change-Id: Id51f03f37d767b26260986f928217613758a3823
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7255

Conflicts:
lttng/org.eclipse.linuxtools.lttng.releng-site/category.xml
lttng/org.eclipse.linuxtools.tmf.core/META-INF/MANIFEST.MF
lttng/org.eclipse.linuxtools.tmf.core/pom.xml

Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Change-Id: Ifce4d4a18d59ca785517bbf8ac64007175e68328
Reviewed-on: https://git.eclipse.org/r/8462
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
11 years agotmf: Statistics provider based on event requests
Alexandre Montplaisir [Mon, 22 Oct 2012 18:37:45 +0000 (14:37 -0400)] 
tmf: Statistics provider based on event requests

This patch adds a TmfEventsStatistics, which uses trace event
requests and counts the instances of each event types to
provide statistics information. This is useful for trace types
that cannot use the default implementation using the state
system (traces where events are not chronologically ordered,
for example).

The previous TmfStatistics has been renamed TmfStateStatistics,
to better differentiate between the two alternatives that are
now available.

To keep the request coalescing, the separate threading is now
done is a new ITmfStatistics.updateStats(). This allows the signal
handler code to send the queries, but return immediately and
spawn a thread that will wait for the requests to be done.

When the results are ready, they will be sent back to the view
using the new TmfStatsUpdatedSignal. This makes the handler for
the StateSystemBuildCompleted signal obsolete.

Change-Id: I5b6237aef7f5c7cb373c68e4624376146a6e5086
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8376
Tested-by: Hudson CI
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>
11 years agoFix for supplementary comments on TmftimestampFormat implementation
Francois Chouinard [Tue, 30 Oct 2012 20:49:02 +0000 (16:49 -0400)] 
Fix for supplementary comments on TmftimestampFormat implementation

Change-Id: I46acc468c064d76cf301618fa47377820d17262f
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8435
Tested-by: Hudson CI
11 years agotmf: Allow waiting for a state system's completion
Alexandre Montplaisir [Tue, 30 Oct 2012 14:38:49 +0000 (10:38 -0400)] 
tmf: Allow waiting for a state system's completion

ITmfStateSystem.waitUntilBuilt() will now block the calling
thread until the state system underneath is finished building.
This will be immediately useful for statistics (intermediate
queries are useless, we need to wait until it's ready anyway).

It's implemented using a CountDownLatch, similar to the
.waitForCompletion() in event requests.

Change-Id: I98420acc3ca2903d76a315259f25dca7d88b8d42
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8427
Tested-by: Hudson CI
11 years agotmf: Store totals separately in TmfStatistics
Alexandre Montplaisir [Thu, 25 Oct 2012 21:19:21 +0000 (17:19 -0400)] 
tmf: Store totals separately in TmfStatistics

This allows the get*Total() methods to query the state directly.
With that, no need to get the map of events per type (which was
already longer by itself), and then add its contents at every
single query.

Change-Id: I2e6708a2708abcdae6cd68baab9b6c26a2cc2d30
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8380
Tested-by: Hudson CI
11 years agoFix for the time range histogram
Francois Chouinard [Tue, 30 Oct 2012 18:21:53 +0000 (14:21 -0400)] 
Fix for the time range histogram

The time range histogram doesn't refresh very well when the new range
has no events either at the start or the end. This patch properly keeps
the range.

Change-Id: I414bb9288327dd9cf56ca8eb22ac2672f4e9e362
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8428
Tested-by: Hudson CI
11 years agoImplement TmfTimestampFormat
Francois Chouinard [Tue, 30 Oct 2012 15:06:32 +0000 (11:06 -0400)] 
Implement TmfTimestampFormat

Change-Id: I29d4f815679503c82a14ac74e8395f9aa3dc0cbf
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8419
Tested-by: Hudson CI
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

11 years agoctf: Add support for scoped event contexts
Matthew Khouzam [Tue, 23 Oct 2012 19:16:58 +0000 (15:16 -0400)] 
ctf: Add support for scoped event contexts

Change-Id: I19f0ed63b494d6f27b434c58691ed428dc991911
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8110
Tested-by: Hudson CI
11 years agoAdd support for selected event in Properties view.
Patrick Tasse [Tue, 23 Oct 2012 17:45:20 +0000 (13:45 -0400)] 
Add support for selected event in Properties view.

Change-Id: I41e8cc7a9d9e0c9f8870445741f9559f951eba0f

11 years agoTemporary fix API version for Kepler
Patrick Tasse [Tue, 23 Oct 2012 17:44:09 +0000 (13:44 -0400)] 
Temporary fix API version for Kepler

Change-Id: I303c9bbf3b023a4c551586fa04b90d7b8649f69a

11 years agoMerge branch 'master' into lttng-kepler
Patrick Tasse [Tue, 23 Oct 2012 17:42:06 +0000 (13:42 -0400)] 
Merge branch 'master' into lttng-kepler

Conflicts:
lttng/org.eclipse.linuxtools.tmf.ui/plugin.xml

Change-Id: Id994aa08fb1af64b99be885c30fbbeda4e67ce24

11 years agoWorkaround for bug 391232: ISharedImages constants not recognized.
Patrick Tasse [Tue, 23 Oct 2012 17:12:22 +0000 (13:12 -0400)] 
Workaround for bug 391232: ISharedImages constants not recognized.

Change-Id: I671fb92236d22c4829bd38a3a076e951595434a6

11 years agoTemporary fix API version for Kepler
Patrick Tasse [Tue, 23 Oct 2012 14:53:41 +0000 (10:53 -0400)] 
Temporary fix API version for Kepler

Change-Id: I276488d50b554f065d8060adcf0ec5133714dce5

11 years agoMerge branch 'master' into lttng-kepler
Patrick Tasse [Tue, 23 Oct 2012 14:47:15 +0000 (10:47 -0400)] 
Merge branch 'master' into lttng-kepler

Conflicts:
gcov/org.eclipse.linuxtools.gcov.core/src/org/eclipse/linuxtools/gcov/Activator.java
lttng/org.eclipse.linuxtools.tmf.core.tests/stubs/org/eclipse/linuxtools/tmf/tests/stubs/trace/TmfTraceStub.java
lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/ctfadaptor/CtfTmfTrace.java

Change-Id: Ifd5503a8abd3250f9c117f369de7fb9745507b8e

11 years agoAdd support for selected event in Properties view.
Patrick Tasse [Thu, 18 Oct 2012 22:05:07 +0000 (18:05 -0400)] 
Add support for selected event in Properties view.

Change-Id: I3568e9d7f227a714f2f47a4f24cc74ca1e6c9312
Reviewed-on: https://git.eclipse.org/r/8296
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
11 years agoFix for bug 392591: ArrayIndexOutOfBoundsException in virtual table.
Patrick Tasse [Mon, 22 Oct 2012 17:07:14 +0000 (13:07 -0400)] 
Fix for bug 392591: ArrayIndexOutOfBoundsException in virtual table.

Change-Id: Ie7f6e36765b5b0a111ba6a63e867f0ac99864fb8
Reviewed-on: https://git.eclipse.org/r/8329
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
11 years agotmf: Move the stats tree structure logic to the nodes
Alexandre Montplaisir [Tue, 16 Oct 2012 17:41:21 +0000 (13:41 -0400)] 
tmf: Move the stats tree structure logic to the nodes

Re-organize the TmfStatisticsTree so that the information
about node children are stored in the nodes themselves,
and not all at the top-level. This makes debugging, and
eventually extending the tree, much easier, imo.

This patch also drops the fKeys (which limited the types
of children each node can have) and the weird limitation
where only nodes whose path depths are mutiples of 2 could
have values. Now the tree is more generic, to give better
flexibility to potential sub-classes.

Change-Id: I30bc0f7f47256388b6c55e09f09b26286723c0b9
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8298
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
11 years agotmf: Refactor TMF statistics
Alexandre Montplaisir [Mon, 15 Oct 2012 21:51:31 +0000 (17:51 -0400)] 
tmf: Refactor TMF statistics

Merge TmfBaseStatisticsTree into AbsTmfStatisticsTree. The abstract
version required both total and per-event-type statistics values
anyway, so there was no need to have a separate class that basically
implemented the required stuff.

Also renamed TmfStatisticsTreeNodeFactory to TmfStatisticsManager,
since it's more a manager for the complete stats trees.

Change-Id: If9942beb14ee0d978722d97e6bdfeafb693c9b66
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8265
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
11 years agotmf: Drop the use of TmfFixedArray for statistics
Alexandre Montplaisir [Mon, 15 Oct 2012 18:53:08 +0000 (14:53 -0400)] 
tmf: Drop the use of TmfFixedArray for statistics

The same behaviour can be achieved by using straight [] arrays
and varargs methods. That way we don't need to instantiate new
wrapper objects all the time.

Unit tests were also updated.

Change-Id: I5f98ca2c08fd5bee5a1569c64466e63ef1e345d8
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8264
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
11 years agotmf: Store the generic statistics timestamps in nanoseconds
Alexandre Montplaisir [Tue, 16 Oct 2012 20:55:44 +0000 (16:55 -0400)] 
tmf: Store the generic statistics timestamps in nanoseconds

Since the TmfStatistics can be used with any trace type, and not
just LTTng kernel traces, we can't know exactly what scale its
timestamps are in.

To be safe, convert all timestamps to nanoseconds before saving
them in the history database. When we want to display the
information, the query timestamps will also be converted to
nanoseconds.

Change-Id: Ibcd2fb309f01cdfeab6b480e41f740296694e4be
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8242
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
11 years agotmf: Make TmfStatisticsViewer use the trace's stats provider
Alexandre Montplaisir [Tue, 9 Oct 2012 15:38:37 +0000 (11:38 -0400)] 
tmf: Make TmfStatisticsViewer use the trace's stats provider

Rework the TmfStatisticsViewer to get its information from a
ITmfStatistics object (instead of doing direct event queries
on the trace). That way, the logic to compute the statistics
is now separate from the view, which I think is a good thing.

This removes the need for the ITmfExtraInfo completely. Unit
tests have also been updated to take account for the fact that
the view does not 'count' anymore, it just displays whatever
we send it.

Other changes:
 - Consolidated the setters in TmfStatisticsTree
 - Renamed TmfStatisticsNode.getValue() to .getValues(), to
   better indicate that it is the wrapper object around the
   values that is returned.

Fixes bug 387634.

Change-Id: I1e6b9931007c79cce8c1c93c6c0ddc955cbd0a93
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6986
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
11 years agoConvert Windows line delimiters to Unix.
Patrick Tasse [Mon, 22 Oct 2012 20:03:41 +0000 (16:03 -0400)] 
Convert Windows line delimiters to Unix.

Change-Id: Ia737c3c468c739a7da20561e11d756036fc8d049

11 years agoLTTng: Handle cancellation of login gracefully (bug 392197)
Bernd Hufmann [Wed, 17 Oct 2012 16:56:05 +0000 (12:56 -0400)] 
LTTng: Handle cancellation of login gracefully (bug 392197)

Change-Id: I1d2ae0e5f852f7350956f39648f20eac6c25c410
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8258
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

11 years agoTMF: add support for popup menu in time chart widgets
Xavier Raynaud [Wed, 12 Sep 2012 15:18:04 +0000 (17:18 +0200)] 
TMF: add support for popup menu in time chart widgets

Change-Id: I4c546a73f23ea596978cff3aa7920a481b81bdae
Reviewed-on: https://git.eclipse.org/r/8202
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
11 years agoFix removal of filter in SDView (Bug 391714)
Bernd Hufmann [Thu, 11 Oct 2012 20:48:47 +0000 (16:48 -0400)] 
Fix removal of filter in SDView (Bug 391714)

Change-Id: I312a64127a8a35fbf152de8fe023df17c0d136cc
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8175
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
11 years agoFix ArrayIndexOutOfBoundsException for sync signals (Bug 391716)
Bernd Hufmann [Thu, 11 Oct 2012 19:59:42 +0000 (15:59 -0400)] 
Fix ArrayIndexOutOfBoundsException for sync signals (Bug 391716)

Change-Id: I4be9c4fec22f25b2ff77a918f692fb7b41e788b7
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8174
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
11 years agoInitialize dialog member variable (bug 391589)
Bernd Hufmann [Wed, 10 Oct 2012 18:22:05 +0000 (14:22 -0400)] 
Initialize dialog member variable (bug 391589)

Change-Id: Iff6450210c88b237ad0abf1971220dff79ce7dc0
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8151
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

11 years agoFix for bug 391277: Rounding error in seekEvent by ratio.
Patrick Tasse [Fri, 5 Oct 2012 21:54:34 +0000 (17:54 -0400)] 
Fix for bug 391277: Rounding error in seekEvent by ratio.

Change-Id: I4fda9f56d5aaf199abcc59c3a9dacabeb681c9b8
Reviewed-on: https://git.eclipse.org/r/8069
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>

11 years agotmf: Add an ID to each state system that gets built
Alexandre Montplaisir [Fri, 28 Sep 2012 18:54:31 +0000 (14:54 -0400)] 
tmf: Add an ID to each state system that gets built

When requesting to build a state system, we now need to specify
a String ID. This ID will be returned with the "state system build
completed" signal, so that a view can differentiate between many
state systems that could be associated to the same trace.

Change-Id: I699d46f3a3cf7300f71282f505eeb40e08cb4d1e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7987

11 years agotmf: Introduce the ITmfStatistics interface
Alexandre Montplaisir [Thu, 27 Sep 2012 20:51:39 +0000 (16:51 -0400)] 
tmf: Introduce the ITmfStatistics interface

With this, any type of ITmfTrace can now define its own
statistics provider. This can then be used to populate views
like the Histogram or the Statistics view.

A base implementation is proposed in TmfStatistics (and used by
TmfTrace), and it uses a state system for its backend. That
state system is completely contained in the TmfStatistics object,
so that it's not confused with any "real" state system that could
be present in the trace.

Change-Id: Ia0bf807cdbed28f9a6ebd47509412d4ea35f99cd
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7986

11 years agotmf: Add an ID to the AbstractStateChangeInput
Alexandre Montplaisir [Fri, 28 Sep 2012 15:13:04 +0000 (11:13 -0400)] 
tmf: Add an ID to the AbstractStateChangeInput

The Abstract version was still, wrongly, using "CTF Kernel"
as its identifier. Replace this with a configurable name,
provided as a constructor parameter.

It's only used for naming the thread that it starts, but it
makes it a bit more clear what is happening when debugging.

Change-Id: I3317d82c366915e4eaa08a5fa65a8379f92e062f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7977

11 years agotmf: Expose getStateSystem() up to ITmfTrace
Alexandre Montplaisir [Thu, 27 Sep 2012 18:57:11 +0000 (14:57 -0400)] 
tmf: Expose getStateSystem() up to ITmfTrace

The default implementation in TmfTrace will not provide any
state system for now, sub-classes need to specify their own.

Change-Id: I9239ac69c5ae20cea1bbe54b34260e829bd84465
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7965

11 years agotmf: Add the Tmf- prefix to the state system interfaces
Alexandre Montplaisir [Thu, 27 Sep 2012 18:47:35 +0000 (14:47 -0400)] 
tmf: Add the Tmf- prefix to the state system interfaces

In preparation with them being exposed into ITmfTrace, the
interfaces to the state system should wear the proper Tmf-
prefix.

The read-only interface that most views and users will see has
been renamed to simply ITmfStateSystem. The builder interface
that is used by the trace for its construction is now called
ITmfStateSystemBuilder.

Change-Id: Id947bb4c933387f5346f78963247e7460e3982cc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7964

11 years agoFix a confusing activation condition for delete handlers
Francois Chouinard [Fri, 5 Oct 2012 13:50:52 +0000 (09:50 -0400)] 
Fix a confusing activation condition for delete handlers

Change-Id: I12baa3a36fd4ad1a9238bf83a893c2754804eda1
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8059
Tested-by: Hudson CI
11 years agotmf: Make ITmfGraphEntry.getChildren() return a List
Alexandre Montplaisir [Wed, 3 Oct 2012 16:29:39 +0000 (12:29 -0400)] 
tmf: Make ITmfGraphEntry.getChildren() return a List

instead of a static array.

Because of the upcoming AbstractTimeGraphEntry and its subclasses,
we will now need to specify the exact class in each view's
.getChildren(). This is not possible to do with an array if we use
a generic type (e.g. E[]), we have to use a Collection like List<E>.

Change-Id: Icf858b471a95ea7d68e6b6b2169afdc35922545a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7747
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
11 years agoFix for bug 390841: Experiment does not dispose trace contexts.
Patrick Tasse [Wed, 3 Oct 2012 19:32:53 +0000 (15:32 -0400)] 
Fix for bug 390841: Experiment does not dispose trace contexts.

Change-Id: Ib2ac07efc2f4b4efbb15971bbaa48401997fa215
Reviewed-on: https://git.eclipse.org/r/8002
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
11 years agoMake the TmfLocation final and get rid of clone()
Francois Chouinard [Fri, 28 Sep 2012 22:10:40 +0000 (18:10 -0400)] 
Make the TmfLocation final and get rid of clone()

- Make fLocation final
- Make TmfLocation concrete classes 'final'
- Remove clone() - not needed anymore
- Fix test cases

Change-Id: Ie4b67907aa53f8b6d7ba513caa6a8eecdbb624b4
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7985

11 years agoMerge branch 'master' into lttng-kepler
Patrick Tasse [Tue, 2 Oct 2012 22:09:31 +0000 (18:09 -0400)] 
Merge branch 'master' into lttng-kepler

Conflicts:
lttng/org.eclipse.linuxtools.lttng2.kernel.core/src/org/eclipse/linuxtools/internal/lttng2/kernel/core/stateprovider/CtfKernelHandler.java
lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/Messages.java
lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/messages.properties
lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/views/controlflow/ControlFlowView.java
lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/views/resources/ResourcesPresentationProvider.java
lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/views/resources/ResourcesView.java
lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/Tracer.java
lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/signal/TmfTraceSelectedSignal.java
lttng/org.eclipse.linuxtools.tmf.ui/plugin.xml
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/messages.properties
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomEvent.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomTxtEvent.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomTxtTrace.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomTxtTraceContext.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomXmlEvent.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomXmlTrace.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomXmlTraceContext.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/wizards/CustomTxtParserOutputWizardPage.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/wizards/CustomXmlParserOutputWizardPage.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/signal/TmfTraceClosedSignal.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/signal/TmfTraceOpenedSignal.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/editors/ITmfTraceEditor.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/editors/TmfEditorInput.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/editors/TmfEventsEditor.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfExperimentFolder.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/signal/TmfTraceClosedSignal.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/signal/TmfTraceOpenedSignal.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/ITmfEventsFilterListener.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/timechart/TimeChartAnalysisEntry.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/timechart/TimeChartView.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/rawviewer/TmfRawEventViewer.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/ITimeGraphPresentationProvider.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/TimeGraphCombo.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/TimeGraphPresentationProvider.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/TimeGraphViewer.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/dialogs/TimeGraphLegend.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/Utils.java

Change-Id: Ie424277c584ffa52bd904649fae620d8c96ce1dc

11 years agoConvert Windows line delimiters to Unix.
Patrick Tasse [Tue, 2 Oct 2012 21:02:07 +0000 (17:02 -0400)] 
Convert Windows line delimiters to Unix.

Change-Id: Idb33e8cc17d49436d2ed3edd49869cf965c86d13

11 years agoMerge branch 'master' into lttng-kepler
Patrick Tasse [Tue, 2 Oct 2012 20:52:54 +0000 (16:52 -0400)] 
Merge branch 'master' into lttng-kepler

Conflicts:
lttng/org.eclipse.linuxtools.lttng.releng-site/category.xml
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsCache.java

Change-Id: Ibcacc51ddaf09ece2433d279dfd6719e2b2c1d59

11 years agoctf: Handle traces with unknown event attributes
Alexandre Montplaisir [Mon, 24 Sep 2012 20:21:09 +0000 (16:21 -0400)] 
ctf: Handle traces with unknown event attributes

Instead of blowing up when it sees an attribute is doesn't know,
the parser should just ignore it. This is quite important,
since CTF allows for custom attributes and the parser can't
know in advance about all possible ones.

Ideally, we should also log whenever an unkown attribute is seen.
Unfortunately there is no logging in place in the ctf.core plugins
yet.

Change-Id: I45aba769205060cdcac6935cecc1479b026a5bc0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7904

11 years agotmf: Rename the UI TmfStatistics class to TmfStatisticsValues
Alexandre Montplaisir [Mon, 1 Oct 2012 15:44:16 +0000 (11:44 -0400)] 
tmf: Rename the UI TmfStatistics class to TmfStatisticsValues

To avoid a clash with the new tmf.core.statistics.TmfStatistics.

Change-Id: Iae1b5cea64c6a441e4dc3ea63c860537a69b24ac
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8005
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI
11 years agoAdd a "Clear Tracing Views" command
Francois Chouinard [Thu, 27 Sep 2012 19:28:05 +0000 (15:28 -0400)] 
Add a "Clear Tracing Views" command

Add the possibility to clear the views the tracing/LTTng perspective.
It does it by disposing of the experiment. Proper signal handlers were
added where necessary.

Change-Id: I33e974f26b6e66d55bcd0c34ac96b375bf3ccddb
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7962
Tested-by: Hudson CI
11 years agoFix for NPE in Sequence diagram when closing Eclipse (Bug 390552)
Bernd Hufmann [Thu, 27 Sep 2012 12:53:09 +0000 (08:53 -0400)] 
Fix for NPE in Sequence diagram when closing Eclipse (Bug 390552)

Change-Id: I132cb8085c44ff5e6af0bf7aa8d2e58c9ebb8310
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7959
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
11 years agoFix 2 actions that had old identifiers
Francois Chouinard [Thu, 27 Sep 2012 17:28:08 +0000 (13:28 -0400)] 
Fix 2 actions that had old identifiers

Change-Id: I0fd1e8d933b2971906422859d33387321c3366ab
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
11 years agoFix for bug 390472: ArrayIndexOutOfBoundsException in TmfEventsCache.
Patrick Tasse [Wed, 26 Sep 2012 18:02:00 +0000 (14:02 -0400)] 
Fix for bug 390472: ArrayIndexOutOfBoundsException in TmfEventsCache.

Change-Id: I1025ec36868837a9e027399f13d02266c24a152e
Reviewed-on: https://git.eclipse.org/r/7936
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>

11 years agoRationalize the TMF commands
Francois Chouinard [Mon, 24 Sep 2012 18:51:29 +0000 (14:51 -0400)] 
Rationalize the TMF commands

- Simplify commands categories
- Re-use the platform command id:s where reasonable
- Adjust context menu order
- Adjust shortcuts and accelerators

Change-Id: I6f2e71239dd1bd8392452792bf3868aa6e6dbdf4
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7916
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
11 years agoFix location cloning issue
Francois Chouinard [Mon, 24 Sep 2012 18:54:39 +0000 (14:54 -0400)] 
Fix location cloning issue

- Provide a basic implementation of TmfLocation.clone()
- Add an abstract TmfLocation.cloneLocationInfo()
- Add implementations for Tmf<Type>Location
- Adjust Tmf<Type>Location.clone()
- Remove some leftover comments

Update: Make Tmf<Type>Location.clone() a one-liner where applicable.

Change-Id: I54cdb4c70846285c6d3fbd7b114a47b95592f2e7
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7901
Tested-by: Hudson CI
11 years agoFix location cloning issue
Francois Chouinard [Mon, 24 Sep 2012 15:03:50 +0000 (11:03 -0400)] 
Fix location cloning issue

- Provide a basic implementation of TmfLocation.clone()
- Add an abstract TmfLocation.cloneLocationInfo()
- Add implementations for Tmf<Type>Location
- Adjust Tmf<Type>Location.clone()
- Remove some leftover comments

Change-Id: Ide1c1b0225251beff5cc527580207b8cc48a1fe7
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7893
Tested-by: Hudson CI
11 years agoRemove Linux Tools URL from LTTng category.xml file
Bernd Hufmann [Tue, 25 Sep 2012 13:09:04 +0000 (09:09 -0400)] 
Remove Linux Tools URL from LTTng category.xml file

Change-Id: I7dc18cfcd14f6cec9c0b07b66528d9833d6a687c
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7915
Tested-by: Hudson CI
11 years agoUpdate remaining LTTng/TMF versions to 2.0.0
Bernd Hufmann [Tue, 25 Sep 2012 11:52:55 +0000 (07:52 -0400)] 
Update remaining LTTng/TMF versions to 2.0.0

- LTTng parent pom.xml
- LTTng releng pom.xml / category.xml
- all references to LTTng parent pom.xml

Change-Id: I96973d7e33f5aabe813e5439432bb98ebf0e33b4
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7912
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
11 years agolttng: Bump lttng2 and lttng2.kernel plugins to 2.0
Alexandre Montplaisir [Tue, 18 Sep 2012 15:54:35 +0000 (11:54 -0400)] 
lttng: Bump lttng2 and lttng2.kernel plugins to 2.0

Change-Id: I53cfe696d0ecd56b1c2099bb8299bb9a11df5d26
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7803
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>

11 years agoRemoved a pile of unnecessary @SuppressWarning
Francois Chouinard [Wed, 19 Sep 2012 21:24:07 +0000 (17:24 -0400)] 
Removed a pile of unnecessary @SuppressWarning

Change-Id: Id6698243bb57be8a2fcb0b4bb1a933738c11a66a
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7842
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

11 years agoRename 'locationData' to 'locationInfo' (for lack of a better name...)
Francois Chouinard [Wed, 19 Sep 2012 17:18:43 +0000 (13:18 -0400)] 
Rename 'locationData' to 'locationInfo' (for lack of a better name...)

Change-Id: I1980f6bd4f9a522804d6b782be1bb32261f917df
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7841
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

11 years agoRemove the generic location (replace by Comparable)
Francois Chouinard [Wed, 19 Sep 2012 17:16:59 +0000 (13:16 -0400)] 
Remove the generic location (replace by Comparable)

Change-Id: I05d4c813d0e2406f47e78beae992da6369f977ce
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7840
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

11 years agoMake TmfLocation abstract and implement a couple of Tmf<type>Location
Francois Chouinard [Wed, 19 Sep 2012 17:16:25 +0000 (13:16 -0400)] 
Make TmfLocation abstract and implement a couple of Tmf<type>Location

Change-Id: I1a8c3fdef01a9ec9c548592d1c71a248e6d9bd60
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7839
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
11 years agoMerge branch 'master' into lttng-kepler
Patrick Tasse [Wed, 19 Sep 2012 19:31:05 +0000 (15:31 -0400)] 
Merge branch 'master' into lttng-kepler

Conflicts:
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/TimeGraphControl.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/TimeGraphTooltipHandler.java

11 years agoFix for bug 389907: Mouse drag zoom and other time graph mouse fixes.
Patrick Tasse [Wed, 19 Sep 2012 15:12:45 +0000 (11:12 -0400)] 
Fix for bug 389907: Mouse drag zoom and other time graph mouse fixes.

Change-Id: Ib7ad84872ff680c1ea1cfdd27d8996a55a64b013
Reviewed-on: https://git.eclipse.org/r/7831
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
11 years agotmf: Define the StateChangeInput's event type at the constructor
Alexandre Montplaisir [Tue, 18 Sep 2012 19:31:28 +0000 (15:31 -0400)] 
tmf: Define the StateChangeInput's event type at the constructor

instead of using an abstract method just for that.

With this we can also check in the abstract class itself if the
event type is the right one before calling the method from the
sub-class.

Change-Id: I0cbce6c87e3ec51acfac4061c9db38f32bbcce9a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7807
Tested-by: Hudson CI
11 years agotmf: Add an abstract class for the StateChangeInput
Alexandre Montplaisir [Mon, 17 Sep 2012 20:58:05 +0000 (16:58 -0400)] 
tmf: Add an abstract class for the StateChangeInput

The state-change-input plugin needed by the state system is
currently offered through a IStateChangeInput interface.
However much of the code is common between implementations.
Furthermore, the LTTng kernel plugin nicely splits the work
in two threads, so it would be great to be able to easily
re-use that feature.

This introduces a AbstractStateChangeInput class which will
provide a good ground base for building a state input plugin.
It will also wrap the multi-thread part of the code, so other
inputs can benefit from it.

The interface remains available for more exotic use cases.

Change-Id: I8c9210af62b63b48ffcdc54b3da35df7754e1583
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7798
Tested-by: Hudson CI
11 years agotmf: Rename TmfLocation.fLocation to .fLocationData
Alexandre Montplaisir [Thu, 16 Aug 2012 19:52:23 +0000 (15:52 -0400)] 
tmf: Rename TmfLocation.fLocation to .fLocationData

and the corresponding methods (getLocationData(), etc.)

Simple rename, to make it more clear the contained value is
(usually) not a Location itself. This way we don't get things
like foo.getLocation().getLocation().

Change-Id: Ia25fde3c834dfed03671079a93be4dfc66f4b328
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7262

11 years agoRe-factor and freshen up TmfCoreTracer (previously Tracer)
Francois Chouinard [Mon, 17 Sep 2012 21:19:22 +0000 (17:19 -0400)] 
Re-factor and freshen up TmfCoreTracer (previously Tracer)

Summary of main changes:
- Renamed o.e.l.internal.tmf.core.Tracer to TmfCoreTracer
- Removed the error/warning/info tracing classes (already handled by
activator)

Change-Id: Ic75a05c6add22b6c29b699d928bb830124db6a73
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
11 years agotmf: CtfTmfEvent improvements
Alexandre Montplaisir [Thu, 6 Sep 2012 20:49:51 +0000 (16:49 -0400)] 
tmf: CtfTmfEvent improvements

- Remove extraneous Javadoc
- Change fTimestamp from a singleton to a proper field, set at
  the constructor.
- Drop unneeded singletons (fReference and fSource)
- Remove getTimestampValue(), call getTimestamp.getValue() instead,
  it is more compatible with ITmfEvent/Timestamp interfaces.

Change-Id: I0522a40f3817bcc34bde48dc90358fb745f7bdbc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7648
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
11 years agoFix for bug 387934: Single event experiment not shown in events table.
Patrick Tasse [Fri, 24 Aug 2012 17:52:57 +0000 (13:52 -0400)] 
Fix for bug 387934: Single event experiment not shown in events table.

Change-Id: Ic0984c905f2f7d5b7ca60734eda9e2b54f692243
Reviewed-on: https://git.eclipse.org/r/7386
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>
11 years agoMerge branch 'master' into lttng-kepler
Alexandre Montplaisir [Thu, 13 Sep 2012 20:07:40 +0000 (16:07 -0400)] 
Merge branch 'master' into lttng-kepler

Conflicts:
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsTable.java

Change-Id: I553c88f56037dc35b9f646887b12d83e623d3543

11 years agoctf: Correctly handle big-endian traces
Matthew Khouzam [Fri, 7 Sep 2012 18:20:15 +0000 (14:20 -0400)] 
ctf: Correctly handle big-endian traces

Fixes the opening of big-endian traces, coming from PowerPC systems
for example.

Closes bug 389002.

Change-Id: I1bd85b80931b8a7c61e6dd2b4b575e8608195bb6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7655
Tested-by: Hudson CI
11 years agoctf: Fix feature.xml to allow building with pde-build
Alexandre Montplaisir [Tue, 11 Sep 2012 20:30:06 +0000 (16:30 -0400)] 
ctf: Fix feature.xml to allow building with pde-build

When trying to build the CTF feature with pde-build, it currently
fails because of unsatisfied dependencies.

We need to:
- Remove the e.o.l.ctf.parser dep completely (the feature ships
  this plugin, it cannot depend on it before it's built!)
- Change the order of the plugins so .parser is built first, since
  the .core depends on it.

Side note, this .parser plugin is the only one (apart from the help
plugin) that does not get put into a jar when built. I really have
no idea why...

Change-Id: Id520ba5fe4b2aa064f0850748774e14a6b83e49b
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7716
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
11 years agooups, revert last commit
Xavier Raynaud [Wed, 12 Sep 2012 15:15:12 +0000 (17:15 +0200)] 
oups, revert last commit

11 years agoFix for bug 386075: Show the TID number in the Resource View's tooltip.
Patrick Tasse [Tue, 11 Sep 2012 19:46:46 +0000 (15:46 -0400)] 
Fix for bug 386075: Show the TID number in the Resource View's tooltip.

Change-Id: I83c30e7d33fed5184e0c430e34c9829f57a11283
Reviewed-on: https://git.eclipse.org/r/7714
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
11 years agoTMF: add support for popup menu in time chart widgets
Xavier Raynaud [Wed, 12 Sep 2012 15:01:10 +0000 (17:01 +0200)] 
TMF: add support for popup menu in time chart widgets

11 years agoFix for bug 389328: Provide hover time for time graph tool tip info.
Patrick Tasse [Wed, 12 Sep 2012 14:11:50 +0000 (10:11 -0400)] 
Fix for bug 389328: Provide hover time for time graph tool tip info.

Change-Id: I2eaf701ff090fbac1a48f5bc159d27e64dd3938d
Reviewed-on: https://git.eclipse.org/r/7713
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
11 years agoFix for bug 389300: Events table does not synchronize on search.
Patrick Tasse [Tue, 11 Sep 2012 20:23:58 +0000 (16:23 -0400)] 
Fix for bug 389300: Events table does not synchronize on search.

Change-Id: Ic403e97022f665278059f356b71ef33976242c66
Reviewed-on: https://git.eclipse.org/r/7715
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
This page took 0.047199 seconds and 5 git commands to generate.