David Goulet [Wed, 12 Mar 2014 18:07:12 +0000 (14:07 -0400)]
Fix: wrong number of elements in array for loop
Fixes coverity issue
1191759.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 12 Mar 2014 17:55:44 +0000 (13:55 -0400)]
Fix: possible unlink on uninitialized buffer path
Fixes coverity issue
1191752.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 12 Mar 2014 17:48:53 +0000 (13:48 -0400)]
Fix: possible load config domain overwrite
The uniqueness of the domain CAN NOT be enforced with the XML xsd schema
so if the same domains are seen, return an error.
Fixes coverity issue
1191755.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 12 Mar 2014 17:40:49 +0000 (13:40 -0400)]
Fix: memory leak
Fixes coverity issue
1191756.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 12 Mar 2014 17:29:44 +0000 (13:29 -0400)]
Fix: save session usage of string size
Kind of fixes coverity issue
1191758 since there was a bad check but the
reported issue does not makes sense since there is in fact a validation
before writing the string making the "len" variable never able to reach
4096 (PATH_MAX).
Signed-off-by: David Goulet <dgoulet@efficios.com>
Zifei Tong [Wed, 12 Mar 2014 09:44:10 +0000 (17:44 +0800)]
Fix: remove unused tp in high-throughput test
Signed-off-by: Zifei Tong <zifeitong@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Lars Persson [Wed, 12 Mar 2014 09:22:40 +0000 (10:22 +0100)]
Use autoconf AM_MAINTAINER_MODE.
Give distribution maintainers the option to skip rebuilding autoconf and
automake generated files. The default behaviour is still to have the
rebuild rules enabled.
Signed-off-by: Lars Persson <larper@axis.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 10 Mar 2014 20:18:42 +0000 (16:18 -0400)]
Fix: handle signed return value for snprintf
Signed-off-by: David Goulet <dgoulet@efficios.com>
Zifei Tong [Tue, 4 Mar 2014 13:27:38 +0000 (21:27 +0800)]
Fix: clang 'constant-out-of-range-compare' warning
This patch fixes two 'autological-constant-out-of-range-compare' clang
warnings caused by comparing enum type variables with -1.
It's possible that compilers optimize these two comparisons away.
Signed-off-by: Zifei Tong <zifeitong@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Mon, 10 Feb 2014 20:31:46 +0000 (15:31 -0500)]
Fix: Fail configuration if libxml2 is not found
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 10 Feb 2014 16:47:14 +0000 (11:47 -0500)]
Add load command to the lttng client
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Mon, 10 Feb 2014 16:44:55 +0000 (11:44 -0500)]
Add session configuration load capability to libconfig
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Wed, 22 Jan 2014 17:04:49 +0000 (12:04 -0500)]
Add a save command based on the save API to the lttng client
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Wed, 22 Jan 2014 19:36:01 +0000 (14:36 -0500)]
Add session configuration save feature to session daemon
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Wed, 22 Jan 2014 16:57:19 +0000 (11:57 -0500)]
Add a save API to lttng-ctl
This adds multiple function calls to the lttng-ctl API with save.h and
save-internal.h files.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Wed, 22 Jan 2014 16:46:06 +0000 (11:46 -0500)]
Add session configuration XSD
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Tue, 21 Jan 2014 19:24:54 +0000 (14:24 -0500)]
Add a config_writer API based on libxml2
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Tue, 21 Jan 2014 18:44:56 +0000 (13:44 -0500)]
Add a dependency to libxml2
libxml2 2.7.6 is the oldest supported version.
This is the version distributed as part of RHEL 6.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Tue, 21 Jan 2014 17:24:24 +0000 (12:24 -0500)]
Send filter expression string to session daemon
Send the filter expression string along with the filter's bytecode to
the session daemon. The session daemon now stores the filter expression.
This makes it possible to list the filter's expression when listing
events.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Tue, 28 Jan 2014 20:01:25 +0000 (15:01 -0500)]
Fix: tcp4 and net4 protocol support in uri_parse
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Wed, 22 Jan 2014 16:50:10 +0000 (11:50 -0500)]
session_find_by_name does not need a non-const name param
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Tue, 4 Mar 2014 18:45:17 +0000 (13:45 -0500)]
Fix: Unchecked session pointer when destroying a connection in relayd
An unknown command currently crashes the relay daemon since
destroy_connection calls destroy_session without checking whether or not
a session is associated with the connection.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 28 Feb 2014 17:31:46 +0000 (12:31 -0500)]
Fix: improve lttng with live by spawning relayd
The create --live, will try to spawn a default relayd if no URL is
given.
The lttng view now supports the live tracing mode thus lttng view is
usable with a live session.
Fixes #738
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Fri, 28 Feb 2014 13:33:49 +0000 (08:33 -0500)]
Fix: relayd should listen for viewers on localhost only by default
Having relayd listening by default on 0.0.0.0 (all interfaces) with a
protocol without authentication is an information leak waiting to
happen.
Users should explicitely specify if they want to listen on all
interfaces, using e.g. -L tcp://0.0.0.0:5344 (see lttng-relayd(8)
manpage for details). They should only do so if they use a firewall, or
are within a secured network.
Fixes #746
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 27 Feb 2014 20:04:53 +0000 (15:04 -0500)]
Fix: handle loglevel range ALL in list command
Print the ":" if we get the ALL range and not TYPE UNKNOWN.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 27 Feb 2014 19:48:07 +0000 (14:48 -0500)]
Tests: add JUL test for multiple loglevel
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 27 Feb 2014 19:00:13 +0000 (14:00 -0500)]
Fix: index JUL event by name *and* loglevel
This is to support multiple loglevels for a JUL event.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 27 Feb 2014 15:03:14 +0000 (10:03 -0500)]
Fix: JUL to enable user and root tracepoints
This is needed to support the LTTng JUL agent to connect to both user
and root session daemon, we have to enable different tracepoint for the
two cases in order to avoid duplicating the trace payload in both the
user and root trace output.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 27 Feb 2014 14:56:51 +0000 (09:56 -0500)]
Revert "Fix: format + PACKAGE_URL for dynamic printing"
This changes the lttng version output considered as a stable ABI in RC
cycle. This will apply to 2.5.
This reverts commit
9afbd878f072d5e0577811acf1d3340f65cf2e26.
David Goulet [Wed, 26 Feb 2014 21:13:34 +0000 (16:13 -0500)]
Fix: handle the registration done command for JUL
Lockstep with lttng-ust.
Part of the fix for issue #692
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 26 Feb 2014 20:13:46 +0000 (15:13 -0500)]
Test fix: use temp file sync. of test app
Fixes #736
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 26 Feb 2014 20:07:12 +0000 (15:07 -0500)]
Fix: keep metadata channel attr in UST session
This is so that if we have NO application we can use the metadata
channel attributes once one appears.
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Wed, 26 Feb 2014 15:56:57 +0000 (10:56 -0500)]
Tests fix: Missing waitpid in fork test
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 26 Feb 2014 18:22:32 +0000 (13:22 -0500)]
Fix: add loglevel type to lttng list <name>
For range loglevel, the <= is used and for single ==. For instance:
ev_log_range (loglevel <= TRACE_WARNING (4)) (type: tracepoint)
ev_log_single (loglevel == TRACE_NOTICE (5)) (type: tracepoint)
Fixes #628
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 26 Feb 2014 17:04:57 +0000 (12:04 -0500)]
Fix: minor rephrasing of the lttng.1 man page
Fixes #730
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 26 Feb 2014 16:45:45 +0000 (11:45 -0500)]
Fix: Warn user if JUL port is already being used
Fixes #740
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 26 Feb 2014 16:29:57 +0000 (11:29 -0500)]
Fix: add some sane default values to --live opt
The lttng create --live now takes optional arguments meaning if no USEC
or/and -U are found, some defaults value are used.
Fixes #738
Signed-off-by: David Goulet <dgoulet@efficios.com>
Stefan Seefeld [Wed, 26 Feb 2014 03:44:30 +0000 (22:44 -0500)]
Fix: possible NULL deref. in sessiond error path
Fxies #735
Signed-off-by: Stefan Seefeld <stefan@codesourcery.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jonathan Rajotte [Tue, 25 Feb 2014 18:04:17 +0000 (13:04 -0500)]
Fix: format + PACKAGE_URL for dynamic printing
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 25 Feb 2014 20:24:53 +0000 (15:24 -0500)]
Fix: flag that kernel streams FDs has been sent
Flag the session *after* every stream was successfully sent.
Fixes #731
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 25 Feb 2014 19:45:08 +0000 (14:45 -0500)]
Fix: forbid session name creation if contains /
This adds a validation function for session name which for now denies
any session name containing '/'.
This is in response of bug #721 that actually uses a path as a session
name such as "test/../session1" which would then be concatenated to the
session path adding a relative path to it making this a serious security
issue.
Because of this issue, this is backported from master up to stable-2.3.
Fixes #721
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 25 Feb 2014 19:22:19 +0000 (14:22 -0500)]
Fix: don't start session if no channel
This adds a new error code that indicates that the session contains NO
channel.
Fixes #715
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 25 Feb 2014 19:02:32 +0000 (14:02 -0500)]
Fix: add missing relayd option to man page
Fixes #706
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 25 Feb 2014 18:55:12 +0000 (13:55 -0500)]
Fix: report error if consumer can't be spawned
On error of the UST consumer execl(), we now exit the forked process
like the kernel does.
Furthermore, fix an error handling value when timing out when waiting
for the consumer to bootstrap thus returning an error to the client and
not continuing with the command thinking that the consumer was actually
spawned.
So, the expected behavior is to wait for the pthread condition and if a
timeout is seen, the client is informed thus making the client command
hang for the default timeout value of 30 seconds.
Fixes #702
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 25 Feb 2014 17:42:04 +0000 (12:42 -0500)]
Fix: lttng list -u <name> should only list UST
Fixes #654
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 25 Feb 2014 17:21:32 +0000 (12:21 -0500)]
Fix: kernel channel destroy on consumer if sent
An enable-channel immediately followed by a destroy session triggered an
assert on the consumer followed by the shutdown of the consumer thread
for the kernel.
This fix make sure we don't ask the consumer to destroy a channel if not
previously sent to it and handle not found channel on destroy.
Fixes #643
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 25 Feb 2014 17:01:59 +0000 (12:01 -0500)]
Update changelog with stable 2.3 and 2.4 branch
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 25 Feb 2014 16:03:35 +0000 (11:03 -0500)]
Fix: only create UST metadata on start trace
Fixes #739
Acked-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 24 Feb 2014 19:35:05 +0000 (14:35 -0500)]
Revert "Fix: wrong condition on startup for low-activity streams"
This reverts commit
d3aac146d0800fe9820d51e5b9fa52e7543c1237.
Acked-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Mon, 24 Feb 2014 18:34:00 +0000 (13:34 -0500)]
Fix: missing big endian conversion for one index field
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Mon, 24 Feb 2014 18:02:19 +0000 (13:02 -0500)]
Fix: wrong condition on startup for low-activity streams
If we only received and sent one index, we should not be in the retry
condition.
The rstream->total_index_received == vstream->last_sent_index is checked
before.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Mon, 24 Feb 2014 18:02:18 +0000 (13:02 -0500)]
Fix: perror on index directory creation error
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jonathan Rajotte [Mon, 24 Feb 2014 00:50:52 +0000 (19:50 -0500)]
Comments fix: lttngerr.h -> error.h (./Changelog:754)
Signed-off-by: Jonathan Rajotte <jonathan.r.julien@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Fri, 21 Feb 2014 15:14:46 +0000 (10:14 -0500)]
Fix: consumerd errors on exit
- The LTTNG_CONSUMER_STOP command is not used by sessiond anymore, so
deprecate it,
- Ensure that the normal teardown (with signal handler) does not trigger
a health error in consumer daemon by distinguishing between errors and
"should exit" with different lttng_consumer_poll_socket() return values.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Fri, 21 Feb 2014 03:53:04 +0000 (22:53 -0500)]
Fix: scanf unbounded input
Awaiting a proper cleanup (introducing nscanf), do what we can to
validate the scanf input using its utterly broken API.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 20 Feb 2014 15:23:46 +0000 (10:23 -0500)]
Fix: miscellaneous memory handling fixes
Issues found with Valgrind:
- Uninitialized memory sent through sendmsg,
- Uninitialized realloc memory,
- Erroneous pointer arithmetic in jul_list_events(),
- Memory leaks in kernel_consumer_add_channel(),
kernel_consumer_add_metadata(),
- Memory leak (snapshot_destroy missing hash table cleanup),
- Uninitialized poll/epoll memory on realloc.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 20 Feb 2014 15:23:45 +0000 (10:23 -0500)]
Fix: add missing VALGRIND ifdef checks and documentation
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Fri, 14 Feb 2014 19:25:26 +0000 (14:25 -0500)]
Fix: race with index file creation
Only the data thread should create the index file since it is
responsible of filling the FD field of the index struct in memory.
When the control thread is ready to write the index, the FD is already
set.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Fri, 14 Feb 2014 20:51:34 +0000 (15:51 -0500)]
Fix: deadlock during rotation
The overwrite_lock is nested inside the viewer_stream_rotation_lock.
And the viewer_stream_rotate function is always called with the
viewer_stream_rotation_lock held.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 13 Feb 2014 18:58:19 +0000 (13:58 -0500)]
Fix: simplify get next index in live
This fixes some case of unitialized status, use of bad ret value and
help modularize the get next index function.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 12 Feb 2014 20:17:57 +0000 (15:17 -0500)]
Fix: steal channel key in the consumer to avoid race
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 13 Feb 2014 15:55:47 +0000 (10:55 -0500)]
Fix: change ERR statement to DBG in kernel read subbuffer
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 13 Feb 2014 15:42:58 +0000 (10:42 -0500)]
Fix: handle snapshot ENODATA in live timer
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 12 Feb 2014 16:19:43 +0000 (11:19 -0500)]
Fix: relayd leak on error in consumer splice()
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 11 Feb 2014 21:27:57 +0000 (16:27 -0500)]
Fix: protect close_write_flag with the rotation lock
Acked-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 12 Feb 2014 19:46:08 +0000 (14:46 -0500)]
Man: clarify loglevel for JUL domain
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Mon, 10 Feb 2014 16:04:22 +0000 (11:04 -0500)]
Fix: Define __STDC_LIMIT_MACROS to fix C++ builds
Necessary to include the fixed-width type limits on glibc versions
older than 2.18 when building with a C++ compiler.
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 11 Feb 2014 21:36:30 +0000 (16:36 -0500)]
Fix: wrong data structure used in commit
df41f83
Signed-off-by: David Goulet <dgoulet@efficios.com>
Christian Babeux [Fri, 7 Feb 2014 17:43:38 +0000 (12:43 -0500)]
Fix: add missing optional dependency to babeltrace in README
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Christian Babeux [Fri, 7 Feb 2014 17:48:51 +0000 (12:48 -0500)]
Fix: cleanup inconsistent use of spaces/tabs in README
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Mon, 10 Feb 2014 23:52:29 +0000 (18:52 -0500)]
Fix: only set the new_streams flag if a viewer is attached
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Mon, 10 Feb 2014 23:52:28 +0000 (18:52 -0500)]
Fix: lttng-live documentation
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 11 Feb 2014 21:08:43 +0000 (16:08 -0500)]
Fix: remove dead code in relayd live code
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 11 Feb 2014 21:04:15 +0000 (16:04 -0500)]
Fix: use after free error code path
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 11 Feb 2014 20:58:52 +0000 (15:58 -0500)]
Fix: wrong sizeof argument in live viewer create session
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 11 Feb 2014 20:16:34 +0000 (15:16 -0500)]
Fix: zero out the reply structure in viewer_connect
Fixes #728
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 11 Feb 2014 19:13:01 +0000 (14:13 -0500)]
Fix: write index only if fd is valid
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 11 Feb 2014 18:21:59 +0000 (13:21 -0500)]
Fix: cleanup relayd on any I/O error in read subbuffer mmap
Any I/O operation that triggers an error now cleans the relayd since
there is no way we can recover from that in any cases and streams
associated to that relayd need to be cleaned up.
This commit also removes the "written" variable that is simply not
needed and was a bit confusing as a returned value.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 11 Feb 2014 18:16:45 +0000 (13:16 -0500)]
Fix: memory/fd leak when cleaning streams in channel
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 10 Feb 2014 22:23:20 +0000 (17:23 -0500)]
Fix: destroy streams in consumer del channel
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 10 Feb 2014 22:21:14 +0000 (17:21 -0500)]
Fix: add missing urcu wfqueue headers in relayd
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 10 Feb 2014 18:43:08 +0000 (13:43 -0500)]
Fix: in lttng_read/write deny count bigger than the possible returned value
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 6 Feb 2014 21:49:37 +0000 (16:49 -0500)]
Fix: fd leak when closing metadata stream
Make sure to close the metadata poll pipe when the endpoint of the
stream dies out (ex: relayd stops unexpectedly). That was causing a fd
leak when we were destroying a metadata stream without using the close
metadata code path.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 6 Feb 2014 19:16:06 +0000 (14:16 -0500)]
Fix: read subbuffer mmap/splice signedness issue
Signed and unsigned values were compared thus making the code path where
ret = -1 being interpreted as ret > len == true thus not cleaning up the
relayd.
This patch simplifies the read subbuffer mmap operation since
lttng_write() now provides a guarantee that the return data is either
equal to the count passed or less which the later means the endpoint has
stop working.
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Thu, 6 Feb 2014 15:50:56 +0000 (10:50 -0500)]
Doc: live protocol clarifications
Updates about the get_new_stream, the attach procedure, the create
viewer_session and the multiple attach.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Thu, 6 Feb 2014 15:21:21 +0000 (10:21 -0500)]
Fix: remove unused create_viewer_session option
Since it is unused for now, don't bloat the ABI with that.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
David Goulet [Wed, 5 Feb 2014 22:40:59 +0000 (17:40 -0500)]
Fix: don't sleep(1) on the consumer ready flag
This is way too long on especially when the first command that spawn the
consumer as to wait a full second on powerful system.
Bring this down to 0.1 sec sleep by using usleep().
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 5 Feb 2014 21:37:46 +0000 (16:37 -0500)]
Fix: free viewer session in connection_free()
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 5 Feb 2014 21:26:43 +0000 (16:26 -0500)]
Fix: add missing ctf trace delete before destroy
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 5 Feb 2014 21:03:35 +0000 (16:03 -0500)]
Fix: don't delete ctf trace while in snapshot mode
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Wed, 5 Feb 2014 19:55:11 +0000 (14:55 -0500)]
Fix: add flag to create session command and fix tests
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Wed, 5 Feb 2014 19:55:10 +0000 (14:55 -0500)]
Fix: cleanup indef guards following the rename
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
David Goulet [Wed, 5 Feb 2014 17:18:04 +0000 (12:18 -0500)]
Fix: merge issue with thread quit pipe
Signed-off-by: David Goulet <dgoulet@efficios.com>
Marc-Andre Laperle [Tue, 4 Feb 2014 19:40:50 +0000 (14:40 -0500)]
Fix: use uint32_t for metadata_flag in viewer's ABI
This struct is meant to be sent over the network so members should be
of exact-width.
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Tue, 4 Feb 2014 02:08:07 +0000 (21:08 -0500)]
Fix: check for new streams in all attached sessions
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Fri, 31 Jan 2014 20:17:06 +0000 (15:17 -0500)]
Fix: Move static functions up in the code
When we detect that the viewer is trying to get new streams for a
session closed and for which it already got all the streams, we can
delete and destroy the session, we know it won't be useful anymore.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Thu, 30 Jan 2014 23:36:28 +0000 (18:36 -0500)]
Fix: allow attach command to multiple sessions
The attach session command can now attach to multiple session using an
ID list.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Thu, 30 Jan 2014 22:08:31 +0000 (17:08 -0500)]
Fix: handle session hang up in get_new_streams
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Thu, 30 Jan 2014 20:44:20 +0000 (15:44 -0500)]
Fix: force the client to create a viewer session before attaching
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Julien Desfossez [Thu, 30 Jan 2014 16:11:44 +0000 (11:11 -0500)]
Fix: Namespace lttng-viewer-abi
This header is copied to all the viewers that implement the lttng-live
protocol, we need to make sure it is properly namespaced.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
This page took 0.042619 seconds and 5 git commands to generate.