Mathieu Desnoyers [Sat, 8 Nov 2014 17:16:41 +0000 (12:16 -0500)]
Fix: off-by-one in sequence filter comparator
If we pass the following sequence as event input:
- field name "seqfield2"
- seq. len.: 4
- sequence array: "testA" (5 characters),
The following filters do not have the intended effect:
* 'seqfield2=="testA"'
- expected: no match.
- actual behavior: match.
* 'seqfield2=="test"'
- expected: match.
- actual behavior: no match.
This is caused by an off-by-one in the comparison with sequence length
in the filter bytecode interpreter.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Christian Babeux [Tue, 4 Nov 2014 21:28:19 +0000 (16:28 -0500)]
Fix: Java Agent JAR file symlink should be created after objects install
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Christian Babeux [Mon, 3 Nov 2014 20:12:26 +0000 (15:12 -0500)]
Fix: Add versioning to liblttng-ust-agent JAR
The liblttng-ust-agent JAR need versioning. The manifest file contains the
appropriate information about the JAR, such as the current version.
A symlink is also created and installed in order to point to the latest
version of the JAR.
e.g: liblttng-ust-agent.jar -> liblttng-ust-agent-1.0.0.jar
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Christian Babeux [Fri, 31 Oct 2014 19:33:59 +0000 (15:33 -0400)]
Fix: Warn when log4j version is too old
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Christian Babeux [Fri, 31 Oct 2014 19:33:40 +0000 (15:33 -0400)]
Update Java agent documentation
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Fri, 31 Oct 2014 18:03:47 +0000 (14:03 -0400)]
Fix: Try loading classes using the thread context class loader
LTTngAgent should load classes using the current thread context's
class loader and then try using the system class loader if a
ClassNotFoundException is thrown.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Thu, 9 Oct 2014 17:21:02 +0000 (13:21 -0400)]
Add Python agent support
This adds a new library in this repository being the
liblttng-ust-python-agent. It contains the Python agent and a library
for the tracepoints used by the agent.
To enable the python agent, use --enable-python-agent to build it.
This new agent is bound to the LTTng python domain in lttng-tools which
implements the -p,--python option for agent's command.
It works and tested for python 2.7.x and 3.x
Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 20 Oct 2014 22:57:50 +0000 (18:57 -0400)]
Update version name
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 20 Oct 2014 22:54:31 +0000 (18:54 -0400)]
Version 2.6.0-rc1
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 16 Oct 2014 15:03:40 +0000 (17:03 +0200)]
Add missing file to gitignore
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Thu, 16 Oct 2014 13:45:19 +0000 (09:45 -0400)]
Fix: preserve example files' timestamps when copying
This fixes an issue where examples were always being rebuilt
when performing an out of tree build since the examples were
being copied to the build directory with a timestamp more
recent than the already-built example objects.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Christian Babeux [Thu, 2 Oct 2014 20:31:56 +0000 (16:31 -0400)]
Fix: Abort loading log4j agent classes when detected log4j version is too old
The Java Log4j agent rely on the getTimeStamp() method that was
introduced in log4j 1.2.15. This fix implement a runtime detection of
the log4j library capabilities and abort the loading of the relevant
agent classes if the version used is too old.
Thus, log4j tracing will be deactivated on older version of the
library.
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Christian Babeux [Thu, 25 Sep 2014 16:08:11 +0000 (12:08 -0400)]
Cleanup: Remove the no longer needed liblttng-ust-jul folder
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Christian Babeux [Thu, 25 Sep 2014 16:07:32 +0000 (12:07 -0400)]
Fix: Wrong CLASSPATH when building liblttng-ust-java oot
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Christian Babeux [Wed, 24 Sep 2014 19:44:05 +0000 (15:44 -0400)]
Fix: Wrong CLASSPATH when building liblttng-ust-java-agent oot
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Simon Marchi [Wed, 13 Aug 2014 23:10:41 +0000 (19:10 -0400)]
Rename public structure to avoid collisions
Since nobody raised any concern about this, I submit the patch for
merging. You can find the original discussion here:
http://lists.lttng.org/pipermail/lttng-dev/2014-July/023364.html
(the rest of the message is identical to the RFC post)
When trying to use lttng-ust with a program that defines its own struct
tracepoint, a name collision arises and compilation fails (see example
lower).
I suggest the following renames (the problem only showed up with struct
tracepoint in my case, but let's be proactive):
* struct tracepoint -> struct lttng_ust_tracepoint
* struct tracepoint_probe -> struct lttng_ust_tracepoint_probe
* struct tracepoint_dlopen -> struct lttng_ust_tracepoint_dlopen
Strictly speaking, those names are part of the public API of LTTng, so I
understand that it would be a felony to rename it, since it breaks the
holy API. However, those structures are only used through some macros,
and I am not aware of any sensible use case where a user of lttng-ust
would directly reference those structures. Therefore, it should not break
any existing code. If you do have such a use case, where it would break
your code, please jump in the discussion.
This should not break any application instrumented and built before the
change. Tested by building "hello" before and tracing it after the
change.
Here is an example of error due to the name collision. This is when
building gdb, which I try to instrument with lttng-ust.
In file included from /usr/local/include/lttng/tracepoint.h:28:0,
from ust_tracepoints.h:15,
from inf-ptrace.c:38:
/usr/local/include/lttng/tracepoint-types.h:32:8: error: redefinition of
‘struct tracepoint’
struct tracepoint {
^
In file included from inferior.h:37:0,
from inf-ptrace.c:22:
breakpoint.h:817:8: note: originally defined here
struct tracepoint
^
Makefile:1088: recipe for target 'inf-ptrace.o' failed
make: *** [inf-ptrace.o] Error 1
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Christian Babeux [Mon, 15 Sep 2014 03:11:30 +0000 (23:11 -0400)]
Refactor liblttng-ust-jul in liblttng-ust-agent
This is a major refactor of the initial implementation of the UST JUL
agent. The agent now support the log4j logging backend.
The agent can now be built in three different configurations:
1) Java agent with JUL support:
$ ./configure --enable-java-agent-jul
2) Java agent with Log4j support:
$ export CLASSPATH=$CLASSPATH:/path/to/log4j.jar
$ ./configure --enable-java-agent-log4j
3) Java agent with JUL + Log4j support
$ export CLASSPATH=$CLASSPATH:/path/to/log4j.jar
$ ./configure --enable-java-agent-all
To build the agent with log4j support, make sure that the log4j jar
is in your Java classpath.
The configure script will automatically detect the appropriate Java
binaries to use in order to build the Java agent.
The name of the agent jar file is now "liblttng-ust-agent.jar".
It will be installed in the arch-agnostic "$prefix/share/java" path
e.g: "/usr/share/java".
In order to support older applications using the "org.lttng.ust.jul"
package, a transitional package is built with the same name.
All applications should move to use the "org.lttng.ust.agent" package.
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Christian Babeux [Mon, 15 Sep 2014 03:30:45 +0000 (23:30 -0400)]
Build the liblttng-ust-java library using the new M4 macros
The liblttng-ust-java can now be built without passing paths to
the JDK:
$ ./configure --enable-jni-interface
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Christian Babeux [Mon, 15 Sep 2014 03:28:38 +0000 (23:28 -0400)]
Add M4 macros helpers to build Java programs
These M4 were taken from the autoconf archive [1].
[1] - http://www.gnu.org/software/autoconf-archive
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Philippe Proulx [Wed, 17 Sep 2014 03:29:06 +0000 (23:29 -0400)]
Modernize README using Markdown
This commit also:
* adds a project description at the top
* simplifies the steps to build/link a user
application with LTTng-UST and provides examples
of commands
* updates the Package contents list
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 11 Sep 2014 15:19:05 +0000 (11:19 -0400)]
Documentation: clarify event name in lttng-ust.3
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 9 Sep 2014 14:09:13 +0000 (10:09 -0400)]
Add cscope to gitignore
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Philippe Proulx [Tue, 2 Sep 2014 20:12:55 +0000 (16:12 -0400)]
configure.ac: fix "missing jni.h" error message
DIR in --with-java-jdk=DIR must point to the JDK base
directory, not the actual JDK include directory.
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 13 Aug 2014 16:27:46 +0000 (12:27 -0400)]
Fix: remove references to trace_printf()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Fri, 8 Aug 2014 16:48:48 +0000 (12:48 -0400)]
Change JUL agent to use the new ABI
Two things have changed, the agent port file created by the session
daemon, the name is now "agent.port". The second thing is that upon
registration, the agent needs to send its domain which is here
LTTNG_DOMAIN_JUL (val: 3).
Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 16 Jul 2014 22:18:11 +0000 (18:18 -0400)]
Version 2.5.0
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 16 Jul 2014 21:40:53 +0000 (17:40 -0400)]
Mutex while updating statedump_pending is not needed
Take care of coverity warning ** CID
1226392: Data race condition (MISSING_LOCK)
/liblttng-ust/lttng-ust-comm.c: 1704 in lttng_ust_sockinfo_session_enabled()
It's not that the lock is missing, it's that we don't need to hold the
lock when doing the other modification.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Paul Woegerer [Mon, 14 Jul 2014 08:38:25 +0000 (10:38 +0200)]
Revert "Turn base address dump into experimental feature"
This reverts commit
b11abb674e50c67e3410ab2bd5d0a263e88b73ba.
Signed-off-by: Paul Woegerer <paul_woegerer@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 16 Jul 2014 14:35:43 +0000 (10:35 -0400)]
Fix: document ust_fork_mutex nesting
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Paul Woegerer [Mon, 14 Jul 2014 08:38:24 +0000 (10:38 +0200)]
Bugfix for #745 deadlock with baddr statedump+fork
Fixes #745
Signed-off-by: Paul Woegerer <paul_woegerer@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Francis Deslauriers [Thu, 10 Jul 2014 22:22:14 +0000 (18:22 -0400)]
Move enablers syncing after the channel registration
Fixes possible race condition where an event registration is received
before its channel registration by the consumer.
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Paul Woegerer [Mon, 7 Jul 2014 14:04:21 +0000 (16:04 +0200)]
Add lttng_ust_notrace to static inline functions
The static inline functions
__tracepoint_provider_mismatch_<TRACEPOINT_PROVIDER> and
__tracepoint_provider_check_<TRACEPOINT_PROVIDER> are missing the
lttng_ust_notrace attribute to prevent them from getting instrumented
with -finstrument-functions (if e.g. defined in CFLAGS). This patch is
adding the attribute to those functions.
Signed-off-by: Paul Woegerer <paul_woegerer@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michel Normand [Mon, 30 Jun 2014 16:12:19 +0000 (12:12 -0400)]
lttng ust: support ppc64le within configure
Takes care of https://bugzilla.redhat.com/show_bug.cgi?id=
1114691
Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 27 Jun 2014 14:07:32 +0000 (10:07 -0400)]
Version 2.5.0-rc2
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Thu, 26 Jun 2014 19:07:54 +0000 (15:07 -0400)]
Fix: lttng-ust-jul: set thread in daemon mode
This way, when the JVM stops the main thread, the agent's thread will be
automatically shutdown thus making the .dispose() call optional.
Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Wed, 18 Jun 2014 18:08:24 +0000 (14:08 -0400)]
JUL: use root logger to capture events
The JUL agent now uses the root logger ("") to capture all events. This
allows us to remove the Timer thread and cleanup a huge portion of the
code base. It simplifies a great deal the internal structure of the
agent since we don't have to monitor the Logger object anymore.
Since tracepoint filtering is done in UST, we just the LTTng handler to
the root logger and send everything to UST.
Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Christian Babeux [Thu, 26 Jun 2014 15:42:28 +0000 (11:42 -0400)]
Fix: Wrong configure check for UST perf event counters context support
When building on non-x86 platforms, the build errors out with the following:
CC lttng-context-perf-counters.lo
lttng-context-perf-counters.c:95:2: error: #error "Perf event counters are only supported on x86 so far."
lttng-context-perf-counters.c: In function 'read_perf_counter':
lttng-context-perf-counters.c:114:4: warning: implicit declaration of function 'rdpmc' [-Wimplicit-function-declaration]
make[2]: *** [lttng-context-perf-counters.lo] Error 1
The configure script checks for the presence of the "perf_event.h" header to enable support for
perf events counters. However, the current implementation is only available on x86,
hence the build fails on platform where the perf header is available.
Fix this issue by detecting the architecture we are currently building and wether
to enable or not the support for perf event counters context.
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 10 Jun 2014 16:17:08 +0000 (12:17 -0400)]
Fix: multiple providers in same C file failure
If we have a C file in an application that is meant to contain both the
instrumentation and the provider, build fails if we have more than one
provider.
Fixed by putting back definitions to the state they were when defined by
tracepoint.h after a probe provider is created. This allows the next
tracepoint provider to define its tracepoints.
Fixes #805
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Gerlando Falauto [Tue, 3 Jun 2014 08:01:58 +0000 (10:01 +0200)]
Fix: header inclusion guard typo in lttng-ust-tracef-provider.h
Fix typo potentially allowing for multiple inclusions.
Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 28 May 2014 14:24:08 +0000 (10:24 -0400)]
Fix: 2.5.0-rc1 changelog has off-by-one date
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 28 May 2014 14:18:27 +0000 (10:18 -0400)]
Version 2.5.0-rc1
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Tue, 27 May 2014 15:03:42 +0000 (11:03 -0400)]
Fix: out of tree build for lib Java and JUL
Reported-by: Daniel Olivier <daniel.olivier@ericsson.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 23 May 2014 14:28:41 +0000 (10:28 -0400)]
Fix: default loglevel is DEBUG
Include "tracef" events when no explicit loglevel is specified. (for
usability)
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 23 May 2014 13:27:01 +0000 (09:27 -0400)]
Fix: refuse overwrite mode buffers with less than two subbuffers
Fixes #793
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 13 May 2014 13:34:03 +0000 (09:34 -0400)]
Fix: tracef.h: add missing c++ guard
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Wed, 7 May 2014 15:33:41 +0000 (11:33 -0400)]
Fix: remove JUL loglevel filtering from the agent
The loglevel filtering is now done on the UST side setup by
liblttng-ctl. To achieve that, the agent has a new structure to support
two semantic concepts being a LTTng event and a JUL logger that have a
relation of N:1. This addition does not impact the current interfaces of
the agent.
Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Tue, 6 May 2014 15:56:25 +0000 (11:56 -0400)]
Fix: cleanup JUL agent state on sessiond disconnect
Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Wed, 7 May 2014 15:41:46 +0000 (11:41 -0400)]
Fix: Move generated headers to the BUILT_SOURCES target
This fixes the out of tree build when enabling Java support. The
problem in using an LTTngUst.c target is that automake will then
assume the file is generated and thus be found in the builddir.
Using the BUILT_SOURCES target will ensure the
org_lttng_ust_LTTngUst.h and org_lttng_ust_jul_LTTngUst.h headers
are generated before LTTngUst.c is compiled.
Tested-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 30 Apr 2014 16:09:59 +0000 (18:09 +0200)]
Fix: perf ust: check close return value
Fix coverity defect:
** CID
1208905: Unchecked return value (CHECKED_RETURN)
/liblttng-ust/lttng-context-perf-counters.c: 147 in setup_perf()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 30 Apr 2014 07:08:27 +0000 (09:08 +0200)]
Cleanup: work-around missing inet.h struct mmsghdr fwd declaration
Removes build warning.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 7 Feb 2014 16:07:44 +0000 (11:07 -0500)]
Implement LTTng-UST perf counters support on x86
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Adrien Vergé [Fri, 25 Apr 2014 16:12:24 +0000 (12:12 -0400)]
Fix linking failure when cross-compiling
Examples binaries in doc/examples require libs in liblttng-ust/.libs/,
and those libs require other libs in the same directory. For instance
liblttng-ust.so uses liblttng-ust-tracepoint.so symbols, so the latter
is needed to properly link example programs. Currently, ld is given
the lib dir only via -rpath (used for linking executables dependencies)
but not via -rpath-link (used for linking libs dependencies).
When compiling regularly, this does not seem to be a problem (maybe ld
is smart enough). However when cross-compiling with the
arm-linux-gnueabihf toolchain, -rpath-link is needed otherwise linking
fails with:
arm-linux-gnueabihf/bin/ld: warning: liblttng-ust-tracepoint.so.0, needed by ../../../liblttng-ust/.libs//liblttng-ust.so, not found (try using -rpath or -rpath-link)
This patch adds -rpath-link to doc/examples/Makefile.am.
Signed-off-by: Adrien Vergé <adrienverge@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Romain Naour [Wed, 9 Apr 2014 21:55:07 +0000 (23:55 +0200)]
Fix: disable liblttng-ust-dl if dlinfo is not available in C library
According to uClibc commit [1], dlinfo is not available in recent uClibc
(>0.9.33), but available in older version of uClibc (<=0.9.33) whith a
different prototype than glibc.
dlinfo used by liblttng-ust-dl require RTLD_DI_LINKMAP that is not
available in uClibc.
To be able to use LTTng UST with uClibc, we need to disable the Dynamic
Linker Tracing functionality [2] if RTLD_DI_LINKMAP is not detected.
[1] http://git.uclibc.org/uClibc/commit/?id=
f3c9dc499c5c787ddd8c4320f2d44d2ae6e40c22
[2] http://lists.lttng.org/pipermail/lttng-dev/2014-February/022423.html
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Apr 2014 17:05:34 +0000 (13:05 -0400)]
Fix: pass proper args when writing commit counter
lib_ring_buffer_write_commit_counter()'s 'buf_offset' argument should
contain offset of beginning of area used by the record being comitted.
However, lib_ring_buffer_commit() passes ctx->buf_offset, that gets
advanced by lib_ring_buffer_write() and thus points to just-after-
end-of-record at lib_ring_buffer_commit() time. This causes
lib_ring_buffer_write_commit_counter() to return without changing
commit_hot[idx].seq, due to
if (unlikely(subbuf_offset(offset - commit_count, chan)))
return;
Since after-crash data extraction tool checks 'seq' field to find out
how much data is in buffer, this results into inavailability of
data from partially-filled subbuffer for after-crash analysis.
This patch modifies lib_ring_buffer_write_commit_counter() and all its
callers to pass and expect the end of the area. So code works as it
should, and complete information becomes visible in crash dump.
[ Fix ported from lttng-modules. Changelog inspired from Nikita
Yushchenko's original patch. ]
Fixes #785
Reported-by: Nikita Yushchenko <nyoushchenko@mvista.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 14 Apr 2014 14:58:52 +0000 (10:58 -0400)]
Fix: pad strings that are modified concurrently with tracing
Fixes #734
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Tue, 8 Apr 2014 18:43:32 +0000 (14:43 -0400)]
Fix: Use $AM_CC when it is defined instead of gcc in demo-tracef
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 8 Apr 2014 18:29:29 +0000 (14:29 -0400)]
Revert "Fix: disable liblttng-ust-dl if dlinfo is not available in C library"
This reverts commit
88a15b8f075177056017dbcc2e0c6d624805a34e.
It has been reported that this commit breaks the standard case.
Fixes: #778
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Tue, 8 Apr 2014 15:28:23 +0000 (11:28 -0400)]
Fix: .split() the CC environment variable in lttng-gen-tp
The CC variable might contain command line arguments which lttng-gen-tp
currently does not handle. This fix ensures that the arguments are
properly passed on to the compiler binary as if a normal Makefile
was used.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Romain Naour [Sun, 6 Apr 2014 21:02:41 +0000 (23:02 +0200)]
Fix: disable liblttng-ust-dl if dlinfo is not available in C library
According to uClibc commit [1], dlinfo is not available.
To be able to use LTTng UST with uClibc, we need to disable
the Dynamic Linker Tracing functionality [2].
[1] http://git.uclibc.org/uClibc/commit/?id=
f3c9dc499c5c787ddd8c4320f2d44d2ae6e40c22
[2] http://lists.lttng.org/pipermail/lttng-dev/2014-February/022423.html
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jesper Derehag [Thu, 27 Mar 2014 07:57:06 +0000 (08:57 +0100)]
Fix: python invocation through env
This modification calls the interpreter through env instead of
directly, which should be more portable for those distros which do not install
python into /usr/bin/.
Signed-off-by: Jesper Derehag <jderehag@hotmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 2 Apr 2014 20:02:37 +0000 (16:02 -0400)]
Change default loglevel to TRACE_DEBUG_LINE
We do not want default loglevel to include tracef() debug output.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Tue, 1 Apr 2014 15:49:58 +0000 (11:49 -0400)]
Fix: Override AM_PATH_PYTHON's default action-if-not-found
AM_PATH_PYTHON's default action aborts configure. This fix ensures that
configure follows through with a noop.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 25 Mar 2014 14:00:28 +0000 (10:00 -0400)]
Fix: don't accept configure --disable-shared
Building LTTng-UST with --disable-shared compiles fine, but the
resulting installed static libraries silently fails to trace, because
tracepoint fails to dlopen liblttng-ust-tracepoint.so. So don't allow
this unsupported configure option.
Also document this requirement in the README.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 25 Mar 2014 13:46:40 +0000 (09:46 -0400)]
Fix: configure.ac: add missing result to alignment req. check
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 18 Mar 2014 14:27:03 +0000 (10:27 -0400)]
Fix: malloc wrapper: infinite recursion with compat TLS
Fixes #765
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 15 Mar 2014 13:43:26 +0000 (09:43 -0400)]
Fix: lttng-ust needs -ldl for tracef()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 15 Mar 2014 13:36:01 +0000 (09:36 -0400)]
Fix: typo in lttng-ust.3
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 15 Mar 2014 00:31:13 +0000 (20:31 -0400)]
Fix: liblttng-ust-libc-wrapper recursive use of calloc
When built with URCU with --disable-compiler-tls, URCU tls-compat.h uses
calloc in its TLS compat layer. This is used by RCU read-side, which is
used by tracepoint. So using a tracepoint in calloc triggers an infinite
recursion, since its first use of the TLS (with TLS compat) calls
calloc.
Fix this issue by keeping a per-thread nesting counter, and as soon as
we are allocating memory from a context nested within the memory
allocator, don't trace.
Don't trace from the static allocator: keep it as simple as possible,
since this is our fallback.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 14 Mar 2014 22:24:16 +0000 (18:24 -0400)]
Fix: add demo-tracef to dist tarball
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 14 Mar 2014 21:34:41 +0000 (17:34 -0400)]
Fix: add missing header files for tracef
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 12 Dec 2013 12:29:26 +0000 (07:29 -0500)]
Implement tracef() instrumentation API
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Zifei Tong [Fri, 14 Mar 2014 13:23:21 +0000 (21:23 +0800)]
Add 'unused' attribute to tracepoint callback
Compiling tracepoint provider with clang generates 'Wunused-function'
warnings. Add 'unused' attribute to silence these warnings.
Fixes #760
Signed-off-by: Zifei Tong <zifeitong@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Lars Persson [Wed, 12 Mar 2014 09:28:49 +0000 (10:28 +0100)]
Use autoconf AM_MAINTAINER_MODE
Give distribution maintainers the option to skip rebuilding
autoconf and automake generated files. The default behaviour
is still to have the rebuild rules enabled.
Signed-off-by: Lars Persson <larper@axis.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Zifei Tong [Tue, 4 Mar 2014 12:50:14 +0000 (20:50 +0800)]
Fix: mismatch between code and comments
Signed-off-by: Zifei Tong <zifeitong@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 10 Mar 2014 15:16:35 +0000 (11:16 -0400)]
Fix: incorrect urcu git URL in README
Reported-by: Ruslan Uvashev <ruslan.uvashev@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 28 Feb 2014 18:33:51 +0000 (13:33 -0500)]
Version 2.4.0
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 28 Feb 2014 18:26:28 +0000 (13:26 -0500)]
Fix: JUL test: update to API change
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 28 Feb 2014 15:40:33 +0000 (10:40 -0500)]
Fix: Cast from pointer to different integer size warning
Occurs on a 32-bit build. Caused by casting pointer arguments to 64-bit
integers (in the filter stack preparation code).
Fixes #691
Reviewed-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Paul Woegerer [Fri, 28 Feb 2014 09:02:00 +0000 (10:02 +0100)]
Turn base address dump into experimental feature
Instead of having base address state dump enabled by default make it
necessary to explicitly enable it with environment variable
LTTNG_UST_WITH_EXPERIMENTAL_BADDR_STATEDUMP.
Documentation is updated to reflect this change and explain about the
experimental nature of this feature.
Signed-off-by: Paul Woegerer <paul_woegerer@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Thu, 27 Feb 2014 19:51:55 +0000 (14:51 -0500)]
Fix: JUL support multiple loglevels
Fixes #744
Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Thu, 27 Feb 2014 17:30:41 +0000 (12:30 -0500)]
Fix: Skip lttng-gen-tp example build if Python is missing
Fixes #665
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Thu, 27 Feb 2014 16:53:22 +0000 (11:53 -0500)]
Fix: dynamically fetch the session daemon port
When connecting to the session daemon, fetch the port at each try. This
moves the read port file functions to the TCP session daemon client
where the connect happens.
If the port file is not found, simply retry 3 seconds later. Also, this
adds a timeout to the acquire semaphore of 3 seconds.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 27 Feb 2014 15:06:52 +0000 (10:06 -0500)]
Fix: JUL agent connect to user and root sessiond
In order to achieve such a thing, two tracepoints are used where one is
for the regular user and the other one for root. This is to avoid
duplicating the payload in the user and root traces.
Furthermore, if a root port is found, a new thread is started to handle
the second session daemon.
This is lockstep commit with lttng-tools:
f43f95a9a82e01eed34593260d510bd32e2083ec
Fixes #732
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 26 Feb 2014 21:06:31 +0000 (16:06 -0500)]
Fix: handle registration done command
This makes the getLTTngAgent() call wait until we receive that message
so that in the meantime the session daemon can enable events.
Fixes #692
Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Tue, 25 Feb 2014 21:32:05 +0000 (16:32 -0500)]
Fix: Unsynchronized access in LTTngTCPSessiondClient
enabledEventList is shared between the LTTngThread and eventTimer
threads but is not synchronized.
This patch changes enabledEventList's type from an ArrayList to a
synchronized HashSet.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 25 Feb 2014 11:43:46 +0000 (06:43 -0500)]
Cleanup: fix comment
Fixes #652
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Paul Woegerer [Tue, 25 Feb 2014 09:47:00 +0000 (10:47 +0100)]
Fix: Dump executable base-address with readlink
The previous approach only worked if the traced executable was invoked
via its fully qualified path. Using readlink to determine the full
qualified path of the traced executable works reliably even when the
traced executable is started via PATH lookup.
Signed-off-by: Paul Woegerer <paul_woegerer@mentor.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 21 Feb 2014 18:16:20 +0000 (13:16 -0500)]
Fix: add assert for NULL dereference
CID
1021248 (#1 of 1): Dereference null return value (NULL_RETURNS)3.
dereference: Dereferencing a null pointer "obj".
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 21 Feb 2014 18:13:14 +0000 (13:13 -0500)]
Fix: tracepoint out of memory handling
CID
1021247 (#1 of 1): Dereference null return value (NULL_RETURNS)3.
dereference: Dereferencing a null pointer "pl".
Handle more gracefully add_callsite memory allocation failure too.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 21 Feb 2014 18:00:59 +0000 (13:00 -0500)]
Fix: dereference before null check
Found by Coverity:
CID
1090602 (#1 of 1): Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking "stream" suggests that it may be null,
but it has already been dereferenced on all paths leading to the check
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 21 Feb 2014 17:54:07 +0000 (12:54 -0500)]
Cleanup: remove logically dead code
CID
1021235 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line:
Execution cannot reach this statement "case LTTNG_UST_LOGLEVEL_ALL:".
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 21 Feb 2014 16:01:01 +0000 (11:01 -0500)]
Fix: handle sysconf errors
CID
1021261 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS)10.
negative_returns: "sysconf(30)" is passed to a parameter that cannot be
negative.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Tue, 18 Feb 2014 18:59:35 +0000 (13:59 -0500)]
Fix: java-jul/Makefile should not be marked as a binary
java-jul/Makefile is part of bin_SCRIPTS which causes it to be
installed under /usr/local/bin.
It is already installed as an example.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 14 Feb 2014 16:42:38 +0000 (11:42 -0500)]
Version 2.4.0-rc4
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 14 Feb 2014 15:13:32 +0000 (10:13 -0500)]
Cleanup: remove extra space in dlerror wrapper
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 14 Feb 2014 15:02:51 +0000 (10:02 -0500)]
Fix: work-around glibc lying about dlsym()/dlerror() leafness
Especially in the LTTng-UST malloc instrumentation, we run into the
following situation:
1) Our calloc wrapper is called,
2) we setup the static allocator,
3) we call dlsym() to lookup the symbol of the real allocator,
4) dlsym() calls into calloc(), which is overridden by our own wrapper.
Our calloc does not see that the static allocator has been set,
because the stores setting up the static allocator have been optimized
away by gcc-4.8 (in O2), because the dlsym() prototype declares it
with the "leaf" attribute, and thus we end up doing an infinite
recursion, and eventually a segmentation fault.
Thanks to Alexander Monakov for pointing out the culprit of this glibc
bug.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 12 Feb 2014 22:00:58 +0000 (17:00 -0500)]
Cleanup: add lttng_ust_malloc_wrapper_init prototype to header
Ensure the weak symbol prototype matches the non-weak function.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 8 Feb 2014 22:12:16 +0000 (17:12 -0500)]
Fix: malloc libc instrumentation wrapper
calloc and realloc wrt dlsym and dlerror can trigger segmentation
faults. Ensure that we fully populate the allocator symbols all at once,
and also ensure that we use the static allocator while doing the dlsym
lookups.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Fri, 7 Feb 2014 20:09:12 +0000 (15:09 -0500)]
Fix: add LTTngEvent class to fix delayed logger
This commit introduces a new object called LTTngEvent that represent a
LTTng event containing some attributes, for now loglevel data.
Instead of moving event string name around, this object is created once
and kept in the log handler so once a record is publish we can match
attributes such as loglevels.
This has to be done in order to fix the issue where we have a Logger
that appears later on during runtime (with the timer that poll every 5
seconds). With a created event object we can lookup back the event
attributes and enabled it accordingly. Same goes with the * (all events)
where we now keep the loglevel values process wide so we can force the
new events to use it.
Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 7 Feb 2014 16:54:06 +0000 (11:54 -0500)]
Fix: FD leak in liblttng-ust-ctl
Make sure wait/wakeup stream and channel FDs are closed at teardown.
This led to FD leaks on the consumer daemon when the relay daemon
disconnects unexpectedly.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
This page took 0.044738 seconds and 5 git commands to generate.