Jérémie Galarneau [Thu, 26 Jun 2014 14:42:00 +0000 (10:42 -0400)]
Fix (Python bindings): Return a string if a sequence's element are chars
An AttributeError exception was raised when accessing the value property
of a sequence that contains a string.
Reported-by: Yiyang Dai <daiyiyang@hotmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Sebastian Andrzej Siewior [Tue, 27 May 2014 08:08:13 +0000 (10:08 +0200)]
Fix: don't use a return code in _bt_ctf_stream_append_discarded_events
That function is defined as void:
| File "/usr/lib/python3/dist-packages/babeltrace.py", line 2284, in
| append_discarded_events
| if ret < 0:
| TypeError: unorderable types: NoneType() < int()
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 21 May 2014 15:38:08 +0000 (11:38 -0400)]
Fix: Report the sequence's length field's value as length
bt_ctf_get_field_list currently returns the underlying array's
size which is always the highest element count encountered to
date.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Fredrik Markström [Fri, 16 May 2014 02:10:38 +0000 (10:10 +0800)]
Fix: Align buffers from objstack_alloc on sizeof(void *)
The buffers from objstack_alloc will store pointers, so they must
be aligned on a pointer's size, or else it will cause issues on the
CPUs which do not support unaligned addresses access.
Signed-off-by: Fredrik Markstrom <fredrik.markstrom@gmail.com>
Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jesper Derehag [Wed, 23 Apr 2014 15:45:26 +0000 (17:45 +0200)]
Add fallback for betoh/htobe if they do not exist
For older systems endian.h may not contain the betoh/htobe macros.
If they are missing, add them and make sure that any user of
htobe/betoh uses the compat/endian.h
Signed-off-by: Jesper Derehag <jderehag@hotmail.com>
Tested-by: Jesper Derehag <jderehag@hotmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Fri, 25 Apr 2014 13:22:33 +0000 (09:22 -0400)]
Fix: Variable name typo in SequenceField and Event classes
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Julien Desfossez [Tue, 15 Apr 2014 18:28:23 +0000 (14:28 -0400)]
Fix python: remove weird char at the end of line
There was the character \xc2 at the end of one line that caused an
import error on some ubuntu distros.
Reported-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Amit Margalit [Tue, 8 Apr 2014 07:51:00 +0000 (10:51 +0300)]
Added bt_ctf_get_decl_event_id() API function.
Signed-Off-By: Amit Margalit <amitm@il.ibm.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Tue, 18 Mar 2014 17:53:03 +0000 (13:53 -0400)]
Fix: add missing files to gitignore
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 15 Mar 2014 16:31:47 +0000 (12:31 -0400)]
Fix: ctf-text: add missing double-quotes around enum tag
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Lars Persson [Wed, 12 Mar 2014 09:05:17 +0000 (10:05 +0100)]
Use autoconf AM_MAINTAINER_MODE
Give distribution maintainers the option to skip rebuilding
autoconf and automake generated files. The default behaviour
is still to have the rebuild rules enabled.
Signed-off-by: Lars Persson <larper@axis.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Lars Persson [Wed, 12 Mar 2014 07:12:46 +0000 (08:12 +0100)]
Fix: Support out of tree builds in babeltrace
Signed-off-by: Lars Persson <larper@axis.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Mon, 10 Mar 2014 22:03:24 +0000 (18:03 -0400)]
Fix: Add missing lttng_live_should_quit checks
Missing should_quit checks can cause the live plugin to
report errors on exit.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 10 Mar 2014 18:11:07 +0000 (14:11 -0400)]
Fix: Report errors occuring in lttng_live_read
The lttng-live plugin does not return an error code when trying
to open a live trace that is already opened by another client.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 5 Mar 2014 23:19:56 +0000 (18:19 -0500)]
Add README to dist_doc_DATA
This ensures the README is available to users when installed.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 4 Mar 2014 16:49:57 +0000 (11:49 -0500)]
Remove outdated Python binding documentation
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 3 Mar 2014 16:27:29 +0000 (11:27 -0500)]
Fix: Accept an input port in the live URL when no session is provided
Fixes a regression introduced @
2a6d197b310 which causes Babeltrace
to not list sessions if the live URL contains a port and complain
that a port number is not provided after the ":" delimiter.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Fri, 28 Feb 2014 18:12:39 +0000 (13:12 -0500)]
Version 1.2.0
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 28 Feb 2014 13:08:29 +0000 (08:08 -0500)]
Fix: lttng-live parse url port check
Ensure there is a port number after the ':' delimitor.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 27 Feb 2014 17:53:58 +0000 (12:53 -0500)]
Version 1.2.0-rc2
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 25 Feb 2014 22:36:11 +0000 (17:36 -0500)]
Fix: events discarded timing inaccuracy
Introduce babeltrace_ctf_console_output too, to ensure we only print
discarded events when a text output is used.
Fixes #589
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Tue, 25 Feb 2014 20:47:39 +0000 (15:47 -0500)]
Fix: Move offset endianness conversion to get_data_packet
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 25 Feb 2014 20:40:42 +0000 (15:40 -0500)]
Fix: Remove negative comparison to unsigned value
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 25 Feb 2014 20:13:18 +0000 (15:13 -0500)]
Fix: Uninitialized scalar variable
Defect Reported-by: Coverity Scan
** CID
1187497: Uninitialized scalar variable (UNINIT)
/formats/lttng-live/lttng-live-comm.c: 753 in get_data_packet()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 24 Feb 2014 15:30:50 +0000 (10:30 -0500)]
Fix: Don't assert on metadata generation failure
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Tue, 25 Feb 2014 16:26:14 +0000 (11:26 -0500)]
Fix: add missing SIGTERM and SIGINT handler
Handle expected signals gracefully: stop processing at cancellation
points expected by the protocol, so the relay daemon does not print
error messages when clients quit gracefully.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 25 Feb 2014 16:08:54 +0000 (11:08 -0500)]
Fix: Reverse incorrect error message argument order
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 25 Feb 2014 16:25:25 +0000 (11:25 -0500)]
Cleanup: add brackets to lttng-live-plugin.c
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 25 Feb 2014 15:53:47 +0000 (10:53 -0500)]
Cleanup lttng-live: add brackets in lttng_live_read()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 25 Feb 2014 15:51:43 +0000 (10:51 -0500)]
Cleanup lttng-live: 80 columns wrapping
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 25 Feb 2014 15:48:13 +0000 (10:48 -0500)]
Fix: handle new streams in get_data_packet()
- don't skip ask_new_streams() if new metadata _and_
new streams are available.
- goto retry after getting new streams.
- Add missing "ret = 0" assignment at the end of the function. Takes
care of "possible use of uninitialized variables" warnings in the
caller given by gcc.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 24 Feb 2014 18:23:54 +0000 (13:23 -0500)]
Fix: accept empty metadata on append
"Append" should accept receiving metadata packets that contain exactly 0
byte of metadata payload. This kind of flush can happen on trace
teardown.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 24 Feb 2014 17:54:03 +0000 (12:54 -0500)]
Fix: lttng-live: 100ms active poll delay
Do a 100ms delay before retry intead of 1s delays (slightly too long in
terms of user experience) and instead of actively hogging the CPU (too
fast).
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 24 Feb 2014 17:24:54 +0000 (12:24 -0500)]
Fix: lttng-live await metadata
Expect at least _some_ metadata in get_new_metadata. Retry until we
receive some metadata.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 24 Feb 2014 16:49:03 +0000 (11:49 -0500)]
Fix: lttng-live recv() and send() flags, partial recv()
Introduce lttng_live_recv() and lttng_live_send():
- Enforce MSG_NOSIGNAL flag for send(),
- Continue recv() after partial message is received.
- Handle EINTR within those wrappers.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Mon, 24 Feb 2014 18:34:01 +0000 (13:34 -0500)]
Fix: missing little endian conversion for one index field
Locked-step with lttng-tools commit :
Fix: missing big endian conversion for one index field
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 21 Feb 2014 15:17:22 +0000 (10:17 -0500)]
Cleanup: remove logically dead code
CID
1021557 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line:
Execution cannot reach this statement "goto end;".
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 21 Feb 2014 13:58:02 +0000 (08:58 -0500)]
Fix: untrusted value as argument
Fix coverity:
CID
1132646 (#1 of 1): Untrusted value as argument (TAINTED_SCALAR)8.
tainted_data: Passing tainted variable "index_hdr.packet_index_len" to a
tainted sink.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 21 Feb 2014 02:49:31 +0000 (21:49 -0500)]
Fix: off by one in lttng-live path length check
Does not account for final \0.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 20 Feb 2014 22:01:55 +0000 (17:01 -0500)]
Fix: fclose return value unchecked
** CID
1181988: Unchecked return value (CHECKED_RETURN)
/formats/lttng-live/lttng-live-comm.c: 900 in get_new_metadata()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Thu, 20 Feb 2014 05:50:27 +0000 (00:50 -0500)]
Fix: call to append metadata when new metadata is added
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Thu, 20 Feb 2014 05:50:26 +0000 (00:50 -0500)]
Fix: use memstream instead of tmp file for live metadata
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Thu, 20 Feb 2014 05:50:25 +0000 (00:50 -0500)]
Fix: assign a trace handle to every live trace
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Thu, 20 Feb 2014 05:50:24 +0000 (00:50 -0500)]
Fix: get_new_metadata receive all the metadata
Instead of doing the loop in the caller, let get_new_metadata fetch all
the metadata required. Also, call this function when get_packet detects
that we need to refresh the metadata.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Thu, 20 Feb 2014 06:12:01 +0000 (01:12 -0500)]
Fix: Coverity warning CWE-457: Use of Uninitialized Variable
ret is uninitialized if no streams are declared in the trace
descriptor.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 20 Feb 2014 03:20:43 +0000 (22:20 -0500)]
Revert "Fix: get_new_metadata receive all the metadata"
This reverts commit
bb17fa55a7694db83af6f00b16b3e545712662f7.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 20 Feb 2014 03:20:18 +0000 (22:20 -0500)]
Revert "Fix: assign a trace handle to every live trace"
This reverts commit
42423b0a691fb4b2efbb5a45eb7eefa5f350ec30.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Wed, 19 Feb 2014 23:23:53 +0000 (18:23 -0500)]
Fix: assign a trace handle to every live trace
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Wed, 19 Feb 2014 23:23:52 +0000 (18:23 -0500)]
Fix: get_new_metadata receive all the metadata
Instead of doing the loop in the caller, let get_new_metadata fetch all
the metadata required. Also, call this function when get_packet detects
that we need to refresh the metadata.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 19 Feb 2014 00:19:26 +0000 (19:19 -0500)]
CTF: Support incremental metadata append
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 19 Feb 2014 01:40:40 +0000 (20:40 -0500)]
Fix: ctf.c fscanf missing integer length check
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 19 Feb 2014 01:25:02 +0000 (20:25 -0500)]
Bump soname version to 1.0.0
Since there were ABI changes since 0.0.0.
Also add missing -Wl,--no-as-needed to lttng-live plugin.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 18 Feb 2014 23:01:55 +0000 (18:01 -0500)]
Move scanner allocation/free outside of ctf_open_trace_metadata_read
In preparation for incremental metadata parsing.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 18 Feb 2014 22:44:37 +0000 (17:44 -0500)]
CTF parser: prepare for incremental metadata parsing
Associate the file pointer to ctf_scanner_append_ast() rather than to
ctf_scanner_alloc().
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Tue, 18 Feb 2014 07:04:22 +0000 (02:04 -0500)]
Python bindings: return char arrays as strings in value()
Implement the same logic as in ctf-text to return a string when
value() is called on an array of elements that are encoded as ASCII
or UTF8 and 8-bits long.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 18 Feb 2014 07:03:01 +0000 (02:03 -0500)]
Python bindings: sched_switch example clean-up
Remove unecessary while loop to handle event skipping.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Mon, 17 Feb 2014 14:35:33 +0000 (09:35 -0500)]
Fix: add missing test scripts to Makefile.am
Fix make check ran from tarball.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 14 Feb 2014 21:39:12 +0000 (16:39 -0500)]
Version 1.2.0-rc1
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 14 Feb 2014 20:29:12 +0000 (15:29 -0500)]
Cleanup: lttng-live: use perror() rather than fprintf for err msg
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 14 Feb 2014 20:19:37 +0000 (15:19 -0500)]
Fix: lttng-live: handle orderly shutdown
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Thu, 13 Feb 2014 19:42:36 +0000 (14:42 -0500)]
Fix: Unchecked array index when importing trace indexes
import_stream_packet_index may access the streams array with an invalid
stream_id index when a stream has an index but is not declared in the
trace's metadata.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Julien Desfossez [Mon, 10 Feb 2014 23:50:40 +0000 (18:50 -0500)]
LTTng-live usage documentation
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 10 Feb 2014 21:23:24 +0000 (16:23 -0500)]
Fix: ctf: uninitialized packet_index, misuse of index
Issues introduced by
commit
f1f52630ef26bb227cf1e8fedcff9b938d7a2f1e
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 10 Feb 2014 21:06:19 +0000 (16:06 -0500)]
Cleanup: rename lttng live implementation files
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Wed, 5 Feb 2014 23:34:28 +0000 (18:34 -0500)]
Attach and list by session name and hostname
From now on, the user attaches to a session by hostname and session name
(no ID anymore). With this new features, we automatically merge the
sessions with the same hostname and session name.
The new URL format to attach to a session is :
net://<relay-hostname>/host/<traced-hostname>/<session-name>
All the fields are mandatory.
No changes for the listing :
net://<relay-hostname>
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Wed, 5 Feb 2014 23:34:27 +0000 (18:34 -0500)]
get_new_streams and multi-session
We now support the get_new_stream lttng live command. This command
allows us to retrieve new streams added while tracing.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Wed, 5 Feb 2014 23:34:26 +0000 (18:34 -0500)]
Create the live viewer session before attaching
The lttng-live protocol now requires that we create a viewer session
before attaching to a trace.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Thu, 6 Feb 2014 16:13:12 +0000 (11:13 -0500)]
Sync lttng live ABI with lttng-tools
Rename lttng-viewer.h to lttng-viewer-abi.h
Add the structures for two new commands.
Also, add the missing headers to the Makefile.am.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Wed, 5 Feb 2014 23:34:24 +0000 (18:34 -0500)]
Extract adding a trace to the iterator from bt_iter_init
With live tracing, we have cases where we need to add traces to an
iterator currently in use. Here, we just extract the code from
bt_iter_init that adds the trace to the iterator so we can call it from
elsewhere.
We don't necessarily want to expose this interface to the public, so it
stays in the internal headers for now.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 29 Jan 2014 03:15:48 +0000 (22:15 -0500)]
Compute discarded events in live
We now save the indexes received in live in the two first elements of a
packet index. This allows us to compute the number of discarded events.
We only keep the packet index elements we need in live so we don't leak
packet indexes when reading a live trace over many days (or longer).
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 29 Jan 2014 02:14:48 +0000 (21:14 -0500)]
Merge real index and cycles index into a single index
Merge those two into a single index array, rather than having partially
duplicated data.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Fri, 7 Feb 2014 16:12:58 +0000 (11:12 -0500)]
Fix: import index containing only a header
If the index file is present, we have to make sure we imported at least
one index before using the stream_class.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 4 Feb 2014 17:53:34 +0000 (12:53 -0500)]
Remove outdated Python bindings test
This test is based on the old version of the Python bindings which
was part of the experimental branch.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Julien Desfossez [Fri, 17 Jan 2014 18:11:39 +0000 (13:11 -0500)]
Fix: replace assert with proper error handling
If we receive the wrong packet, we should send the error and exit
cleanly instead of asserting.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 16 Jan 2014 19:52:24 +0000 (14:52 -0500)]
Fix: lttng-live: unbounded use of sscanf() in parse_url()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Tue, 7 Jan 2014 19:16:03 +0000 (14:16 -0500)]
Fix: lttng-live should accept 0 in addresses
Fixes #708
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Tue, 7 Jan 2014 18:04:38 +0000 (13:04 -0500)]
Remove default to display field names in live
Let Babeltrace option parsing code to set this option instead of
overriding it.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Sat, 14 Dec 2013 15:38:31 +0000 (10:38 -0500)]
Remove null checks on g_new0
g_new0 never returns NULL. We need to either always check for NULL, or
never. Remove all NULL checks on pointers returned by g_new0. Coverity
was complaining because we were dereferencing a pointer in an error path
after checking it against NULL, which is certainly never OK.
Found by coverity:
** CID
1136988: Dereference after null check (FORWARD_NULL)
/formats/lttng-live/lttng-live.c: 152 in lttng_live_open_trace_read()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 14 Dec 2013 15:55:04 +0000 (10:55 -0500)]
Cleanup: iterator unused pointer value
Found by Coverity:
** CID
1136757: Unused pointer value (UNUSED_VALUE)
/lib/iterator.c: 831 in bt_iter_next()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 14 Dec 2013 15:51:37 +0000 (10:51 -0500)]
Fix: lttng-live: resource leak
Found by Coverity:
** CID
1136987: Resource leak (RESOURCE_LEAK)
/formats/lttng-live/lttng-live-functions.c: 372 in lttng_live_attach_session()
/formats/lttng-live/lttng-live-functions.c: 386 in lttng_live_attach_session()
/formats/lttng-live/lttng-live-functions.c: 383 in lttng_live_attach_session()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 14 Dec 2013 15:47:00 +0000 (10:47 -0500)]
Fix: lttng-live uninitialized scalar variable
Found by coverity:
** CID
1136985: Uninitialized scalar variable (UNINIT)
/formats/lttng-live/lttng-live-functions.c: 128 in lttng_live_establish_connection()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 14 Dec 2013 15:44:17 +0000 (10:44 -0500)]
Fix: lttng-live non NULL-terminated strings
Found by coverity.
** CID
1136986: String not null terminated (STRING_NULL)
/formats/lttng-live/lttng-live-functions.c: 375 in lttng_live_attach_session()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 14 Dec 2013 15:36:13 +0000 (10:36 -0500)]
lttng-live: fix unchecked mkdir return value
Found by coverity:
** CID
1136989: Unchecked return value from library (CHECKED_RETURN)
/formats/lttng-live/lttng-live-functions.c: 374 in lttng_live_attach_session()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Thu, 12 Dec 2013 20:32:35 +0000 (15:32 -0500)]
lttng-live input plugin
This new input format allows Babeltrace to connect a lttng-relayd and
attach to a running live session.
In order to use it, you need to create a live session (refer to LTTng
documentation for that) and then :
babeltrace -i lttng-live net://hostname
Where hostname is the hostname or IP address of the lttng-relayd
receiving the live trace.
When you do this command, it will list the active sessions on the relay.
To attach to a particular session, redo the same command, but add after
the hostname the session ID of the session you want to read.
For example, to attach to the session 42 :
babeltrace -i lttng-live net://hostname/42
If you want to know what is going on in the background, you can add the
-v for a verbose output.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Thu, 12 Dec 2013 20:32:34 +0000 (15:32 -0500)]
Live: let read API detect inactive streams, allow streams without fd
In live streaming, there are cases where a stream will be inactive from
beginning to end and so will never call bt_iter_next. For those cases,
we have to detect when we are reading an inactive stream which happens
when all other active streams have been closed.
We don't want to have the same checks in two places, so this fix removes
the return of EAGAIN in bt_iter_next and instead returns a NULL event
with the new BT_ITER_FLAG_RETRY flag set.
Also, handle cases where streams and traces have no associated file
descriptors.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 11 Dec 2013 20:22:36 +0000 (15:22 -0500)]
Add Jérémie Galarneau as co-maintainer
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 10 Dec 2013 21:45:08 +0000 (16:45 -0500)]
Fix: disallow re-using same event ID in same stream
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 9 Dec 2013 12:31:11 +0000 (07:31 -0500)]
Fix: check for unknown enum/variant fields
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 9 Dec 2013 12:28:51 +0000 (07:28 -0500)]
Fix: libbabeltrace lib build dependencies
The "no-as-needed" is only needed for plugins, not for libraries we
depend upon, so it is not really needed here. Using LIBADD instead
ensures that libbabeltrace gets rebuilt whenever the content of
libbabeltrace_types (statically linked) is modified.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Tue, 3 Dec 2013 22:34:57 +0000 (17:34 -0500)]
Fixes in babeltrace core to support non-CTF traces
Since we will have an effort soon to cleanup the Babeltrace plugin
mechanism, this patch adds just the bits required in Babeltrace to not
crash if a non-ctf is opened. We also add the support of net:// URIs.
That way, an input plugin can just implement the open_trace callback
and process its own input trace without requiring a CTF iterator.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Tue, 3 Dec 2013 22:34:56 +0000 (17:34 -0500)]
Add a private pointer to the ctf_stream_pos
This allows a custom packet_seek function to fetch private information
about the current stream.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 4 Dec 2013 16:09:16 +0000 (17:09 +0100)]
Be more widely accepting for missing variant/enum fields
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 3 Dec 2013 16:41:16 +0000 (17:41 +0100)]
Cleanup: remove index_read (unused var)
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 3 Dec 2013 16:13:12 +0000 (17:13 +0100)]
Refuse 0 integer size
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Fri, 29 Nov 2013 18:26:42 +0000 (13:26 -0500)]
Fix ctf-writer: possible use after free
ctf_stream_pos' base_mma member must be copied from stream->pos before
updating the final packet and content sizes. The original base_mma
structure will be reallocated if the packet is resized.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Fri, 29 Nov 2013 22:43:39 +0000 (17:43 -0500)]
Fix data_offset when importing the indexes
When importing an index, we don't have the data_offset and we want to
mmap the tracefile only when needed, so we introduce a new function to
only compute this information when we are going to use a new packet.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 29 Nov 2013 06:19:33 +0000 (07:19 +0100)]
Merge branch 'master' into bindings/python
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Thu, 28 Nov 2013 18:19:10 +0000 (13:19 -0500)]
Python-bindings fix: Out of tree build fails to find babeltrace.i
This fixes the out of tree builds by using the appropriate top_srcdir
and top_builddir variables in the bindings' Makefile.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Thu, 28 Nov 2013 20:46:41 +0000 (15:46 -0500)]
Test: Validate that enumeration mapping strings are properly escaped
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Thu, 28 Nov 2013 20:46:40 +0000 (15:46 -0500)]
Fix ctf-writer: Quote strings provided as enumeration mappings
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
This page took 0.041207 seconds and 4 git commands to generate.