Marc-Andre Laperle [Fri, 28 Feb 2014 20:32:42 +0000 (15:32 -0500)]
tmf: Fix Font leak in TmfEventsTable/TmfRawEventViewer
Bug: 428493
Change-Id: Id665a5b0256a57d7926f30b848c9ca089fcc47bc
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22698
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Fri, 28 Feb 2014 11:48:15 +0000 (06:48 -0500)]
tmf: Show all traces of an experiment in statistics view (Bug 429087)
Change-Id: I9aeae0d44cbaf647ffd9284a1cabc82ee20356a8
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22666
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Wed, 26 Feb 2014 05:33:16 +0000 (00:33 -0500)]
tmf: Add persistent index support to TextTrace
Change-Id: I55d9529b56c1716032c9105bb02de61e7f396b96
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22544
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Thu, 27 Feb 2014 19:30:43 +0000 (14:30 -0500)]
tmf: Remove dependency to ctfadaptor from the state system
Change-Id: I79b7cf539eba6ace434fc7dfbb32bc3386c68b8c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/22640
Tested-by: Hudson CI
Geneviève Bastien [Wed, 29 Jan 2014 20:52:23 +0000 (15:52 -0500)]
TMF: Add unit tests for XML state providers
Change-Id: I219ea02913f1d9505e8bc894523e1a73722b5cd5
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/21484
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Geneviève Bastien [Wed, 29 Jan 2014 20:50:57 +0000 (15:50 -0500)]
TMF: Introduce the XML state provider for data driven analysis
This patch presents how to define by XML a state provider for a trace. It
contains a test file that works for the test CtfTmfTraces.
Change-Id: I4b2db36beb2185049c96344a5faff12d51996317
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/19910
Tested-by: Hudson CI
Florian Wininger [Tue, 14 Jan 2014 02:51:44 +0000 (21:51 -0500)]
TMF: Add XML state provider schema definition and test file
This patch adds to the XSD the schema definition for a full XML-defined state
provider. The valid test file is also augmented to use that definition.
Change-Id: Ib75082f04fae69f62f6c7990ee8c92ea4cc042e5
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/20595
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Fri, 21 Feb 2014 23:42:30 +0000 (18:42 -0500)]
tmf: Fix most Number unboxing problems
Based on the patch at https://git.eclipse.org/r/#/c/19470/
Don't enable the new warnings, but at least fix the most obvious
problems that the patch exposed.
Change-Id: I3f5d9165cb6db8a2697c87193ea35cf90c89a9b0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/22398
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Tue, 25 Feb 2014 22:07:38 +0000 (17:07 -0500)]
tmf: Replace "find" with "matches" for TextTrace.java
This means that if a pattern is not 100% correct, it will
fail to read an event. However, performance should increase.
If we have for example a pattern (\\d\\d)\s(\S+)
and "123 blabla" will work with find(), returning "23 blabla"
but will fail with matches().
Change-Id: I54e259f31b44fa2996316150665e5ca011576825
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22539
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Wed, 26 Feb 2014 21:59:35 +0000 (16:59 -0500)]
lttng: Update remaining time stamp url in help
Change-Id: I55feb118bcc56b06f455a0d33a768b58ae1fb325
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22597
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Tue, 25 Feb 2014 19:36:19 +0000 (14:36 -0500)]
tmf/lttng: Refresh help projects after building help files
Before this patch, to build the html, it was necessary to do
Build Project manually then Refresh the project manually. With
this patch, it is not necessary to Refresh the project manually
after building the project.
Change-Id: Id67039f3554d3a4cfab19dd987292126f4aed365
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22536
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Tue, 18 Feb 2014 21:26:51 +0000 (16:26 -0500)]
tmf: Remove deprecated methods/classes from tmf.ui
Change-Id: I147d7f96b6a6d224a03a249444406ee334251901
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/22191
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Tue, 18 Feb 2014 21:17:08 +0000 (16:17 -0500)]
tmf: Merge ITimeDataProvider2 back into ITimeDataProvider
Was TODO for 3.0
Change-Id: Ic29c6db1947b0c5375f17dce8ca43389bab0ef66
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/22190
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Tue, 25 Feb 2014 15:36:35 +0000 (10:36 -0500)]
ctf: make DeclarationScope.java more inline with coding style
Change-Id: Ib2dfc791dc56d3d9b34a838b3912731b51f56617
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22515
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Tue, 25 Feb 2014 15:42:58 +0000 (10:42 -0500)]
ctf: make IOStructGen.java more inline with coding style
Change-Id: I3d3671d43ec24bd046e0d1c8b5bb11089bd2110d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22519
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Tue, 25 Feb 2014 15:26:23 +0000 (10:26 -0500)]
ctf: Make EventDefinition.java more inline with coding style
Change-Id: I009d8d59d7d372bd0208c4799b716a05000620d4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22513
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Tue, 25 Feb 2014 23:40:21 +0000 (18:40 -0500)]
tmf: Update documentation to reflect recent changes in time stamp handling
Change-Id: Id6220e6758717b120916714c0abd48521a3e5bc1
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22542
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Geneviève Bastien [Mon, 17 Feb 2014 20:11:58 +0000 (15:11 -0500)]
TMF: Changed the state system explorer to use an abstract tree viewer
This adds the possibility to sort columns. And we don't need to worry about
which thread runs the code.
Change-Id: Iee53523f05eb3a3bdc6bf4d4226cc22a93bf9864
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/22185
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Geneviève Bastien [Mon, 17 Feb 2014 15:26:19 +0000 (10:26 -0500)]
TMF: Add an abstract tree viewer class
Provides default functionalities for all tree viewers, like how to set the
column data, basic classes to manage the content of the tree, provide easy
abstract method to fetch the data to fill the tree.
Change-Id: I0b19027f24f9e612304bb89f32a03f8c67d8edf7
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/22184
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Mon, 24 Feb 2014 22:39:16 +0000 (17:39 -0500)]
ctf: make CTFCallsite.java more inline with coding style
Change-Id: Ide285ff2a836c9f407233a5729268bbb76121056
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22485
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Tue, 25 Feb 2014 15:24:06 +0000 (10:24 -0500)]
ctf: make CTFClock more inline with coding style
Change-Id: I652f8caeed96fa66c0da0d58998c6e048d436ff0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22514
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Tue, 25 Feb 2014 15:56:23 +0000 (10:56 -0500)]
ctf: make StreamInputPacketIndexEntry.java more inline with coding style
Change-Id: I61d3ae7a2f8f438b0fca744a5337f65dc9a90d58
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22517
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Matthew Khouzam [Tue, 25 Feb 2014 15:48:00 +0000 (10:48 -0500)]
ctf: Make EventDeclaration more inline with coding style
Change-Id: Ic35b766bd56dba8ef73d809802c25bc01fe8828f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22516
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Sun, 16 Feb 2014 18:05:26 +0000 (13:05 -0500)]
tmf: Add standard import trace wizard to the file menu of the RCP
Also simplify the selection handling for BatchImportTraceHandler
Change-Id: Ice7ec29c3b5d3a34c4c5960084a2062c593885df
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22122
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Tue, 18 Feb 2014 20:57:47 +0000 (15:57 -0500)]
tmf: Remove all deprecated methods in tmf.core
Change-Id: I9c567004a9bede6aef6a27843fdf7b03d103f555
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/22189
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Mon, 24 Feb 2014 22:27:07 +0000 (17:27 -0500)]
ctf: make StreamInputPacketReader.java more inline with coding style
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Change-Id: I89cf26eb659059ec2309e58a97f050d3d183fcf6
Reviewed-on: https://git.eclipse.org/r/22484
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Mon, 24 Feb 2014 22:24:42 +0000 (17:24 -0500)]
ctf: make StreamInput.java more inline with coding style
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Change-Id: If4ea784f51cb25b65fa64da90b535783f9271b01
Reviewed-on: https://git.eclipse.org/r/22483
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Mon, 24 Feb 2014 22:19:50 +0000 (17:19 -0500)]
ctf: fix artefact in javadoc
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Change-Id: I3e08aab27576592d8932b629fc152c9c5204c6bd
Reviewed-on: https://git.eclipse.org/r/22481
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Mon, 24 Feb 2014 22:22:24 +0000 (17:22 -0500)]
ctf: make stream.java more inline with coding style
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Change-Id: Ic0d28e04b39596cb1939485d4a5b861b3eec59ed
Reviewed-on: https://git.eclipse.org/r/22482
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Geneviève Bastien [Mon, 24 Feb 2014 17:31:30 +0000 (12:31 -0500)]
TMF: Add possibility to cancel update thread in XY line viewer
When the update takes a long time to run (or when it is updated too frequently)
many threads may be running at the same time and the results are not accurate.
The update is now done in its own thread class that can be cancelled and the
updateData method has a monitor to cancel when necessary.
Change-Id: I1430e0d2329b896d85c48326dcd2bef4a013d7a9
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/22460
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Mon, 24 Feb 2014 17:56:24 +0000 (12:56 -0500)]
tmf: Fix trace type id in extension for Generic CTF traces
Change-Id: I270f7eec2d8f08a7c0325165081b0c20a3e28ba4
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22465
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Thu, 20 Feb 2014 22:04:37 +0000 (17:04 -0500)]
tmf: Bug 428432: A trace moved to an experiment loses its trace type
- Updated all setting of trace persistent properties to use the common
method in TmfTraceTypeUIUtils, which refreshes the trace type.
- Updated the method to accept the resource as argument and to be able
to set the trace type of a trace element under an experiment.
- Added getExperiments() method to TmfExperimentFolder, and cleaned up
some code to use it.
Change-Id: I3446ac77d9929c7688a4b92fe8094b9428f15524
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/22337
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Fri, 14 Feb 2014 13:28:15 +0000 (08:28 -0500)]
tmf: Add unit tests for tmf.core.trace.text package
Change-Id: Ia2be3341f92747f09d0bdda41b4615439e98f597
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22064
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Wed, 19 Feb 2014 20:55:01 +0000 (15:55 -0500)]
tmf: Update unit tests for TmfTimestampFormat
Change-Id: I86fa1df4d0020d709ee62698f4bc38addac7b05d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/22261
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Mon, 17 Feb 2014 18:36:18 +0000 (13:36 -0500)]
tmf: Fix time stamp format help button in custom parser wizards
Change-Id: I54c40166ec272b3a4ef0dd707062218235f1a356
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/22119
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Thu, 13 Feb 2014 20:11:07 +0000 (15:11 -0500)]
tmf: Update Time Format preference page and defaults
Change-Id: Id95ab7280b12ec358a0cbef5ed1f2c5c8f32aa32
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/21970
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Thu, 13 Feb 2014 20:09:54 +0000 (15:09 -0500)]
tmf: Support TmfTimestampFormat in custom parsers
Change-Id: Idb28af8790432363e24617cca057a5aacb69afe5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/21969
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Thu, 13 Feb 2014 20:08:41 +0000 (15:08 -0500)]
tmf: Support fraction of second in TmfTimestampFormat
- Change "S" pattern from Milliseconds to Fraction of second, supporting
up to 9 digits that can be split.
- Fix date and time parsing with time reference.
- Allow any sub-second delimiter to be the decimal separator.
Change-Id: I50e9a88fe1c19be953ac57fc696dc625a5b7c4b3
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/21968
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Thu, 20 Feb 2014 23:01:46 +0000 (18:01 -0500)]
tmf: Remove the TRACEBUNDLE and TRACEICON properties
The bundle is always available through Platform.getBundle(), and the
icon location can be read from the extension point (which is now in
tmf.ui.tracetypeui).
Change-Id: Ibc9a88d279b78ce570261b8e94f4489dce63ed3a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/22341
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Thu, 20 Feb 2014 05:46:00 +0000 (00:46 -0500)]
tmf: Display icons using the new tracetypeui extension point
Change-Id: Idf0ecb3b209acd0ceb98c92dbc4d6735a2c46960
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22340
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Thu, 20 Feb 2014 22:30:33 +0000 (17:30 -0500)]
tmf: Move the tmftracetype extension point to tmf.core
Split the current "tmf.ui.tracetype" extension point into a
tmf.core.tracetype and tmf.ui.tracetypeui. "tracetypeui" refers to
the ID of the "tracetype", to add UI elements like type-specific icon
and events editor.
This separation makes it possible to unit-test the trace validation
without depending on UI/SWTBot tests. We will also eventually be able
to handle trace opening/validation in completely headless mode.
Change-Id: I227a199d1dddf62ad07b60392793b4694d0ec2de
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21421
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Wed, 22 Jan 2014 22:20:00 +0000 (17:20 -0500)]
ctf: add support for additional streams after trace is started
Minor clean-up in code.
A minor subtelty in this patch is that CTFTraceReader has an update()
method that needs to be called if a stream is added to the trace.
Change-Id: I253634d382eec38b033e30d36539b367f7efaccc
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/21056
Geneviève Bastien [Mon, 17 Feb 2014 15:21:31 +0000 (10:21 -0500)]
TMF: Allow XY line chart classes to change the resolution of the viewer
While a resolution of 1 point per pixel shows a good level of precision for
charts showing absolute values at time t (like memory usage charts), it is not
the case when the data to show is a marginal difference with preceding point
(like CPU usage view). In those cases, a lower resolution makes better looking
graphs, so the viewer should be able to set the resolution.
Change-Id: I7cad9a85555f57fcb812dd774929925125b39ca0
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/22102
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 22 Jan 2014 23:13:06 +0000 (18:13 -0500)]
ctf: add support for growing streams
This patch adds the notion of the parser being in several states.
These states are detailed in the CTFResponse file.
The possible states are OK (we can keep reading),
WAIT (data will be available but is not yet),
FINISH (the trace has no more data),
ERROR (something happened that should not).
Note: this patch is non-trivial, even though it has been tested,
if there are regressions later, this patch is an interesting
candidate to check.
Change-Id: I2e6bd4bdc9e8e490ebb43910a749bcdca9754214
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/21057
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Geneviève Bastien [Wed, 5 Feb 2014 19:22:04 +0000 (14:22 -0500)]
TMF: Changed the LTTng kernel analysis module to use the output extension
The analysis module itself has moved to the .core plugin and the views are
associated to it via the analysis output extension point.
Change-Id: Ic92478e6a67be0888c112e90769199fd4dd8c547
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/21582
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Fri, 14 Feb 2014 16:55:04 +0000 (11:55 -0500)]
ctf: minor code style cleanup
Changed fields to start with f, removing the need for so many this pointers.
Change-Id: Ibff3a4de733fa1c2eeb49a3b8b8baa0654fe7136
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22023
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Thu, 13 Feb 2014 21:26:18 +0000 (16:26 -0500)]
tmf: Add default custom Xml parsers
This will allow to add default parsers to custom_xml_default_parsers.xml.
If they are edited, a shadow copy is made. If the shadow copy is deleted,
the default one returns. These parsers can be exported, but of course,
you cannot import to the default zone.
The default xml file is now stored in the eclipse install directory
under the templates/org.eclipse.linuxtools.tmf.core directory
Change-Id: I77591b0224afdc9f95bca602563d9e8164218f51
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/21971
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Thu, 13 Feb 2014 18:13:14 +0000 (13:13 -0500)]
tmf: Add attribute isDirectory to the trace type extension point
Knowing whether a trace is a directory trace or a single file trace
makes it easier to auto detect the trace trace types.
Change-Id: I1a8dc2b33bbd1f97a9347646e6698d4d41a582d6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22063
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Wed, 12 Feb 2014 22:30:27 +0000 (17:30 -0500)]
tmf: add initial place for default custom text trace types
This will allow to add default parsers to
custom_txt_default_parsers.xml.
If they are edited, a shadow copy is made.
If the shadow copy is deleted, the default one returns.
These parsers can be exported, but of course, you cannot import to
the default zone.
The default text file is now stored in the eclipse install directory
under the templates/org.eclipse.linuxtools.tmf.core directory
Change-Id: I55754de7a1551dfa7bd19f7098ce6bddbbc6c08a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/21923
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Wed, 19 Feb 2014 16:02:10 +0000 (11:02 -0500)]
tmf: Fix compilation error in XmlAnalysisModuleSourceTest
Change-Id: Id8f79e368c8229a11daf1ee22b29624e36feab46
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22247
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Geneviève Bastien [Wed, 5 Feb 2014 19:19:15 +0000 (14:19 -0500)]
TMF: Change unit tests to use analysis output listeners
Change-Id: I7b75abb2f7c48f66a5e642415482724a75957b4c
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/21581
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Geneviève Bastien [Wed, 5 Feb 2014 19:16:41 +0000 (14:16 -0500)]
TMF: Create an analysis listener for the outputs defined in extension point
For each output defined in the extension point, a new analysis module listener
is added to the analysis manager.
Change-Id: Ic4373f990c1c9656f9a9cfa6e7b008f8606c2a03
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/21580
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Geneviève Bastien [Wed, 5 Feb 2014 19:13:02 +0000 (14:13 -0500)]
TMF: Add new analysis module listener called when module are being instantiated
Those listeners are managed by the analysis manager and the helpers need to
call a method from the analysis manager when they instantiate new module
objects so that the listeners are run on this module.
This will allow among other to associate the applicable outputs to the
analysis module being created.
Change-Id: I004e2b83dd233d8e9971807a517f37817f503ea0
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/21579
Tested-by: Hudson CI
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Geneviève Bastien [Wed, 5 Feb 2014 19:02:32 +0000 (14:02 -0500)]
TMF: Added the possibility to define analysis outputs in extension point
A new element is added to the o.e.l.tmf.core.analysis extension point to be
able to associate an output to either an analysis (identified by ID) or an
analysis class. That will allow the analysis to be in the .core plugins and
views to be registered to them in the .ui plugins.
Change-Id: I7a3e542c250c35a95bc9c3712e14e731e30c5d86
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/21578
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Geneviève Bastien [Fri, 14 Feb 2014 19:23:29 +0000 (14:23 -0500)]
TMF: Move methods from TmfXYChartViewer to new abstract TmfTimeViewer
The TmfXYChartViewer already had time synchronization methods implemented,
but those can be used by other types of viewer. They have been moved to an
abstract class. All viewers who need to synchronize with trace time may extend
this class.
Change-Id: I5d64c4412ea2de06e88ae8000b29770dbeecca83
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/22029
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Wed, 12 Feb 2014 19:29:27 +0000 (14:29 -0500)]
tmf: Use explicit annotations in ITmfAnalysisModuleWithStateSystems
It seems Eclipse and Maven don't handle nested null annotation
contexts the same way (@NonNullByDefault -> @Nullable -> @NonNull).
To keep both happy, just remove the @NonNullByDefault and use
annotations everywhere in this file. There's acutally only one extra
place that needs it...
Eventually everything should move to package-level annotations.
Change-Id: I84b8c9bb9ea468e6a27e0c1025d0a8f328b2f8bb
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/22045
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Wed, 5 Feb 2014 23:47:45 +0000 (18:47 -0500)]
tmf: Make it possible to hide trace package elements
Change-Id: Id3fc64625a078dbef6f80ff3774223bdd1227d65
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22070
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Tue, 4 Feb 2014 19:04:15 +0000 (14:04 -0500)]
tmf: Reorder Import and Export trace package and add separator
Change-Id: I061051b1fafa8c4abfacb9225034fa5b9fd3ae5c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22069
Tested-by: Hudson CI
Marc-Andre Laperle [Tue, 28 Jan 2014 21:59:17 +0000 (16:59 -0500)]
tmf: Support renaming traces when importing package
Change-Id: Ic23169e485d0aa8fb183e32ffea9b3a4c9f60eb0
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22068
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Mon, 10 Feb 2014 22:24:44 +0000 (17:24 -0500)]
lttng: Update user guide with latest Import changes
Change-Id: I0caa2a202eea0cf0075e6480febc9b50be546515
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22117
Tested-by: Hudson CI
Marc-Andre Laperle [Tue, 28 Jan 2014 17:46:07 +0000 (12:46 -0500)]
tmf: Introduce ManifestReader
Change-Id: I5b24d8339b64e08782c4f1c16c1115b13f1c39df
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22067
Tested-by: Hudson CI
Marc-Andre Laperle [Mon, 27 Jan 2014 22:52:05 +0000 (17:52 -0500)]
Make trace package import easier to extend
Change-Id: I5ee88bb1243df8904597076244f6399189967783
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22066
Tested-by: Hudson CI
Bernd Hufmann [Wed, 12 Feb 2014 18:11:07 +0000 (13:11 -0500)]
tmf: Use auto detection algorithm when using Open Trace File/Directory
Also the trace viewer user guide was updated to reflect that change.
Change-Id: I698dc8a3dba973f93b148f54f1b12ab23c865d67
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22065
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Thu, 13 Feb 2014 20:20:05 +0000 (15:20 -0500)]
lttng: Bump target definitions to use Java 7
This affects the default launch configurations created when
you launch the project for the first time.
Change-Id: If9ae9cabccc42da5f5b3bebf60b07fdff2bd3f17
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/22049
Alexandre Montplaisir [Wed, 12 Feb 2014 20:23:33 +0000 (15:23 -0500)]
lttng: Add Guava dependency to help plugins
Recent versions of the Wikitext Ant task depend on Guava
(com.google.common.base.Strings among other things). Maven had it
covered already, but building it from within Eclipse was broken.
Change-Id: I278425489c4334eb5bd6bb699ea193b5e35891df
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/22048
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Tue, 4 Feb 2014 22:58:19 +0000 (17:58 -0500)]
tmf: Remove getStateSystemID() from the module's API
This value is now stored in the state system, callers can now use
ITmfStateSystem.getSSID().
Change-Id: I4fcfa746c7ba3867d6971cfd5a88a00a1d4637a7
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21541
Alexandre Montplaisir [Wed, 12 Feb 2014 20:09:19 +0000 (15:09 -0500)]
lttng: Drop the Debian-specific location for Wikitext
Our distro/OS-agnostic dev setup instructions tell users to install
Wikitext from p2 if they want to build the help plugins. Everybody should
have done this by now, this is much less intrusive than pulling 200+ MB of
packages based on Eclipse 3.x...
Change-Id: I1542b68448ac4b6a3e25cf0321431fd982e0f8d2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/22047
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Tue, 11 Feb 2014 20:29:53 +0000 (15:29 -0500)]
tmf: Remove validate methods that are not used
Change-Id: I0b2aea99ba6084f8de3a260b6a9cfd5b0387041b
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/21844
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Tue, 11 Feb 2014 19:00:43 +0000 (14:00 -0500)]
tmf: Fix NPE in Import wizard
Change-Id: I5a7ce6131d15af7d4329716da2be531aff0f5dc8
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/21843
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Wed, 12 Feb 2014 13:34:42 +0000 (08:34 -0500)]
tmf: Remove HistoryBuilder and TmfStateSystemFactory
Everything in-tree has been migrated to the state system analysis
module, we can now remove the legacy way of doing things.
Change-Id: I52e5e50dff28588c1609d5a212ef7ede0e4d2514
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21911
Tested-by: Hudson CI
Patrick Tasse [Tue, 11 Feb 2014 14:48:35 +0000 (09:48 -0500)]
tmf: Do not use OS String for import trace wizard destination path
Change-Id: Id6f13335027cbbf748f3251be7ed35d0ec6d1545
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/21842
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Geneviève Bastien [Wed, 12 Feb 2014 14:15:24 +0000 (09:15 -0500)]
TMF: Add method to get traces with build thread in Time graph view
This new method returns the traces for which a build thread will be started
in the abstract time graph view. This will allow a time graph view displaying
results from an experiment to override this method so that only one build
thread for the experiment starts.
Change-Id: I630424b3753f98924fc4c2dfc71a4902cddb0bee
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/21887
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Mon, 10 Feb 2014 19:56:24 +0000 (14:56 -0500)]
tmf: fix freezing of UI when selection large directory structure
Change-Id: I40d4dc7ffa5edce23a8fa05ff89af4f7d5a1ec71
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/21841
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Wed, 12 Feb 2014 12:41:21 +0000 (07:41 -0500)]
tmf/lttng: Migrate remaining users to the state system analysis
- Removed the VerifyHistoryFile program, this dates from long ago,
these checks can now be done via unit tests.
- Removed the BasicStateSystemExample. Doing a range query on the
full range of the trace?!? That's a good example of what NOT to do!
- Tweaked the GenerateTestValues program to use the analysis module
instead.
Change-Id: I224f93642b8b3a9a4a0c1c4ca9a1e2f5f7089130
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21910
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Fri, 7 Feb 2014 13:10:27 +0000 (08:10 -0500)]
tmf: Unify import and validate methods
There is less duplicate code now.
Change-Id: If7941bc2b812d421a4b17ca6fa872ba424b1c614
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/21840
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Fri, 7 Feb 2014 13:21:00 +0000 (08:21 -0500)]
tmf: Fix concurrent modification exception when importing many traces
Change-Id: I85499c9641a864c93069a3db8eed257e3b6bb53e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/21839
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Fri, 7 Feb 2014 12:35:07 +0000 (07:35 -0500)]
tmf: Disable import unrecognized button for non auto detection
Change-Id: Ie9ee6300ec07cc1272638562b1b33c38343428eb
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/21838
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Thu, 6 Feb 2014 19:18:29 +0000 (14:18 -0500)]
tmf: Remove dialog to show unrecognized traces during import
Change-Id: If8d53aecaaec4658a9a2771b0dbbce7644a3329d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/21837
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Tue, 4 Feb 2014 18:14:28 +0000 (13:14 -0500)]
tmf: Add automatic trace type detection to drag & drop
Change-Id: Idc8d8c379e2d2cfba10c77fdcbaf34f331c8c96f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/21836
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Wed, 5 Feb 2014 21:21:06 +0000 (16:21 -0500)]
tmf: Add automatic trace type detection to import trace wizard
Change-Id: I93e16989fcceaebffd4ef745360a09bc45713ff1
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/21835
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Tue, 11 Feb 2014 23:33:28 +0000 (18:33 -0500)]
tmf: Use full history backend by default
Full history is used in most places, so instead of having to specify
it in every implementation, set it as such in the abstract state system
module. Sub-classes are then free to override it if they want.
Change-Id: I856155114fd2a189bd2d582acb43b724e71f508d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21909
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Mon, 3 Feb 2014 20:18:09 +0000 (15:18 -0500)]
tmf: Update CTF and custom trace validation
Change-Id: I991b17c363645aa22c0456309cbdd2db6deee2f4
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/21834
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Wed, 29 Jan 2014 16:46:12 +0000 (11:46 -0500)]
tmf: Add TextTrace abstract class with trace validation status
Change-Id: I1e027b4ee4e9581bcee2df99edaf7fde7cc9ee12
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/21833
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Fri, 31 Jan 2014 13:57:14 +0000 (08:57 -0500)]
tmf: support for renaming, overwriting or skipping during import
If a trace with a given name already exists in the target project
and the checkbox "Overwrite existing trace without warning" is not
checked, then a dialog box will be opened so that the user can
specify if he wants to rename, overwrite or skip the trace. The user
also has the option to apply this for all the imported traces, for
example "Rename all". For the renaming case the import operation will
automatically add a number as suffix to the trace name, for example
(2). This is similar to how it is done for drag and drop or
"Open Trace File/Directory" command in the RCP.
Change-Id: I316752fb7a76f6f448958b147e212af9a1ee2bcb
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/21832
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Wed, 29 Jan 2014 15:20:24 +0000 (10:20 -0500)]
tmf: Rework trace import wizard
- Use standard directory and file trees from the base import resource
wizard. This fixes the problem of UI freezes in the previous
implementation when setting the checked state of a large file system
tree. Instead of having on single tree for directories and files there
are 2 trees side-by-side, one for directories and one for the files of
the highlighted directory.
- Introduce TraceFileSystemElement class for the tree viewers
This class extends FileSystemElement that is used in the standard
tree viewers of base import wizard class and it supports lazy
loading of the children elements.
- Only import directories as traces if they are valid directory
traces. This avoids directories to be imported when they are selected
in the tree. Right now only CTF traces are considered for that. A
generic solution needs to implemented for that.
- Don't try to validate a trace when changing the selection state
and a trace type is selected. The validation of traces can be very
long if many files and directories are selected and we don't want
to do that for each selection change. The trace type validation
is now only done after pressing the finish button.
- Directories are validated first using trace types for directories
By doing that, valid directory traces are not considered for file
trace types
- Support for auto detection of trace types
When this option is selected the wizard tries to detect automatically
the trace type. For CTF traces (directories) this is working well.
For file traces additional code is needed to detect the valid trace
type.
- Possibly long validation and import operation can now be cancelled.
- New checkbox to import unrecognized traces or to omit them
During auto detection it might happen that a trace type is not found
for a given file. This new checkbox allows the use to import the
unrecognized traces or to omit them. This checkbox value is persisted
in the dialog settings and loaded when opening the wizard afterwards.
- Trace type selection combo box has now sorted entries
Change-Id: I4920ad1d1de40e7665f1394549d3ff945b91d870
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/21831
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Bernd Hufmann [Tue, 11 Feb 2014 02:10:58 +0000 (21:10 -0500)]
Revert "tmf: Remove legacy import wizard"
This reverts commit
38b5d28eb185cdee37a452d312f9ca91a2c7af2f.
Change-Id: I4874e4a9347532df16eae1599d25b4faece0a998
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/21830
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Fri, 7 Feb 2014 21:28:30 +0000 (16:28 -0500)]
lttng: Migrate LTTng-UST CallStack to the analysis framework
Reworked the tests a bit for less copy-paste.
Change-Id: Ibd8587dfd41464e9f5e54fbaa3f6dd22cfabadfe
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21788
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Alexandre Montplaisir [Thu, 6 Feb 2014 21:10:36 +0000 (16:10 -0500)]
tmf: Transition custom parsers to the new location
If a user has some custom parsers defined in their workspace, and
they upgrade past
1b7d4a9, we can still look in the old location
so that they do not have to re-create the parsers manually.
Change-Id: Idd1c5f92f58d925be7494c75b8d1b668f487c119
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21651
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Mon, 10 Feb 2014 23:56:08 +0000 (18:56 -0500)]
tmf: Move the Statistics tests to the analysis API
Also, the TmfLostEventsStatisticsTest was not even run by default,
let's enable it!
Change-Id: I7585691432e136cebc87f659c167fb696030c68c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21789
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Mon, 27 Jan 2014 21:59:58 +0000 (16:59 -0500)]
tmf: Protect HTNode accesses with a reader/writer lock
Some funny things could happen in multi-thread scenarios, especially
if someone is querying the node while it is being written to disk.
Change-Id: Icbd5e1a5edf3118f9aa8e4827ba865b9b6f6f8ab
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21159
Tested-by: Hudson CI
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Tue, 28 Jan 2014 18:38:50 +0000 (13:38 -0500)]
tmf: Synchronize accesses to HistoryTree's latest branch
Most accesses are punctual, so the synchronizedList wrapper covers
for most of them. There is the iteration in readNode() that is done
by reader threads, but it's usually very quick, so there was not
really much advantage of using a ReadWriteLock - considering the
downside of more verbose locking.
Also made the list final and avoided exposing it publicly - the
backend object only needs the root node.
Change-Id: I46c315d46a5e96d609c052d4cedb4404fe765176
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21219
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Matthew Khouzam [Tue, 21 Jan 2014 15:47:22 +0000 (10:47 -0500)]
ctf: Metadata add support for incremental reading
Metadata now supports parseText and parseTextFragment
ParseText is needed to parse the initial trace
ParseFragment is needed to avoid reparsing in full the trace
Change-Id: If1857e0b5bb07e5a97cb635bcd7b960b9037f2c7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20881
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Fri, 7 Feb 2014 20:03:04 +0000 (15:03 -0500)]
tmf: TmfStatisticsModule fixes
Following exta review comments on https://git.eclipse.org/r/#/c/19412/
Change-Id: Ie0200ee7beb6a69c450220ade97a7f5bfe570649
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21700
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI
Geneviève Bastien [Wed, 29 Jan 2014 20:08:28 +0000 (15:08 -0500)]
TMF: Renamed o.e.l.tmf.analysis.xml.core.tests stubs folder to common
As mentioned as a last comment in the https://git.eclipse.org/r/#/c/19914/
patch, this folder contains test traces and not implementation stubs so
the name is more fit as "common".
Change-Id: Ia274cb4de2086a0311ffea4a1b95f6407d584b77
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/21294
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Tue, 4 Feb 2014 22:53:18 +0000 (17:53 -0500)]
tmf: Store the ID in the state system itself
Many components already refer to state systems with an ID, might
as well store it in the state system object itself for better
encapsulation.
Beyond the SSID pun, I like having it *not* be getId(), because that
quickly becomes confusing with IAnalysisModule.getId() (even though
those two values are usually the same).
Change-Id: I51babc177f54b4f8af66544e6c75be53da56b6c4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21540
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Alexandre Montplaisir [Mon, 3 Feb 2014 21:46:03 +0000 (16:46 -0500)]
tmf: Cleanup TmfStatisticsViewer
Some elements were supposedly used "for streaming", but now we
actually support steaming, and it's done through the analysis
module, so we can remove them.
Change-Id: I1d4b5ed49c7dc112d1904f050be6145814b58924
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21538
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 6 Feb 2014 16:16:28 +0000 (11:16 -0500)]
tmf: Add a waitForCompletion() with no parameter to analysis modules
This avoids having to instantiate useless NullProgressMonitor's we
can't cancel anyway.
Change-Id: Ibe9464315c7d957722817f9332e1024ab18e9609
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21629
Geneviève Bastien [Tue, 14 Jan 2014 18:35:41 +0000 (13:35 -0500)]
TMF: Add memory usage chart for UST traces with libc events enabled
It uses the date in the memory usage state system module to display in a xy
chart the memory used by the threads of the system.
Change-Id: Ifd435c318be20b19c8c1367a431c82f0a7152ea2
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/20629
Tested-by: Hudson CI
Alexandre Montplaisir [Wed, 5 Feb 2014 19:20:31 +0000 (14:20 -0500)]
tmf: Handle empty traces with the abstract state provider
Traces with state systems using the AbstractTmfStateProvider (ie,
all of them) would not get closed correctly if no event was ever
received in the provider - currentEvent would remain null, and the
closing step would be skipped.
This is probably an artifact back from the time where history backends
were optional. Now the closing step should always be run, and if we do
not have a valid end time to define, simply use 0. The dummy state
system will go from MIN_VALUE to 0, and since it will have absolutely
no data in it, it really doesn't matter.
Change-Id: Ia36d7bb2cce0b5712825043c7d9becd85cd7ec35
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21576
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Florian Wininger [Thu, 6 Feb 2014 18:58:57 +0000 (13:58 -0500)]
tmf : fix for CtfIterator getCurrentEvent()
This function is very costly and is called 3 times per event.
The previous CurrentEvent is cached to accelerate the process of building the state system
Benchmark for the TMF sample trace (13.4 Mo with 697343 events) :
Before :
Build of the state system : 8.896 s
Call of createEvent function : 2 091 982
After :
Build of the state system : 6.829 s
Call of createEvent function : 697 343
Benckmark with a 100Mo kernel trace :
Before : 48.1s
After : 38.0s
Possible gain of the state system building time : 23 %
Change-Id: Ibee6509dc378503ad672ca038b3ab17273a11966
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/21480
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
This page took 0.046389 seconds and 5 git commands to generate.