Matthew Khouzam [Fri, 3 Apr 2015 13:54:32 +0000 (09:54 -0400)]
pcap: address some redundant nullchecks in packets
Change-Id: I0855239ff5b567951be9189d8c6167d6f62d03fa
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45233
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Mon, 6 Apr 2015 13:39:56 +0000 (09:39 -0400)]
tmf remote: Decouple connection creation from JSchConnection
The o.e.remote API used to not provide an API to store username,
host and port programmatically without using internal APIs of
the JSchConnection implementation. Now, o.e.remote API has been updated
to provide a generic API to set this values independent of the
actual implementation (see Bug on PTP 463468).
This patch is to update TMF remote to use the generic API.
Change-Id: Ib7ddd64d64f000e9c9e3de99e9f40afcbe10df8e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45328
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Fri, 3 Apr 2015 13:45:14 +0000 (09:45 -0400)]
import/export: replace | with || allowing short circuiting if in extension check
Change-Id: I1a446c92b289843dd6f1e88b0e3eb51080fd5085
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45229
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Thu, 2 Apr 2015 19:44:48 +0000 (15:44 -0400)]
pcap.ui: replace hashmap iteration over key with entryset iteration
This is a performance helper and also reduces the amount of gets in the
hashmap
Change-Id: I4df95b7e2172ff839073e7a716f065213fb2d718
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45174
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Thu, 2 Apr 2015 19:35:47 +0000 (15:35 -0400)]
pcap: use NonNullUtils.equalsNullable in packet equals
Change-Id: Ie1e96a72b378d3ad2f9b3f90000acf201bd4a2c2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45173
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Marc-Andre Laperle [Thu, 26 Mar 2015 19:09:11 +0000 (15:09 -0400)]
Add property to control GTK version used in SWTBot tests
This will allow test builds for GTK3.
Change-Id: I70bed507ce47fc8cc907df84a252b0fde195b77d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44709
Reviewed-by: Hudson CI
Marc-Andre Laperle [Wed, 1 Apr 2015 17:41:40 +0000 (13:41 -0400)]
tmf: Add user documentation about importing archives from directories
Change-Id: I5088ff39349eb7e5be969ac2c3d833f86e713ae3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45054
Marc-Andre Laperle [Wed, 1 Apr 2015 04:53:56 +0000 (00:53 -0400)]
tmf: SWTBot tests for importing archives from directories and archives
Change-Id: I47b16520e3c91f3cf21af2c91fdcfeedd8dec1e6
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44966
Reviewed-by: Hudson CI
Marc-Andre Laperle [Wed, 1 Apr 2015 04:52:54 +0000 (00:52 -0400)]
tmf: Support importing archives from directories and archives (nested
archives)
This features complements the existing import wizard so that the
archives present in the selected source (directory or archive) get
extracted automatically.
Change-Id: Ia30ca927c4634e092e674b8d36b1d3846d4061b6
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44965
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Thu, 2 Apr 2015 14:09:08 +0000 (10:09 -0400)]
tmf: Remove use of CtfTmfTrace instance during CTF trace validation
This prevents unnecessary stuff from happening, such as creating an
indexer and its files.
It also makes sure all validations from the super class are executed.
Change-Id: I76823a12727f4a4a82d8969b6730bfd30570d369
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/45143
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Wed, 1 Apr 2015 18:40:37 +0000 (14:40 -0400)]
tmf: Use default checkpoint indexer in TmfTrace empty constructor
The default checkpoint indexer uses a TmfMemoryIndex.
This prevents TmfTraceType from creating unnecessary empty index files
for every trace type instance, and actual traces from creating index
files that become obsolete as soon as initTrace() is called.
Change-Id: I40c407d68ce9d6cd6f9c7f736ca5fa33b9c41b37
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/45057
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Fri, 20 Mar 2015 16:14:22 +0000 (12:14 -0400)]
ctf: remove StreamInputPacketReader string literals
Also remove overridable methods from constructor
Change-Id: I8ecbbb0fc46b7fd3d98462669e746279cf0872d1
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44266
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Wed, 1 Apr 2015 18:21:12 +0000 (14:21 -0400)]
fix modifier order
Now comply with "private static final Type typeName"
Change-Id: I63341b31bce02348b9fb799ebd4b4752fe542142
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45056
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Wed, 1 Apr 2015 17:36:00 +0000 (13:36 -0400)]
fix modifier order in TmfWorkspaceModifiyOperation.java
Change-Id: Ib9b8337ac1bf3f7294b62a9e441fb01042a9e33e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45052
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Wed, 1 Apr 2015 17:34:42 +0000 (13:34 -0400)]
fix modifier order in TracePropertyTester
Change-Id: Ife2341be4f78423a497da5aae2d65a83042acb7c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45051
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 1 Apr 2015 17:33:27 +0000 (13:33 -0400)]
fix modifier order in TmfSignalTracer
Change-Id: I8b15c83782686eb5b19ee48496783d05ba0d4712
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45050
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 1 Apr 2015 17:32:17 +0000 (13:32 -0400)]
fix modifier order in CustomTxtTraceDefinition.java
Change-Id: I2c8d6550afd977251e7ff61610e1fba0cea8cbb8
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45049
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 1 Apr 2015 17:30:57 +0000 (13:30 -0400)]
fix modifier order in TmfCallsite
Change-Id: I9b3587fad9ffebdd4ef84987f1da895ab057d532
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45048
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 1 Apr 2015 17:29:48 +0000 (13:29 -0400)]
fix modifier order in TmfEventField.java
Change-Id: I4b1003e38884221a3c8f4db9f56c01de6637a4f7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45047
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Tue, 31 Mar 2015 20:58:07 +0000 (16:58 -0400)]
ctf: remove deprecated code from CTFStreamInputPacketReader.java
Change-Id: I39b8b1c1ba614cf5b21c391972c14442e38d3f32
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44954
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Tue, 31 Mar 2015 20:53:21 +0000 (16:53 -0400)]
ctf: remove unused constructor in StructDefinition
Change-Id: I1b4ff80dbc604621b23ebf6f4aef57ccf8f5f8b7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44952
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Tue, 31 Mar 2015 20:57:43 +0000 (16:57 -0400)]
ctf: remove deprecated code from CTFStream.java
Change-Id: Ic7078009387d4c3297d53e4a56ac4dda1bf57020
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44953
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Wed, 1 Apr 2015 17:28:35 +0000 (13:28 -0400)]
fix modifier order in AbstractFileCheckpointCollection.java
Change-Id: I0018331bff7e91187e6fc54efc7fadfb94b6c707
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45046
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Tue, 31 Mar 2015 16:53:52 +0000 (12:53 -0400)]
dev guide: add section for TMF remote API
Change-Id: I60acb456aa39d034d987138b3d3c2b41de9b0a7d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44937
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Tue, 31 Mar 2015 18:46:21 +0000 (14:46 -0400)]
tmf remote: Fix connection handling for explicitely opened connections
It turns our that call to remoteConnection.isOpen() sends a
connection changed event with type closed. This will overwrite
the flag to false that keeps track whether the connection was
opened explicitely.
Also, when calling disconnect() on the RemoteSystemProxy only
close the connection if it was not explicitely opened.
Change-Id: Idce1cf9515c01667ce2e4d49a30d8296a8a7977d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44946
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Tue, 31 Mar 2015 21:52:52 +0000 (17:52 -0400)]
doc: Update user guide for event table font preferences
Change-Id: I20d73190d63418e59d4249ea78a1591bad07a3bf
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44957
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Patrick Tasse [Tue, 31 Mar 2015 21:46:37 +0000 (17:46 -0400)]
doc: Update user guide for persistent trace editor column order
Change-Id: Ic71532c71c7573707e69b5abed3f28fa93850b4e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44956
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Patrick Tasse [Tue, 31 Mar 2015 21:37:32 +0000 (17:37 -0400)]
doc: Update user guide for search and filter highlighting
Change-Id: Idce262d7efc713bd889ab3fd56a2da41a342b2c9
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44955
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Thu, 26 Mar 2015 15:53:51 +0000 (11:53 -0400)]
Ctf: remove circular initialization issue in LexicalScope
Introduce ILexicalScope, an interface to make a scope.
May introduce performance regression, to be monitored
Change-Id: I1c0838e8190a665db8a2aaf99e974348d4f98da4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44607
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Tue, 31 Mar 2015 00:11:34 +0000 (20:11 -0400)]
tmf remote: consolidate remote connection access methods
Change-Id: I9abd058d37f71d6df5e9774a11a09f750e22f363
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44882
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Patrick Tasse [Fri, 27 Mar 2015 22:54:19 +0000 (18:54 -0400)]
swtbot: Fix TestTraceOffsetting
The keystroke for enter key is fixed.
The test waits for project element to exist before opening trace.
The test waits for the trace editor to be opened or closed.
The old event table is disposed after reopening the trace and cannot be
reused. The new trace editor and its event table must be used.
The test now checks correctly that the timestamp is actually offset.
Change-Id: I069b406698207f2ca7d08f4ca87dcf0d45a4385e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44791
Reviewed-by: Hudson CI
Patrick Tasse [Fri, 27 Mar 2015 21:58:37 +0000 (17:58 -0400)]
swtbot: Fix FontEventEditorTest to close Preferences dialog
Change-Id: Ia54844dbee7d0cd2926ec856b233aed8068b8338
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44790
Reviewed-by: Hudson CI
Patrick Tasse [Fri, 27 Mar 2015 21:44:24 +0000 (17:44 -0400)]
swtbot: Fix FilterColorEditorTest failure in Windows
Due to antialiasing, the pixels that become of the highlighting color
were not all of the background color before the highlighting.
Change-Id: I91cad37ec4f882385d563488f8ceec737393739c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44789
Reviewed-by: Hudson CI
Patrick Tasse [Fri, 27 Mar 2015 21:50:58 +0000 (17:50 -0400)]
swtbot: Fix SWTBotUtils instability
Tracing project elements that have a label with a count suffix (e.g.
trace folders) can have the count updated in the middle of a test by a
resource change event. Methods to get those tree items should be able to
handle this atomically.
Methods that need a project tree item now wait until it is available.
The method openEditor() now waits for the editor to be opened.
Change-Id: I4c2540fcc8a947ca4f61de66372968b11b10df7c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44788
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Mon, 30 Mar 2015 20:36:03 +0000 (16:36 -0400)]
tmf remote: clean up RemoteSystemProxy class
Remove pass-through methods to IRemoteConnection instance. Users
can get the connection from the proxy and act directly on it.
This avoids duplication of methods.
Change-Id: I0cdd8a9ceb698ebdb6f7404f07d449e5bdaa7bee
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44877
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Mon, 30 Mar 2015 19:34:53 +0000 (15:34 -0400)]
tmf remote: change implementation getProcessBuilder of RemoteSystemProxy
Change-Id: I1c5ebc88620950595522fbf149f9032356818226
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44870
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Mon, 30 Mar 2015 19:10:12 +0000 (15:10 -0400)]
tmf-remote: use dispose instead of disconnect for a fetch connection
This ensures that the connection stays up if it connection had
been establieshed before the fetching of log procedure.
Change-Id: I056a6c2632a2b9dc33fbe7504c48889e98567dc3
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44869
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Mon, 30 Mar 2015 19:08:31 +0000 (15:08 -0400)]
tmf remote: update and rename RemoteSystemProxyFactory
Change-Id: I4cdfd96fb75a213638be8c7fd733bf49c67173e1
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44868
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Mon, 30 Mar 2015 16:32:46 +0000 (12:32 -0400)]
doc: User guide update for remote fetching feature
Change-Id: I38459b1083a7b035c2c244c91d4a1556f92d0f7b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44863
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Fri, 27 Mar 2015 17:36:14 +0000 (13:36 -0400)]
tmf remote: comply with naming convention
Change-Id: I7fa35d7bc443ccac196123f7f2c0061060ba36c0
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44826
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Fri, 27 Mar 2015 17:34:01 +0000 (13:34 -0400)]
tmf remote: remove code duplication
Change-Id: Id8ab4d7f328a45130d5fe69a758c27da31181e7a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44777
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Fri, 27 Mar 2015 16:46:00 +0000 (12:46 -0400)]
tmf remote: use System.arraycopy instead of manually coppy array.
Change-Id: If697e6208f1abd387a8678a3c7f30561dc6f62d5
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44775
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Fri, 27 Mar 2015 15:32:20 +0000 (11:32 -0400)]
tmf remote: collapse if-statement in preference page
Change-Id: I1938160a044d9e7560dfee75772a64418ee3b01e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44774
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Fri, 27 Mar 2015 15:16:14 +0000 (11:16 -0400)]
tmf remote: comply with naming convention in RemoteSystemProxyFactory
Change-Id: I164204b2849272a777cf05291bd0fbf9137b3c61
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44772
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Fri, 27 Mar 2015 15:27:09 +0000 (11:27 -0400)]
tmf remote: fix modifier order warnings
Change-Id: Ifa919b9e6f3a76947718447f0f4d3bc40d6e4317
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44773
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Fri, 27 Mar 2015 15:11:55 +0000 (11:11 -0400)]
tmf-remote: Add java doc to messages
Change-Id: Idca9609b93aacd0dc38ec575ecefb21cdab87c07
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44771
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Fri, 27 Mar 2015 14:39:50 +0000 (10:39 -0400)]
tmf-remote: fix dead variable storage warning in preference page
Change-Id: Ia075cdc566d19ef38a246147d620d0717e4b4791
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44770
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Fri, 27 Mar 2015 14:28:00 +0000 (10:28 -0400)]
tmf-remote: fix dead variable storage warning
Change-Id: I32e815d954b4c2e83c01e6317f34d9af5cce46c6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44769
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Mon, 23 Mar 2015 20:23:04 +0000 (16:23 -0400)]
tmf remote: Allow plugin customization for alternative profile location
Change-Id: Iec0f44f5a2ddd85d20cb8bb1e8f808939afb6280
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44531
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Marc-Andre Laperle [Mon, 23 Mar 2015 16:45:30 +0000 (12:45 -0400)]
tmf remote: Bug 460847: SWTBot tests for remote fetching of traces
Change-Id: I562080bf651f8ccbbfccd711fc4eb3d0a6e71993
Signed-off-by: Marc-Andre Laperle <Marc-Andre.Laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44529
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Marc-Andre Laperle [Mon, 23 Mar 2015 19:16:37 +0000 (15:16 -0400)]
tmf remote: Bug 460847: Add Junits for XML reader/writer of remote fetch
Change-Id: If1789368077c103eb88d6ec96668502da431f60b
Signed-off-by: Marc-Andre Laperle <Marc-Andre.Laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44530
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Tue, 24 Mar 2015 13:26:00 +0000 (09:26 -0400)]
swtbot: check syntax highlighting with filter bar
This test will take a screen grab of the cell being highlighted
and compare it before and after highlighting.
Change-Id: Iae5fe05cc965b19aa5dec775c26e1b637901982b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44540
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Wed, 25 Mar 2015 19:58:57 +0000 (15:58 -0400)]
swtbot: Introducing ImageHelper
The ImageHelper is a way to compare screenshots quickly and efficiently.
It has many helpers made to aid in comparisson. Each pixel is queried as
an RGB, the image can give the following info:
* its dimensions and place in the screen
* its pixels
* all the pixel values of a query (for sampling)
* a row of the image
* a column of the image
Change-Id: Id7a4c168cad18448a4d0d5c14ef395e05b6f018b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44635
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Tue, 24 Mar 2015 18:00:40 +0000 (14:00 -0400)]
tmf.ui: clean up SelectTracesWizardPage
Remove notion of vector
No longer locally supply provided array
Change-Id: I6958faa73d7747dc5c0471fe60af0a7773be243e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44518
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Tue, 24 Mar 2015 15:30:01 +0000 (11:30 -0400)]
analysis: combine nested ifs in TmfAbstractAnalysisModule
Change-Id: I79a930305c599202b69bddd066ca5e22b88ada58
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44480
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Marc-Andre Laperle [Thu, 26 Mar 2015 04:18:42 +0000 (00:18 -0400)]
Fix a few file handles not being closed
This could lead to test failures on Windows and potentially the import
from archive could fail in real world scenarios.
Change-Id: I96ca34bfcaeced704f4d6fe7c6478c2ba19b988d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44646
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Thu, 26 Mar 2015 16:43:26 +0000 (12:43 -0400)]
Add some missing test plugins to testing feature
Change-Id: I0bee49e6f558987aa2325e89f54f76261ef5c39e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44704
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Tue, 24 Mar 2015 17:51:01 +0000 (13:51 -0400)]
tmf remote: Bug 460847: Add remote fetch wizard and operations
Change-Id: I630035d8581c6bb6e473fc4672e3f03078da500b
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Patrick Tasse <Patrick.Tasse@gmail.com>
Signed-off-by: Marc-Andre Laperle <Marc-Andre.Laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44528
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Thu, 26 Mar 2015 02:25:16 +0000 (22:25 -0400)]
remote: add non null checks
Change-Id: I536548d1c8a7f8c481e6828d4298050896277514
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44643
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Tue, 24 Mar 2015 17:44:19 +0000 (13:44 -0400)]
tmf remote: Bug 460847: Add profile preference for remote fetching
Change-Id: I53cea25df04ec323a73ab2caeca2b77b7fb7d78b
Signed-off-by: Patrick Tasse <Patrick.Tasse@gmail.com>
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Marc-Andre Laperle <Marc-Andre.Laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44527
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Geneviève Bastien [Mon, 9 Feb 2015 03:28:02 +0000 (22:28 -0500)]
TMF: Add the possibility to specify a content provider for time graphs
This gives more flexibility to manage time graph entries instead of
building the list only once when the trace is loaded.
For example, a view like the Critical Path View where the list of
entries depend on the selection from another view can be managed using a
content provider.
Change-Id: I5de7b5c16ba3b60c26f7d0d4a69289f6ddb8441b
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/41476
Reviewed-by: Hudson CI
Patrick Tasse [Sat, 14 Mar 2015 16:56:48 +0000 (12:56 -0400)]
tmf: Make ITimeGraphContentProvider extend ITreeContentProvider
This will allow the same provider to be used for the time graph viewer
and tree viewer in a time graph combo.
A default implementation is provided that accepts an ITimeGraphEntry
array or list as input element.
Change-Id: Icd8ac8b89e4b46c91c0474616578c375475e7e9a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43853
Reviewed-by: Hudson CI
Marc-Andre Laperle [Tue, 24 Mar 2015 17:36:01 +0000 (13:36 -0400)]
tmf-remote: Bug 460847: add model for remote fetching of traces
Change-Id: I9d9ef176ac72ee93edf62df1797309b6d843b430
Signed-off-by: Marc-Andre Laperle <Marc-Andre.Laperle@ericsson.com>
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Patrick Tasse <Patrick.Tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44526
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Mon, 9 Feb 2015 16:17:58 +0000 (11:17 -0500)]
control: display file rotation properties (Bug: 459483)
Change-Id: I7f15d718de92fbd60357600ecd3c49b68fd727a3
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41535
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Tue, 24 Mar 2015 16:36:30 +0000 (12:36 -0400)]
tmf.ui: merge nested if statement
Change-Id: I42d9ef509d0be765118eca25e90668c99e5a07f5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44507
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Tue, 24 Mar 2015 15:34:07 +0000 (11:34 -0400)]
tmf.core: CustomXmlTrace combine if statements
Change-Id: Id159d52caef5f762788d2081e9f62100579c8b40
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44482
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Tue, 24 Mar 2015 22:26:55 +0000 (18:26 -0400)]
ss: Expose method to get an attribute's path as a string array
Most attribute-creation methods use string arrays (or varargs
parameters), it'd be nice to be able to get the same array back.
Change-Id: I8948d0d2120e24be5ba0ed72d0cb951d278f4e14
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/44543
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Tue, 24 Mar 2015 18:28:14 +0000 (14:28 -0400)]
tmf.core: make tracer follow naming convention
Also add javadoc
Change-Id: I9b166cd7a425aacf20ede4cac3105ffc21e4a164
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44522
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Tue, 24 Mar 2015 17:53:23 +0000 (13:53 -0400)]
tmf.ui: Make InterruptedExceptions not get caught as Exceptions
in TracePackageExportOperation only
Change-Id: I2405115af174e4619da655a4f4d7cf8930e09504
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44515
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Tue, 24 Mar 2015 19:22:37 +0000 (15:22 -0400)]
tmf.ui: update names to follow code convention
Change-Id: Ic9601b72fd86e5ce1ef5b5324b50d13e9998d594
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44524
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Tue, 24 Mar 2015 17:50:51 +0000 (13:50 -0400)]
tmf.ui: Nest ifs in ImportTraceWizardPage
Change-Id: I4123e43aa218fe39bb567b100b72e6862c9f77e0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44514
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Tue, 24 Mar 2015 18:33:14 +0000 (14:33 -0400)]
tmf.ui: use indexOf(char) instead of String in ExportTracePackageWizardPage
Change-Id: Ic215454ac0cd947086fc584b1aa7a827ca94078a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44523
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Thu, 12 Mar 2015 22:30:58 +0000 (18:30 -0400)]
tmf: Rename time range signals
The meanings of TmfTimeSynchSignal and TmfRangeSynchSignal have changed
since those classes were first introduced. "TimeSynch" also refers to
a time range now. Rename those two signals to better reflect their
contemporary meanings:
TmfTimeSynchSignal -> TmfSelectionRangeUpdatedSignal
TmfRangeSynchSignal -> TmfWindowRangeUpdatedSignal
Change-Id: I05b2c9b8c6aaf30a07188c4695e117832aabb4b1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/43761
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Mon, 23 Mar 2015 20:33:39 +0000 (16:33 -0400)]
Build documentation index
This speeds up the initial search in the Help. This is mostly useful for bigger
Eclipse installation therefore there is not that much of a difference in the
Trace Compass RCP.
Change-Id: I5edc0ae3350410f7916b8ba625768eaf2a3e6435
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44409
Reviewed-by: Hudson CI
Matthew Khouzam [Tue, 24 Mar 2015 17:29:53 +0000 (13:29 -0400)]
swtbot: fix colorsetting instability
Waits for table to be populated before selecting event.
Reset colors after test.
Fix typo in comments.
Change-Id: I166681c827e311c9d7d2ee8aa35ce429679b1c37
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44510
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Marc-Andre Laperle [Thu, 19 Mar 2015 23:49:23 +0000 (19:49 -0400)]
Fix some instability in custom parser SWTBot tests
We need to wait until the XML files are written to disk after clicking on the
Finish button of the wizard. Otherwise, the content might be not be up to date
when we verify the content (assert) in the non-UI test thread.
From what I understand, SWTBotButton.click should be synchronous so all the
code in the UI thread should be done executing by the time it returns. But this
doesn't seem to be the case all the time. This will require more investigation
that might take quite some time so we can use this work around for now.
Change-Id: I9177b01f3ac425530aba454c26a97b5b7d31301d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44217
Reviewed-by: Hudson CI
Matthew Khouzam [Tue, 24 Mar 2015 15:31:04 +0000 (11:31 -0400)]
analysis: combine nested ifs and merge exception handling
Change-Id: I88cf8ffb36ac10e4bbfb0493e33bae1d9d54e1f2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44481
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Mon, 23 Mar 2015 19:50:22 +0000 (15:50 -0400)]
swtbot: add font change test
Test the raw viewer as the font picker is a native window.
Change-Id: Id2fb0f7492bce82ddc162ec2e4b48b66161e13e0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44406
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Tue, 24 Mar 2015 15:26:34 +0000 (11:26 -0400)]
ctf: Remove redundant modifiers in CtfConstants
Change-Id: I207e1a9dff63d4fcadb7a7bfdb801ff82dc3847f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44478
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Fri, 20 Mar 2015 15:24:23 +0000 (11:24 -0400)]
colors: add util helpers and collapse exceptions
Change-Id: I0e95cfd2d3887a7ea320dc00d7c06400d6e92493
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44261
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Fri, 20 Mar 2015 15:11:51 +0000 (11:11 -0400)]
color: Make ColorSettingsXML not check type of filter.
Change-Id: If1055568768499aaef9f29e56043ed5288b57992
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44254
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Thu, 19 Mar 2015 15:24:31 +0000 (11:24 -0400)]
ctf: remove variant tag definition from declaration
The tag definition of a variant was cached in the declaration.
This could create the possibility of a variant misreading the data.
The declaration is now more stateless and will not have these issues
pop up at a later date. Also this optimisation is no longer helpful
and consumes more memory.
Change-Id: I0136e936748ac5ea1e08d9b44caa0444fc6b6561
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44184
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Mon, 23 Mar 2015 17:39:55 +0000 (13:39 -0400)]
tmf remote: rename messages constants
Change-Id: Ib0c9ebbc3378c9a1e8466270cf6179b4f5453988
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44400
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Mon, 2 Mar 2015 21:16:31 +0000 (16:16 -0500)]
tmf remote: Add unit tests for tmf.remote.core
Change-Id: Id865b2f29f91e5128bda87b7ffa50ac1672d2f04
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44207
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Fri, 20 Mar 2015 21:53:43 +0000 (17:53 -0400)]
swtbot: move column in trace editor test
Moves columns and checks if the setting is preserved.
Change-Id: I58167ae3353900eea3db492dbc767c0d93c16caf
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44287
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Fri, 20 Mar 2015 18:55:39 +0000 (14:55 -0400)]
tmf: Use find() instead of matches() in TmfFilterMatchesNode
This removes the need for a regex fix to add .* before and after, and
ensures the highlighting is always correct even for complex expressions.
Change-Id: I0fd19b0c396861b68292e458cb0f2f67202561c9
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44278
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Thu, 12 Mar 2015 18:31:24 +0000 (14:31 -0400)]
os.linux: Add Linux-specific static definitions
And replace some magic numbers in KernelStateProvider with values
from this file.
It includes some LTTng-specific definitions, but since the statedump
events are handled in this plugin (and not in something lttng2.kernel)
it makes sense for now to put them there.
Change-Id: If47a13ca277a9da0220066b03024fca1f403beb4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/43758
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Fri, 20 Mar 2015 19:09:09 +0000 (15:09 -0400)]
ss: Add @NonNull to attribute name-getting methods
If the quark is valid, its name and full path can never be null.
This removes a check in AttributeTree that would return null on failure.
Instead, let it throw an ArrayOutOfBoundsException if the quark is
invalid, like many other methods in that class already do.
Change-Id: I384ff8be26f003d684c9f9170cba2d155ed3c08e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44281
Reviewed-by: Hudson CI
Alexandre Montplaisir [Thu, 26 Feb 2015 08:30:16 +0000 (03:30 -0500)]
Fix the run configuration shipped with the alltests plugin
Change-Id: I8de5ecb56f39f60c1a29966ee56e2a25675eedeb
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/42723
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
Marc-Andre Laperle [Fri, 20 Mar 2015 23:24:44 +0000 (19:24 -0400)]
Fix SDViewTest on Mac
The test should be expected command+F not Ctrl+F
Change-Id: I6650c63b02177cfb6f307cb48b539c004047c3e2
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44293
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Christian Mansky [Tue, 10 Mar 2015 18:59:12 +0000 (19:59 +0100)]
tmf.ui: Add (Un)check(In)active buttons to TimeGraphFilterDialog
Adds installable buttons to TimeGraphFilterDialog in order to provide
view specific filtering functionality. In this case check/uncheck
active/inactive buttons are added specific to the ControlFlowView.
Change-Id: Ibac317385527a61df09e82f0721eff19dcfcce83
Signed-off-by: Christian Mansky <christian.mansky@gmx.at>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43648
Reviewed-by: Hudson CI
Matthew Khouzam [Sat, 29 Nov 2014 16:52:54 +0000 (11:52 -0500)]
ctf: Remove deprecated methods
Remove setByteBuffer from bitBuffer, it is an immutable field. (deprecated)
Remove getEvents and getEventType from CTFTrace (deprecated)
Change-Id: Ie181005874d380a0ed1197f09e108fc9f7a59272
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/37317
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Wed, 18 Mar 2015 17:53:52 +0000 (13:53 -0400)]
tmf: Fix event table item default colors and foreground positions
The default system colors should be used whenever the default color
setting from the color setting manager is used. This no longer requires
special handling since if the color from the default color setting is
null. The current theme's system colors are not necessarily equal to
COLOR_LIST_BACKGROUND and COLOR_LIST_FOREGROUND.
The background needs to be drawn in the custom EraseItem listener if the
item background is different from the table's background (set to the
default system color as it is never changed), not when it is different
from COLOR_LIST_BACKGROUND (which may not be the default system color in
the current theme).
The text bounds and image bounds adjustments in the custom PaintItem
listener need to be set differently for Windows and Linux.
Change-Id: I06e6ed48e866ce7831ea3ad630d120a8cf228973
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44124
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Thu, 12 Mar 2015 17:40:26 +0000 (13:40 -0400)]
tmf: Support nullable colors in ColorSetting
A null Color in a ColorSetting indicates that the default system color
should be used.
Change-Id: I01f129ac30ba4c6589229b19851e15cc93362622
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44173
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Thu, 20 Nov 2014 14:28:07 +0000 (09:28 -0500)]
ctf: make StreamInputPacketIndexEntries immutable
Fix a long running "bug" of byte/bit inconsistency that
accidentally cancelled itself out before.
Change-Id: Ie8801ef951eb9619b3ef96e2826103203b7c371f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36774
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 18 Mar 2015 20:11:38 +0000 (16:11 -0400)]
Add javadoc for TmfTimestampFormat.java
Change-Id: Ib6ee40c2563ed66a7cd6bcd99f8266432ea42209
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43626
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Mon, 16 Mar 2015 18:41:19 +0000 (14:41 -0400)]
tmf: Add font preferences for trace editor event table and raw text
The font settings can be changed in Window > Preferences > General >
Appearance > Colors and Fonts > Tracing.
Change-Id: Icc95f2ad6df25552293e8ee1d75ab580cdc63af7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43965
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Mon, 16 Mar 2015 21:15:55 +0000 (17:15 -0400)]
Fix running tests with 4.4 target with 4.5 installation
The plugin org.eclipse.pde.junit.runtime bundled with Eclipse 4.5 is now
incompatible with Eclipse 4.4 because it requires org.eclipse.core.runtime
version 3.11.0 as the minimum which is only in 4.5. The first build that has
this problem is 4.5-I20150224-0800.
Trying to run tests would result in this error:
org.osgi.framework.BundleException: Could not resolve module: org.eclipse.pde.junit.runtime [217]
Unresolved requirement: Require-Bundle: org.eclipse.core.runtime; bundle-version="[3.11.0,4.0.0)"
Also, we can point to the 4.4.2 update site which is faster than pointing
to the composite update site, especially when building with Tycho (dependency
resolution).
Change-Id: I910216656496cf961e580a69c78d285548d57452
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43975
Reviewed-by: Hudson CI
Patrick Tasse [Fri, 13 Mar 2015 19:45:30 +0000 (15:45 -0400)]
tmf: Preserve trace editor column order per trace type
Save the column order when the trace editor is closed.
Load the column order when the trace editor is opened.
Clear the column order when a custom trace type is modified or deleted.
Change-Id: If8063e59f44b69b0eca306b8b54c8c807e65c838
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43826
Reviewed-by: Hudson CI
Patrick Tasse [Fri, 13 Mar 2015 19:38:06 +0000 (15:38 -0400)]
tmf: Perform cleanup when custom parser is modified or deleted
All traces in all projects which have the modified or deleted custom
parser's trace type should be closed and have their supplementary files
deleted.
Change-Id: I872cefb7e0aa9e3d9e6370766bb6319cb256d503
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43825
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
This page took 0.044536 seconds and 5 git commands to generate.