Etienne Bergeron [Fri, 29 Nov 2013 18:24:04 +0000 (13:24 -0500)]
tmf: Implement a cache of TmfStateValue
This patch provides a caching implementation in the TmfStateValue factory.
TmfStateValue are immutable and can be shared.
By changing the size of the cache, we observed this cache ratio.
size hit total ratio
2 count:
7369956/
15551000 [0.
4739216770625683]
4 count:
11742495/
15530000 [0.
7561168705730843]
8 count:
14622383/
15545000 [0.
9406486330009649]
16 count:
15007948/
15552000 [0.
965017232510288]
32 count:
15372868/
15543000 [0.
9890541079585665]
64 count:
15432506/
15523000 [0.
9941703279005347]
128 count:
15488720/
15534000 [0.
9970851036436205]
Which seems to be an excellent ratio for a really small cache.
The same idea is used with Integer.valueOf(...).
Change-Id: I3701b900035d83b19531101ab60e7292899d8cef
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19030
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Geneviève Bastien [Wed, 6 Nov 2013 18:43:38 +0000 (13:43 -0500)]
TMF: Add new XML analysis project
Empty project where the data-driven XML analysis will be added
Change-Id: I3fc3c1ab468c601127451990bbb87dc26881f547
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/18583
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Etienne Bergeron [Wed, 4 Dec 2013 21:03:13 +0000 (16:03 -0500)]
ctf: Re-indent the CTF grammar to ease reading.
This patch-set does not change any rules.
I tried to apply the same Java indent rules.
A few rules are still badly indented.
I don't get why you keep all enter/exit debugging in the grammar.
You have antlr option to do this:
-trace have all rules call traceIn/traceOut.
-traceParser have parser rules call traceIn/traceOut.
-traceLexer have lexer rules call traceIn/traceOut.
-traceTreeParser have tree walker rules call traceIn/traceOut.
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Change-Id: I5077cdc23fe8c76fb17fd6ce0569bdd66d2e9ad7
Reviewed-on: https://git.eclipse.org/r/19334
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Geneviève Bastien [Fri, 29 Nov 2013 14:14:05 +0000 (09:14 -0500)]
TMF: Bug 422846, trace resource is refreshed after analysis
Change-Id: I2c9301eb5f6eb18139e0af475ad639429b6126bd
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/19116
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Etienne Bergeron [Wed, 4 Dec 2013 16:18:26 +0000 (11:18 -0500)]
ctf: fix a misleading comment on string alignment.
Signed-off-by: etienne.bergeron@gmail.com <etienne.bergeron@gmail.com>
Change-Id: I4efeaf273c8695a0aa8f72ba57592dd8d0e8b649
Reviewed-on: https://git.eclipse.org/r/19320
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Wed, 4 Dec 2013 18:37:49 +0000 (13:37 -0500)]
Merge branch 'master' into lttng-luna
Bernd Hufmann [Tue, 3 Dec 2013 20:36:09 +0000 (15:36 -0500)]
tmf: Fix NullPointerExeptions in Histogram view
These NPEs happens when clicking or dragging the mouse in the
histogram windows before any data is available in the scaled data
instance.
Change-Id: I57efdb03cd53e2198580fa6c0ed047fc2dc4c3ac
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19268
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexander Kurtakov [Wed, 4 Dec 2013 14:04:35 +0000 (16:04 +0200)]
Bump build system to build 3.0.0.
Subprojects parent poms are losing their versions as they are always the
same as the parent pom version and thus only introduce noise.
Change-Id: I6388f33c5e68d8c061cf57c7c09612817e189e30
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/19310
Tested-by: Hudson CI
Francois Doray [Mon, 2 Dec 2013 06:06:35 +0000 (01:06 -0500)]
ctf: Add support for arrays or any type.
A null pointer exception occured for events that contained an array
of something else than "int". For example, an array of struct:
fields := struct {
...
struct {
string arg_name;
string arg_value;
} arguments[4];
};
With this fix, all arrays of CTF types are supported.
Sample output in the "Properties" view: http://i.imgur.com/31tqbgG.png
Change-Id: I3f2be314d1fd2bda8c95b208d018227477572fa8
Signed-off-by: François Doray <fdoray.eclipse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19029
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Francois Doray [Mon, 2 Dec 2013 05:28:19 +0000 (00:28 -0500)]
ctf: Make CtfTmfEventFieldTest easier to maintain.
Before this patch, a test event was created by filling a buffer with 0x02
bytes. Then, 0x00 bytes were added at magic positions to terminate the
strings used in the tests. That made the code hard to read and maintain. In
particular, it was hard to add new values in the test event without breaking
the null-terminated strings. It was also hard to understand, for example, that
0x02020202 is the float 9.
551467814359616E-38.
With this patch, values in the right format are added explicitly to the test
event. It's easier to understand the tests and to add values for new tests.
Change-Id: I5d482442a10f09627b3ed2b32a9a8cc68c0f5cdc
Signed-off-by: Francois Doray <fdoray.eclipse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19192
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Etienne Bergeron [Wed, 27 Nov 2013 05:37:40 +0000 (00:37 -0500)]
tmf: fix multiples coding style issues.
There is no behavior change in this patch.
Change-Id: I892fe351754363768210ba4bd333e39e339533ca
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19242
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Etienne Bergeron [Tue, 3 Dec 2013 09:20:12 +0000 (04:20 -0500)]
ctf: Hide internal functionalities of StringDefinition.
The StringDefinition should not expose its internal data structures.
The StringBuffer is a temporary buffer used by read. Nothing outside
the 'read' method should ever play with this object.
Change-Id: I2edda57f9208f4d1a56a3aa619545f803ea4278d
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19235
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Matthew Khouzam [Tue, 3 Dec 2013 21:41:41 +0000 (16:41 -0500)]
ctf: Improve int decoding in IOStructGen
Now handles "0x10" and "010" better, by using Long.decode() instead of
Long.parseLong().
Change-Id: I25d9cd239063674d52a73f00b3f4af90e1ddff33
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19272
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Matthew Khouzam [Wed, 27 Nov 2013 22:18:54 +0000 (17:18 -0500)]
ctf: support traces with no content but a packet size
Change-Id: I979e3826580db246263cfcb219ee7f9cba968922
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19023
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Patrick Tasse [Tue, 3 Dec 2013 19:22:48 +0000 (14:22 -0500)]
tmf: Fix Linux drawing weirdness in Histogram
- Set anti-aliasing to off when drawing histogram bars because it's on
by default in Linux
- Change order of drawing histogram bars and draw one pixel too far
because Linux doesn't draw last pixel of a line
- Clamp rounded rectangle arc size to rectangle width because Linux
doesn't
Change-Id: I574c80ecf15cda8655b3fbb8b34b80fd0f5a6d0c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19263
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Etienne Bergeron [Tue, 3 Dec 2013 10:00:04 +0000 (05:00 -0500)]
ctf: avoid temporary array creation when parsing CTF-Array.
The temporary List<long> is useless and the conversion function too.
Change-Id: I42bb50536deb1529998287fd9dae34c5f009c194
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19240
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Mon, 2 Dec 2013 20:52:26 +0000 (15:52 -0500)]
ctf: Succeed at failing on OOME in tests
There is a test that fails with an OutOfMemoryError. This catches the
failure and thus makes the test succeed at failing.
Change-Id: If4b1a14bf135da3fae9f356631440acede56673c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19001
Tested-by: Hudson CI
Matthew Khouzam [Wed, 27 Nov 2013 23:00:56 +0000 (18:00 -0500)]
ctf: Fix out of bounds positioning of the bitbuffer
rename private fields to follow fNameHere style
Change-Id: Ie579863b352a99e70cc9c1887d647aaa6018c9d4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19024
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Marc-Andre Laperle [Thu, 28 Nov 2013 22:41:46 +0000 (17:41 -0500)]
tmf: Update documentation for Open File, legacy import removal
Change-Id: Ib2c636e0e75ab8923a12728bec12260bd051ce7d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19090
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Etienne Bergeron [Sat, 30 Nov 2013 05:16:54 +0000 (00:16 -0500)]
ctf: Fix decoding of an invalid packet id type.
When an event id is not present, it is assumed to be zero.
Otherwise, it must be a _valid_ integer.
The current implementation accepts a "struct" as an id and map to the event id zero.
This fix throw an exception on an invalid id.
Change-Id: Iff6f6bd0173048dd3fb9b00f564948d7ebd55f4f
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19166
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Matthew Khouzam [Fri, 29 Nov 2013 23:06:11 +0000 (18:06 -0500)]
ctf: improve code clarity by merging if
Change-Id: I8ca0351762d36a5e25ba861e9fbc90ed14f5620a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19160
Alexandre Montplaisir [Fri, 29 Nov 2013 23:48:52 +0000 (18:48 -0500)]
ctf: Cleanup BitBufferIntTest
Update Javadoc, use correct order for (expected, actual) in asserts,
remove unneeded variables, etc. Hopefully they'll start looking less
like copy-pasted CodePro stubs.
Change-Id: Ie73748217201e93f9101a7c74928022857b93153
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19161
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Wed, 27 Nov 2013 20:06:07 +0000 (15:06 -0500)]
ctf: remove false positive in the case of cross-packet events
Change-Id: I8ba4d1edee641aa52c03c2f7742f672700b3282f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19006
Tested-by: Hudson CI
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Matthew Khouzam [Wed, 27 Nov 2013 20:48:19 +0000 (15:48 -0500)]
ctf: make float use readlong for 64 bit floats
Change-Id: I15dd34cd4a5068894155bac33a8ada58d35fcfca
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19015
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Marc-Andre Laperle [Tue, 19 Nov 2013 01:23:49 +0000 (20:23 -0500)]
tmf: Import trace package without manifest
Change-Id: I4e97dcc25734b6a5a91ffb35bfa38a94246b4b85
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18591
Marc-Andre Laperle [Thu, 14 Nov 2013 23:42:44 +0000 (18:42 -0500)]
tmf: Import and export multiple traces in a package
Change-Id: I935a1fcf76518bcad02940f8cc687389dae89673
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18533
Etienne Bergeron [Sat, 30 Nov 2013 06:37:04 +0000 (01:37 -0500)]
ctf: Remove unused alignment comparison
This code just do nothing.
What was the original purpose?
Change-Id: I0bf24dcdf5cb607c1af0a3326dbab60d51c6fbd4
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19167
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Etienne Bergeron [Fri, 29 Nov 2013 05:04:02 +0000 (00:04 -0500)]
tmf: Fix a method name typo in CtfTmfTrace.
There is not behavior change in this patch.
Change-Id: Ib1c043ca13528e7b307275f3728ffab14ca2ac1a
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19092
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Matthew Khouzam [Wed, 27 Nov 2013 18:56:30 +0000 (13:56 -0500)]
ctf: Fix Integer 33-63 bit handling
Thanks Etienne Bergeron for the initial patch.
Change-Id: I388280ef111fe3fd50729780f13e984cbf648886
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18909
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Fri, 29 Nov 2013 21:45:21 +0000 (16:45 -0500)]
tmf: Update Javadoc in CtfIterator
And removed the clone() method, it wasn't used and clone() is bad.
Change-Id: Ib82eb78a50fe4ad1a0836cb98f99f4cc0da9606a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19155
Tested-by: Hudson CI
Matthew Khouzam [Wed, 27 Nov 2013 14:24:05 +0000 (09:24 -0500)]
ctf: BitBuffer.java api overhaul
* Now 3 getters are public: get(length, extendSign), getInt(), and getLong().
Change-Id: I6848b2bde4e37580c1327f03cd025ea2bae4e134
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18908
Tested-by: Hudson CI
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Alexandre Montplaisir [Thu, 28 Nov 2013 22:26:52 +0000 (17:26 -0500)]
ctf: Throw CTFReaderException in the BitBuffer API
Instead of the hard-to-catch BufferOverflowException. This ensures
that users of the library handle cases where the trace reader fails
to read correctly (corrupted traces, twisted test traces, etc.)
Change-Id: If79e6f4fa9650c08e66f22c91a4cf4d250551e40
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19091
Tested-by: Hudson CI
Patrick Tasse [Thu, 12 Sep 2013 22:00:50 +0000 (18:00 -0400)]
tmf: Bug 416660: -1 long state value is not long
- Do not return nullValue when creating a new int or long with a value
of -1. This ensures that these values can be used and be differentiated
from a null value.
- Change occurences of -1 null value check to use isNull() method.
Change-Id: I7c9e80963736e701a0b30f5f3009a0c7084527bb
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/16396
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Etienne Bergeron [Thu, 28 Nov 2013 00:29:23 +0000 (19:29 -0500)]
tmf: Cleanup TmfStateValue to remove 1-level of indirection.
This is a refactoring to diminush the memory usage of the
StateSystem.
In the current implementation, each TmfStateValue has a
"box" for an other object (i.e. Integer, Double, String, ...).
We propose to remove this indirection and use the raw type inside
the corresponding type.
As an example, IntegerStateValue now contains an "int" instead
of an "Integer".
Change-Id: Iaa75172be42174ebd6dc7d9bdd434631077c0146
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19027
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Thu, 28 Nov 2013 17:59:49 +0000 (12:59 -0500)]
Merge branch 'master' into luna
Conflicts:
lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/types/Definition.java
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Change-Id: I59e02fdb4d9f58edd817dcacb6852458097a1ca2
Matthew Khouzam [Wed, 20 Nov 2013 19:28:44 +0000 (14:28 -0500)]
ctf: add early exit to alignRead
Change-Id: Ic1467ec9cdb6820e306bd92ec3137ed185c72dd8
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18630
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Wed, 20 Nov 2013 19:20:02 +0000 (14:20 -0500)]
ctf: improve alignment performance
Change-Id: I1ace35dc0002285874f1d0c3d9a841d2fb9900fd
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18589
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Etienne Bergeron [Thu, 28 Nov 2013 00:48:26 +0000 (19:48 -0500)]
tmf: Fix NPE in the TimeGraphControl.
On TMF startup, the variable fEventColorMap may be <null>.
for (Color color : fEventColorMap) {
Change-Id: I83db13bffa93c4c1fbbcbc21198f3660b56866b3
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/19025
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Marc-Andre Laperle [Thu, 21 Nov 2013 20:08:53 +0000 (15:08 -0500)]
tmf: Add Open Trace file, directory under Traces folder
Change-Id: I4acb8121c8cb2915117f1bf5a501bc246a93877d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18695
Tested-by: Hudson CI
Marc-Andre Laperle [Wed, 20 Nov 2013 23:00:01 +0000 (18:00 -0500)]
tmf: Remove legacy import wizard
Change-Id: I5915c26efd4f076959ea791d8b7d33b2cec1ce56
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18694
Tested-by: Hudson CI
Matthew Khouzam [Wed, 27 Nov 2013 19:34:28 +0000 (14:34 -0500)]
ctf: Catch ANTLR runtime exceptions in Metadata parsing
Change-Id: Ia50ee58b56a6e50b213e008950322c2e04231c28
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/19000
Matthew Khouzam [Wed, 27 Nov 2013 20:20:25 +0000 (15:20 -0500)]
ctf: fix CTF-testsuite to only test traces and not scripts
Change-Id: I7575b2cbe1eae5bc9019496515c081d51f5a6bdd
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/19011
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Wed, 27 Nov 2013 18:35:12 +0000 (13:35 -0500)]
Merge branch 'master' into lttng-luna
Conflicts:
lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/request/TmfSchedulerTest.java
Change-Id: I54ee583ea1075e7b50a0008b1940c00c7412a41a
Patrick Tasse [Tue, 26 Nov 2013 15:58:22 +0000 (10:58 -0500)]
lttng: Update user guide for histogram changes
Change-Id: Ia9b5cdab10f6444acd035f9f57ddac6031dbb8d3
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18938
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Geneviève Bastien [Fri, 22 Nov 2013 16:52:32 +0000 (11:52 -0500)]
TMF: TimeGraphPresentationProvider can notify listeners of color change
Bug 419282: If a presentation provider see its state table change and modify
colors, it fires a notification to listeners
The TimeGraphControl implements that listening interface.
Change-Id: I985576b10e0f5dcff154c555c307433193065d81
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/18764
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Wed, 27 Nov 2013 00:17:50 +0000 (19:17 -0500)]
tmf: Disable scheduler executionOrder test
That unit test has always been prone to multi-threaded uncertainty,
but recently it has been failing a lot more, which is very annoying
for the CI. I suspect it's because of the recent changes to the CTF
parser, some requests may end up finishing faster than they did before,
and before another request could be scheduled.
I suggest disabling it until we rewrite it to be more permissive (or
better, add testing mechanisms to the scheduler, and test the order
of requests being *sent*, not the order in which they finish).
Change-Id: I70db04feb9f86534f5d12623cf33f06d56b3a737
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/18942
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Xavier Raynaud [Tue, 5 Nov 2013 09:42:50 +0000 (10:42 +0100)]
TMF: add support of cut/copy/paste/dnd in FilterView
Signed-off-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Change-Id: I67f15cd9c1dcb046de8dc6eef196012be14d9265
Reviewed-on: https://git.eclipse.org/r/17019
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Geneviève Bastien [Mon, 25 Nov 2013 22:03:46 +0000 (17:03 -0500)]
TMF: Add assert exists and dispose to traces in synchronization tests
Change-Id: Ida426ccb6abe6404aa6c443dc5ae38b8d175f745
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/18862
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Tue, 26 Nov 2013 20:12:31 +0000 (15:12 -0500)]
Merge branch 'master' into lttng-luna
Etienne Bergeron [Sun, 17 Nov 2013 03:57:50 +0000 (22:57 -0500)]
ctf: Fix multiple coding style and typo issues while reading code.
Change-Id: If63330f4c86e7cd87cf979e1709a81fb7c8958ab
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18541
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Etienne Bergeron [Sun, 24 Nov 2013 05:52:17 +0000 (00:52 -0500)]
ctf: Plug the unsigned utils comparator into Stream comparator.
This patch-set fixes a pending TODO found randomly.
It modifies the code to use the unsigned comparator and avoid
bugs for large timestamp values.
The comparator no longer accept null values.
Change-Id: Idee0e56edfe85ba01a27fb79d1076736fee24874
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/18785
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Marc-Andre Laperle [Mon, 18 Nov 2013 01:44:39 +0000 (20:44 -0500)]
tmf: Fix core tests failing on Windows
2 tests did not dispose the index correctly. Solution: make sure
fCheckpointCollection gets assigned when recreating the collection so
that it gets disposed in the tearDown.
Change-Id: I6a79b62cdabf136790bcf76ca606e71c31cdd81b
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18481
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Mon, 25 Nov 2013 22:27:44 +0000 (17:27 -0500)]
tmf: Add timeouts to potentially hanging tests
Change-Id: Ia429dad124844abbac44afa644250238c8a60f5a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/18863
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Etienne Bergeron [Tue, 26 Nov 2013 01:49:28 +0000 (20:49 -0500)]
tmf: Remove unused TmfSortedArray.
This data-structure seems unused.
It's implemented with an insertion sort, and won't scale.
Change-Id: I49ae518a384817c4fd537c989240454e00f6f38b
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18875
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Etienne Bergeron [Fri, 22 Nov 2013 05:11:19 +0000 (00:11 -0500)]
[ctf] Fix coding style issues in BitBuffer.
Fix potential issue with an undefined behavior in CTF.
- Reading a integer of zero bit at the end of the buffer may be valid.
- Change the behavior to accept it.
Change-Id: I22fccc4e2ffee3bbf796e52b516b00f7fc5e31ac
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18707
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Etienne Bergeron [Thu, 21 Nov 2013 00:03:05 +0000 (19:03 -0500)]
[ctf] Fix binary search for a long sequence of same timestamps.
The binary search algorithm does not need a third case
(when values are equals) if there is a guarantee to remove
one element in the search space at each iteration.
The actual binary search implementation performs a sequential
search on elements with the same timestamp (to find the first
one).
The ETW2CTF traces produce many debug events for the debugging
information at the module load timestamp. Which is the worse
case for the actual implementation.
We changed the algorithm to use the timestamp end of a packet
instead of the beginning. We changed the way to choose a
middle element to ease the recursion by using only two cases.
Change-Id: I4f16d43b9533f8f1449cdb3c4c213bcb9f962daf
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18654
Reviewed-by: Matthias Nick <Matthias.Nick@bsiag.com>
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Tested-by: Hudson CI
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Geneviève Bastien [Mon, 25 Nov 2013 19:27:57 +0000 (14:27 -0500)]
TMF: Check presence of fields for TCP event synchronization
Traces using an old version of the TCP addons module would get a NPE when
getting the key to match packets.
Change-Id: Ib0470834807b1933f5f46069c5377115764b9dda
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/18848
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Mon, 25 Nov 2013 18:08:32 +0000 (13:08 -0500)]
ctf: Replace Long.compare() with Java 6 compatible method
We still technically support Java 6, and Long.compare() was added in 7.
Change-Id: I565b40bbc11c1c1c3b05a4097cc0e619598d0553
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/18841
Reviewed-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Wed, 20 Nov 2013 19:57:15 +0000 (14:57 -0500)]
tmf: Update histogram text controls
- 'Current Event' text control replaces with 'Selection Start' and
'Selection End' controls
- Text control layout updated
- Added link button to force single selection time
- Added selection span to histogram tool tip when mouse hovers over
selection range
- Fixed text control to support keypad Enter key
- Fixed to ignore invalid window span value
- Externalized tool tip messages
Change-Id: I2158dd579b2e508b3c2d0332aedc6b34626e6feb
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18634
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Wed, 13 Nov 2013 21:44:12 +0000 (16:44 -0500)]
tmf: Update histogram layout
- Both histograms fill all available space with no minimum height
- The max nb event text control grows in width according to its maximum
(watermark) text extent but never shrinks, eliminating layout jitter
(bug 375990)
Change-Id: I1ca835434f3e0fca4196aa7f23eb29dead2f50db
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18355
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Tue, 12 Nov 2013 18:51:37 +0000 (13:51 -0500)]
tmf: Support drag zoom in histogram
- Right button drag is used to select a new zoom window in both
histograms
- Shift-right button drag or click is used to modify the zoom window in
full range histogram
- Zoom is cancelled if the selected range duration is zero
- New time range is propagated when the mouse button is released
- Move draw time range window method to base class
Change-Id: If46c1edd5c8f67a1b48ebc2ebbe2527613ba927c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18310
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Mon, 11 Nov 2013 22:53:20 +0000 (17:53 -0500)]
tmf: Support drag move in time range histogram
- Add support for bucket display offset in histogram
- Middle button or Ctrl-left button are used to drag the window in time
range histogram
- New time range is propagated when the mouse button is released
- Remove restriction of selection buckets to visible range in data model
- Adjust histogram tool tip according to bucket display offset
- Prevent histogram tool tip when mouse is not over visible time range
Change-Id: I9ee3663511b57ac32a668cc25cf97e903a72e60f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18309
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Fri, 8 Nov 2013 17:43:56 +0000 (12:43 -0500)]
tmf: Support drag selection in histogram
- Left button drag makes a range selection in both histograms
- Middle button or Ctrl-left button are used to drag the window in full
trace histogram
- Middle-click or Shift-left-click on full trace histogram now centers
the window on the mouse position
- Selection is only propagated when the mouse button is released
- When moving the mouse only redraw instead of refreshing the whole
histogram
- Fix range selection start on Shift-click
- Limit selection range to visible time range
- Draw selection region background corrected when end time is before
start time
- Prevent mouse wheel zoom when dragging in progress
Change-Id: I393e0e72cd2f445be2bd75bb90090f27abc2a2da
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18308
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Fri, 8 Nov 2013 16:36:31 +0000 (11:36 -0500)]
tmf: Fix time range histogram to show its full range
- Set the end time of the time range histogram to the time range end
time (instead of the last event time)
- Display the time range text controls even when model has no events
- Snap selection to the end time
- Draw the delimiter to the right of the end time instead of last event
time
- Fill the area to the right of the delimiter with the background color
- Draw selection range anywhere in the histogram range regardless of
last event time
Change-Id: I913d22a20d79a3ca138902acd0d9cc815918cbc9
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18307
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Etienne Bergeron [Sun, 24 Nov 2013 21:36:14 +0000 (16:36 -0500)]
ctf: Remove unused StreamInputReaderComparator.
This is a clone of StreamInputReaderTimestampComparator.
Change-Id: Ib640cbafe8105bad2c18a3f5e35136e0a5693597
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18796
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Etienne Bergeron [Sun, 24 Nov 2013 05:17:35 +0000 (00:17 -0500)]
[ctf] Simplify the logic of the unsigned long comparator.
To understand this modification, let assume the "char 8-bits" domain.
unsigned [0 .. 255]
signed [-128 .. 127]
By receiving the parameters encoded in a signed number, the method receives
left: [0..127,-128..-1] (which represents [0..127,128..255])
right: [0..127,-128..-1] (which represents [0..127,128..255])
By definition (on an unconstrained domain), this assertion holds
left < right <==> left + k < right + k
Thus, the idea is to rotate the domain by k to allow a signed operator to
be able to compare to full domain.
In this case k must be -128.
By rotating the domain, left and right range become [-128..-1,0..127],
and are now comparable with the signed operator.
Change-Id: I92b27ab00e8f14102a04e085ef807e211e39a7f0
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18784
Tested-by: Hudson CI
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Xavier Raynaud [Fri, 22 Nov 2013 08:41:13 +0000 (09:41 +0100)]
TMF: make BufferedRandomAccessFile fields private, and final if possible.
Change-Id: I213410e6e4cc5fe96e24c88d6eac61d6bb2b1b23
Signed-off-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Reviewed-on: https://git.eclipse.org/r/18711
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Etienne Bergeron [Tue, 19 Nov 2013 02:14:46 +0000 (21:14 -0500)]
Avoid multiple seek to the same location.
There is multiple instance of seeking to the same location twice.
To solve this issue the seek method check if the current location is the same.
Here is the explanation:
[CtfTmfContext.java]
public void setLocation(ITmfLocation location) {
curLocation = (CtfLocation) location;
if (curLocation != null) {
getIterator().seek(curLocation.getLocationInfo());
}
}
GetIterator --> will force a seek to curLocation
.seek --> force an other seek to curLocation
Here are the called method:
private CtfIterator getIterator() {
return CtfIteratorManager.getIterator(fTrace, this);
}
public static synchronized CtfIterator getIterator(final CtfTmfTrace trace,
final CtfTmfContext ctx) {
return map.get(trace).getIterator(ctx);
}
public CtfIterator getIterator(final CtfTmfContext context) {
[...]
if (context.getLocation() != null) {
final CtfLocationInfo location = (CtfLocationInfo) context.getLocation().getLocationInfo();
retVal.seek(location); /// FORCE SEEK!!!!!!!!!!!!
}
Change-Id: Ib5ad6d05eb47045660c7ab5076930a30e829c7a0
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18461
Reviewed-by: François Doray <fdoray.eclipse@gmail.com>
Tested-by: Hudson CI
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Fri, 4 Oct 2013 21:57:28 +0000 (17:57 -0400)]
tmf: Fix unsafe cast warning in TmfTrace
Now that TmfData/EventProvider are merged, .getType() will always
return an instance of an ÌTmfEvent. Simply fix the generic types
to take this in consideration.
Change-Id: I791b59c480311a34c7416564219f6d3fed3f5951
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/17054
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Fri, 4 Oct 2013 22:08:09 +0000 (18:08 -0400)]
tmf: Move TmfEventRequest.ALL_DATA to the interface
No reasons for static defines to not be in the interface. And it was
always confusing that ExcecutionType was in the interface, but
ALL_DATA was not.
Change-Id: I373f0d36e779e9194315ad5d1df8c1237b94be1f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/17053
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Marc-Andre Laperle [Thu, 21 Nov 2013 21:28:05 +0000 (16:28 -0500)]
lttng rcp: Add Batch Import to File menu
Change-Id: I95e7c6f40aeb0c10c4ce92eabe9f8e3c3e39c0ac
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18697
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Mon, 18 Nov 2013 19:37:41 +0000 (14:37 -0500)]
tmf: Deregister traces used for validation only from signal manager
Bug 421860
Change-Id: I885ab62960a8cfc8af50591e52c239d0ca9c2479
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18521
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Alexandre Montplaisir [Fri, 22 Nov 2013 21:41:01 +0000 (16:41 -0500)]
Merge branch 'master' into lttng-luna
Alexandre Montplaisir [Fri, 4 Oct 2013 20:50:46 +0000 (16:50 -0400)]
tmf: Merge TmfDataProvider and TmfEventProvider together
Initially, there was a plan to support "traces" that had no timestamps,
and this would be handled by a DataProvider. Turns out the whole
framework requires some sort of timestamp nowadays, so this distinction
is no longer necessary.
(If a trace really does not have any timestamp, they could just use the
event rank as a sort of dummy timestamp, which is quite intuitive anyway).
This also merges Tmf{Data|Event}Request and TmfCoalesced{Data|Event}Request.
Change-Id: I734bb297d252d56902e1eb0534669b0d4088d911
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/17052
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Sun, 17 Nov 2013 19:13:26 +0000 (14:13 -0500)]
ctf: Update paths in the CTF-Testsuite tests
The upstream CTF-Testsuite was updated, let's follow 'suite'.
This also changes the test mechanisms to use parametrized tests. This
way, we get one JUnit test per test-trace being run, so we'll know the
exact amount of tests that are failing (instead of bailing out as soon
as we get one failure).
Those tests are disabled by default to avoid build failures for now,
but they should be fixed/reenabled as soon as possible.
Change-Id: Iadcd7c2d4352301cf60c132e0f2d8dc80f75a688
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/18479
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Etienne Bergeron [Sat, 16 Nov 2013 06:48:36 +0000 (01:48 -0500)]
Avoid flickering redraw of TmfEventsTable on open.
There is a 4 or 5 redraw of the Events table caused by the columns pack.
To avoid flickering, it's better to disable the redraw of the table.
I didn't try this fix on linux.
Change-Id: Idcfd1f5a79faee8ae0c31b268c67576ba1547760
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18648
Reviewed-by: François Doray <fdoray.eclipse@gmail.com>
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Etienneb Bergeron [Fri, 22 Nov 2013 05:30:05 +0000 (00:30 -0500)]
[ctf] Fixes multiple coding style issues while reading ctf Types.
Change-Id: I73a2e42b76090ed344a32da330cd0ab240b68099
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18706
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Bernd Hufmann [Fri, 22 Nov 2013 17:45:17 +0000 (12:45 -0500)]
tmf: Fix NullPointerException TmfTraceElement
and fix timing issues in TMF UI tests. The NPE and timing issues
causes problems in the TMF UI tests. That's way they are committed in
one patch.
Change-Id: If80562c11f9daab5756adf982b35a9e6b308e03b
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18748
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Etienne Bergeron [Fri, 15 Nov 2013 04:17:37 +0000 (23:17 -0500)]
Shortcut string creation in tracing functions.
This quick fix avoid useless creation of the message to be logged when tracing isn't enabled.
Change-Id: If1a667451c59afa67e25572f598e0826ce92f090
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18453
Reviewed-by: François Doray <fdoray.eclipse@gmail.com>
Tested-by: Hudson CI
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Marc-Andre Laperle [Sun, 17 Nov 2013 23:25:26 +0000 (18:25 -0500)]
tmf: Remember last selected directory in Batch Import wizard
Change-Id: I2a166af74ef8720ec672b56980493967bf7eb874
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18480
Tested-by: Hudson CI
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Thu, 14 Nov 2013 16:42:31 +0000 (11:42 -0500)]
TMF: Add base class and interface for state system analysis
Also update the state system explorer to show state systems from modules
instead.
Change-Id: Iab6424be1a469c541d3e9b199d7377c8a4e70299
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/18098
Tested-by: Hudson CI
Alexandre Montplaisir [Mon, 18 Nov 2013 23:37:31 +0000 (18:37 -0500)]
Merge branch 'master' into lttng-luna
Conflicts:
lttng/org.eclipse.linuxtools.tmf.ui/META-INF/MANIFEST.MF
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/handlers/DeleteTraceHandler.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java
Change-Id: I06c617e5e9ec6e691592971f9fc78812751623c8
Alexandre Montplaisir [Mon, 18 Nov 2013 23:29:12 +0000 (18:29 -0500)]
Revert "ctf: Simplify position arithmetic in aligned reads"
This reverts commit
24aae8967b763e5e2c8d87acac9c1a10533ae598.
With the newest content of master, this patch fails some unit tests while it didn't before... This will have to be investigated further.
Change-Id: I08dae5325b2048d84a6492780a02132a485ca914
Reviewed-on: https://git.eclipse.org/r/18536
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Mon, 18 Nov 2013 23:18:15 +0000 (18:18 -0500)]
Merge commit '
cea87c3123c41bd06cd2b816f885a27612dfc356' into lttng-luna
Conflicts:
lttng/org.eclipse.linuxtools.ctf.core.tests/pom.xml
lttng/org.eclipse.linuxtools.ctf.core.tests/shared/org/eclipse/linuxtools/ctf/core/tests/shared/CtfTestTrace.java
lttng/org.eclipse.linuxtools.ctf.core.tests/traces/.gitignore
lttng/org.eclipse.linuxtools.ctf.core.tests/traces/get-traces.xml
lttng/org.eclipse.linuxtools.tmf.core.tests/shared/org/eclipse/linuxtools/tmf/core/tests/shared/CtfTmfTestTrace.java
Change-Id: Id7e995409cfeace1407abea1bd7c3c81f758ef22
Alexandre Montplaisir [Mon, 18 Nov 2013 22:14:16 +0000 (17:14 -0500)]
Merge commit '
2c789b58062b5bf3bb16ca1654ccf9cf87f3c444' into lttng-luna
Conflicts:
lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/types/EnumDefinition.java
lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/types/FloatDefinition.java
lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/types/IntegerDefinition.java
lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/types/StringDefinition.java
lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/types/StructDefinition.java
Change-Id: I1f0ffe6e8f8546aa1e0a6b850841558d57eb766b
Alexandre Montplaisir [Sun, 17 Nov 2013 05:09:46 +0000 (00:09 -0500)]
ctf: Simplify position arithmetic in aligned reads
Thanks to Étienne Bergeron for this suggestion.
Change-Id: Ib8617651e797afa806b4997828f6ba7e392e8165
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/18466
Alexandre Montplaisir [Sun, 17 Nov 2013 18:28:14 +0000 (13:28 -0500)]
ctf: Move CTF-testsuite tests to a separate file
Change-Id: I0ebbe99f577430c16388ee6619d7a4d3a98044ae
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/18478
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Fri, 1 Nov 2013 19:06:45 +0000 (15:06 -0400)]
tmf: Import and Export trace package user guide
Change-Id: Ib9b56867257434db0afcb8c53e8969a1d6729d19
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18110
Marc-Andre Laperle [Wed, 18 Sep 2013 22:19:26 +0000 (18:19 -0400)]
tmf: Import and Export trace package
Import and export files, bookmarks, supplementary files for a
single trace as an archive (tar, tar.gz or zip)
Change-Id: I71f5f104b2c552a5dbb2721fbdde9b069dd1a306
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/17666
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Etienne Bergeron [Sat, 16 Nov 2013 02:57:08 +0000 (21:57 -0500)]
Fix invalid cast which break trace files bigger than 2 gig.
The min operation received a value which can be negative after the cast.
(Values bigger then 2^31). Thus, the trace files has one chance on two to open.
Change-Id: Id97578f430af8336bab9d863f575f46ed7f54adc
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18456
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Etienne Bergeron [Fri, 15 Nov 2013 05:56:20 +0000 (00:56 -0500)]
Fix coding style in TmfVirtualTable.
Fixing some nits I've found while reading this file.
Mostly no behavior changed, except shortcut a loop and removing a useless test.
Change-Id: Iaa2db0f7fc6cf72a3b87b0f67763a4dbf073cf57
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18454
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Wed, 16 Oct 2013 23:18:56 +0000 (19:18 -0400)]
ctf: Add advanced trace tests
Using a more exotic test trace.
I'm not exactly sure why a string field ends up in-between the variant
selector and its value, but this is how they are printed by Babeltrace,
so I assume we're doing the right thing.
Change-Id: I4bd0f35d31a7c592fafd64b3321f182f9de71c79
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/17550
Matthew Khouzam [Thu, 17 Oct 2013 15:37:15 +0000 (11:37 -0400)]
tmf: update batch import wizard to show file sizes
Change-Id: I970c569860f81a2bd33a3ab227aa7ff3db2679b8
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/17690
Tested-by: Hudson CI
Matthew Khouzam [Fri, 4 Oct 2013 20:39:44 +0000 (16:39 -0400)]
ctf: add synthetic LTTng kernel trace
This will allow us to have much more control over testing the parser
and it allows scalability testing too.
Change-Id: I433709dafab8fd5c8d412cb9b4b632ade03f18a9
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/17050
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Marc-Andre Laperle [Mon, 18 Nov 2013 06:38:51 +0000 (01:38 -0500)]
lttng: Bump the target definition sequence number because of RSE change
The sequence number needs to be changed so that PDE reloads the target
definition properly in certain cases. In Eclipse 4.4 it can lead to
non-obvious
errors, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=420322
Change-Id: I8fac34ba6c0edc3d3f243d70ec8b76bc6ddab9e9
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/18483
Alexandre Montplaisir [Mon, 18 Nov 2013 04:03:50 +0000 (23:03 -0500)]
Merge commit '
e1de8d2d152352eded708615a967021db7800709' into lttng-luna
Conflicts:
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/Messages.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/messages.properties
Change-Id: I542be9c92e142114af14796545097c44c8962360
Alexandre Montplaisir [Fri, 15 Nov 2013 23:45:51 +0000 (18:45 -0500)]
tmf: Add a debugging test Suite
When a test suite is run with the new DebugSuite runner, the name
of every test being run will be printed to stdout. It's not used
by default, but it can be manually switched to. This can help debug
unit tests, especially when run from Maven.
Change-Id: I5b3ca8a0a0f7867977500e5b3a280c46d702672c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/18464
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Tue, 29 Oct 2013 22:35:33 +0000 (18:35 -0400)]
tmf: Add function name mapping to the Callstack View
Initial version of the "function name mapper" for the Callstack View.
It currently only supports a text file listing addresses followed by
names, like the output of "nm [binary] > out.txt".
The next steps will be:
- Add support for reading the binary directly, by tapping into the
relevant CDT components.
- Add a separate dialog that shows the currently imported file name(s).
- Add support for dynamically-loaded libraries. This will require some
work on the tracer side.
Change-Id: Id622cce487965b8c770fc40218685ec7605924ff
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/17978
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Etienne Bergeron [Sat, 9 Nov 2013 03:59:35 +0000 (22:59 -0500)]
Avoid calling reverse on a list.
Change-Id: I3f3b17ea4372ef5db64b20f9c267d606ded8101a
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18452
Reviewed-by: François Doray <fdoray.eclipse@gmail.com>
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Matthew Khouzam [Wed, 6 Nov 2013 22:01:26 +0000 (17:01 -0500)]
ctf: Move non-aligned reads to a unified method
* Clean up integer reading
* Clean up string reading
* Clean up enumeration reading
* Clean up float reading
* Clean up structure reading
Change-Id: I3627f0c1aaecbaa84d861cba05c0681a7b267388
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/17465
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
This page took 0.049115 seconds and 5 git commands to generate.