Bernd Hufmann [Fri, 19 Aug 2016 15:11:45 +0000 (11:11 -0400)]
flamegraph: remove signal handler for selection range updated
This signal is not applicable for flamegraphs
Change-Id: I283cd9ee1a542a376090e55ccd338c6ebd7e5b50
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/79369
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Geneviève Bastien [Tue, 9 Aug 2016 20:14:35 +0000 (16:14 -0400)]
xml: bug 497272 Populate views from built-in XML files
This patch makes sure that outputs defined in built-in XML files
advertised through the extension point are added under their analyses.
It moves the method to list the built-in files from the analysis module
source to the XmlUtils class and adds a unit test for this use case.
Change-Id: I5984d1cc9adbbc7e6348632c0f58390f73db41bd
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/78723
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Sonia Farrah [Tue, 2 Aug 2016 18:10:00 +0000 (14:10 -0400)]
timing : Add Tests for the aggregation tree
This tests the aggregation tree created by the callGraphAnalysis.
Change-Id: I558086efda9f38efa9bccf31a84759e9a44bb3d7
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78346
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Sonia Farrah [Fri, 12 Aug 2016 14:17:28 +0000 (10:17 -0400)]
Timing: Change the order of statistics in the Flame graph
The statistics in the time event's tool tip will be shown this way:
Durations:
Average
Std dev
Max
Min
Self times:
Average
Std dev
Max
Min
Change-Id: I029fb92e4c96d7c79a44302c4c902bedc9c040a0
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78956
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Geneviève Bastien [Fri, 22 Jul 2016 19:52:24 +0000 (15:52 -0400)]
xml: bug 497959 add the possibility to update the current state
This adds an 'update' attribute to state values, such that it uses the
updateOngoingState method of the state system to change the value of the
current state instead of modifying it.
Change-Id: I44b80c1801b9dbbb4f858ba7e3c05434d84f9003
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77797
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Bruno Roy [Mon, 8 Aug 2016 19:32:59 +0000 (15:32 -0400)]
lttng.control: Fix enabling logger by specifying the name
If a user enters a specific logger name to be enabled, we should not
enable all loggers. With the original code, if there was not a logging
application running the fIsAllLoggers flag would evaluate true, even if
the user entered a specific name in the text field (which I don't think
is the desired behavior).
Change-Id: Iab37f45dedba82b2c0d420432488e7fd7c770511
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78641
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Fri, 5 Aug 2016 18:52:15 +0000 (14:52 -0400)]
tmf: Bug 499251: Call Stack view double-click listener no longer works
The Call Stack view's time graph double-click listener is fixed to
handle the updated structured selection's content.
The class TimeGraphSelection is deprecated.
The spacing ratio added around the call stack event's range is removed.
Change-Id: I81d40aea54cd74b469cbcf3e119fde2db3b3b38f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/78566
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Sonia Farrah [Mon, 8 Aug 2016 13:56:49 +0000 (09:56 -0400)]
timing: Add tests for statistics of the aggregation tree
This tests the statistics of each node of the aggregation tree returned
by the CallGraphAnalysis.
Change-Id: I93150fd4f57721eb9013fc94e2fff4d9f8c2a436
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78713
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Thu, 21 Jul 2016 15:28:57 +0000 (11:28 -0400)]
Update targets with CDT 9.0.1
CDT 9.0.1 was released last Friday.
Change-Id: I93b93bb36fd7c17480042ea02d2b06e7d0250177
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77694
Reviewed-by: Hudson CI
Gabriel-Andrew Pollo-Guilbert [Mon, 11 Jul 2016 16:19:43 +0000 (12:19 -0400)]
custom charts: Add factory constructor for charts
This patch adds the factory constructor for making
any type of charts.
Change-Id: I9f82bc65c2d9b13ab52bf0494fd27e550d1e96a8
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77158
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Gabriel-Andrew Pollo-Guilbert [Tue, 26 Jul 2016 18:49:10 +0000 (14:49 -0400)]
custom charts: Add interfaces for computing data
This patch adds three interfaces that are used for
consuming objects in the source of the data provider.
An object is first consumed by a chart consumer. This
first consumer sends the object to all of its series
consumers. Then, each series consumer passes the
object to individual data consumer.
While this may seems a lot, it is rather simple and
it allows going to the stream of data only once. It
also provides flexible data computing as well as
reusing code for different charts.
Change-Id: Ife9f321fa840cde6f499a09094ec996d6bf669f2
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Reviewed-on: https://git.eclipse.org/r/78011
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Bruno Roy [Thu, 11 Aug 2016 17:53:58 +0000 (13:53 -0400)]
lttng.control: Document and test the Python domain in the Control view
Add the documentation and tests for enabling loggers of the Python
domain in the Control view.
Change-Id: I703927c048c2f850a7c441643e724025fec4e916
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78891
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bruno Roy [Fri, 5 Aug 2016 18:26:13 +0000 (14:26 -0400)]
lttng.control: Document and test the LOG4J domain in the Control View
Add the documentation and tests for enabling loggers of the LOG4J domain
in the Control view.
Change-Id: Ib7cf63f7761dd3214cf25632e5e93d12f49d0f6f
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78631
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bruno Roy [Wed, 3 Aug 2016 13:28:59 +0000 (09:28 -0400)]
lttng.control: Adding support for the Python domain in the Control view
Adding the controls for the Python loggers in the Control view. Also
implemented the visualization of those loggers in the Control view.
Change-Id: I59d877e60fc0c9afbd5211e219faa6ba67b8af73
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78506
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bruno Roy [Thu, 11 Aug 2016 19:16:59 +0000 (15:16 -0400)]
lttng.control: Remove class that is no longer used
The EnableJulEventsComposite is no longer used since the introduction of
EnalbeLoggersComposite in patch 77796.
Change-Id: Ib7c4a336e40d0f9133eef3c6d3df5d3d12bb5219
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78896
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Wed, 10 Aug 2016 19:10:21 +0000 (15:10 -0400)]
timing: bug 499516 Make internal timing.ui packages internal
Change-Id: Ibc8bd6a69305666a2cd09c72f9f482b06d2eb0f8
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/78800
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Thu, 11 Aug 2016 19:44:07 +0000 (15:44 -0400)]
releng: Add orbit dependencies to update site
So that we have all dependencies that we need for the simrel build.
The Orbit update site is not used in this build so we need to provide
our own dependencies.
Change-Id: I255964df42b02f68612f474a725b0a5778c65b44
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78898
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Gabriel-Andrew Pollo-Guilbert [Mon, 11 Jul 2016 16:11:56 +0000 (12:11 -0400)]
custom charts: Add formatter for the charts
This patch adds some formatter used in the chart.
All of them comes from *.lami.* packages, but with
some modifications to work with our interfaces.
Change-Id: I57ac9edffdd39792e787ead5c15838b3888c920d
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77157
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Gabriel-Andrew Pollo-Guilbert [Wed, 27 Jul 2016 14:04:16 +0000 (10:04 -0400)]
custom charts: Add classes for describing a chart
The patch adds a chart data class that contains the
information about which series to plot. The chart
model class contains information about the chart (e.g.
chart type, logscale, etc).
Change-Id: I831bf4d695c52230dd5c9a2c20a4c226d95e32c0
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Reviewed-on: https://git.eclipse.org/r/76910
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Gabriel-Andrew Pollo-Guilbert [Wed, 6 Jul 2016 15:32:27 +0000 (11:32 -0400)]
custom charts: Add core classes
A data provider provides all the informations needed to obtain
data in order to make a chart. It has a source that can be of any
object and a list of data descriptors that can map specific values
from a object.
In order to make a chart from the plugin, an analysis must
implement a data provider and create a data descriptor for each
data stream that can be used for plotting. Other patches will be
coming as examples.
Change-Id: Ic93982ffd92f2eb582f9ad120ec9ba7fe87d2a7a
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Reviewed-on: https://git.eclipse.org/r/76730
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Matthew Khouzam [Wed, 10 Aug 2016 21:45:23 +0000 (17:45 -0400)]
tmf.ui: make Comparator in Symbol Manager use the correct size.
Now compares integers as the priority is an integer.
Change-Id: I8bddbc8ff46cef34a7e12ee2bde69776a01226a8
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78810
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Sonia Farrah [Thu, 4 Aug 2016 21:01:14 +0000 (17:01 -0400)]
timing: Add statistics for time events in the flame graph view
This will show users the statistics for each aggregated function in the
flame graph view.
The statistics are shown in the tooltip of each time event ( aggregated
function).
This shows the maximum/minimum duration,maximum/minimum self time,number
of calls, deviation and the average duration of each function.
Change-Id: I0d4c2f4da12a334d76d5173f68397f5f1e7abadf
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78500
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Tue, 2 Aug 2016 15:27:05 +0000 (11:27 -0400)]
lttng: Update LTTng event matching to use event layout
This removes the netif_receive_skb and net_dev_queue from the TcpEventStrings
and makes use of the layout in the TcpLttngEventMatching class.
Change-Id: I2b168114228a79195c088430baf75a64f07c2698
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/78333
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Matthew Khouzam [Wed, 10 Aug 2016 13:47:14 +0000 (09:47 -0400)]
tmf.ui: fix potential priority inversion in symbol providers.
It is a common practice to set a priorty of -Long.MIN_VALUE to an item to
make sure it is last. With the current implementation, it will always be
first, appearing before even Long.MAX_VALUE.
This patch fixes that issue.
Also, the constructor could fail out with an exception in several paths.
Now this is done by the factory method. This avoids having partial
objects in the heap which can be a security issue.
Change-Id: I392205a0b1a0557c168a2ae547b57915ee57f6f3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78758
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI
Alexandre Montplaisir [Wed, 10 Aug 2016 19:00:08 +0000 (15:00 -0400)]
tmf.chart: Link plugins to the external annotations
These plugins were not making use of our external annotations at all!
Change-Id: I10bf42080deb1b11eda7cd6a1f939124c15036fa
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/78798
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Sonia Farrah [Tue, 5 Jul 2016 18:39:55 +0000 (14:39 -0400)]
timing: Add Flame Graph View
The Call Graph analysis creates an aggregation tree for the call stack
view. The functions in the tree are aggregated by address and caller.
The tree nodes have links to their children and parents.
This tree is used to fill a flame graph view.
The Flame Graph is used to analyze the function call durations in a more
aggregated manner. This will show users which function call is consuming
the most time and what call chain is consuming the most time.
Change-Id: I4da99847ecef1e5246be27a2719957a568c8cae6
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76636
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Mon, 30 May 2016 03:05:57 +0000 (23:05 -0400)]
tmf.ui: Use a job for the time graph view's build thread
This allows swtbot's waitForJobs to wait for the build thread to complete.
It also prevents from having to instanciate a monitor.
Change-Id: Idbb5031b0343ba44e39ff6a1ba0f06b2e764a6de
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/75279
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Geneviève Bastien [Thu, 28 Jul 2016 14:49:38 +0000 (10:49 -0400)]
linux/lttng: Fix return type and names of layout's network events
All new events added to the layout should return a Collection instead of a
single string. This patch updates the network event's signature
Change-Id: I978f760d6f72714467511f3c58c7a9f3a134830d
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/78070
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Bruno Roy [Tue, 26 Jul 2016 14:12:17 +0000 (10:12 -0400)]
lttng.control: Document and test the JUL domain in the Control view
Add the documentation and tests for enable loggers of the JUL domain in
the Control view.
Change-Id: Idad308ed06ced482bda4aff1e2da2156b937095d
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78280
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bruno Roy [Tue, 2 Aug 2016 18:58:41 +0000 (14:58 -0400)]
lttng.control: Add a text field for enabling specific logger by name
Add a text field in the "Enable Events" dialog under the JUL and LOG4J
domain to be able to enable logger(s) by entering names in a comma
separated list format.
Change-Id: Ife28b08b14d4ffb30a7fc5adaed370da8063bc5f
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78349
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Thu, 4 Aug 2016 19:50:24 +0000 (15:50 -0400)]
statesystem: Fix a typo in test
Change-Id: Ib7038337f81c3c838e4684d0c060b7e0f4601a81
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78490
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bruno Roy [Wed, 20 Jul 2016 18:49:59 +0000 (14:49 -0400)]
lttng.control: Adding support for the LOG4J domain in the Control view
Adding the controls for the org.apache.log4j (LOG4J) loggers in the
Control view. Also implemented the visualization of those loggers in the
Control view.
Change-Id: Ia73bab1279ea4cc72527e8bee96d16d39aab9745
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77796
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Philippe Proulx [Wed, 1 Jun 2016 21:54:10 +0000 (17:54 -0400)]
analysis.lami: Do not validate extra arguments (anything is valid)
Change-Id: I744eb779d246e778fdb7a1f59ea07babf05c354c
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74336
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Philippe Proulx [Wed, 1 Jun 2016 21:54:10 +0000 (17:54 -0400)]
analysis.lami: use ShellUtils in execute() to split arguments
Change-Id: Ice0c0ef04794b0299537e4b007ee5ad474e2b404
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74335
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Philippe Proulx [Wed, 1 Jun 2016 21:54:10 +0000 (17:54 -0400)]
analysis.lami: check if command is executable, and support relative paths
This patch makes LamiAnalysis check if a given executable name
is indeed executable, not just existing.
It also adds support for relative paths. For example, if your
current working directory is /tmp/hello, and there's an analysis
at /tmp/hello/my-analysis, then creating a custom external
analysis starting with `./my-analysis` finds the executable
file/link.
Change-Id: I7a6ba4bbd95a9c190296c07f0f04c87aca2ecf34
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74334
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Philippe Proulx [Wed, 1 Jun 2016 21:54:10 +0000 (17:54 -0400)]
analysis.lami: support LAMI 1.0 data objects
This patch adds support for the LAMI 1.0 protocol in the data
object layer, keeping backward compatibility with the pre-1.0
LAMI (parsing behaviour before this patch).
The main differences between LAMI pre-1.0 and 1.0 are:
* Integer and number classes are merged as the number class
* Number objects can have low and high bounds of uncertainty
* The ratio, timestamp, duration, size, and bitrate objects
inherit the number object (i.e. they can all have a
range of values in which it is guaranteed that the real
value falls)
* The time range object is a composition of two timestamp objects
* There are no more "loose" JSON values in the cells of
result tables: all the data objects are JSON objects with
a class property
Change-Id: I728503672648a2be6c6a9310c29a49c209110f86
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74333
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Wed, 3 Aug 2016 17:37:57 +0000 (13:37 -0400)]
tmf.ui: move optimization algorithm out into its own file.
This also adds a bit more javadoc explaining how the algorithm works.
Change-Id: I74f5bdb163e7cfa1aee7181a9b3a4b30c0cc86d7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78399
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Tue, 26 Jul 2016 03:00:33 +0000 (23:00 -0400)]
linux.ui: simplify optimizer with multiset
Replace the patterns of getx, put(x+1) with a multiset.
Replace large stream operation with simple built-in function.
Change-Id: I2697de79929ffcc4998cac8ed220c549fc577fbf
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77874
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Patrick Tasse [Wed, 3 Aug 2016 18:22:03 +0000 (14:22 -0400)]
timing: Fix CallGraphAnalysisTest
Change-Id: I6ff6bf31d8a96000d9808ca5afbf0929b40c7f97
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/78400
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Tue, 26 Jul 2016 13:46:25 +0000 (09:46 -0400)]
linux.ui: Add tests for control flow view optimizer
This test suite is overridable and defines the contract
of the optimizer function.
Change-Id: I7bfa6b9c18c64620a9663b8c663b5f5bb4b0bd1c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77909
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Sonia Farrah [Wed, 27 Jul 2016 22:03:20 +0000 (18:03 -0400)]
Timing: Fix call stack state value bug in CallGraphAnalysis
The CallGraphAnalysis works only if the state value is a long.
Now it'll work if the state value is a long,integer or a string.
Change-Id: I119f47bd7c81d3c8ede6253bae1f8712aba2229d
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78026
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Mon, 25 Jul 2016 22:10:46 +0000 (18:10 -0400)]
linux.ui: extract control flow view optimizer
The control flow view optimizer algorithm is now extracted into
a Function<>, this allows for better testing of the code and
improves modularity.
To change the optimizer behaviour, one needs to override the
getUpdatedSchedulingColumn() function to return another algorithm.
Consider ILinkEvents to be edges in a graph where the vertices are
the entries.
Change-Id: I2a8cb686e2c31589873006d1fca2f489ad724b33
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77871
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Bruno Roy [Mon, 1 Aug 2016 20:59:55 +0000 (16:59 -0400)]
lttng.control: Remove "exclusions" node in the pre MI 3 test config file
The "exclusions" node what introduced in the third version of the MI,
before that only "<exclusion>true</exclusion>" was available. There is a
separated file for the third version of the MI
(LTTngServiceMi3Test.cfg).
Change-Id: I9df6100ef2de816fb2a88678c1fc5f12ca01298a
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78281
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bruno Roy [Mon, 4 Jul 2016 19:29:40 +0000 (15:29 -0400)]
lttng.control: Bug 486658: Improve the enable event handler
With the right-click enable event in the Control view, it is now
possible to enable/disable the same event with different loglevels
(having a single event enabled multiple times with different loglevels).
It is also possible to enable disabled kernel dynamic probe and function
probe.
Change-Id: I35194310b2332f3c4f74084f8189c3325729bad7
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76547
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Bruno Roy [Fri, 8 Jul 2016 13:19:38 +0000 (09:19 -0400)]
lttng.control: Add support for enabling syscall by name
Add a tree in the Enable Event dialog for enabling System call event.
Also update tests and documentation concerning this feature.
Change-Id: I7ddbdc2e33b4bcc782d1eb45598252e04c6cd486
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76972
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Mon, 1 Aug 2016 14:41:23 +0000 (10:41 -0400)]
lttng: Bug 498066: Update test file to verify bug fix
Change-Id: I07e3600503982cda35d241182161a762cce0496f
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78269
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Loïc Prieur-Drevon [Mon, 1 Aug 2016 14:28:22 +0000 (10:28 -0400)]
ss: Replace hard-coded sizes by their types' sizes
Change-Id: Iefbafd41654a2dbead75333cbd34bf45022a405d
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Reviewed-on: https://git.eclipse.org/r/78267
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Abder Benbachir [Tue, 26 Jul 2016 21:42:58 +0000 (17:42 -0400)]
lttng: bug 498529, use event layout in VM analysis
Change-Id: Id29c600d4345e5d66a46a2551ad85cec6f985cf8
Signed-off-by: Abder Benbachir <anis.benbachir@gmail.com>
Reviewed-on: https://git.eclipse.org/r/78000
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Abder Benbachir [Tue, 26 Jul 2016 20:10:02 +0000 (16:10 -0400)]
lttng: override kvm events for LTTng27
kvm event have been changed in the lttng-modules 2.7
due to naming clash.
Those events were hardcoced in the VM Analysis,
now it will be possible for the analysis to use
layout.
Change-Id: I9e23b43111479066a5035a94c03ea53f9740247c
Signed-off-by: Abder Benbachir <anis.benbachir@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77999
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Abder Benbachir [Tue, 26 Jul 2016 19:57:21 +0000 (15:57 -0400)]
linux.core: add kvm entry/exit events to IKernelAnalysisEventLayout
Change-Id: I2d0242a150e2c0eb78bce2eac91d3d4e3c8a6fd4
Signed-off-by: Abder Benbachir <anis.benbachir@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77998
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Bruno Roy [Thu, 30 Jun 2016 16:32:13 +0000 (12:32 -0400)]
lttng.control: Improve the enable logger handler
With the right-click enable logger in the Control view, it is now
possible to enable/disable the same logger with different loglevels
(having a single logger enabled multiple times with different
loglevels). Before, there was a command error because the loggers had
the same name.
Also added a work-around for an LTTng bug with the enabling and
disabling of JUL events. The bug is now fixed, and will probably be in
LTTng 2.8.1.
Change-Id: If7e5107846a2495d7835e8d1d6e0d22462a786c3
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76360
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Thu, 28 Jul 2016 21:56:31 +0000 (17:56 -0400)]
common.core: move saturated math to common core
As overflow problems are more and more common, it is justified
to make saturated (clamped) math available to all packages.
Test coverage is 100%, the code has to be rigourously tested as
this is part of the base of trace compass now.
Change-Id: Icf9771162230b8ff0371015ed0f39cc5ff07a06f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78107
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Fri, 15 Jul 2016 19:33:27 +0000 (15:33 -0400)]
tmf: Support dynamic marker event sources
The signal TmfMarkerEventSourceUpdatedSignal is added to notify
components that a marker event source has changed and that markers and
marker categories need to be refreshed.
The zoom threads in abstract time graph views are changed to update the
marker categories along with the marker lists, to ensure they match.
Change-Id: I2c6fb2443a474d01d9d37ae5b6b8fc13a1ee7457
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77415
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 27 Jul 2016 19:15:47 +0000 (15:15 -0400)]
tmf.ui: add second unit to timegraph scale
This adds seconds in the time units to make it clear what unit
the time is in.
Change-Id: Ide467c2e1738c6e2f8aadbe7e06e64a15d2ae71b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78016
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Thu, 28 Jul 2016 20:03:41 +0000 (16:03 -0400)]
doc: update documentation to reflect preserved aspect of the events editor
Show the user the changes in saving the state of the events editor.
Change-Id: I6442ac1074238b2916c0903481bc2fddd1586f43
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78095
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Thu, 28 Jul 2016 20:56:44 +0000 (16:56 -0400)]
tmf: Change getTracesToBuild trace parameter to be @Nullable
The default implementation already handles a null trace, and
VirtualMachineView overrides it as @Nullable.
This allows subclasses to call the method with the return value of
getTrace(), which can be null, without needing a null check and get an
empty list back.
Change-Id: Ie7cb5c79bb841796be4e20fcafedb43ad8b2c839
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/78104
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Sonia Farrah [Wed, 20 Jul 2016 20:53:44 +0000 (16:53 -0400)]
timing: Add Tests for the callStack segment store
This tests the segment store created by the callGraphAnalysis
Change-Id: I4b5d71be752653d4bd5ee49640e0591531336a64
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77636
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Bruno Roy [Wed, 8 Jun 2016 14:02:21 +0000 (10:02 -0400)]
lttng.control : Adding support for the JUL domain in the Control view
Adding the controls for the java.util.logging (JUL) loggers in the
Control view. Also implemented the visualization of those loggers in the
Control view.
Change-Id: I6ee97902eb166fa251415df21ec26a3e5d85049b
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75428
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Sonia Farrah [Fri, 22 Jul 2016 15:05:12 +0000 (11:05 -0400)]
Change warnings to errors in build.properties
Missing entries in those files result in build failures so they should
be reported as errors.
Change-Id: Ib8df4c9baf062e9eadcdd6b9593abfd7aef38fc0
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77784
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Tue, 26 Jul 2016 19:58:38 +0000 (15:58 -0400)]
tmf: Do not persist width of auto-expanded last event table column
Change-Id: I9a9e7e1ab72d8bf443590df4a7b1bb252fd5a472
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77933
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Wed, 27 Jul 2016 17:29:34 +0000 (13:29 -0400)]
lttng: Add a lttng 2.9 event layout and update network events/fields
Change-Id: Idc388cad9f9117ed2f0b4c4b1f7450c2c296fb05
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/78007
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Geneviève Bastien [Wed, 27 Jul 2016 14:00:37 +0000 (10:00 -0400)]
xml: Fix behavior of time graph view for experiment analyses
Reverts part of commit
f3dac92a8f96850f47c1be3279cdab71b8857b65 which was
reverting another commit
When an XML analysis is for an experiment, the time graph view remains empty
because the view is never built with the experiment, only with its children
Change-Id: Ib3d12fc6765cdd66a5846950b032240e1add7496
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77984
Reviewed-by: Hudson CI
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Matthew Khouzam [Wed, 20 Jul 2016 15:06:54 +0000 (11:06 -0400)]
tmf.ui: add test for persisting column hiding.
This tests that hiding a column is preserved from one open to the next.
Change-Id: I22aded548ccc5c8841acae0eb175182145096c05
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77611
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Thu, 30 Jun 2016 22:11:54 +0000 (18:11 -0400)]
tmf.ui: make table columns persist their size and visibility
This allows the configuration to remain after closing and
re-opening a given trace.
Change-Id: I93dd11e8ccc5c8bf5078a95b45e47fc02b74a99c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76395
Reviewed-by: Hudson CI
Patrick Tasse [Mon, 25 Jul 2016 19:25:03 +0000 (15:25 -0400)]
tmf: Update tests for default timestamp output format in custom parsers
Change-Id: I188c68511a38364ba31b50645bebb125243bed22
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77865
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Mon, 25 Jul 2016 17:22:27 +0000 (13:22 -0400)]
tmf: Update unit tests for custom event type by text line or XML element
Change-Id: Ie97c63b72dcc5b9483b9f25faa1c5a51c54400e7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77859
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Mon, 11 Jul 2016 23:30:08 +0000 (19:30 -0400)]
lttng: Fix ControlFlowViewTest on Mac
Going to the top of a tree is Option-Up instead of Home. Use the new
SWTBotUtils method.
Change-Id: I77a5d88b84d529c6ae0bf3739ae5eed19438a974
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77105
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Mon, 18 Jul 2016 21:17:24 +0000 (17:17 -0400)]
tmf: Remove function name from ITmfCallsite
It just so happens today that the UST Debug-info analysis makes
use of addr2line to retrieve the source code location AND the
function names, but those two are completely separate concepts.
Since "function name" is not relevant for source lookup, it
should be removed from the concept of what is a call site.
ISymbolProvider should be the sole provider of function names,
especially now that it has been decoupled from ITmfCallsite.
While at it, add a new version of #getLineNumber() which returns
a "@Nullable Long", since it's very possible for callsites to
have a file name but no line number available.
Change-Id: I9b7407876166d9cc1e174804145937388306137d
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/77554
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bruno Roy [Thu, 30 Jun 2016 21:42:31 +0000 (17:42 -0400)]
lttng.control: Improve regular expression recognition for pre-MI LTTng
Changed the regular expression matcher that detects if a session has
exclusions and is using a filter.There was some weird behavior when
those two things were enabled at the same time.
Also updated some tests to make sure the functionality works properly.
Change-Id: I407b6ad9b701e593a963e67c52dcc90eb7f185a9
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76393
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bruno Roy [Thu, 14 Jul 2016 20:44:57 +0000 (16:44 -0400)]
lttng.control: Add filtering to the Control view
There is now a FilteredTree that is using the TreeView. It is now
possible to filter the Control view tree.
Change-Id: I75a0af123623658d2407c3a6b63b8972a758f74e
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77349
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Fri, 22 Jul 2016 21:23:34 +0000 (17:23 -0400)]
linux.core: Add network events and fields to the kernel layout
Event matching definitions can then make use of those events and fields
Change-Id: I0a71de243f74519241ebd2eebbb8ea5a7313bd35
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77799
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Marc-Andre Laperle [Fri, 22 Jul 2016 21:41:07 +0000 (17:41 -0400)]
tmf: Fix PatternScatterChartViewTest intermittent failure
It is possible that the test tries to open the scatter chart view
before it's actually available under the Project Explorer. This is
because the trace hasn't fully opened and the analysis outputs haven't
been determined yet.
To reproduce the issue, go to TmfOpenTraceHelper.openTraceFromElement
and add Thread.sleep(5000) right before the asyncExec call. The test
should fail with:
WidgetNotFoundException:Could not find node with text: Latency vs Time
The fix is to wait until tree nodes are available in the tree before
proceeding. The tree util methods have been augmented to handle using
a tree item as the root to find other items from. It will also now
wait before children items are present before expanding, this is to
cover the case where children are not yet created.
Change-Id: Ib9070b20effb8e409d69f70513500ea5ff478778
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77800
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Matthew Khouzam [Fri, 22 Jul 2016 14:29:51 +0000 (10:29 -0400)]
lttng.kernel: remove getX86IrqVectorsEntry/Exit
Use getIPIIrqVectorsEntry/Exit instead. This solves the downcast issues
in BaseHandler.
Change-Id: I362712eb4e38d661d5f3066e15f5046a5de749aa
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77782
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Matthew Khouzam [Thu, 21 Jul 2016 20:53:21 +0000 (16:53 -0400)]
linux.core: Support IPIs in kernel analysis (Bug 498215)
Interprocessor interrupts (IPIs) are special types of interrupts by
which one processor will interrupt another in a multi-core system. They
are typically used for
* cache flushes
* shutdowns
They are not logged with standard events, but rather events looking like
"x86_irq_vectors_thermal_apic_exit".
This patch makes them register as IRQs (which they are) in the control
flow view and resources view.
Change-Id: I5380b6bc2d18f2ee98f7675eb1918794a78a71b3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77731
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Tested-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Loïc Prieur-Drevon [Fri, 6 May 2016 20:16:03 +0000 (16:16 -0400)]
ss: Improve attribute tree encoding to disk
The attribute tree used to be encoded as a list of full attribute
paths.
This patch improves the encoding by replacing common subpaths from
one attribute to the next by "*".
For example, if the previous attribute was "Threads/42/Status", and the
current attribute is "Threads/42/Prio", we encode the current
attribute as "*/*/Prio".
On common Kernel Analysis State Systems, the Attribute Tree is 1 MiB
per 50k attributes, with this patch the Attribute Tree size on disk
is reduced by 75%.
Change-Id: I53b119eba760c10b720e9a3c173ed2996c02c2a2
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72213
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Marc-Andre Laperle [Mon, 25 Jul 2016 04:34:26 +0000 (00:34 -0400)]
releng: Update outdated Maven plugins
Change-Id: Ibe9af7134d99c788e9466371714c2650ddded277
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77825
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Sonia Farrah [Thu, 30 Jun 2016 15:25:56 +0000 (11:25 -0400)]
timing: show callStack segments in a density view
This creates a segment store for the callstack view and populates it.
Then the segments are used to fill a density view.
The segments are special segments with links to their children. This
effectively is a callgraph that can then be used for other analyses.
Examples of these analyses are:
* Flame graphs
* Tree maps
* Caller trees
* Call statistcs
These views will allow trace compass to work better as a profiler
on an application level.
Change-Id: I0a1e8eda192e0646dd02bc4134c672a392231208
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76369
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Geneviève Bastien [Mon, 11 Jul 2016 01:31:07 +0000 (21:31 -0400)]
ss: Use a factory to create SHTs
This is a first step to allow different history tree types to coexist in this
plugin.
Change-Id: I411d2a1a6de06258d98090ce418eeb24e80303a1
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/77006
Reviewed-by: Hudson CI
Geneviève Bastien [Mon, 18 Apr 2016 16:25:31 +0000 (12:25 -0400)]
ss: Add a unit tests for history tree integrity check
Change-Id: I38f18b243925a711a472636daf78e16f965c4588
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/70891
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI
Alexandre Montplaisir [Thu, 21 Jul 2016 20:43:29 +0000 (16:43 -0400)]
ss: Mark HistoryTreeBackend#getSHT() to be @NonNull
Was already taken for granted, just not explicitly annotated.
Change-Id: Ib0ea170583da6a08c8c27d9cfae327735341117c
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/77728
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Geneviève Bastien [Tue, 12 Jul 2016 19:47:28 +0000 (15:47 -0400)]
ctf: Add a constant to get the currently selected field for variant types
Variants typically have only 1 struct fields per choice and its name is the
tag. Many possible choices may have the same fields in the struct so it should
be possible to use one lookup to check in every possible choice. This patch
adds a constant to use to get the currently selected field no matter its name.
Use case for this: network packets in LTTng traces have a network_header
variant field that contains a transport_header variant field. But the various
network_header choices have the same transport_header field. We want to be
able to query the { network_header, ANY, transport_header } field and not, as
previously { network_header, ipv4, transport_header } or { network_header,
ipv6, transport_header }.
Change-Id: I74b1e0494a43eae9a9f91dca575d5419f3907168
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77172
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Wed, 20 Jul 2016 23:54:19 +0000 (19:54 -0400)]
tmf.core/ui: Introduce CallStackAnalysis
This class moves the core of the call stack to tmf.core. It
decouples core logic from UI.
Change-Id: I3d393a9663a4d79817d1867f4759bdb1df2ccfed
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77643
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Alexandre Montplaisir [Mon, 18 Jul 2016 19:02:36 +0000 (15:02 -0400)]
tmf: Remove ITmfCallsite from ISymbolProvider
We should let ISymbolProvider focus on function/symbol names,
and use a separate interface for source code locations.
Change-Id: Iab4bbe0945f8ab1f633eadb862885a86dccde708
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/77553
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jean-Christian Kouame [Wed, 13 Jul 2016 17:50:03 +0000 (13:50 -0400)]
tmf.xml: Use LinkedHashMap instead of HashMap
The order in which the FSM are declared in the XML is important. Here,
we use a LinkedHashMap instead of a HashMap to conserve this order when
iterating through the FSMs.
Change-Id: I68837e8f8296741f20d1271d92c43b03ef90c986
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77273
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Jean-Christian Kouame [Wed, 13 Jul 2016 17:44:54 +0000 (13:44 -0400)]
tmf.xml: Fix validate event in TmfXmlBasicTransition
Previously, if the user do not specify an event in a transition, the
validation always yields false, which is not true. This patch returns
true instead.
Change-Id: I2ec0afb344c3e4fb51366168cca8ebac6c7cb30f
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77272
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Geneviève Bastien [Tue, 12 Jul 2016 21:23:46 +0000 (17:23 -0400)]
doc: Add user documentation for JUL logging
Change-Id: I44118045ba1bee20f2a0d9964130caf07688e1fd
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77183
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Patrick Tasse [Mon, 18 Jul 2016 19:26:57 +0000 (15:26 -0400)]
tmf: Support default timestamp output format in custom parsers
The timestamp output format can now be left blank to use the default
Time Format preference. In that case the Timestamp base aspect will be
used.
When the default format is used, the Timestamp is no longer stored as a
content field, as it is already stored in the event's timestamp.
Change-Id: I1e6f83ffb35f44be7828e3d25ee43f87fa8a97e1
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77497
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Thu, 26 May 2016 19:11:37 +0000 (15:11 -0400)]
timing: Use sub-second formatter for duration in table viewer
A formatter makes the duration clearer, especially for large durations when
it's hard to figure the number of numbers in the string
Change-Id: I8b71ccc18c905809530df148d63881aced09c916
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/73802
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Tue, 12 Jul 2016 19:29:55 +0000 (15:29 -0400)]
tmf.ui: introduce TmfTableColumnUtils
This class adds more functions and removes it from the API.
TmfTraceColumnManager now calls functions from this internal class. This
allows more functionality to be added without bumping the API version
number.
Change-Id: Id8a53f9cbe1f7b7adb72e59482971efbaaf22599
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76394
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Patrick Tasse [Thu, 7 Jul 2016 15:18:10 +0000 (11:18 -0400)]
doc: Update user guide for custom parser event type
Change-Id: I3910ac6ae754d9fb2981d42956fc028ce8ab2e8d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/76870
Reviewed-by: Hudson CI
Patrick Tasse [Tue, 5 Jul 2016 19:09:37 +0000 (15:09 -0400)]
tmf: Bug 497347: Custom event aspects incorrect in mixed experiments
Change the custom event aspects to use TmfContentFieldAspect with the
field name. In a mixed experiment, fields from different custom trace
types with the same name will be combined in a single aspect.
Use the base aspect for the Event type if specified as a custom parser
output.
Remove the internal column data array in custom event, as its
information is stored in the event content.
Do not store the custom event type name as a content field, as it is
already stored in the custom event type.
Change-Id: Ic8b39672f0b6f27439774262791d249e6ecf24b1
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/76640
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Wed, 29 Jun 2016 20:58:08 +0000 (16:58 -0400)]
tmf: Bug 497038: Custom parser field names conflict with built-in tags
A new Tag enum is added as part of the custom parser definition model.
The 'tag' attribute is added to the XML definition.
For backward compatibility if the 'tag' attribute is not present when
loading a definition from XML, the Tag is determined from the 'name'
attribute.
In the internal payload data map of the custom event, the map's key is
changed from a String to an Object that can either be the Tag, a String,
or an enum constant, to ensure there is no conflict of keys.
If the tag is OTHER, the wizards should ensure that the user-entered
name does not conflict with one of the built-in tag labels.
Change-Id: If9bf65fb32d646cda4f24f28bf41941f1f5c85f6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/76257
Reviewed-by: Hudson CI
Patrick Tasse [Thu, 14 Jul 2016 20:10:39 +0000 (16:10 -0400)]
tmf: Bug 497413: Abstract time graph view JUL logger incorrectly enabled
The time graph view abstract classes are changed to use their own class
when getting the logger so that they are in their own namespace and
inherit the Trace Compass parent logger's log level.
Change-Id: If117f307d8c12e601f26f97c57e6a26ba77311a6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77347
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Matthew Khouzam [Thu, 14 Jul 2016 22:10:35 +0000 (18:10 -0400)]
ctf: fix npe in size() if trace is not inited
This is a race condition that can appear when bulk openning 5-6
ctf traces at onces.
Change-Id: I8f64d373674e6b1b925a43e607763c518f866ccb
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77361
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Mon, 18 Jul 2016 18:19:16 +0000 (14:19 -0400)]
lttng: Bug 498083: Fix sys call entry matching in I/O analysis
Change-Id: I30bf823530b8613f2db58e4e1bd4a8550b76bf4f
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77485
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Bernd Hufmann [Mon, 18 Jul 2016 14:49:23 +0000 (10:49 -0400)]
lttng: Bug 498066: Check if field ret exists in syscall exit handler
Change-Id: I25dbd7534cafc20b0ad96e9dc73933d4ae71ab51
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77477
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Patrick Tasse [Fri, 15 Jul 2016 21:03:36 +0000 (17:03 -0400)]
tmf: Bug 497994: Hide Table action does not layout properly
Change-Id: I8b1f2c741203434b80ea5165d430b01d16514225
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77418
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Mon, 27 Jun 2016 19:32:40 +0000 (15:32 -0400)]
tmf: Rename tag name label in custom XML parser wizard
Change-Id: I51215a25d07a8eb00b3bd5cac834964f1114e653
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/76256
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Patrick Tasse [Wed, 13 Jul 2016 19:56:55 +0000 (15:56 -0400)]
tmf: Fix incorrect zoom thread time bounds when time graph view is empty
When the time graph view is empty because none of its build threads have
started yet, the time bounds still have the initial values set to [+INF,
-INF].
If a zoom thread is started at that moment, the requested start and end
time of the zoom thread are clamped to the time graph view's bounds and
are consequently set to [-INF, +INF].
This is changed so that the zoom thread does not clamp the requested
start and end time when the time graph view's bounds are not set.
Change-Id: I6c751641dab8eb4d1389adabf89c3c5a614e6b90
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77279
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Patrick Tasse [Thu, 23 Jun 2016 22:32:55 +0000 (18:32 -0400)]
tmf: Add support for custom event type by text line or XML element
The text line or XML element can have an associated event type that will
override the definition name as the default event type.
If a custom event field or attribute is defined to set the event type,
it will override that default.
Change-Id: I9e38a0cdb5dc1b4442ca8028bbbbee220dc6001c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/75892
Reviewed-by: Hudson CI
This page took 0.046406 seconds and 5 git commands to generate.