Kurt Kanzenbach [Fri, 30 Nov 2012 11:18:17 +0000 (12:18 +0100)]
staging: keucr: Replaced c99 comments
Fixed a coding style issue. Replaced all
c99 comments by c89 ones and deleted
commented out code.
Signed-off-by: Kurt Kanzenbach <shifty91@gmail.com>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sebastian Hahn [Wed, 5 Dec 2012 20:40:23 +0000 (21:40 +0100)]
staging/rtl8192u: do not init statics to 0
Fix the checkpatch error "do not initialize statics to 0 or NULL"
Signed-off-by: Sebastian Hahn <snsehahn@cip.cs.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sebastian Hahn [Wed, 5 Dec 2012 20:40:22 +0000 (21:40 +0100)]
staging/rtl8192u: use same indent for switch and case
Fix the checkpatch error "switch and case should be at the same indent"
Signed-off-by: Sebastian Hahn <snsehahn@cip.cs.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sebastian Hahn [Wed, 5 Dec 2012 20:40:21 +0000 (21:40 +0100)]
staging/rtl8192u: don't init globals to 0 or NULL
Fix a couple of instances where checkpatch complained about
initializing globals with 0.
Signed-off-by: Sebastian Hahn <snsehahn@cip.cs.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sebastian Hahn [Thu, 6 Dec 2012 11:23:03 +0000 (12:23 +0100)]
staging/rtl8192u: indent with tabs, not spaces
Converted staging/rtl8187se to use tabs instead of spaces for
indentation to fix the checkpatch error "code indent should use tabs
where possible".
Signed-off-by: Sebastian Hahn <snsehahn@cip.cs.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jennifer Naumann [Wed, 5 Dec 2012 20:40:19 +0000 (21:40 +0100)]
staging/rtl8192u: put { on same line as struct
This fixes the checkpatch error "open brace '{' following struct go on the
same line" in staging/rtl8192u
Signed-off-by: Jennifer Naumann <Jennifer.Naumann@informatik.stud.uni-erlangen.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sebastian Hahn [Wed, 5 Dec 2012 20:40:18 +0000 (21:40 +0100)]
staging/rtl8192u: cleanfile run
Run cleanfile on all files inside drivers/staging/rtl819u
Signed-off-by: Sebastian Hahn <snsehahn@cip.cs.fau.de>
Signed-off-by: Jennifer Naumann <Jennifer.Naumann@informatik.stud.uni-erlangen.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Fri, 30 Nov 2012 13:01:37 +0000 (22:01 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/dot11d.c
The following errors fixed.
- ERROR: "foo * bar" should be "foo *bar"
- ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Fri, 30 Nov 2012 13:01:24 +0000 (22:01 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/dot11d.c
The following errors and warnings fixed.
- WARNING: braces {} are not necessary for single statement blocks
- ERROR: that open brace { should be on the previous line
- ERROR: space required before the open parenthesis '('
- ERROR: space prohibited after that open parenthesis '('
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Fri, 30 Nov 2012 13:00:52 +0000 (22:00 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/dot11d.c
The following errors fixed.
- ERROR: spaces required around that '=' (ctx:VxV)
- ERROR: spaces required around that '<=' (ctx:VxV)
- ERROR: space required after that ',' (ctx:VxV)
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Thu, 29 Nov 2012 13:36:07 +0000 (22:36 +0900)]
staging/rtl8187se: Use netdev_ printks in ieee80211/ieee80211_wx.c
The following warnings fixed.
-WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...
-WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Thu, 29 Nov 2012 13:35:51 +0000 (22:35 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_wx.c
The following errors fixed.
-ERROR: spaces required around that '<' (ctx:VxV)
-ERROR: spaces required around that '?' (ctx:VxV)
-ERROR: spaces required around that ':' (ctx:VxV)
-ERROR: spaces required around that '>' (ctx:VxV)
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Thu, 29 Nov 2012 13:35:37 +0000 (22:35 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_wx.c
The following errors fixed.
-ERROR: that open brace { should be on the previous line
-ERROR: space required before the open parenthesis '('
-ERROR: else should follow close brace '}'
-ERROR: space required before the open brace '{'
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YAMANE Toshiaki [Thu, 29 Nov 2012 13:34:39 +0000 (22:34 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_wx.c
The following errors and warnings fixed.
- ERROR: code indent should use tabs where possible
- WARNING: please, no spaces at the start of a line
- WARNING: please, no space before tabs
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ilija Hadzic [Fri, 7 Dec 2012 21:49:44 +0000 (16:49 -0500)]
staging: usbip: userspace: suppress a bogus error
If mkdir() of VHCI_STATE_PATH fails because the directory
already exists, that's not an error. This patch fixes
annoying "record connection" errors that would typically
come up on attach.
Signed-off-by: Ilija Hadzic <ihadzic@research.bell-labs.com>
Acked-by: David Chang <dchang@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ilija Hadzic [Fri, 7 Dec 2012 21:49:43 +0000 (16:49 -0500)]
staging: usbip: userspace: add option to turn fortify on or off
This comes handy when hacking with different cross
compilers, some of which may or may not have
_FORTIFY_SOURCE turned on by default. This patch
allows us to turn _FORTIFY_SOURCE on by specifying
--with-fortify option at configuration time (or
to turn it off by specifying --without-fortify).
If nothing is specified, default compiler behavior
is assumed.
Signed-off-by: Ilija Hadzic <ihadzic@research.bell-labs.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ilija Hadzic [Fri, 7 Dec 2012 21:49:42 +0000 (16:49 -0500)]
staging: usbip: userspace: eliminate glib dependency
USBIP daemon relies on functions available in glib2 library
to spawn handler code for incoming connection. This makes the
whole program dependent on glib2 library, which is a GNOME library
that on systems that don't have GNOME results in pulling more
dependency, only to be able to run a relatively trivial
socket-based program.
While this may not seem to be a problem on full-blown desktops
that already have the necessary libraries, it is a big issue
on small embedded systems (think USB hub with an Ethernet port)
that only have bare essentials in their file systems.
This patch eliminates glib2 dependency by reworking the
code to use lower level system calls to dispatch connection
handler. Instead of using glib2-style event loop and dispatching
mechanism, just do a ppoll(2) system call in our own loop and call
accept(2) followed by fork(2) on the socket that has incoming
connection. Stevens' books taught us that more than twenty
years ago. No need for anything smarter in a simple server, such
as usbipd.
Signed-off-by: Ilija Hadzic <ihadzic@research.bell-labs.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ilija Hadzic [Fri, 7 Dec 2012 21:49:41 +0000 (16:49 -0500)]
staging: usbip: userspace: add gitignore file
There are a bunch of automatically generated files that git
should not care about.
Signed-off-by: Ilija Hadzic <ihadzic@research.bell-labs.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ilija Hadzic [Fri, 7 Dec 2012 21:49:40 +0000 (16:49 -0500)]
staging: usbip: userspace: fix build breakage in doc directory
File doc/usbip_bind_driver.8 does not exist any more but it is
listed in dist_man_MANS. This breaks the build of the userspace.
Remove the file from the list.
Signed-off-by: Ilija Hadzic <ihadzic@research.bell-labs.com>
Acked-by: David Chang <dchang@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kurt Kanzenbach [Wed, 5 Dec 2012 19:03:35 +0000 (20:03 +0100)]
Staging: ft1000-usb: Fix call to obsolete function
strict_strtoul is obsolete and should be replaced with
kstrto* function as reported by checkpatch.pl.
pInfo->CardNumber is a u8. This is why kstrtou8 should be
used here.
Signed-off-by: Kurt Kanzenbach <shifty91@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ondrej Zary [Sun, 2 Dec 2012 17:51:40 +0000 (18:51 +0100)]
staging: ft1000: rename struct ft1000_device to ft1000_usb
After unifying struct ft1000_info, struct ft1000_device is now wrong name.
Rename it to ft1000_usb to match its semantics.
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Reviewed-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ondrej Zary [Sun, 2 Dec 2012 11:30:19 +0000 (12:30 +0100)]
staging: ft1000: unify struct ft1000_info between USB and PCMCIA drivers
Unify struct ft1000_info between ft1000-usb and ft1000-pcmcia and move it to
common ft1000.h.
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Tested-by: Marek Belisko <marek.belisko@open-nandra.com>
Review-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Tue, 25 Dec 2012 16:23:29 +0000 (01:23 +0900)]
staging: vt6655: Fix typo in vt6655 driver
Correct spelling typo in comments within vt6655 driver.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cyril Roelandt [Sun, 2 Dec 2012 02:40:22 +0000 (03:40 +0100)]
staging: vt6656: remove a useless call to memset().
This call is followed by a call to memcpy() on the same memory area, so it can
be safely removed.
Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
Acked-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 10 Dec 2012 22:14:36 +0000 (22:14 +0000)]
staging: vt6656: channel/control/firmware/int/usbpipe to new structures
This patch cleans up function declarations, definitions and local variables
where appropriate replacing types defined in "ttype.h" with linux/types.h.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 10 Dec 2012 22:12:07 +0000 (22:12 +0000)]
staging: vt6656: iwctl/key/rf use new structures.
This patch cleans up function declarations, definitions and local variables
were appropriate replacing types defined in "ttype.h" with linux/types.h
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 10 Dec 2012 22:03:56 +0000 (22:03 +0000)]
staging: vt6656: change wmgr to new structures
This patch cleans up function declarations, definitions and local variables
were appropriate replacing types defined in "ttype.h" with linux/types.h.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 10 Dec 2012 22:01:23 +0000 (22:01 +0000)]
staging: vt6656: change baseband/mac/wcmd/wctl to new structures.
This patch also cleans up function declarations, definitions and local variables
were appropriate replacing types defined in "ttype.h" with linux/types.h.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 10 Dec 2012 21:59:10 +0000 (21:59 +0000)]
staging: vt6656: card/main_usb/device use new structure names
This patch also cleans up function declarations, definitions and local variables
were appropriate replacing types defined in "ttype.h" with linux/types.h.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 10 Dec 2012 21:55:59 +0000 (21:55 +0000)]
staging: vt6656: create new structure names to remove typedefs.
This patch and the next 8 patches remove the old structure names and
replace;
struct vnt_private for DEVICE_INFO and PSDevice
struct vnt_manager for SMgmtObject
struct vnt_rx_mgmt for SRxMgmtPacket and PSRxMgmtPacket
struct vnt_tx_mgmt for STxMgmtPacket and PSTxMgmtPacket
and
struct vnt_manager vnt_mgmt
to replace
SMgmtObject sMgmtObj;
Applied after patch staging: vt6656: dpc.c :RXbBulkInProcessData clean up RSC
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 28 Nov 2012 21:11:02 +0000 (21:11 +0000)]
staging: vt6656: Remove QWORD from source and replace with u64.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cyril Roelandt [Tue, 4 Dec 2012 20:08:36 +0000 (21:08 +0100)]
staging: wlags49_h2: remove unneeded memset() in wireless_get_bssid()
A few lines after this call, we memcpy over the same memory area, so the call to
memset is not necessary.
Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:57 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_util: corrects asterisk placement
This commit fixes incorrect placement of the asterisk character.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:56 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_util: converts C99 // comment
This commit converts a C99 // comment to /* */
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:55 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_util: fixes spacing around parentheses
This commit corrects the spacing in an and around parentheses in the
file.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:54 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_priv: converts C99 // comments
This commit converts C99 // comments to /* */
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:53 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_priv: converts indentation to tabs
This commit converts instances of space-based indentation to tabs.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:52 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_priv: fixes brace placement
This commit fixes incorrect brace placements in the file, as
indicated by the checkpatch.pl tool.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:51 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_priv: fixes case statement styling issues
This commit fixes issues related to the styling of case statements.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:50 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_priv: fixes incorrect #include
This commit forces the file to use <linux/uaccess.h> instead of
<asm/uaccess.h>. Everything still compiles a-OK.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:49 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_priv: fixes parentheses styling issues
This commit fixes further parentheses styling issues as identified
by the checkpatch.pl tool.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:48 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_priv: fixes spacing around parentheses
This commit fixes many instances where the spacing in and around
parentheses was applied incorrectly.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:47 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_profile.h: fixes C99 // comment
This commit converts a C99 // comment to /* */. The checkpatch.pl
tool reports that this file has no further styling issues.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:46 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_profile.h: fixes spacing around parentheses
This commit cleans up the spacing around parentheses.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:45 +0000 (18:58 +0200)]
staging: wlags49_h2: sta_h2: corrects C99 // comments
This commit converts C99 // comments to /* */
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:44 +0000 (18:58 +0200)]
staging: wlags49_h2: sta_h2: fixes casting style issue
This commit cleans up a styling issue when casting to "hcf_8 *".
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:43 +0000 (18:58 +0200)]
staging: wlags49_h2: sta_h2: fixes spaces around parentheses
This commit fixes an instance where the spacing around parentheses
was incorrect.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:42 +0000 (18:58 +0200)]
staging: wlags49_h2: sta_h2: fixes malformed #include filename
This minor change simply removes quotations from within a comment
so that the checkpatch.pl tool won't complain about a malformed
include filename anymore.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:41 +0000 (18:58 +0200)]
staging: wlags49_h2: sta_h2: fixes spaces-before-tabs problems
This commit various cases where there were spaces before tabs, as
reported by the checkpatch.pl tool.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:40 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_netdev.h: sorts out spacing issues
This commit fixes issues regarding spacing around parentheses. The
checkpatch.pl tool reports that this file has no further styling
issues.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:39 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_netdev.h: converts C99 // comments
This commit converts C99 // comments to /* */
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:38 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_priv.h: fixes instances of 80+ char lines
This commit corrects cases where lines where longer than 80
characters. checkpatch.pl now reports that this file has no further
issues.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:37 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_priv.h: converts C99 // comments
This commit converts C99 // comments to /* */
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:36 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_priv.h: fixes spacing around parentheses
This commit fixes the incorrect spacing around parentheses.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:35 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_enc: fixes incorrect use of return
This commit removes parentheses that were used as part of return
statements, seeing as how return is not a function.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:34 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_enc: corrects spacing around colons
This commit fixes incorrect use of spaces around colons.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:33 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_enc: corrects spacing around parentheses
This commit corrects various instances where the use of spaces
around parentheses was incorrect.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:32 +0000 (18:58 +0200)]
staging: wlags49_h2: wl_enc: converts indentation spaces to tabs
This commit converts space-based indentation to tabs.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:31 +0000 (18:58 +0200)]
staging: wlags49_h2: ap_h25: corrects incorrect use of // comments
This commit converts C99 // comments to /* */
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:30 +0000 (18:58 +0200)]
staging: wlags49_h2: ap_h25: corrects casting styling issue
This commit corrects a casting styling issue as reported by the
checkpatch.pl tool.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:29 +0000 (18:58 +0200)]
staging: wlags49_h2: ap_h25: corrects malformed #include warning
This extremely minor commit removes quotation marks from within a
comment so that the checkpatch.pl tool won't complain about the
line in question anymore.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:28 +0000 (18:58 +0200)]
staging: wlags49_h2: ap_h25: corrects parentheses styling issue
This commit corrects incorrect spaces around parentheses.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:27 +0000 (18:58 +0200)]
staging: wlags49_h2: ap_h25: corrects tabs/spaces syling issues
This commit corrects tabs and spaces issues as reported by the
checkpatch.pl tool.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Meiring [Fri, 30 Nov 2012 16:58:26 +0000 (18:58 +0200)]
staging: wlags49_h2: ap_h2: corrects a pointer styling issue
This commit correct a pointer styling issue as reported by the
checkpatch.pl tool.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 5 Jan 2013 04:35:10 +0000 (23:35 -0500)]
Staging: bcm: Fix warning: "Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ..."
This patch fixes the following warning: "WARNING:
Prefer netdev_dbg(netdev, ... then dev_dbg(dev,
... then pr_debug(... to printk(KERN_DEBUG ..." in
Debug.h
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 5 Jan 2013 04:35:09 +0000 (23:35 -0500)]
Staging: bcm: Change the name of typedef USER_BCM_DBG_STATE to bcm_user_debug_state.
This patch removes typedef for USER_BCM_DBG_STATE, and
changes the name of the struct to bcm_user_debug_state.
In addition, any calls to struct "USER_BCM_DBG_STATE"
are changed to call directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 5 Jan 2013 04:35:08 +0000 (23:35 -0500)]
Staging: bcm: Remove typedef for _S_BCM_DEBUG_STATE and call directly.
This patch removes typedef for _S_BCM_DEBUG_STATE, and
changes the name of the struct to bcm_debug_state. In
addition, any calls to struct "S_BCM_DEBUG_STATE" are
changed to call directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 5 Jan 2013 04:35:07 +0000 (23:35 -0500)]
Staging: bcm: Replace UINT with unsigned int in Debug.h
This patch replaces "UINT" with "unsigned int"
in Debug.h
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 5 Jan 2013 04:35:06 +0000 (23:35 -0500)]
Staging: bcm: Fix error: "Macros with complex values should be enclosed in parenthesis" in Debug.h
This patch fixes the following error: "Macros with
complex values should be enclosed in parenthesis"
as reported by checkpatch.pl.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 5 Jan 2013 04:35:05 +0000 (23:35 -0500)]
Staging: bcm: Fix warning: "__packed is preferred over __attribute__((packed))" in Debug.h
This patch fixes the following warning: "__packed
is preferred over __attribute__((packed))" as
reported by checkpatch.pl.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 5 Jan 2013 04:35:04 +0000 (23:35 -0500)]
Staging: bcm: Properly format braces in Debug.h
This patch formats braces in Debug.h as reported
by checkpatch.pl.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 5 Jan 2013 04:35:03 +0000 (23:35 -0500)]
Staging: bcm: Properly format comments in Debug.h
This patch properly formats comments, and removes
them as needed in Debug.h.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 5 Jan 2013 04:35:02 +0000 (23:35 -0500)]
Staging: bcm: Fix all white space issues in Debug.h
This patch fixes all white space issues in
Debug.h as reported by checkpatch.pl.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:56 +0000 (14:27 -0500)]
Staging: bcm: Remove typedef for TransportHeaderT and call directly.
This patch removes typedef for TransportHeaderT, and
changes the name of the struct to bcm_transport_header.
In addition, any calls to struct "xporthdr" are
changed to call directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:55 +0000 (14:27 -0500)]
Staging: bcm: Remove typedef for _E_NWPKT_IPFRAME_TYPE and call directly.
This patch removes typedef for _E_NWPKT_IPFRAME_TYPE,
and changes the name of the enum to bcm_ip_frame_type.
In addition, any calls to enum "E_NWPKT_IPFRAME_TYPE"
are changed to call directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:54 +0000 (14:27 -0500)]
Staging: bcm: Remove typedef for _E_NWPKT_ETHFRAME_TYPE and call directly.
This patch removes typedef for _E_NWPKT_ETHFRAME_TYPE,
and changes the name of the enum to bcm_eth_frame_type.
In addition, any calls to enum "E_NWPKT_ETHFRAME_TYPE,
are changed to call directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:53 +0000 (14:27 -0500)]
Staging: bcm: Remove typedef for _S_ETHCS_PKT_INFO and call directly.
This patch removes typedef for _S_ETHCS_PKT_INFO, and
changes the name of the struct to bcm_eth_packet_info.
In addition, any calls to struct "S_ETHCS_PKT_INFO, or
*PS_ETHCS_PKT_INFO" are changed to call directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:52 +0000 (14:27 -0500)]
Staging: bcm: Remove typedef for _ETH_CS_802_Q_FRAME and call directly.
This patch removes typedef for _ETH_CS_802_Q_FRAME, and
changes the name of the struct to bcm_eth_q_frame. In
addition, any calls to struct "ETH_CS_802_Q_FRAME" are
changed to call directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:51 +0000 (14:27 -0500)]
Staging: bcm: Remove typedef for _ETH_CS_802_LLC_FRAME and call directly.
This patch removes typedef for _ETH_CS_802_LLC_FRAME, and
changes the name of the struct to bcm_eth_llc_frame. In
addition, any calls to struct "ETH_CS_802_LLC_FRAME" are
changed to call directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:50 +0000 (14:27 -0500)]
Staging: bcm: Remove typedef for _ETH_CS_802_LLC_SNAP_FRAME and call directly.
This patch removes typedef for _ETH_CS_802_LLC_SNAP_FRAME, and
changes the name of the struct to bcm_eth_llc_snap_frame. In
addition, any calls to struct "ETH_CS_802_LLC_SNAP_FRAME" are
changed to call directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:49 +0000 (14:27 -0500)]
Staging: bcm: Remove typedef for _ETH_CS_ETH2_FRAME and call directly.
This patch removes typedef for _ETH_CS_ETH2_FRAME, and
changes the name of the struct to bcm_ethernet2_frame. In
addition, any calls to struct "ETH_CS_ETH2_FRAME" are
changed to call directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:48 +0000 (14:27 -0500)]
Staging: bcm: Remove typedef for _E_SERVICEFLOW_CS_SPEC_ and call directly.
This patch removes typedef for _E_SERVICEFLOW_CS_SPEC_,
and changes the name of the enum to bcm_spec_encoding.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:47 +0000 (14:27 -0500)]
Staging: bcm: Remove typedef for _TCP_HEADER and call directly.
This patch removes typedef for _TCP_HEADER, and changes
the name of the struct to bcm_tcp_header. In addition,
any calls to struct "TCP_HEADER, or *PTCP_HEADER" are
changed to call directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:46 +0000 (14:27 -0500)]
Staging: bcm: Replace UCHAR with unsigned char in Protocol.h
This patch replaces "UCHAR" with "unsigned char"
in Protocol.h
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:45 +0000 (14:27 -0500)]
Staging: bcm: Replace ULONG with unsigned long in Protocol.h
This patch replaces "ULONG" with "unsigned long"
in Protocol.h
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:44 +0000 (14:27 -0500)]
Staging: bcm: Replace USHORT with unsigned short in Protocol.h
This patch replaces "USHORT" with "unsigned short"
in Protocol.h
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:43 +0000 (14:27 -0500)]
Staging: bcm: Fix issue: "Macros with complex values should be enclosed in parenthesis" in Protocol.h
This patch fixes the following issue: "Macros with
complex values should be enclosed in parenthesis"
as reported by checkpatch.pl.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:42 +0000 (14:27 -0500)]
Staging: bcm: Fix warning: "__packed is preferred over __attribute__((packed))" in Protocol.h
This patch fixes the following warning: "__packed
is preferred over __attribute__((packed))" as
reported by checkpatch.pl.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:41 +0000 (14:27 -0500)]
Staging: bcm: Properly format braces in Protocol.h
This patch formats braces in Protocol.h as reported
by checkpatch.pl.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:40 +0000 (14:27 -0500)]
Staging: bcm: Properly format comments in Protocol.h
This patch properly formats comments, and removes
them as needed in Protocol.h.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Sat, 22 Dec 2012 19:27:39 +0000 (14:27 -0500)]
Staging: bcm: Fix all white space issues in Protocol.h
This patch fixes all white space issues in
Protocol.h as reported by checkpatch.pl.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Fri, 21 Dec 2012 20:10:39 +0000 (15:10 -0500)]
Staging: bcm: Replace UCHAR with unsigned char in Macros.h
This patch replaces "UCHAR" with "unsigned char" in
Macros.h.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Fri, 21 Dec 2012 20:10:38 +0000 (15:10 -0500)]
Staging: bcm: Remove typedef for _LINK_STATE and call directly.
This patch removes typedef for _LINK_STATE, and changes
the name of the struct to bcm_link_state. In addition,
any calls to struct "LINK_STATE, or PLINK_STATE" are
changed to call directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Fri, 21 Dec 2012 20:10:37 +0000 (15:10 -0500)]
Staging: bcm: Remove typedef for _E_PHS_DSC_ACTION and call directly.
This patch removes typedef for _E_PHS_DSC_ACTION, and
changes the name of the enum to bcm_phs_dsc_action.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Fri, 21 Dec 2012 20:10:36 +0000 (15:10 -0500)]
Staging: bcm: Remove typedef for eNVM_TYPE and call directly.
This patch removes typedef for eNVM_TYPE, and changes
the name of the enum to bcm_nvm_type. In addition,
any calls to enum "NVM_TYPE" are changed to call
directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Fri, 21 Dec 2012 20:10:35 +0000 (15:10 -0500)]
Staging: bcm: Remove typedef for ePMU_MODES and call directly.
This patch removes typedef for ePMU_MODES, and
changes the name of the enum to bcm_pmu_modes.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Thu, 20 Dec 2012 05:31:34 +0000 (00:31 -0500)]
Staging: bcm: Remove typedef for _S_PHS_RULE and call directly.
This patch removes typedef for _S_PHS_RULE, and changes
the name of the struct to bcm_phs_rule. In
addition, any calls to struct "S_PHS_RULE" are
changed to call directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Thu, 20 Dec 2012 05:31:33 +0000 (00:31 -0500)]
Staging: bcm: Remove typedef for _E_CLASSIFIER_ENTRY_CONTEXT and call directly.
This patch removes typedef for _E_CLASSIFIER_ENTRY_CONTEXT, and
changes the name of the enum to bcm_phs_classifier_context. In
addition, any calls to enum "_E_CLASSIFIER_ENTRY_CONTEXT" are
changed to call directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Thu, 20 Dec 2012 05:31:32 +0000 (00:31 -0500)]
Staging: bcm: Remove typedef for _S_CLASSIFIER_ENTRY and call directly.
This patch removes typedef for _S_CLASSIFIER_ENTRY, and
changes the name of the struct to bcm_phs_classifier_entry. In
addition, any calls to struct "_S_CLASSIFIER_ENTRY" are
changed to call directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kevin McKinney [Thu, 20 Dec 2012 05:31:31 +0000 (00:31 -0500)]
Staging: bcm: Remove typedef for _S_CLASSIFIER_TABLE and call directly.
This patch removes typedef for _S_CLASSIFIER_TABLE, and
changes the name of the struct to bcm_phs_classifier_table. In
addition, any calls to struct "S_CLASSIFIER_TABLE" are
changed to call directly.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This page took 0.043209 seconds and 5 git commands to generate.