Mathieu Desnoyers [Fri, 2 Mar 2012 23:17:33 +0000 (18:17 -0500)]
Fix: meaningful error message
Show a meaningful error message to users attempting to do kernel tracing
without root sessiond/tracing group creds.
Reported-by: "Brosseau, Yannick" <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 2 Mar 2012 22:26:10 +0000 (17:26 -0500)]
Fix: UST consumer need to iterate on streams, just change their key
We need iteration to still be able to see the stream/channel, but not
lookups from sessiond query.
Ensure that teardown does not lookup by key.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 2 Mar 2012 21:56:13 +0000 (16:56 -0500)]
Fix: add missing rcu read lock across RCU HT iteration
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 2 Mar 2012 21:16:02 +0000 (16:16 -0500)]
Fix: kernel session closes fd 0 after create
This fix the make check test for kernel session handling. We ensure that
all FDs that are unset are set to -1.
Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 2 Mar 2012 20:53:09 +0000 (15:53 -0500)]
Fix: sendmsg EPIPE should be quiet by default (expected)
Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 2 Mar 2012 20:45:11 +0000 (15:45 -0500)]
Fix: thread_registration_apps should set its local sock to -1 when passing it
.. to another thread.
Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 2 Mar 2012 20:20:45 +0000 (15:20 -0500)]
Fix: clock -> sock typo
Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 2 Mar 2012 20:13:18 +0000 (15:13 -0500)]
Fix: consumer race: should allow reuse of FD key
Issue was triggered by running "hello" UST test program in a loop while
tracing was active.
Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 2 Mar 2012 19:01:42 +0000 (14:01 -0500)]
Fix: Use PERROR all across lttng-tools, never make it quiet
We never want to hide these errors, even in quiet mode. For those
"errors" that are expected and part of the normal operation (e.g. send
consumer channel: Socket operation on non-socket), we will have to
handle the return values and errno explicitly in the code.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 2 Mar 2012 18:10:11 +0000 (13:10 -0500)]
Fix: test all close return values in sessiond
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 2 Mar 2012 18:03:38 +0000 (13:03 -0500)]
Fix: All perror turned into PERROR to show file and line number
Needed to find error culprits.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 2 Mar 2012 17:57:38 +0000 (12:57 -0500)]
Fix: large audit of close() use in sessiond main.c
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 2 Mar 2012 17:10:32 +0000 (12:10 -0500)]
Fix: main.c client/apps sockets and kernel_trace_fd close(0)
thread_registration_apps and thread_manage_clients threads are closing
sock == 0 in error handling path, which is an error.
They also may use kernel_tracer_fd at 0 value if no kernel tracer has
been found. cleanup() can close this 0 socket too, which should never
happen.
Set all these sockets as "-1" when unset.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 2 Mar 2012 16:54:13 +0000 (11:54 -0500)]
Fix: incorrect close of fd 0 for syscall kernel event destroy
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 2 Mar 2012 16:12:26 +0000 (11:12 -0500)]
Fix: sessiond has incorrect missing 0 value in FD check
When run with daemon(), the 0 file descriptor can be re-used for
something else than stdout.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 1 Mar 2012 04:34:11 +0000 (23:34 -0500)]
Fix: sessiond app listening: use posix-compliant poll flags
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 1 Mar 2012 03:33:17 +0000 (22:33 -0500)]
Fix: consumer printf type should match ssize_t (%zd)
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 1 Mar 2012 03:30:17 +0000 (22:30 -0500)]
Fix: make ust consumer posix compliant for poll flags
poll flags can have both POLLHUP and POLLIN set, which is not expected
by the consumer. Do not depend on this implementation-specific behavior.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 1 Mar 2012 15:36:06 +0000 (10:36 -0500)]
Fix security permission on lttng run directory
Add execute flag for other (r+x) on the lttng run directory at
/var/run/lttng so instrumented application *not* in the tracing group
can register to the global session daemon running as root.
(refs #141)
Signed-off-by: David Goulet <dgoulet@efficios.com>
Raphaël Beamonte [Tue, 28 Feb 2012 18:29:18 +0000 (13:29 -0500)]
Fix: Display right loglevel_type in error message
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Raphaël Beamonte [Mon, 27 Feb 2012 22:37:18 +0000 (17:37 -0500)]
Fix documentation in lttng.h
Some functions in lttng.h are not aimed to be used only for kernel but
also for UST. This patch changes only the references made to 'kernel' to
make the documentation generic in the comments.
(closes #126)
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Fri, 24 Feb 2012 19:41:49 +0000 (14:41 -0500)]
Fix: lttng UST and kernel consumer: fix ret vs errno mixup
- errno should be set to -ret (not the opposite!)
The main effect is that the perror errors were meaningless.
- errno should always be compared with positive values.
This was also causing consumerd error handling mistakes.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Fri, 24 Feb 2012 19:26:30 +0000 (14:26 -0500)]
Fix: restart consumerd and sessiond when interrupted in poll()
When poll() is interrupted (e.g. by a debugger attaching), it should
restart instead of exiting with an error.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 23 Feb 2012 22:30:41 +0000 (17:30 -0500)]
Fix: handling bad channel when sending to consumer
If the channel object is NULL it means that it's not created on the
tracer.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 23 Feb 2012 22:19:29 +0000 (17:19 -0500)]
Fix useless variable
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 23 Feb 2012 21:32:45 +0000 (16:32 -0500)]
Fix add-context returned error
Commit closes #99
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 23 Feb 2012 16:06:29 +0000 (11:06 -0500)]
fix: add missing break in command handling
fix missing break in switch statement introduced in commit
2e09ba096b399ff18769cdd794c3946e54194491
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 23 Feb 2012 16:02:00 +0000 (11:02 -0500)]
fix: command handling: do not check domain for commands not requiring domain
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 23 Feb 2012 15:41:45 +0000 (10:41 -0500)]
fix: if tracing group does not exist, do not report a client error
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 23 Feb 2012 15:09:09 +0000 (10:09 -0500)]
Fix: run_as error handling
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Tue, 21 Feb 2012 20:33:07 +0000 (15:33 -0500)]
Fix usage note on -a
This option also enable syscall tracing, just clarify it in doc.
Signed-off-by: Julien Desfossez <julien.desfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 22 Feb 2012 21:53:12 +0000 (16:53 -0500)]
Revert FreeBSD compatibility layer
Move those commits to the compat-freebsd branch instead of master branch
which is currently between release canditate and stable and this compat
layer will NOT go into 2.0-stable.
Revert "Fix rest of the code to support compat layer"
This reverts commit
a440509044c2828bf6dbfb05e8d9d6d0277ce1a4.
Revert "Fix consumer to handle compat layer"
This reverts commit
fbb2c21aac1386b7752f6254b2bd0bf001fa0ac1.
Revert "Multiple fix for FreeBSD compat layer"
This reverts commit
bcc5eeb02fcad910c4de961b040351dad31b6f9f.
Revert "Add multiple FreeBSD compat layer"
This reverts commit
d50813007e79158828e8ee6e1b5444950bc90847.
Revert "Add FreeBSD compat layer for splice and sync_file_range"
This reverts commit
826a02a292d2bd409be87ea96ba2fccbccee76b1.
Revert "Support XSI strerror_r in error.h"
This reverts commit
e672cc585c3d67ee80278e29b538a3aed65df825.
Revert "Add FreeBSD compat layer for socket.h"
This reverts commit
ef50a575de02a28aa158d7ba34b3d20ea329751a.
Revert "Fix FreeBSD support for rculfhash mmap"
This reverts commit
e21193ea4abf7d93112b8ad3144ba11484d623c6.
Revert "Add FreeBSD compat layer for endian.h"
This reverts commit
ae9d96fe577c198df432102cde69a28e82cccc1b.
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 01:18:33 +0000 (20:18 -0500)]
Fix: documented number of subbuffers is incorrect
Reported-by: Tan Dung Le Tran <tan.dung.le.tran@ericsson.com>
Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 22 Feb 2012 01:07:29 +0000 (20:07 -0500)]
Document that num-subbuf and subbuf-size need to be power of 2
Reported-by: Tan Dung Le Tran <tan.dung.le.tran@ericsson.com>
Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Tue, 21 Feb 2012 22:53:02 +0000 (17:53 -0500)]
Merge branch 'master' of git://git.lttng.org/lttng-tools
David Goulet [Tue, 21 Feb 2012 22:46:49 +0000 (17:46 -0500)]
Fix rest of the code to support compat layer
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 21 Feb 2012 22:46:24 +0000 (17:46 -0500)]
Fix consumer to handle compat layer
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 21 Feb 2012 22:45:50 +0000 (17:45 -0500)]
Multiple fix for FreeBSD compat layer
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 21 Feb 2012 22:43:53 +0000 (17:43 -0500)]
Add multiple FreeBSD compat layer
Adds clone, posix_fadvise and splice compatibility layer.
This commit ENOSYS those function for now and better implementation
will come in the future.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 21 Feb 2012 20:36:59 +0000 (15:36 -0500)]
Add FreeBSD compat layer for splice and sync_file_range
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Tue, 21 Feb 2012 18:54:20 +0000 (13:54 -0500)]
Support XSI strerror_r in error.h
Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Tue, 21 Feb 2012 18:12:55 +0000 (13:12 -0500)]
Add FreeBSD compat layer for socket.h
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 21 Feb 2012 18:12:20 +0000 (13:12 -0500)]
Fix FreeBSD support for rculfhash mmap
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 21 Feb 2012 18:11:47 +0000 (13:11 -0500)]
Add FreeBSD compat layer for endian.h
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 20 Feb 2012 19:28:11 +0000 (14:28 -0500)]
Update version to v2.0.0-rc1
Signed-off-by: David Goulet <dgoulet@ev0ke.net>
Mathieu Desnoyers [Mon, 20 Feb 2012 19:53:20 +0000 (14:53 -0500)]
Standardize lttng-modules header version
refs #79
Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Juha Niskanen [Thu, 16 Feb 2012 20:32:12 +0000 (22:32 +0200)]
lttng-sessiond: Set group permissions explicitly
If root has a restrictive umask, e.g. 0077 when starting the session
daemon, users in kernel tracing group cannot access the global run
directory.
This patch drops unnecessary group mode bits and always sets the global
run dir permission regardless of umask.
Signed-off-by: Juha Niskanen <juniskane@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 16 Feb 2012 22:29:37 +0000 (17:29 -0500)]
Fix lttcomm_close_unix_sock to actually close the socket
To all soul out there, shutdown(sock, SHUT_RDWR) does NOT close the
socket keeping it open after the call. I have to say for my defense that
the man page does not specify it clearly :P.
Reported-by: Irina Guilman <irina.guilman@ericsson.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 16 Feb 2012 18:23:46 +0000 (13:23 -0500)]
Update version to v2.0-pre23
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 16 Feb 2012 16:01:09 +0000 (11:01 -0500)]
modprobe timer instrumentation module
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 16 Feb 2012 15:48:28 +0000 (10:48 -0500)]
modprobe lttng-probe-signal
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 16 Feb 2012 02:15:55 +0000 (21:15 -0500)]
Automatically load new lttng-probe-statedump.ko module
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Wed, 15 Feb 2012 16:29:16 +0000 (11:29 -0500)]
Fix ust app session started state on start trace
The started flag must be set as soon as possible in the start trace
function since if the start fails, it is still consider started for the
code logic.
Added one test to validate the restart tracing in UST.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 15 Feb 2012 00:00:56 +0000 (19:00 -0500)]
Fix double start/stop trace
The started flag, use to detect start vs restart, was set to 0 when
stopping tracing which is really not suppose to. An assert has been
addedd to detect a started = 0 at this stage which is a bad execution
flow error.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 14 Feb 2012 22:31:57 +0000 (17:31 -0500)]
Small fix to lttng list session
This patch makes lttng_list_sessions return 0 (not an error) when there
is in fact zero registered sessions. Also adding a MSG() to the user to
inform that no sessions exist and the error code is 0.
Reported-by: Tan Dung Le Tran <tan.dung.le.tran@ericsson.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 14 Feb 2012 20:40:17 +0000 (15:40 -0500)]
Fix return value on ust app session create
Two possible error can occur here where the malloc() failed or the
tracer is gone (app unregistered) so two error code is needed.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 14 Feb 2012 20:35:31 +0000 (15:35 -0500)]
Fix missing session locks
When an application registers, an update is triggered to create pending
events of the global event registry. This process MUST held the session
lock and the session list locks since it's iterating over all sessions.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 14 Feb 2012 20:33:20 +0000 (15:33 -0500)]
Fix existing session daemon check
On unclean exit, the session daemon socket are not removed making the
access() test valid on the next session daemon execution and failing to
recover from a fatal error.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 14 Feb 2012 17:40:25 +0000 (12:40 -0500)]
Improve create sessions test to show progress
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 14 Feb 2012 17:18:39 +0000 (12:18 -0500)]
Fix hyphens in man pages
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Tue, 14 Feb 2012 15:14:10 +0000 (10:14 -0500)]
configure.ac: Fix consumerd64-libdir typo
Reported-by: Devon MacDougall <devon.macdougall@ericsson.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Tue, 14 Feb 2012 14:18:56 +0000 (09:18 -0500)]
Update version to 2.0-pre22
Signed-off-by: David Goulet <dgoulet@efficios.com>
Alexandre Montplaisir [Mon, 13 Feb 2012 22:44:26 +0000 (17:44 -0500)]
Add the LICENSE file too
Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Alexandre Montplaisir [Mon, 13 Feb 2012 22:31:06 +0000 (17:31 -0500)]
Add the bash-completion file to the dist tarball
Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 13 Feb 2012 15:40:57 +0000 (10:40 -0500)]
Update version to 2.0-pre21
Signed-off-by: David Goulet <dgoulet@efficios.com>
Daniel U. Thibault [Mon, 13 Feb 2012 15:36:16 +0000 (10:36 -0500)]
Fix memory leak
Signed-off-by: Daniel U. Thibault <daniel.thibault@drdc-rddc.gc.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Alexandre Montplaisir [Sat, 11 Feb 2012 01:11:39 +0000 (20:11 -0500)]
Install man pages, lulz
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 24 Jan 2012 22:29:14 +0000 (17:29 -0500)]
Initial import of man lttng.1 and lttng-sessiond.8
This is the first import and first draft of lttng-tools man pages. It is
most likely that they still contain a lot of mistakes.
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Fri, 10 Feb 2012 18:26:54 +0000 (13:26 -0500)]
enable-event: Remove "<all> from MSG() when no loglevel is selected
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 10 Feb 2012 18:22:11 +0000 (13:22 -0500)]
Print loglevel value in list -u
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 10 Feb 2012 18:10:03 +0000 (13:10 -0500)]
lttng cmd: use enum instead of value for mapping
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Thu, 9 Feb 2012 22:22:28 +0000 (17:22 -0500)]
Fix licensing for hashtable/utils.c
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 9 Feb 2012 21:49:18 +0000 (16:49 -0500)]
Fix date in Changelog
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 9 Feb 2012 21:44:55 +0000 (16:44 -0500)]
Update version to 2.0-pre20
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 8 Feb 2012 21:02:25 +0000 (16:02 -0500)]
Increase sleep time for ust-nprocesses test
On slower system, the sleep time of ust-nprocesses can be too short
making the test fail. However, there is not much we can do to make sure
all app. registers to the session daemon and there is no time guarantee
also.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 8 Feb 2012 20:34:10 +0000 (15:34 -0500)]
Add trace directory option to lttng view
With -t, --trace-path, you can specify a trace directory to be used by
the viewer. This option override the session name.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 8 Feb 2012 20:22:39 +0000 (15:22 -0500)]
Remove fork() for the lttng view spawn viewer
We can now ctrl+c the viewer :). The fork() is useless since the command
does nothing else after the exec().
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Tue, 7 Feb 2012 22:46:54 +0000 (17:46 -0500)]
Fix unitilialized ret value (revisited)
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 7 Feb 2012 22:36:05 +0000 (17:36 -0500)]
Update hardcoded loglevels, allow shortcuts, add to lttng.h API
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Tue, 7 Feb 2012 22:02:44 +0000 (17:02 -0500)]
Fix uninitialized ret value
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 7 Feb 2012 21:51:21 +0000 (16:51 -0500)]
Change default options to lttng view
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 7 Feb 2012 21:48:38 +0000 (16:48 -0500)]
Remove forgotten debug printf
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 7 Feb 2012 21:44:30 +0000 (16:44 -0500)]
Fix session syscall listing
This problem occured because the "syscall" event was not added to the
event list since his kernel FD is not valid (fd=0). However, this fd is
only usefull if we want to add context or disable events. Those two
operations are not supported for now.
So, we can safely add the event to the list and add a hardcoded name in
the lttng cli list command.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 7 Feb 2012 19:13:20 +0000 (14:13 -0500)]
Add the lttng view command
This adds "view" to the lttng command line interface. It's used to
visualize traces with a given viewers (default: babeltrace).
The -e, --viewer options is available to override the default viewer
settings or add arguments to the viewer.
For example:
$ lttng view -e "babeltrace -n scope --no-delta --clock-raw"
The trace directory path is automatically appended using the current
session or the given session name to lttng view.
The default behavior is to simply spawn babeltrace with "-n all".
$ lttng view
[...]
LTTv support is now disabled but is planned for the stable release.
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Tue, 7 Feb 2012 18:28:19 +0000 (13:28 -0500)]
Fix list command
Broken by commit
081311398b0deca05eebaac8672efbc9af272d36
Fix by only creating the handle if kernel or ust is specified (so it
still fixes the valgrind warning).
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 7 Feb 2012 03:59:36 +0000 (22:59 -0500)]
Zero-initialize struct msghdr
==27395== Syscall param socketcall.sendmsg(msg.msg_iov[i]) points to uninitialised byte(s)
==27395== at 0x546C6A0: __sendmsg_nocancel (syscall-template.S:82)
==27395== by 0x4E30880: lttcomm_send_creds_unix_sock (sessiond-comm.c:449)
==27395== by 0x4E2F584: ask_sessiond (lttng-ctl.c:99)
==27395== by 0x4E2FC85: lttng_list_tracepoints (lttng-ctl.c:667)
==27395== by 0x4039C1: cmd_list (list.c:314)
==27395== by 0x40217C: main (lttng.c:266)
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 7 Feb 2012 03:49:20 +0000 (22:49 -0500)]
Fix memleak in lttng list.c
==26825== 580 bytes in 1 blocks are definitely lost in loss record 13 of 13
==26825== at 0x4C2779D: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==26825== by 0x4E2F702: lttng_create_handle (lttng-ctl.c:385)
==26825== by 0x403A5F: cmd_list (list.c:255)
==26825== by 0x40217C: main (lttng.c:266)
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 7 Feb 2012 03:26:21 +0000 (22:26 -0500)]
compat poll: remove useless "void" and semicolons
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 7 Feb 2012 03:09:11 +0000 (22:09 -0500)]
test session: tmp_name needs to be used twice
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 7 Feb 2012 03:06:39 +0000 (22:06 -0500)]
Make execution path with uninitialized domain fail
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 7 Feb 2012 03:06:24 +0000 (22:06 -0500)]
tests: ensure all get random string don't free
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 7 Feb 2012 02:59:42 +0000 (21:59 -0500)]
Cleanup tests coding style
4 spaces -> tab
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 7 Feb 2012 02:59:29 +0000 (21:59 -0500)]
Fix memory leak in get random string
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 7 Feb 2012 02:50:16 +0000 (21:50 -0500)]
Initialize all stack variables to zero, fix uninitialized loglevel variables
If we want the padding behavior to be always the same (for future
extensibility), we need to set those variables to zero when they are
declared on the stack.
Also fix uninitialized loglevel variables in tests, which were failing
on x86_32 due to this.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 6 Feb 2012 22:18:22 +0000 (17:18 -0500)]
Loglevel fixes
- fix event list bug due to loglevel error,
- enforce "-1" loglevel value in the sessiond when ALL loglevels are
selected.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 4 Feb 2012 21:46:21 +0000 (16:46 -0500)]
Install quickstart.txt and ChangeLog into system doc/
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 4 Feb 2012 17:42:19 +0000 (12:42 -0500)]
Cleanup list command printout for loglevel
was:
(loglevel: TRACE_DEFAULT13)
should be:
(loglevel: TRACE_DEFAULT)
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
David Goulet [Thu, 2 Feb 2012 17:48:16 +0000 (12:48 -0500)]
Update version to 2.0-pre19
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 2 Feb 2012 17:27:35 +0000 (12:27 -0500)]
Update lttng-kernel.h with padding
Rename LTTNG_SYM_NAME_LEN to LTTNG_KERNEL_SYM_NAME_LEN. (following
lttng-modules ABI).
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 2 Feb 2012 17:27:28 +0000 (12:27 -0500)]
Update lttng.h with padding
Signed-off-by: David Goulet <dgoulet@efficios.com>
This page took 0.043151 seconds and 5 git commands to generate.