Marc-Andre Laperle [Tue, 24 Nov 2015 04:27:46 +0000 (23:27 -0500)]
tmf: Try to make the shell fully visible in SWTBot at start
In certain environments, the workbench shell can be positioned at random
locations. Depending on the size of the display, it is possible that the
shell is not fully visible. This patch adds logic to the start of SWTBot
tests so that if the top shell is not fully visible, it will try to move
it in within the display bounds. If the shell cannot fit the display, it
will be positioned at the top-left corner of the display.
To be able to apply this to all test, a new utility method was
introduced, SWTBotUtils.initialize. More common code that is applicable
to all SWTBot tests could be moved there in the future.
This fix is important to some tests that can depend on whether of not
some controls get painted. For example, a drag listener is only added on
a sash when it gets first painted. If it is never painted,
TmfAlignTimeAxisTest fails when trying to drag this sash to verify the
proper behavior of time alignment.
Change-Id: Ic67739e204fcb0a4b567914e8b6078c286d56bd3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61094
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Tue, 24 Nov 2015 23:51:24 +0000 (18:51 -0500)]
lttng: Add a Binary Callsite aspect to the debug-info analysis
If the binary is not available at analysis time, we can still display
the binary file and offset information, which comes from the trace.
This information is also re-used by the source callsite.
Change-Id: I40993abedf7057fe6b27cb5c9e787f23e2331f13
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/60843
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Mon, 23 Nov 2015 23:23:02 +0000 (18:23 -0500)]
Exclude Sonar rules that are not working with jdt.annotation
Since we have moved to jdt.annotation 2.0, a few Sonar rules (FindBugs)
do not work properly and report false positives. This resulted in
around 460 false issues in Sonar. We can disable those rules for now
until the problem is resolved. A bug report was filled at the FindBugs
project:
http://sourceforge.net/p/findbugs/bugs/1425/
The exclusions are done in the pom.xml so that any Sonar server can
benefit from this fix.
Change-Id: I31db810bc8a38d96870d94d5192139e6d74527b6
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61292
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 21:46:55 +0000 (16:46 -0500)]
tmf : Avoid concatenating nonliterals in a StringBuilder
Replace the use of StringBuilder with new String()
Change-Id: I64f00a6ef52c3348b361079f0507910b5525f621
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61075
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 22:52:34 +0000 (17:52 -0500)]
lttng : Remove inefficient new String(String) constructor
Change-Id: I964e7798a852e43674ee4eb1d7ad21574dc7bd0f
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61087
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 21:35:09 +0000 (16:35 -0500)]
tmf : Avoid concatenating nonliterals in a StringBuilder
Change-Id: I0e55afcbb0bc7d8b22dcbc68185971dd043c5249
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61073
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 21:40:54 +0000 (16:40 -0500)]
tmf : Avoid concatenating nonliterals in a StringBuilder
Change-Id: I78d9c69e192aab744b110909f050b556baa929d9
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61074
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 22:18:30 +0000 (17:18 -0500)]
tmf : Use of Activator.logError() instead of System.err.println()
Change-Id: Ifbb0cd06f6fb33653a3b9892fb623d1e74c2a387
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61079
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 21:19:55 +0000 (16:19 -0500)]
tmf : Avoid concatenating nonliterals in a StringBuffer
Change-Id: Idc6a9804bc5f2b101a8ada406d7bbd362c1161c5
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61072
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Francis Giraldeau [Thu, 29 Oct 2015 14:13:39 +0000 (10:13 -0400)]
lttng: additional definitions for lttng 2.7 and 2.8
* New event sched_waking (for upcomming lttng 2.8 and linux > 4.3)
* Modified event names in lttng 2.7 for softirqs
(softirq_entry renamed to irq_softirq_entry)
Change-Id: I0c5acd0e201e41ad7f2cf6749cc2105d41523f3f
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59230
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Francis Giraldeau [Thu, 29 Oct 2015 14:15:23 +0000 (10:15 -0400)]
analysis: support sched_waking event
Use sched_waking event if available. This change is backward compatible
with previous instrumentation.
Change-Id: I28b07dc5cdfe988db8a1e11656eceac9856b1ae2
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59231
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Matthew Khouzam [Fri, 16 Oct 2015 01:34:38 +0000 (21:34 -0400)]
analysis: Clean up AlgorithmManager a bit
Change-Id: I092a78d5899bd742acdd002290f67fab06c3126d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/58290
Reviewed-by: Hudson CI
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Marc-Andre Laperle [Tue, 24 Nov 2015 04:30:26 +0000 (23:30 -0500)]
tmf: add missing jdt.annotation on tmf.remote.ui.swtbot classpath
Change-Id: I313261c38f39a03f6e4980190e5df17c7c4476a7
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61095
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Matthew Khouzam [Mon, 23 Nov 2015 23:40:40 +0000 (18:40 -0500)]
ctf: support event-header-less traces
This fixes a regression caused by overly zealous @NonNull annotations
coupled with many warnings hiding a problem. The trace reader can now
read traces without an event header again.
Change-Id: Ida701b45cd0438cfd2000443a7a725e31d96669b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61090
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Mon, 23 Nov 2015 23:39:05 +0000 (18:39 -0500)]
ctf: Support Streamless packet readers
If a stream isn't set, the default one is null. This ensures that streamless
traces work.
Change-Id: Iad06dd965e3ca1173008cec5b8e68ac3bc910cbe
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61089
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 22:44:45 +0000 (17:44 -0500)]
tmf : Remove inefficient new String(String) constructor
Change-Id: I1ee9e4c969042e27219a756daeb9d43c210d23c1
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61085
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jean-Christian Kouame [Mon, 16 Nov 2015 21:30:14 +0000 (16:30 -0500)]
tmf : Use StringBuilder in TmfRawEventViewer
Change-Id: Id144526bf60ed9cf56ea357638b1d28a9b10639b
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60558
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 21:55:34 +0000 (16:55 -0500)]
tmf : Add constant modifier to fields in TimeGraphViewer
Change-Id: I8ca8df586ccfeaf075cd4b1582f1b1d737764756
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61076
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 22:50:18 +0000 (17:50 -0500)]
lttng : Remove inefficient new String(String) constructor
Change-Id: I369520ee58dacb15e40ca9b0262f63e864ba2abd
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61086
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 22:01:00 +0000 (17:01 -0500)]
analysis : Add constant modifier to a field
Change-Id: Iea36b92dd2357915c4b1fc11ed544396f2e6ecc7
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61078
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 21:12:27 +0000 (16:12 -0500)]
tmf : Avoid concatenating nonliterals in StringBuilder
Change-Id: I18b4d61d765f77522cb27cac7bba022d0b6035ad
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61071
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 21:57:35 +0000 (16:57 -0500)]
lttng : Add constant modifier to a field
Change-Id: Ica3bc9006b575aa7a08256a00cfa24da07196e22
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61077
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 20:54:21 +0000 (15:54 -0500)]
tmf : Avoid concatenating nonliterals in a StringBuilder
Split the append() call in two separates calls
Change-Id: Ib86731f916d76002570aad71f4976f6bfdf163a0
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61070
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 20:50:21 +0000 (15:50 -0500)]
tmf : Avoid concatenating nonliterals in a StringBuilder
Split the append() call in two lines
Change-Id: Icd7b69f793bf8a19b44b89d8506981cfbad38ddb
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61069
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Fri, 30 Oct 2015 22:55:57 +0000 (18:55 -0400)]
Add annotations for Map.keySet() and .values()
The returned Set and Collection always exist (would be empty
if there are no entries in the map), so can be marked @NonNull.
The generic types K or V keep the same modifiers as the map definition.
Change-Id: If826108fbbd9abb19c7f87f9ef6e27c047425461
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59423
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Fri, 30 Oct 2015 20:33:56 +0000 (16:33 -0400)]
Annotate Collections.toArray() methods
Both variants return @NonNull array references. The one with the
(T[]) parameter can also e annotated to require a @NonNull array
reference (or else it would just throw an NPE).
Note this covers only the array references themselves. The
contained element types will depend on what is passed in parameter
Change-Id: I31bed98a0b7d1df3486179a9e60cb8c73eb0038d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59421
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Thu, 3 Sep 2015 05:16:38 +0000 (01:16 -0400)]
Fix SWTBot keyboard failure on headless Mac
Running tests that use the keyboard (AWT) on headless Mac fails with
java.awt.AWTException: headless environment
Setting java.awt.headless=false fixes this.
Change-Id: Ia693d1900a2bd8cfdeaf6816366800a872a45bad
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/55160
Reviewed-by: Hudson CI
Alexandre Montplaisir [Sat, 31 Oct 2015 19:07:19 +0000 (15:07 -0400)]
Annotate Arrays.stream() methods
They all return a real, possibly empty, Stream which
is effectively @NonNull.
Change-Id: I3602bc1b879dd88e9ab05ff1d734fcc88ff45ae5
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59426
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
Alexandre Montplaisir [Fri, 30 Oct 2015 23:39:37 +0000 (19:39 -0400)]
Annotate StringBuilder.toString()
Always returns a new String, so is effectively @NonNull.
Again, this applies to this class only and not all Object#toString()
implementations!
Change-Id: I748fd7cc6cc627266733632b9e251f87569369db
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59425
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Fri, 30 Oct 2015 20:48:15 +0000 (16:48 -0400)]
Augment annotation to Map.entrySet()
We already annotated Map.entrySet() to return a
@NonNull Set<Map.Entry<K, V>>
But actually, the returned Set should not contain any null elements,
since then entry objects will always exist, even if the key and/or
value is null. So we could augment the annotation to:
@NonNull Set<@NonNull Map.Entry<K, V>>
K and V in this case need to remain unannotated, their type should
match the Map's declaration.
Change-Id: Id436fd3cfc4f679198070e5efdbb9d2d3ce478ae
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59422
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Fri, 30 Oct 2015 11:50:17 +0000 (07:50 -0400)]
Annotate some static Collections methods
Annotate all the following methods to return @NonNull collections:
.singleton*()
.synchronized*()
.unmodifiable*()
Change-Id: Iffa8743784c68611dcd4262c526afce0509ef155
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59328
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Thu, 19 Nov 2015 05:14:48 +0000 (00:14 -0500)]
ctf: reduce cyclomatic complexity of StreamInputPacketIndexEntry
Change-Id: I8b717fca910b67e1a3150dba5010ca8d062fa5e9
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44609
Reviewed-by: Hudson CI
Marc-Andre Laperle [Wed, 18 Nov 2015 21:28:19 +0000 (16:28 -0500)]
tmf: Fix remote test failing on Windows
IFileInfo.getSize() returns 0 for directories on Windows. "For
directories, the return value is unspecified" so the right thing to do
is to add an isDirectory check.
Change-Id: I6112287adc6cef8fcd7c609edab5bbdfbd933ba3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60756
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Jean-Christian Kouame [Fri, 20 Nov 2015 20:02:03 +0000 (15:02 -0500)]
tmf : Replace String() by an empty string "" in getHelpText
Replace the creation of an empty string using new String() with ""
instead.
Change-Id: Iebbe8dfc48eb5f963dda8d196eaa57e5f32258d3
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60949
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Jean-Christian Kouame [Thu, 19 Nov 2015 21:29:21 +0000 (16:29 -0500)]
tmf : Remove literals duplication in TmfXmlReadWriteStateValue
Change-Id: I4b1a8f7323d6f47344565a0cb3a1f8d9854b4d41
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60831
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Thu, 27 Aug 2015 02:32:24 +0000 (22:32 -0400)]
ctf: Introduce IPacketReader
Introduce the IPacketReader api to allow better decoupling between the
streaminputreader and the packet reader. This allows for more packet
reader types in the future, such as an InMemoryPacketReader for streamed
in RAM traces.
The IPacketReader is currently implemented by 2 classes:
* a NullPacketReader, if there is no data to read
* a CTFPacketReader, the typical packet reader
The CTFPacketReader is quite different from the CTFStreamPacketReader. The
SPR holds on to a FileChannel and maps segments as it needs. This results in
a fast but complex sliding window like reader. On the other hand, the
CTFPacketReader will only read one packet of a stream, a new one needs to
be created for each packet. This makes it wrap a single BitBuffer. As
FileChannels are resources but Bit(Byte)Buffers are not, this means a
CTFPacketReader is NOT autoclosable.
It should be noted that ByteBuffers can hold onto a system file handle. They
are released on GC. Also, ByteBuffers as they have their handle, will not
require the fileChannel to be opened all the time, so resources can be
dynamically closed when running low on file handles.
This patch also fixes some bugs in the tests relating to uninitialized traces
and lost event locations that were hidden due to "event.equals" not working as
well as it should.
The reason this patch does two things at the same time is that the interface
required a major re-write of the packet reader. This resulted in several bugs
being highlighted and fixed. To fix them in a separate patch before would
be very time consuming, and fixing them after would mean deliberately writing
a buggy packet reader to fix it in a subsequent patch.
This change will allow the following changes down the road:
* In memory ctf reading (network streams)
* Encrypted ctf stream reading
* Compressed ctf stream reading
* Multi-threaded stream reading
* A power set of the previous elements
Change-Id: Id45b69bb0dac7a1f74f50cd732cd92064595f737
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53284
Reviewed-by: Hudson CI
Jean-Christian Kouame [Thu, 19 Nov 2015 22:11:15 +0000 (17:11 -0500)]
tmf : Remove duplicate literals in TmfRawEventViewer
Change-Id: I342db238daa4d6ed7579042279548f543b6149d6
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60835
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Jean-Christian Kouame [Thu, 19 Nov 2015 22:02:57 +0000 (17:02 -0500)]
tmf : Refactoring the comments in TmfRawEventViewer
Removing dead code and moving some comments
Change-Id: Ieecd757fca6839019265f03e146d52f36184e4cd
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60834
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Jonathan Rajotte [Fri, 20 Nov 2015 01:21:56 +0000 (20:21 -0500)]
tmf: log when an error message is displayed in a MessageBox
Provide vital information to external tools such as [1] for testing
purpose. Also allow sharing of error messages a lot more easily.
[1] https://www.eclipse.org/rcptt/
Change-Id: I2dfa6da59c566b0f6a5d55a1d092699c9afcbb26
Signed-off-by: Jonathan Rajotte <jonathan.r.julien@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60860
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Jean-Christian Kouame [Wed, 18 Nov 2015 20:45:30 +0000 (15:45 -0500)]
tmf : Use Arrays.asList() instead of a loop
Use Arrays.asList() instead of a loop in TraceValidateAndImportOperation
Change-Id: If2ccf771fe6701164c2ee6f402da780fff9875e4
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60750
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Tue, 27 Oct 2015 19:55:13 +0000 (15:55 -0400)]
lttng: make FileOffsetMapper try-with-resources in #getOutputFromCommand
Change-Id: I8c1dc1e1f81ddd4c4f442af11f91450d73142741
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59055
Reviewed-by: Hudson CI
Patrick Tasse [Fri, 20 Nov 2015 16:06:52 +0000 (11:06 -0500)]
tmf: Add check for ineffective setters in AbstractTimeGraphView
If these setters are called after the part control has been created,
they have no effect.
Change-Id: I34bab27624a98df122efd08546d1740d5d672fd8
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60940
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Tue, 17 Nov 2015 22:35:36 +0000 (17:35 -0500)]
tmf: Make call stack view extend AbstractTimeGraphView
Change-Id: I43c472c0512486e806bc1aa1db034d6268face5e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60667
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Fri, 30 Oct 2015 11:31:18 +0000 (07:31 -0400)]
Annotate often-used Collectors method
We commonly end a Stream with
.collect(Collectors.toList());
However the returned List is not null-annotated, which means it gives a
warning if we want to save it to a @NonNull List<> reference.
It could be tempting to annotate Stream.collect() directly, however that
would be wrong: there is no guarantee that some shoddy Collector does
not return a null value.
Instead, annotate Collectors.toList(), toSet() and toCollection(), which
should cover for most common use cases.
Change-Id: I8adaf55579bf5b1cc66c5fbb122acc416a4870dc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59327
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Fri, 30 Oct 2015 10:56:15 +0000 (06:56 -0400)]
common: Add a checkNotNull method to check contents of a Stream
Change-Id: I7473a5df08a20396d7716bd986a1e1f4e1e0ef27
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59325
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Wed, 18 Nov 2015 16:18:26 +0000 (11:18 -0500)]
tmf: Call synchingToTime in AbstractTimeGraphView when switching traces
When switching traces (or opening a trace for the first time) the method
synchingToTime should be called with the selection begin time, to
perform view-specific handling for the new selected time.
Change-Id: Ia1eaa248b7e6d9616bfc20375276dcc83527fb28
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60736
Reviewed-by: Hudson CI
Patrick Tasse [Tue, 17 Nov 2015 22:10:55 +0000 (17:10 -0500)]
tmf: Allow AbstractTimeGraphView subclass to set filter content provider
Change-Id: I4127bff23d3a76bb0f23758568d1211eaaa1f60f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60666
Reviewed-by: Hudson CI
Patrick Tasse [Tue, 17 Nov 2015 16:02:33 +0000 (11:02 -0500)]
tmf: Make entry comparator apply recursively in AbstractTimeGraphView
Also update ControlFlowView's comparator so that it applies correctly to
non-root child process entries.
Change-Id: If02011789f53c12ef14e128651fdcaf0daedcc8b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60665
Reviewed-by: Hudson CI
Matthew Khouzam [Tue, 27 Oct 2015 20:10:47 +0000 (16:10 -0400)]
lttng: make the field names compliant with the code style.
Change-Id: I15705a4eb0b4291fd86d09170d1a7aa58215e47a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59056
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Fri, 20 Nov 2015 15:05:59 +0000 (10:05 -0500)]
analysis: clean up KernelStateProvider
Change-Id: I39273c94aad9454fccbd4b353780863ca431b4ac
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60924
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Fri, 21 Aug 2015 20:26:18 +0000 (16:26 -0400)]
ctf: simplify search
The search now uses a java binary search instead of a house binary
search. This simplifies code a bit.
Change-Id: I9d9da2fff303f2492df502eeb856936ad94d5206
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46286
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Mon, 16 Nov 2015 20:20:02 +0000 (15:20 -0500)]
tmf: Fix wrong time for synchingToTime in AbstractTimeGraphView
It was incorrectly changed to the window start time instead of the
selection begin time in patch https://git.eclipse.org/r/55670.
Change-Id: I083a2e0d7cdc9843e0c2a0e65119a566b5a0ab1b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60664
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Patrick Tasse [Mon, 16 Nov 2015 20:14:01 +0000 (15:14 -0500)]
tmf: Increase visibility of startZoomThread in AbstractTimeGraphView
This will allow subclasses to trigger the zoom thread when implementing
their own actions, for example.
Change-Id: I798327e044e786064ae2170ded415c2a2ea2e756
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60663
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Fri, 20 Nov 2015 15:06:47 +0000 (10:06 -0500)]
lttng: add NON-NLS to string
Change-Id: I698429469932fd1412c8a56840a75d0fd77a685c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60925
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Tue, 5 May 2015 11:18:09 +0000 (07:18 -0400)]
analysis: Split up KernelStateProvider
Right now, the cpu number and threadid is looked up for each
event, this new architecture will only read the information
as need be. This should accelerate trace reading by about 5%,
also it is more intuitive, as each event has one file
describing what it does.
Change-Id: I0a2c4480b1532536727783e5470acb545f0a705b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47150
Reviewed-by: Hudson CI
Marc-Andre Laperle [Tue, 17 Nov 2015 22:24:33 +0000 (17:24 -0500)]
tmf: Introduce resolveIntEventAspectOfClassForEvent
This pattern of getting an integer aspect is used a lot,
it could be moved to one place.
Change-Id: I8ca1cf09c70457ec116f0b46bfba3654f91a013f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60662
Reviewed-by: Hudson CI
Marc-Andre Laperle [Thu, 5 Nov 2015 21:28:03 +0000 (16:28 -0500)]
Update 4.5 target with Mars.1 update sites
Change-Id: If6208c04c826c8f562eef8eaa0e617f1fa6ae99e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59786
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Wed, 18 Nov 2015 18:29:07 +0000 (13:29 -0500)]
tmf: move custom parser tests from tmf.ui.tests to tmf.core.tests
Change-Id: Ib1d54ad5ad91fe315a68d77ab41d68802fe98178
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60737
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Wed, 18 Nov 2015 18:14:39 +0000 (13:14 -0500)]
tmf: enable and fix o.e.tc.tmf.ui.tests.trace test cases
Change-Id: I19aa42577be1d1c7056299d8d29d7e9fa768257f
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60733
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Fri, 30 Oct 2015 09:47:55 +0000 (05:47 -0400)]
Fix some null warnings
Change-Id: Ibb291421d2625ab80151e4f193cc09eb8febe747
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59129
Reviewed-by: Hudson CI
Marc-Andre Laperle [Tue, 17 Nov 2015 23:24:49 +0000 (18:24 -0500)]
tmf: Make CustomText/Xml test wait until wizard shell is active
Change-Id: I097f47d121613f282d60d057fe1b3a30abd62840
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60671
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Sun, 1 Nov 2015 04:15:17 +0000 (00:15 -0400)]
ctf: Restore the downloading of the ctf-testsuite
When we migrated to using the tracecompass-test-traces, we also stopped
downloading the ctf-testsuite using git. However those are not part of
tracecompass-test-traces. Oops!
Somehow the tests didn't complain so far, but it'd be better if they
actually ran.
Change-Id: Id6b81698bf8e85d840819db8505a95f57a51685c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59438
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Jean-Christian Kouame [Mon, 16 Nov 2015 19:26:16 +0000 (14:26 -0500)]
tmf : remove duplicated lines in TimeGraphScale.java
add of the method drawAbsHeader() with a SimpleDateFormat parameter
Change-Id: I0b65c18e5b367e232e221ea3bc5fe1f2a11e3bdb
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60548
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Tue, 17 Nov 2015 23:45:52 +0000 (18:45 -0500)]
Define some Sonar properties to skip unwanted classes and modules
Those are defined in our Hudson job right now but it's nicer to
have them as a default. For example, when running locally.
Change-Id: I2224a5573162454197be5459bdabcbebb6a8349c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60674
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Tue, 17 Nov 2015 04:48:59 +0000 (23:48 -0500)]
tmf: Make Import/Export package test wait until wizard shell is active
Change-Id: I158a2328a4d534eb2a6a861d25c47d586156cc4a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60572
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Fri, 30 Oct 2015 21:43:42 +0000 (17:43 -0400)]
Annotate Long.valueOf() to return @NonNull
Change-Id: I889546810f6012ea88f34e704bf6d58221f4ac93
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59424
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Mon, 16 Nov 2015 20:27:18 +0000 (15:27 -0500)]
tmf: Fix alignment SWTBot test at low resolution
The test now runs at 640x480.
Make sure the views have enough space otherwise they might not be
painted at all and they won't react to the sash being dragged.
Change-Id: Ib7feb329e9d2fe99fc5ecf02dba122b8324eb950
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60553
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Mon, 16 Nov 2015 23:22:46 +0000 (18:22 -0500)]
Annotate parameters of Immutable collections copyOf() of()
Those methods will throw NPEs if null is passed.
Also fix a few warnings that were introduced by these new annotations.
Change-Id: I73efaa5507b1dfcf9da41c86dc93bbd8ea8b3c27
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60568
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Fri, 30 Oct 2015 11:28:43 +0000 (07:28 -0400)]
Annotate Guava Immutable collections
The following methods in Immutable{List|Set|Map} are all used
to create new collections and never return null values:
builder()
Builder.build()
copyOf()
of()
They can all be annotated as @NonNull.
Change-Id: I7149f488d2905c5def7b7b39993e9584642a4b0a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59326
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Mon, 16 Nov 2015 19:15:08 +0000 (14:15 -0500)]
lttng: add NON-NLS annotations to Lttng27EventLayout
Change-Id: Ieef1cd4c22f5747748e7fc4e69c1bd633e934ce4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60547
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Jean-Christian Kouame [Mon, 16 Nov 2015 20:19:41 +0000 (15:19 -0500)]
gdbtrace : remove occurrences of literals
Change-Id: I337dc2efba794ec3a8b12adec65c76a6c2d1a1e4
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60551
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Jean-Christian Kouame [Mon, 16 Nov 2015 17:50:30 +0000 (12:50 -0500)]
tmf : use of StringBuilder.append() instead of operator + for strings
Change-Id: Ia0156a18fb2e81db4a375d8c36d34e3ced09d55b
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60536
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Thu, 5 Nov 2015 21:07:22 +0000 (16:07 -0500)]
statesystem: Remove ITmfStateInterval.getViewerEndTime
Nothing calls it and its semantics are not well defined.
Also, it makes little sense that the state system would have knowledge
about what views want.
Change-Id: Idff4d0bf24c4173c8cd8a67ac18753dcd6fb4ff4
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59785
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Marc-Andre Laperle [Fri, 13 Nov 2015 00:27:56 +0000 (19:27 -0500)]
tmf: Fix SWTBot test on Windows related to short temp path
On Windows, the system property for the temorary path looks like this:
java.io.tmpdir=C:\Users\MARC-A~1\AppData\Local\Temp\
Which is a "short path". When used in comparison with full, canonical
paths, it fails.
Change-Id: I3a90f792791e6983c2eab60d54b1e0694ed98dab
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60273
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Patrick Tasse [Wed, 11 Nov 2015 15:21:50 +0000 (10:21 -0500)]
tmf: Fix trace markers with experiments in AbstractTimeGraphView
The key of the marker event sources map should always be the view trace.
Change-Id: Iecb458fd291c3ae1b62a5fed9f9954306f41a09a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60138
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Wed, 11 Nov 2015 14:49:12 +0000 (09:49 -0500)]
ctf: Fix CtfTmfLostEvent time range does not use timestamp transform
When a timestamp transform or trace offset was set on the trace, the
lost event time range end time was not transformed, but the timestamp
and time range start time were.
Change-Id: Ie2e79b5e90e900bdaf2e7e8391868132bd632332
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60136
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Mon, 2 Nov 2015 20:31:19 +0000 (15:31 -0500)]
Add workspace/ to the gitignore
A top-level workspace/ directory gets created by the Maven build now.
It should not be tracked in Git.
Change-Id: If8a7e0bce1c99d36f9727d642dbebf95bb11da90
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59879
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Sun, 1 Nov 2015 07:47:09 +0000 (02:47 -0500)]
lttng: Rename orphaned relayd test to TestApplication
This file is a test application that is not intented to be tested as a Junit
test but it is written as such for convenience. We use this while developping
the Live feature.
Change-Id: I705f5a9fdfcb5b01b9478fe5402b48587a4c871c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59441
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
Patrick Tasse [Thu, 5 Nov 2015 17:50:26 +0000 (12:50 -0500)]
tmf: Add Lost Events marker event source and factory
A marker event source factory for Lost Events is enabled for all traces.
The marker event source can reuse a previously returned marker list if
the requested parameters are identical to the previous request.
The event types statistics state system is updated to add a new
attribute which is used to compute the time ranges that are covered by
at least one lost event time range.
Change-Id: I2479afc3f07deb363f5847f4816940010bae3e9e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59389
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Fri, 30 Oct 2015 20:15:04 +0000 (16:15 -0400)]
tmf: Add TmfTraceAdapterFactory
Base class for a trace adapter factory. The factory creates a single
instance of each adapter type per trace, and disposes the adapter when
the trace is closed, if it is an instance of IDisposableAdapter.
Change-Id: Ieec69d17d0cff037f2df0c8dded14eef91db6f97
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59388
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Thu, 5 Nov 2015 15:43:41 +0000 (10:43 -0500)]
tmf: Support adjustment of time graph window range on range selection
When the selection range is modified and 'ensureVisible' is true, then
the window range will be centered on either the selection begin time (if
it has changed) otherwise on the selection end time, if that time is
outside of the current window.
This adjustment is now enabled in time graph views when the
TmfSelectionRangeUpdatedSignal is received.
Change-Id: I8b5ec885b00009be05222db02acd745218759131
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59758
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Fri, 6 Nov 2015 15:38:14 +0000 (10:38 -0500)]
tmf: CallStackView sets wrong bounds
Apply the same changes that were done in patch
https://git.eclipse.org/r/#/c/55593 for the AbstractTimeGraphView.
Change-Id: I3f1bf9b8cc8dc017e60d92b079e74c892e3b8530
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59856
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Mon, 2 Nov 2015 20:35:34 +0000 (15:35 -0500)]
tmf: Add keyboard shortcuts for Next/Previous Marker
Support '.' for Next Marker and ',' for Previous Marker.
Support Shift key for extending the selection, both with the keyboard
shortcut and with the action button.
Update the status line when Next/Previous Marker changes the selection.
Clarify the marker event source API to indicate that the previous and
next markers should be included in the marker list.
Change-Id: I1f435e9620030809f10f3788eca40521c8a745a9
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59512
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Thu, 5 Nov 2015 20:08:23 +0000 (15:08 -0500)]
analysis: Fix missing setItemCount in AbstractSegmentStoreTableViewer
When the last trace is closed, the table viewer input is set to null.
Its item count should also be set to 0. Otherwise this can later cause a
NullPointerException in the TableViewer.
Change-Id: Ic1d482fd5e4ee64f7969375b1fe4d8b626fa31e0
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59781
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Jean-Christian Kouame [Wed, 30 Sep 2015 18:03:57 +0000 (14:03 -0400)]
tmf : Change the order of modifiers of reinitializeCharts() in TmfPieChartViewer
Change-Id: I122d2706472dd5a421ee3e2da1c7277f90959783
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/57109
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Sat, 31 Oct 2015 19:57:55 +0000 (15:57 -0400)]
rcp: Add compile-time dependency to jdt.annotation
The rcp.ui plugin will indirectly depend on the null annotations
due to upcoming new external annotations.
Change-Id: Ief9a2635187cf3fe8ad998810a765b0bbc58176d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59419
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
Alexandre Montplaisir [Fri, 30 Oct 2015 09:42:35 +0000 (05:42 -0400)]
common: Rectify some annotations in NonNullUtils
In-line genereic type definitions should not have @Nullable/@NonNull
annotations. These should be only on the "real" parameter and/or return
types.
Change-Id: Iba75a9cf6eb9cbe4662eec25089fa91ffa079728
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59324
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Thu, 29 Oct 2015 22:34:21 +0000 (18:34 -0400)]
lttng: Remove discriminator part when parsing addr2line output
Remove discriminator part, for example: /build/buildd/glibc-2.21/elf/dl-object.c:78 (discriminator 8)
This fixed a NumberFormatException
Change-Id: I92682bee4106d64dcf2964dc98823a80597df3fa
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59298
Reviewed-by: Hudson CI
Marc-Andre Laperle [Fri, 23 Oct 2015 14:28:07 +0000 (10:28 -0400)]
Upgrade to Tycho 0.24.0
See https://wiki.eclipse.org/Tycho/Release_Notes/0.24
The immediate improvement is that it uses JDT from Mars.1 to compile.
Change-Id: Id66030216ad242996c20dbc37c8409f617838fc2
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/58819
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Bernd Hufmann [Tue, 27 Oct 2015 11:40:22 +0000 (07:40 -0400)]
lttng: update and add HR timer related events and fields
Change-Id: I87b3e1ac4a79059a2c70b1b3ef7e07be6baa4f10
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59011
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Tue, 27 Oct 2015 15:18:32 +0000 (11:18 -0400)]
analysis: Don't run latency analysis automatically
This reverts an unintentional change.
Change-Id: I5e4a9b1b8e8a2f54aac7924b78d1200f831497e6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59017
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Fri, 30 Oct 2015 20:14:14 +0000 (16:14 -0400)]
ctf: Fix simple Javadoc warning
Change-Id: I2bd8c9de68a4b10de1e751da38d4ed061c1f3a18
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59420
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Tue, 15 Sep 2015 18:54:02 +0000 (14:54 -0400)]
ss: Replace some asserts by IllegalStateExceptions
Change-Id: I692279143582c78b629d973107ec65e40f850793
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/56014
Reviewed-by: Hudson CI
Geneviève Bastien [Wed, 28 Oct 2015 03:56:45 +0000 (23:56 -0400)]
ss: Fix a bug where depth of history tree increases at each new node
When adding a sibling after a new root, there was one too many levels.
Change-Id: I19f460347cbba91c5c1f70d9ee4566a3cb164f37
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/59076
Reviewed-by: Hudson CI
Matthew Khouzam [Thu, 1 Oct 2015 00:59:02 +0000 (20:59 -0400)]
TMF: Fix behavior of XML time graph views with experiments
Expected behavior:
* Show the content of analyses when the trace contains those analyses.
* If experiment, show the content of analyses if any of the trace or
the experiment itself contains those analyses.
* Empty if no trace contains the required analyses.
Change-Id: Id04c2f9d4f1ecd9c8c466a9a0536e1b07277ea1f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/35490
Reviewed-by: Hudson CI
Geneviève Bastien [Wed, 28 Oct 2015 03:42:53 +0000 (23:42 -0400)]
ss: Fix wrong calculation of string size in history tree
The strings size was calculated twice in the node size. The nodes were
therefore not used at full capacity.
Change-Id: Iea15dfd701859deaaea7857de83c36c3455eefb9
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/52755
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Patrick Tasse [Wed, 25 Mar 2015 15:27:50 +0000 (11:27 -0400)]
ss: Add AttributeTreeTest unit test
Change-Id: I7a67d33ad694370393fa2789e2508233ec570877
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/45686
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Bernd Hufmann [Tue, 13 Oct 2015 11:47:07 +0000 (07:47 -0400)]
lttng: pack columns in latency table
Change-Id: I18855e0e4d728aca681bcd39229ca156e45cedb8
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/58062
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Wed, 28 Oct 2015 15:39:39 +0000 (11:39 -0400)]
analysis: rename latency to segment store for statistics
Change-Id: I1bd00e238843e9256d0ffcab38c1752ac0f35180
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59134
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Wed, 28 Oct 2015 15:40:39 +0000 (11:40 -0400)]
analysis: avoid division by 0 in latency statistics
Change-Id: Iaa30a5989517777b37aa4b7b21b5c4da025dcec9
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59133
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
This page took 0.045639 seconds and 5 git commands to generate.