Jérémie Galarneau [Wed, 13 May 2015 20:01:07 +0000 (16:01 -0400)]
Plug-in system update
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 6 Mar 2015 22:49:52 +0000 (17:49 -0500)]
Add discarded events notification type
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 4 Mar 2015 17:24:24 +0000 (12:24 -0500)]
Plug-in API corrections
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 4 Mar 2015 17:24:08 +0000 (12:24 -0500)]
Reader plugin skeleton
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 3 Mar 2015 17:07:52 +0000 (12:07 -0500)]
Add plugin base implementation
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 2 Mar 2015 21:49:20 +0000 (16:49 -0500)]
Add plugin interface to build system
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 3 Feb 2015 14:56:45 +0000 (09:56 -0500)]
Initial plug-in interface draft
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Sep 2016 16:14:43 +0000 (12:14 -0400)]
Port: Add glib g_mkdtemp to mkdtemp wrapper
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Sep 2016 16:14:42 +0000 (12:14 -0400)]
Port: Use glib g_mkdir
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Sep 2016 00:32:29 +0000 (20:32 -0400)]
Cleanup: bt namespace for compat glib
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Sep 2016 00:32:30 +0000 (20:32 -0400)]
Cleanup: bt namespace for compat memstream.h
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Sep 2016 00:32:28 +0000 (20:32 -0400)]
Cleanup: bt namespace for compat timegm
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Sep 2016 00:32:27 +0000 (20:32 -0400)]
Cleanup: bt namespace for compat strerror_r
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Sep 2016 00:52:21 +0000 (20:52 -0400)]
Use glib portable macros to convert gpointer to int
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 2 Nov 2016 06:01:30 +0000 (02:01 -0400)]
ax_lib_elfutils -> bt_lib_elfutils
`ax` is a prefix for the GNU Autoconf Archive. `ax_lib_elfutils`
should be namespaced within the project here, with the `bt_` prefix.
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 2 Nov 2016 05:41:13 +0000 (01:41 -0400)]
m4/ax_lib_elfutils.m4: use m4_default() for optional args.
The current macro code does not work because, if you provide 4
arguments to the macro, then `true_action` is not defined (but
it should be: it's the third argument).
Use m4_default() here to expand to a default value if the
argument does not exist.
Also use [:] instead of [] (good practice, safer for shells).
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 2 Nov 2016 05:40:12 +0000 (01:40 -0400)]
m4/ax_lib_elfutils.m4: add cache variable
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Julien Desfossez [Fri, 17 Mar 2017 20:15:23 +0000 (16:15 -0400)]
Fix: text output missing separator when printing the domain
With the "-f all" option, we expect to see
<hostname>:<domain>:<loglevel>, but instead we see
<hostname><domain>:<loglevel>.
Judging from the pattern of the other printed fields, the check for
"dom_print" variable seems to be missing when printing the domain.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 13 Dec 2016 17:17:10 +0000 (12:17 -0500)]
Fix: perform an explicit stdout flush in live even on empty packets
This ensures that babeltrace makes the content of live buffers
visible even if the data packets received are empty.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 6 Oct 2016 19:36:03 +0000 (15:36 -0400)]
Fix: documentation: output plugin is called ctf-metadata
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Sep 2016 22:47:56 +0000 (18:47 -0400)]
Fix: Use autoconf provided grep in test_formats
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Nathan Lynch [Thu, 18 Aug 2016 17:10:28 +0000 (12:10 -0500)]
babeltrace: add test for babeltrace --list
This test simply checks the converter's list of supported formats.
Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 14 Sep 2016 17:42:03 +0000 (13:42 -0400)]
Add empty plug-in hooks to prevent their elimination by the linker
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Nathan Lynch [Fri, 5 Aug 2016 20:06:43 +0000 (15:06 -0500)]
Remove useless PACKAGE_LIBS substitution
PACKAGE_LIBS isn't referred to anywhere in the project so remove this
dead code from configure.ac.
Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Nathan Lynch [Fri, 5 Aug 2016 19:59:42 +0000 (14:59 -0500)]
Do not use g_quark_from_static_string in unloadable code
The GLib Quark documentation says that g_quark_from_static_string:
"... can only be used if the string will continue to exist until the
program terminates. It can be used with statically allocated
strings in the main program, but not with statically allocated
memory in dynamically loaded modules."
https://developer.gnome.org/glib/stable/glib-Quarks.html#g-quark-from-static-string
Convert call sites of g_quark_from_static_string to
g_quark_from_string in code that is potentially unloadable. Call
sites in the babeltrace main program remain unchanged.
Signed-off-by: Nathan Lynch <nathan_lynch@mentor.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Simon Marchi [Sun, 19 Jun 2016 02:54:52 +0000 (22:54 -0400)]
CTF writer: Add function to add an integer environment field value
From the Python API, it's only possible to set an environment field
value as a string (whatever you pass, it gets stringified). This patch
adds a function to the CTF writer to allow setting an integer (int64_t)
environment field, and then exposes it in the Python interface.
The Python method Writer.add_environment_field now uses the type of the
passed value to determine which underlying C function to call (string or
integer). Any other type is rejected. This causes a behavior change,
since passing an integer value to add_environment_field used to produce
a string version of the value, whereas it will now produce an integer
version. However, I think it will now behave more closely to the
expectation of a lambda user.
Example:
w.add_environment_field("foo", 2)
Result before:
env {
foo = "2";
};
Result after:
env {
foo = 2;
};
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Simon Marchi [Sun, 19 Jun 2016 02:54:51 +0000 (22:54 -0400)]
python: Add stream event context support
This patch adds the possibility to get/set the event context type of a
stream class and set the stream context value of an event from Python.
From my experience, the value setter (Event.stream_context.setter) is
not so useful, since it looks like the context is already instanciated
when you create the event. So in order to set the values in it, you
only need to get the existing instance and set its fields. There is no
need to to re-assign the stream context instance to the event. I still
put it there for completeness.
I added an example of the usage to the existing CTF writer Python
example.
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Simon Marchi [Sun, 19 Jun 2016 15:14:29 +0000 (11:14 -0400)]
debug info: Call register_event_debug_infos for all events
The register_event_debug_infos function is responsible for setting the
debug_info_src field of the struct definition_integer representing the
"ip" context field. This pointer is used later to print the
source and binary location of the tracepoint.
Currently, it's not called for the events that have a special meaning
for the debug info analysis (statedump start, dlopen, bin_info, etc).
This means that for these events, the debug_info_src pointer keeps the
value of the previous event from that stream (since the ip field is in
stream event context, there is one instance per stream), which leads to
wrong information and/or crash. A crash can happen when the debug info
structures are cleared because a statedump start is encountered.
debug_info_src becomes a stale pointer and babeltrace tries to print a
string in free memory.
The fix is to call register_event_debug_infos for all events, which will
always set debug_info_src properly. The events used to do the debug
info analysis are still regular events and have their own location
information.
The trace in bug #1018 shows a crash caused by this issue.
Here's an example of wrong info from the same trace:
... lttng_ust_statedump:bin_info: { cpu_id = 1 }, { vpid = 28991, ip = 0x7FD26665657D, debug_info = { bin = "libX11.so.6.3.0+0x213fa" } }, ...
... lttng_ust_statedump:build_id: { cpu_id = 1 }, { vpid = 28991, ip = 0x7FD266656656, debug_info = { bin = "libX11.so.6.3.0+0x213fa" } }, ...
We can see that the ip values are different, but the debug info refers
to the same location, which is impossible. Here's the result with this
patch applied.
... lttng_ust_statedump:bin_info: { cpu_id = 1 }, { vpid = 28991, ip = 0x7FD26665657D, debug_info = { bin = "liblttng-ust.so.0.0.0+0x3557d", func = "trace_bin_info_cb+0xfa" } }, ...
... lttng_ust_statedump:build_id: { cpu_id = 1 }, { vpid = 28991, ip = 0x7FD266656656, debug_info = { bin = "liblttng-ust.so.0.0.0+0x35656", func = "trace_build_id_cb+0xbc" } }, ...
which seems more reasonnable.
Fixed #1018
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 25 Jul 2016 19:16:18 +0000 (15:16 -0400)]
Typo: configure.ac implemenation -> implementation
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Samuel Martin [Wed, 1 Jun 2016 19:56:32 +0000 (21:56 +0200)]
configure: fix uuid support detection on static build
This change adds uuid detection using pkg-config helper before falling
back on the standard AC_CHECK_LIB detection for platforms missing
pkg-config.
AC_CHECK_LIB function achieves its test by trying to link against the
requested library, without taking care of its dependency
requirements/flags that may differ between different targets.
Therefore, in case of static build, it can fail on the uuid detection
like [1], because the uuid's dependency flags (regarding gettext) are
missing.
Instead, using pkg-config to do the check will take care of getting and
setting all required flags.
This issue [1] has been triggered on Buildroot farms.
[1] http://autobuild.buildroot.net/results/43b/
43b98ddf9eb44152ed9ac4a98d887af14831d8da/build-end.log
Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 23 Jul 2016 19:59:30 +0000 (15:59 -0400)]
Fix: don't assert on lib unload failure
A library's load event might have been missed because of
discarded events. In this scenario, it is expected that its
mapping will not be found on unload.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 23 Jul 2016 19:55:09 +0000 (15:55 -0400)]
Use lib unload events to prune library mappings
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 23 Jul 2016 19:24:21 +0000 (15:24 -0400)]
Rename handle_dlopen_event to handle_lib_load_event
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 22 Jul 2016 15:41:35 +0000 (11:41 -0400)]
Use lttng-ust's new load event to track library mappings
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 7 Jun 2016 16:09:27 +0000 (12:09 -0400)]
Tests: no substitution needed for multi-trace intersection test
The use of AC_CONFIG_FILES on with src == dest causes the source
file to be deleted on make distclean.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 3 Jun 2016 11:21:29 +0000 (07:21 -0400)]
Tests: dereference of NULL pointer on allocation failure
Reported by Coverity as:
CID
1354904 (#1 of 1): Dereference null return value (NULL_RETURNS)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 3 Jun 2016 11:17:42 +0000 (07:17 -0400)]
Tests: abort dwarf test on open() failure
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 2 Jun 2016 17:40:25 +0000 (13:40 -0400)]
Fix: lttng-live does not set a trace descriptor
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 31 May 2016 11:59:46 +0000 (07:59 -0400)]
Tests: Unchecked return value in test_ctf_writer
Reported by Coverity as:
CID
1355342 (#1 of 1): Unchecked return value (CHECKED_RETURN)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 31 May 2016 11:56:10 +0000 (07:56 -0400)]
Tests: unchecked return value in test_ctf_writer
Reported by Coverity as:
CID
1355343 (#1 of 1): Unchecked return value (CHECKED_RETURN)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 31 May 2016 11:31:55 +0000 (07:31 -0400)]
Tests: Add missing --merge LOG_DRIVER_FLAGS
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Mon, 30 May 2016 20:39:02 +0000 (16:39 -0400)]
Fix: strerror_r behavior is glibc specific
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Mon, 30 May 2016 20:39:01 +0000 (16:39 -0400)]
sys/param.h is required for MAXNAMLEN on musl libc
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 30 May 2016 19:37:43 +0000 (15:37 -0400)]
Tests: unchecked return values in test_ctf_writer
Reported by Coverity as:
CID
1351745: Unchecked return value (CHECKED_RETURN)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 30 May 2016 19:31:32 +0000 (15:31 -0400)]
Tests: Unchecked return values in test_ctf_writer
Reported by Coverity as:
CID
1351744: Unchecked return value (CHECKED_RETURN)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 30 May 2016 19:19:07 +0000 (15:19 -0400)]
Tests: unchecked return values in test_ctf_writer
Reported by Coverity as:
CID
1351743 (#1 of 1): Unchecked return value (CHECKED_RETURN)
CID
1351740 (#1 of 1): Unchecked return value (CHECKED_RETURN)
CID
1351741 (#1 of 1): Unchecked return value (CHECKED_RETURN)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 30 May 2016 19:10:08 +0000 (15:10 -0400)]
Tests: Unchecked return value in test_ctf_writer
Reported by Coverity as:
CID
1349725 (#1 of 1): Unchecked return value (CHECKED_RETURN)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 30 May 2016 18:39:27 +0000 (14:39 -0400)]
Fix: undefined bit shift operation when printing octal numbers
Reported by Coverity as:
CID
1355338 (#1 of 1): Bad bit shift operation (BAD_SHIFT)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 30 May 2016 14:22:45 +0000 (10:22 -0400)]
Fix: Wrong variable checked in bin_info_child_die_has_address
"contains", which is an output pointer, is used instead of the
local boolean that is set by the call to
bt_dwarf_die_contains_addr.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 30 May 2016 06:36:56 +0000 (02:36 -0400)]
Fix: unchecked bt_ctf_field_type_set_alignment return value
Reported by Coverity as:
CID
1351742 (#1 of 1): Unchecked return value (CHECKED_RETURN)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 30 May 2016 06:31:18 +0000 (02:31 -0400)]
Fix: unchecked return value of bt_ctf_field_type_variant_get_field
Reported by Coverity as:
CID
1351741 (#1 of 1): Unchecked return value (CHECKED_RETURN)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 30 May 2016 06:26:04 +0000 (02:26 -0400)]
Fix: validate return value of bt_ctf_field_get_type_id
Reported by Coverity as
CID
1351739 (#1 of 1): Unchecked return value (CHECKED_RETURN)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Tue, 17 May 2016 19:43:59 +0000 (15:43 -0400)]
Fix: Only close valid fds in is_valid_debug_file
Fixes coverity #
1354901 and #
1354902
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Tue, 17 May 2016 19:21:44 +0000 (15:21 -0400)]
Fix: Free die_name in bin_info_lookup_cu_function_name
Fixes coverity #
1354905
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Tue, 17 May 2016 19:09:03 +0000 (15:09 -0400)]
Fix: Don't dereference null ptr in error path
Fixes coverity #
1355339
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Thu, 19 May 2016 16:21:29 +0000 (12:21 -0400)]
Standardise spelling of debug info
Debug info being short for debugging information is two separate
words. Therefore, the debuginfo spelling is erroneous. Variables and
defines throughout the code and build system should therefore use
'debug_info' or 'DEBUG_INFO', whereas command-line options and file
names should use the 'debug-info' form. In free form text
(i.e. comments and documentation), 'debug info' should be used, or the
long form 'debugging information'.
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Thu, 19 May 2016 15:50:06 +0000 (11:50 -0400)]
Fix: typo in --disable-debug-info in configure error message
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 25 May 2016 13:37:39 +0000 (09:37 -0400)]
Docs: change --clock-raw to --clock-cycles
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 13 May 2016 21:10:38 +0000 (17:10 -0400)]
Display binary location even if source and symbol lookups fail
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 13 May 2016 18:38:59 +0000 (14:38 -0400)]
Copy bindings sources to build directory
The python bindings are made up of both source and generated files.
We copy the source files to the build directory so that the build
directory contains a valid python package for use in tests.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 12 May 2016 16:43:22 +0000 (12:43 -0400)]
bootstrap: Standardize on autoreconf -vi
Don't overwrite already generated files.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 11 May 2016 19:47:35 +0000 (15:47 -0400)]
Move Python bindings to babeltrace subfolder
This change reflects the arborescence used to install Babeltrace's
python bindings and allows Babeltrace's tests to use the normal
module name namespace.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 11 May 2016 19:45:46 +0000 (15:45 -0400)]
Tests: Multi-trace stream intersection test
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 11 May 2016 17:45:10 +0000 (13:45 -0400)]
Change behaviour of stream-intersection with multiple traces
The stream-intersection currently results in the reading of
the intersection of every stream, in every trace of a Trace
Collection.
Since reading a TraceCollection returns the union of its traces,
the behaviour of this option is changed so that it returns the
union of each trace's individual "active" section, that is the
section for which all streams are active.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 11 May 2016 17:44:04 +0000 (13:44 -0400)]
Python bindings: PEP8 mandates two blank lines before class
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Fri, 6 May 2016 20:08:57 +0000 (16:08 -0400)]
Fix: ctf-text: signed base 8, 16 printout
Base 16 signed integer printout is buggy for 64-bit length: a shift of
64-bit is undefined.
Change printout of base 8 signed integer to match what is done for
base 16.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Fri, 6 May 2016 17:39:51 +0000 (13:39 -0400)]
Fix: debug-info feature enable/disable
Explicitly enabling the debug-info feature should not disable the
feature.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Thu, 5 May 2016 15:50:24 +0000 (11:50 -0400)]
Fix: swapped libelf and libdw names in configure error message
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 4 May 2016 18:36:19 +0000 (14:36 -0400)]
Don't use the .so extension on test assets
Some packaging systems, such as dpkg-source in native mode used by
Debian's daily build system, will filter out files considered unclean
prior to the build. This behavior causes our test assets to be deleted
which, subsequently, fails the make check.
Since we do not require the .so extension and these files should be
treated as blobs, we rename them to "_so".
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 4 May 2016 17:02:49 +0000 (13:02 -0400)]
Fix: warnings on Solaris10
Cast values to uint64_t before passing them to htobe64() because
the implementation on Solaris10 uses bitshifts and will complain
when passed 32bits values.
This fixes multiple warnings like:
lttng-live-comm.c:169:2: warning: left shift count >= width of type
cmd.data_size = htobe64(sizeof(connect));
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 4 May 2016 14:56:27 +0000 (10:56 -0400)]
Add missing generated tests to gitignore
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 5 May 2016 15:43:45 +0000 (11:43 -0400)]
Fix: report error when lttng-live is provided with an IPv6 address
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 3 May 2016 20:00:09 +0000 (16:00 -0400)]
Fix: invalid mix of ctf_type_id and bt_ctf_scope enums
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Tue, 3 May 2016 16:51:51 +0000 (12:51 -0400)]
Fix: PATH_MAX requires limits.h on OS X and Solaris
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 3 May 2016 15:57:58 +0000 (11:57 -0400)]
Static build fix: change link order of libtestcommon.la
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 3 May 2016 03:59:13 +0000 (23:59 -0400)]
Clean-up: change space indentation to tabs
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 3 May 2016 03:57:34 +0000 (23:57 -0400)]
Test fix: clean trace files left behind by test_ctf_ir_ref
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 3 May 2016 02:59:33 +0000 (22:59 -0400)]
Clean-up: Missing space after cast operator
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 3 May 2016 02:46:28 +0000 (22:46 -0400)]
Fix: overflow of signed integer results in undefined behaviour
The expression "min_value = -((int64_t)1 << (size - 1))"
will result in a signed integer overflow when size is 64
((1ULL << 63) > LONG_MAX).
Note that larger sizes are unsupported and checked for in the setter.
Signed overflows result in undefined behaviour and llvm takes
advantage of this to optimize away the range check
"if (value < min_value || value > max_value) {"
Surprisingly, this was not catched by GCC, Coverity, scan-build or
cppcheck.
The fix consists in computing both bounds using an unsigned long long
type and, in the case of the lower bound, negating it (resulting in a
long long).
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 2 May 2016 20:27:58 +0000 (16:27 -0400)]
Fix: potential close() of uninitialized elf_fd
elf_fd is uninitialized whenever bin is NULL.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 2 May 2016 19:26:50 +0000 (15:26 -0400)]
Clean-up: add missing new line after end of function
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 2 May 2016 19:26:32 +0000 (15:26 -0400)]
Clean-up: remove extra newline in bin-info.c
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 2 May 2016 19:26:08 +0000 (15:26 -0400)]
Clean-up: fix comment style in bin-info.c
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 29 Apr 2016 22:55:12 +0000 (18:55 -0400)]
Add tap-driver.sh from automake
Solaris 11's automake does not include tap-driver.sh.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Fri, 29 Apr 2016 22:12:42 +0000 (18:12 -0400)]
Tests: skip certain bin-info tests on failure to prevent segfault
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Fri, 29 Apr 2016 22:13:39 +0000 (18:13 -0400)]
Tests: strip ELF symbols from debuginfo-data executables with separate DWARF
Stripping the symbols prevents the framework from falling back to ELF
lookup should the separate DWARF files be missing, which would cause
tests to succeed when they should fail.
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Wed, 27 Apr 2016 16:40:30 +0000 (12:40 -0400)]
Python bindings: add has_intersection property to TraceCollection
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Wed, 27 Apr 2016 16:09:52 +0000 (12:09 -0400)]
Python bindings: make intersect_mode read-only property
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Fri, 29 Apr 2016 21:05:31 +0000 (17:05 -0400)]
Tests: Add missing debuginfo files to dist
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Fri, 29 Apr 2016 20:58:14 +0000 (16:58 -0400)]
Use tar-ustar format for dist
This is required to support file names longuer than 99 characters
when generating the dist tarball, which we require because of the
sphinx theme files in the python bindings documentation.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Fri, 29 Apr 2016 18:35:06 +0000 (14:35 -0400)]
Tests: Replace prove by autotools tap runner
This patch removes the dependency on the prove perl script
to run the TAP test suite. It replaces it with the autotools
shell TAP driver that only requires a shell and awk.
Custom arguments can be passed to the test runner with
env variables as follow:
env LOG_DRIVER_FLAGS='--comments --ignore-exit' \
TESTS='foo.test baz.test' make -e check
This tap driver also creates a log file for each test that
can then be used by another system to build a test report.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 28 Apr 2016 20:15:14 +0000 (16:15 -0400)]
Cleanup test scripts
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 28 Apr 2016 16:57:03 +0000 (12:57 -0400)]
Fix: Don't clean test scripts
Test scripts are generated by configure, not make. Therefore, we do
not want a make clean to remove them. Let automake handle dist and
clean.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Simon Marchi [Thu, 28 Apr 2016 16:43:37 +0000 (12:43 -0400)]
Fix: Make test_dwarf and test_bin_info tests work out-of-tree
When building out of tree, these tests fail to find the test data.
This patch makes them (their _complete wrappers, actually) generated
by Autoconf, so the proper path to the test data (which is in the
source directory) can be written.
We can also get rid of SCRIPT_LIST and it's custom rules.
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 28 Apr 2016 16:38:20 +0000 (12:38 -0400)]
Handle test_ctf_writer_complete like the other tests scripts
Even if test_ctf_writer_complete doesn't require any substitutions,
handle it like the other test scripts which will be less error prone
and will allow to remove all the SCRIPT_LIST custom rules.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Simon Marchi [Thu, 28 Apr 2016 02:52:19 +0000 (22:52 -0400)]
Fix: let automake handle CLEAN and DIST
Files test_seek_empty_packet and test_seek_big_trace are generated by
configuring, not by making. Therefore, we do not want a make clean to
remove them. Otherwise, doing...
* make
* make clean
* make
* make check
... fails.
Automake infers EXTRA_DIST and DISTCLEANFILES from AC_CONFIG_FILES.
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Simon Marchi [Thu, 28 Apr 2016 02:52:18 +0000 (22:52 -0400)]
Fix: Remove test_seek_empty_packet and test_seek_big_trace from SCRIPT_LIST
Since these files are generated by autoconf, they shouldn't be included
in SCRIPT_LIST, which is the list of scripts to copy from the source
directory to the build directory. This gets rid of these warnings when
building out of tree:
cp: cannot stat '/home/simark/src/babeltrace/tests/lib/test_seek_big_trace': No such file or directory
cp: cannot stat '/home/simark/src/babeltrace/tests/lib/test_seek_empty_packet': No such file or directory
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 28 Apr 2016 22:07:48 +0000 (18:07 -0400)]
configure: introduce new macro AX_LIB_ELFUTILS
elfutils has only just started providing pkg-config metadata
which makes the current version check unreliable. This introduces
a new M4 macro which checks elfutils' version using the
_ELFUTILS_PREREQ macro (defined in elfutils/version.h).
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Wed, 27 Apr 2016 21:14:14 +0000 (17:14 -0400)]
Docs: fix typos in babeltrace-log(1) manpage
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Wed, 27 Apr 2016 20:58:30 +0000 (16:58 -0400)]
Docs: update debuginfo doc
Update the output format in the examples and document the new
--debug-info-target-prefix and --debug-info-full-path command line
options.
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.04323 seconds and 4 git commands to generate.