Francois Chouinard [Wed, 19 Sep 2012 17:18:43 +0000 (13:18 -0400)]
Rename 'locationData' to 'locationInfo' (for lack of a better name...)
Change-Id: I1980f6bd4f9a522804d6b782be1bb32261f917df
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7841
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Francois Chouinard [Wed, 19 Sep 2012 17:16:59 +0000 (13:16 -0400)]
Remove the generic location (replace by Comparable)
Change-Id: I05d4c813d0e2406f47e78beae992da6369f977ce
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7840
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Francois Chouinard [Wed, 19 Sep 2012 17:16:25 +0000 (13:16 -0400)]
Make TmfLocation abstract and implement a couple of Tmf<type>Location
Change-Id: I1a8c3fdef01a9ec9c548592d1c71a248e6d9bd60
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7839
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Wed, 19 Sep 2012 19:31:05 +0000 (15:31 -0400)]
Merge branch 'master' into lttng-kepler
Conflicts:
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/TimeGraphControl.java
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/TimeGraphTooltipHandler.java
Patrick Tasse [Wed, 19 Sep 2012 15:12:45 +0000 (11:12 -0400)]
Fix for bug 389907: Mouse drag zoom and other time graph mouse fixes.
Change-Id: Ib7ad84872ff680c1ea1cfdd27d8996a55a64b013
Reviewed-on: https://git.eclipse.org/r/7831
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Tue, 18 Sep 2012 19:31:28 +0000 (15:31 -0400)]
tmf: Define the StateChangeInput's event type at the constructor
instead of using an abstract method just for that.
With this we can also check in the abstract class itself if the
event type is the right one before calling the method from the
sub-class.
Change-Id: I0cbce6c87e3ec51acfac4061c9db38f32bbcce9a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7807
Tested-by: Hudson CI
Alexandre Montplaisir [Mon, 17 Sep 2012 20:58:05 +0000 (16:58 -0400)]
tmf: Add an abstract class for the StateChangeInput
The state-change-input plugin needed by the state system is
currently offered through a IStateChangeInput interface.
However much of the code is common between implementations.
Furthermore, the LTTng kernel plugin nicely splits the work
in two threads, so it would be great to be able to easily
re-use that feature.
This introduces a AbstractStateChangeInput class which will
provide a good ground base for building a state input plugin.
It will also wrap the multi-thread part of the code, so other
inputs can benefit from it.
The interface remains available for more exotic use cases.
Change-Id: I8c9210af62b63b48ffcdc54b3da35df7754e1583
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7798
Tested-by: Hudson CI
Alexandre Montplaisir [Thu, 16 Aug 2012 19:52:23 +0000 (15:52 -0400)]
tmf: Rename TmfLocation.fLocation to .fLocationData
and the corresponding methods (getLocationData(), etc.)
Simple rename, to make it more clear the contained value is
(usually) not a Location itself. This way we don't get things
like foo.getLocation().getLocation().
Change-Id: Ia25fde3c834dfed03671079a93be4dfc66f4b328
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7262
Francois Chouinard [Mon, 17 Sep 2012 21:19:22 +0000 (17:19 -0400)]
Re-factor and freshen up TmfCoreTracer (previously Tracer)
Summary of main changes:
- Renamed o.e.l.internal.tmf.core.Tracer to TmfCoreTracer
- Removed the error/warning/info tracing classes (already handled by
activator)
Change-Id: Ic75a05c6add22b6c29b699d928bb830124db6a73
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Alexandre Montplaisir [Thu, 6 Sep 2012 20:49:51 +0000 (16:49 -0400)]
tmf: CtfTmfEvent improvements
- Remove extraneous Javadoc
- Change fTimestamp from a singleton to a proper field, set at
the constructor.
- Drop unneeded singletons (fReference and fSource)
- Remove getTimestampValue(), call getTimestamp.getValue() instead,
it is more compatible with ITmfEvent/Timestamp interfaces.
Change-Id: I0522a40f3817bcc34bde48dc90358fb745f7bdbc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7648
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
Patrick Tasse [Fri, 24 Aug 2012 17:52:57 +0000 (13:52 -0400)]
Fix for bug 387934: Single event experiment not shown in events table.
Change-Id: Ic0984c905f2f7d5b7ca60734eda9e2b54f692243
Reviewed-on: https://git.eclipse.org/r/7386
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>
Alexandre Montplaisir [Thu, 13 Sep 2012 20:07:40 +0000 (16:07 -0400)]
Merge branch 'master' into lttng-kepler
Conflicts:
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsTable.java
Change-Id: I553c88f56037dc35b9f646887b12d83e623d3543
Matthew Khouzam [Fri, 7 Sep 2012 18:20:15 +0000 (14:20 -0400)]
ctf: Correctly handle big-endian traces
Fixes the opening of big-endian traces, coming from PowerPC systems
for example.
Closes bug 389002.
Change-Id: I1bd85b80931b8a7c61e6dd2b4b575e8608195bb6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7655
Tested-by: Hudson CI
Alexandre Montplaisir [Tue, 11 Sep 2012 20:30:06 +0000 (16:30 -0400)]
ctf: Fix feature.xml to allow building with pde-build
When trying to build the CTF feature with pde-build, it currently
fails because of unsatisfied dependencies.
We need to:
- Remove the e.o.l.ctf.parser dep completely (the feature ships
this plugin, it cannot depend on it before it's built!)
- Change the order of the plugins so .parser is built first, since
the .core depends on it.
Side note, this .parser plugin is the only one (apart from the help
plugin) that does not get put into a jar when built. I really have
no idea why...
Change-Id: Id520ba5fe4b2aa064f0850748774e14a6b83e49b
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7716
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Xavier Raynaud [Wed, 12 Sep 2012 15:15:12 +0000 (17:15 +0200)]
oups, revert last commit
Patrick Tasse [Tue, 11 Sep 2012 19:46:46 +0000 (15:46 -0400)]
Fix for bug 386075: Show the TID number in the Resource View's tooltip.
Change-Id: I83c30e7d33fed5184e0c430e34c9829f57a11283
Reviewed-on: https://git.eclipse.org/r/7714
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Xavier Raynaud [Wed, 12 Sep 2012 15:01:10 +0000 (17:01 +0200)]
TMF: add support for popup menu in time chart widgets
Patrick Tasse [Wed, 12 Sep 2012 14:11:50 +0000 (10:11 -0400)]
Fix for bug 389328: Provide hover time for time graph tool tip info.
Change-Id: I2eaf701ff090fbac1a48f5bc159d27e64dd3938d
Reviewed-on: https://git.eclipse.org/r/7713
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Patrick Tasse [Tue, 11 Sep 2012 20:23:58 +0000 (16:23 -0400)]
Fix for bug 389300: Events table does not synchronize on search.
Change-Id: Ic403e97022f665278059f356b71ef33976242c66
Reviewed-on: https://git.eclipse.org/r/7715
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Thu, 23 Aug 2012 20:18:01 +0000 (16:18 -0400)]
tmf: Enhance TmfEventField.toString() to also print sub-fields
Move the logic to print sub-fields of a TmfEventField into the
base class' toString() method. This removes the need for a
specific CtfTmfContent type.
Change-Id: I4916ab9e0de843b2713ebc40ac8ad376848ab2c1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7382
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Fri, 7 Sep 2012 18:41:46 +0000 (14:41 -0400)]
Merge branch 'master' into lttng-kepler
Conflicts:
lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/ctfadaptor/CtfTmfTrace.java
Change-Id: Ia7e1b8a4cb52d9839f1f6d43d77074e08bcf464f
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Fri, 7 Sep 2012 15:16:20 +0000 (11:16 -0400)]
Add null check of the current event in initTrace() (Bug 389064)
Change-Id: I7d3212370e46b481ae16660997b9fc6810e11c53
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7662
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Fri, 7 Sep 2012 12:18:32 +0000 (08:18 -0400)]
Allow LTTng Control to connect to LTTng 2.x.y nodes (Bug 388545)
Commit includes
- Support of remote nodes that have LTTng Tools 2.x.y installed
- Display of LTTng Tools version in Properties View
- Update JUnit tests
Change-Id: I3dd19cf8ded4ffd74a2ff9f92fbd55c8e1b38c4c
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7584
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Thu, 6 Sep 2012 19:59:51 +0000 (15:59 -0400)]
Merge remote-tracking branch 'origin/master' into lttng-kepler
Patrick Tasse [Wed, 5 Sep 2012 21:22:15 +0000 (17:22 -0400)]
Fix time graph scale absolute tick format and tick calculation.
Change-Id: I9b5bb44c860ac08f298a8213b6961d8dcbe949f5
Reviewed-on: https://git.eclipse.org/r/7629
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Thu, 6 Sep 2012 15:01:52 +0000 (11:01 -0400)]
tmf: Clarify column titles in the satistics view
The "Partial event count" in particular was confusing to most
new users. I propose renaming it to "Events in selected time range".
Change-Id: I4e778a6c670f62d6116176f6f0e1cf50a29a0522
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7644
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Patrick Tasse [Wed, 5 Sep 2012 18:07:57 +0000 (14:07 -0400)]
Store event in TableItem data.
Change-Id: I89b9c854dd9ac1eae1527f9f95a995d7f84237ef
Reviewed-on: https://git.eclipse.org/r/7625
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Patrick Tasse [Wed, 5 Sep 2012 17:49:20 +0000 (13:49 -0400)]
Add tree handling APIs and fix tree synchronization in TimeGraphCombo.
Change-Id: Ic3f871a72eea0cdf97de146634075a42dd47f550
Reviewed-on: https://git.eclipse.org/r/7624
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Patrick Tasse [Wed, 5 Sep 2012 17:26:06 +0000 (13:26 -0400)]
Add thousands space separator for nanosecond timestamp output.
Change-Id: I76de73c1cc9ce0319b97a0be9b2cc8ca454e1615
Reviewed-on: https://git.eclipse.org/r/7623
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Tue, 4 Sep 2012 19:48:09 +0000 (15:48 -0400)]
Update since annotations after merge from master
Change-Id: I5164d5b50e81e5ce1b278a7405c56beeb5ca224f
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7606
Tested-by: Hudson CI
Bernd Hufmann [Tue, 4 Sep 2012 19:19:57 +0000 (15:19 -0400)]
Merge branch 'master' into lttng-kepler
Bernd Hufmann [Wed, 29 Aug 2012 19:09:27 +0000 (15:09 -0400)]
Add support pin in TmfView base class (Bug 388372)
Change-Id: I8d5710ab56165b9db296629a4eeb73982995fad5
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7500
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>
Bernd Hufmann [Fri, 31 Aug 2012 17:36:07 +0000 (13:36 -0400)]
Merge branch 'master' into lttng-kepler
Bernd Hufmann [Fri, 31 Aug 2012 14:11:19 +0000 (10:11 -0400)]
Add support for UST-only nodes in Control View (Bug 388477)
- Updated command parser for "lttng list -k"
- Disable Kernel in Enable Channel and Enable Events on session
level if no kernel is available
- Add JUnit tests
Change-Id: If6dd01df26a1bcc5cf237b1f9c39d2246dd8a324
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7529
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Tue, 28 Aug 2012 14:58:16 +0000 (10:58 -0400)]
Add support for displaying of CTF context info in TMF (Bug 385494)
Change-Id: Ib1ca3094b7d203ac4207fb027d48629028571de4
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7456
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Tue, 28 Aug 2012 11:49:57 +0000 (07:49 -0400)]
Provide interface for showing state type names per time graph entry
This change adds an interface to the ITimeGraphPresentationProvider to
allow user to define state type names per entry instead of one name
for all entries. This change also provides a default implementation.
In case that the entry specific name and the global name are define
then the entry specific name takes precedence when displaying the
tooltip information during hovering operation.
Change-Id: Ib3d545588bf8e09ee58532a2145ee0c6294ec2be
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7451
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Mathieu Denis [Fri, 24 Aug 2012 21:26:48 +0000 (17:26 -0400)]
tmf: Update test cases of the statistics
Adds test cases for partial event count and updates the existing test
cases.
Change-Id: Ic4186eaab2ac9a7f5937179023a29f2dcc4630ec
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/7419
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Mathieu Denis [Fri, 24 Aug 2012 18:49:40 +0000 (14:49 -0400)]
tmf: Dispose of the model in the statistics viewer
Fixes bug 388022
When a statistics view is disposed, it cleans the complete static model
that may still be in used by another statistics view. It is useless to
suppress the complete model in the view, since the viewers are the one
responsible to delete their own data.
Change-Id: I450b935cebf317c9afca24858aef41139bd055e3
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/7407
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Mathieu Denis [Thu, 23 Aug 2012 21:03:32 +0000 (17:03 -0400)]
tmf: Correct event type in statistics
Use the eventType.getName() rather than eventType.toString() for the
event type name to show in the statistics.
Change-Id: I55e17249b84b8ae2d28405c3036b089ea90c6507
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/7384
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Mathieu Denis [Thu, 23 Aug 2012 20:56:19 +0000 (16:56 -0400)]
tmf: Complete the statistics API
There were missing methods and fields in the statistics API to make it
logically complete.
Change-Id: I9d5078d1ed3f75e358c3b840cb1bf213d53caf6a
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/7383
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Thu, 23 Aug 2012 21:21:12 +0000 (17:21 -0400)]
Save the encoding type as project settings
To better deal with contributors on different platforms
*cough* Patrick *cough*
Change-Id: Id3b02751f166594891c72941d3e5e5912a423caa
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7387
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Mathieu Denis [Wed, 22 Aug 2012 21:34:50 +0000 (17:34 -0400)]
tmf: Correct the statistics partial event count
Fixes bug 387838
Reload correctly the partial event count in the statistics view when an
experiment is reselected during its indexing.
Change-Id: I1f5aaf7d54812ba2f934e173df5268c7eb24e869
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/7357
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Thu, 23 Aug 2012 18:30:30 +0000 (14:30 -0400)]
Fix clone of CtfTmfTimestamp in CtfTmfEvent.
Change-Id: I7e118cf0c9b82990ed9628acf66c004eab37f0b7
Matthew Khouzam [Wed, 22 Aug 2012 19:47:29 +0000 (15:47 -0400)]
Fix seek by ratio in CTF
Change-Id: Ie7165f379608bf0eadda387c49b5d1e38eeb1963
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/7369
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Wed, 15 Aug 2012 15:49:20 +0000 (11:49 -0400)]
ctf: Simplify StreamInputPacketReader
- Make all internal structures final, initialize them in
the constructor.
- Remove all the public getters and setters for those, they
are only used internally.
- Replace a couple more null checks by "instanceof" checks.
(previously, if a field name was present but not of the
right type, it would throw a ClassCastException)
Change-Id: If4376a6310b48737a45892399dbb935e647ef0d8
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7241
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Mathieu Denis [Wed, 22 Aug 2012 15:47:36 +0000 (11:47 -0400)]
tmf: some updates to the statistics
- Changes the statistics node reset behavior to avoid useless
operations;
- Removes unused messages;
- Updates some javadoc;
Change-Id: I5af35217a711cdce06807929c4621dfb88cd2fa1
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/7333
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Mathieu Denis [Tue, 21 Aug 2012 21:09:36 +0000 (17:09 -0400)]
tmf: Refactor the statistics
Manage the viewer input directly in the viewer rather than in the view.
Change-Id: I2ed5ee303036d384939d5a2a121e30462c9c9fb7
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/7332
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Mathieu Denis [Tue, 21 Aug 2012 21:10:21 +0000 (17:10 -0400)]
tmf: Fix reload of the same trace for statistics
Fixes bug 387639
Avoids deleting the statistics tree if the global request gets
canceled.
Change-Id: I596930b2b08ea796bd82c920d836c90a86cafe09
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/7308
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
Patrick Tasse [Wed, 22 Aug 2012 18:19:35 +0000 (14:19 -0400)]
Fix context location after first event seek.
Change-Id: I84205cede4cf7d3a4f561b61cbcbf0812fece512
Reviewed-on: https://git.eclipse.org/r/7353
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Tue, 21 Aug 2012 20:33:18 +0000 (16:33 -0400)]
Fix NPE with traces that are time scaled.
Change-Id: I733ccd4e29c42fb3239c25f5e8dc6f7959000e13
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/7337
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Fri, 3 Aug 2012 17:59:15 +0000 (13:59 -0400)]
Add time scaling support
Useful if your clock is not == 1.0 ghz
Change-Id: Ie81bfa6b4379d5cbe5b88abae22618bc5a08dc3f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/7104
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Bernd Hufmann [Tue, 21 Aug 2012 18:49:57 +0000 (14:49 -0400)]
Updated Enum handling for a CTFTmfEventField
This change provides a way to extract the Enum long value and Enum
value name from the CTF EnumDefinition and store it in a
CtfTmfEventField object. Before this change the CtfTmfEventField
only contained the Enum value name.
For this change, the class Pair<A,B> which was part of the legacy
LTTng core is now integrated in TMF core.
Added JUnit tests for Pair class.
Change-Id: I948d3b9bdde83d5eda7c8397c1b9494e15f7706a
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7326
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Mathieu Denis [Wed, 15 Aug 2012 21:04:37 +0000 (17:04 -0400)]
tmf: Updates statistics test cases
Change-Id: I5c40b27da713dd67e5e39abdc09f0c7cafe016fa
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/7306
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Fri, 17 Aug 2012 22:23:35 +0000 (18:23 -0400)]
tmf: Add unit tests for the state system stack-attributes
Since the reference LTTng kernel handler does not make use
of stack attributes, this part of the code should be covered
by stand-alone unit tests.
Change-Id: I5888a450dc104229970f41e9aa5a7cf0bf45633d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7289
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Sun, 19 Aug 2012 00:03:56 +0000 (20:03 -0400)]
tmf: Correctly use null values for empty stacks
When removing the last element of a stack attribute, the
popAttribute() method would leave the stack-attribute (which
represents the depth of the stack) with a state value of 0.
We expect a null value for empty stacks, and the integer
representation of a null value is -1. This would make it
impossible to re-use an attribute stack after it was completely
emptied once.
This patch fixes this by correctly assigning a null value when
emptying a stack.
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Change-Id: If2d4edc8a0bee55f007a4dcbffefe44f513f567d
Reviewed-on: https://git.eclipse.org/r/7288
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Fri, 17 Aug 2012 21:11:45 +0000 (17:11 -0400)]
tmf: Add a convenience method to query stack attributes
Change-Id: Iad7ecdfd5580e819837f69c444583b805f0864e4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7287
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Fri, 17 Aug 2012 20:46:56 +0000 (16:46 -0400)]
tmf: Return the removed value in GSS's popAttribute()
When calling IStateSystemBuilder.popAttribute(), it will now
return the state value that was popped from the stack. This
can help with sanity checks, dealing with lost events, etc.
Change-Id: I2853bd2fa17d40193ea336080a64f60818aa9242
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7286
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Tue, 7 Aug 2012 18:59:34 +0000 (14:59 -0400)]
Fix previous commit
Commit
1ff9cea was actually a rebased Patch Set #1 on
https://git.eclipse.org/r/#/c/7134/
This small patch adds the delta that was part of Patch Set #2,
which is the correct one.
Change-Id: I17a374e4a7e8e29a05f19466cfd4b6b380a5afdc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Tue, 7 Aug 2012 18:59:34 +0000 (14:59 -0400)]
Drop the legacy LTTng 0.x plugins
Here comes the axe!
LTTng 0.x has been unsupported upstream for more than 2 years now.
The plugins themselves haven't received any new development since
then.
We plan to drop support for LTTng 0.x in Linux Tools 2.0. It will
remain supported in the Linux Tools 1.x branch.
This will open the door for some future improvements that were
impossible to make with this codebase still around. For example,
immutable timestamps in the framework.
Change-Id: I176f6e03012cb7e4a11e4dd6fd450272b015ca36
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7134
Mathieu Denis [Fri, 10 Aug 2012 19:15:25 +0000 (15:15 -0400)]
tmf: Use tabs in statistics view for each traces
When an experiment/trace is selected, the statistics view creates a
global viewer and a specific viewer for each trace contained in the
experiment. These viewers are placed in tabs and shown in the
statistics view. Also, a factory is now used to create a viewer based
on his definition in the plug-in.xml from the trace type. An
extension point element has been added to the trace type extension
point to provide custom statistics viewer.
Fixes bug 387217 on bugs.eclipse.org
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Change-Id: I8d380e8c28cba855b5361069200e50ab0cbca7f3
Reviewed-on: https://git.eclipse.org/r/7042
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Thu, 16 Aug 2012 14:21:46 +0000 (10:21 -0400)]
Fix compilation error in legacy LTTng
Change-Id: Ie32d799ef382276b52221697e912b96bf1a0d86b
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7258
Alexandre Montplaisir [Thu, 9 Aug 2012 20:26:00 +0000 (16:26 -0400)]
ctf: Handle absence of stream and event IDs
As per the CTF spec, a trace could define no stream_id field
in its packet headers. In such a case, the parser should assign
it ID 0.
Similarly, if only one event type is present, the event id field
is optional, and 0 should be used if it's not explicitely set.
Partially fixes bug #387039
Change-Id: I38dcdbdefc6c18a16b2ad8fb9ad6135303da208f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7203
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Tue, 14 Aug 2012 18:50:35 +0000 (14:50 -0400)]
tmf: Un-deprecate CtfLocation's constructor
The new recommended constructor adds an "index" parameter.
However I think it's worth keeping the previous one, and have
it use a default value of 0.
Change-Id: I21d33c99471d0e4622a3334085b27c223e5b76f2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7224
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Tue, 14 Aug 2012 17:45:44 +0000 (13:45 -0400)]
tmf: Fix visibility warning with TmfRequestExecutor
TmfDataProvider.fExecutor is protected, but TmfRequestExecutor
is not part of the public API. This means any class from another
plugin extending TmfDataProvider couldn't access the fExecutor.
Solve this by making the fExecutor field private, and supplying
protected access methods.
Change-Id: Ia3df1247fe2a6c98c87048bb17c9bc3529abfd47
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7223
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
Mathieu Denis [Tue, 31 Jul 2012 21:32:48 +0000 (17:32 -0400)]
tmf: Generalization of the statistics view
The creation of the statistics view is now based on the type of the
trace selected and his plugin definition. Thus, it is easier to provide
a new implementation of the statistics for a different kind of trace.
Change-Id: If105007a5f349565c14cdf6e5e084a4ab5d227b3
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/7041
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Fri, 10 Aug 2012 19:49:19 +0000 (15:49 -0400)]
Fix JUnit test failing after previous merge
Change-Id: Ie35a0947b90c95405ab3c887b4a8577a37097c60
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7188
Francois Chouinard [Thu, 9 Aug 2012 20:19:32 +0000 (16:19 -0400)]
Temporary fix API version for Kepler
The version in the master branch is correctly set to '1.2', the upcoming
version for that branch.
Since there are major API changes in the lttng-kepler branch and that
there is no '1.2' baseline yet, the API tool insists on a '2.0' version
being provided for these files.
The issue will be resolved LT 1.2 is released and we merge the master
branch in lttng-kepler: at that point everything should fall in place
as we have to undo these fixes to get rid of the API errors.
Change-Id: I3164f7d4facbd909540abb3dca66b3ba7627145a
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7174
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Fri, 10 Aug 2012 00:12:19 +0000 (20:12 -0400)]
Merge branch 'master' into lttng-kepler
Conflicts:
lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/request/TmfCoalescedDataRequest.java
lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/request/TmfCoalescedEventRequest.java
Francois Chouinard [Thu, 9 Aug 2012 18:57:45 +0000 (14:57 -0400)]
Fix a sporadic distribution problem in the TMF coalesced requests
When a data/event provider receives a set of requests during the
processing of a signal, it will do its best to coalesce these requests
in order to minimize the number of physical accesses that need to be
performed on the back-end traces.
The coalesced request, itself being a request, also has a data type. By
default, its data type is determined by the first sub-request coalesced
by the data/event provider. Afterwards, when it receives data from the
back-end, it dispatches the data/events to the appropriate sub-request.
This works fine for homogeneous experiments (same trace/event types).
However, when dealing with heterogeneous traces or even with different
event types during a given session, the coalesced event type, being
determined by the first sub-request, can in fact hide the data/events
for sub-requests whose data type is not an extension of the base type.
This fix forces the data type of the coalesced request to ITmfEvent
therefore ensuring that the data meant for the sub-requests is not
inadvertently filtered out.
Change-Id: I2862f7ca30d38c968968dd6cd41f6cc04bbcd9a4
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7171
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Francois Chouinard [Thu, 9 Aug 2012 17:55:31 +0000 (13:55 -0400)]
Add a generic 'lost events' event to TMF
Change-Id: Ic7d1189e3bca397a4bb7a775e7b1757dfde00926
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7100
Bernd Hufmann [Wed, 8 Aug 2012 14:23:38 +0000 (10:23 -0400)]
Update Sonar version in LTTng pom.xml
Change-Id: Ia6b451f22ce8418e3f1726f8f42125ce87d4023c
Reviewed-on: https://git.eclipse.org/r/7141
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Matthew Khouzam [Thu, 2 Aug 2012 17:27:03 +0000 (13:27 -0400)]
ctf: BitBuffer improvements
Minor performance improvements. Simplified the API a bit:
Removed the 'index' parameter from the public API in read()
and put() methods. All reads/writes can be done from the
current position, and this position can be set with position().
Updated the tests accordingly.
Change-Id: I24b30f2a2e5d79be1b873795ebd4183b70551907
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7076
Reviewed-by: Philippe Proulx <eeppeliteloop@gmail.com>
Bernd Hufmann [Tue, 7 Aug 2012 17:32:22 +0000 (13:32 -0400)]
Merge branch 'master' into lttng-kepler
Bernd Hufmann [Tue, 7 Aug 2012 14:01:38 +0000 (10:01 -0400)]
Added destination parameter for LTTng specific releng site
With this commit it is possible to specify the destination directory
of the LTTng update site when building profile lttngPackage from
Maven command line. Use "-DlttngPackageDestination=<path>"
Change-Id: I89224d438dbea373655ff3b5d4c94150caa854bb
Reviewed-on: https://git.eclipse.org/r/7133
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Matthew Khouzam [Thu, 2 Aug 2012 14:47:22 +0000 (10:47 -0400)]
ctf: Fix lost events in a more elegant way
- Read the stream context packet once instead of at each load
of the packet.
- Clean up code.
- Change the API to handle seeks to a specific event in a timestamp.
- Update test cases.
Change-Id: I0dddf56645bc0b8a69256ac947f3a806d1cfedf3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7075
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Mon, 6 Aug 2012 20:11:16 +0000 (16:11 -0400)]
Fix Statistics JUnit test
New implementation of TMF statistics feature shows 3 columns
instead of 2. This has been updated.
Change-Id: I6fef4cae9a95e63a15e71129152f3127221b77b6
Reviewed-on: https://git.eclipse.org/r/7121
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Tue, 31 Jul 2012 20:36:50 +0000 (16:36 -0400)]
lttng: Fix off-by-one in the check for new attributes
In some places, we want to check if a get*AndAdd() call just
created an attribute, or re-used an existing one. The correct
way to check for this is if (quark == ss.getNbAttributes() - 1).
The -1 was missing.
Since this test comes relatively often, also add a specific method
to the interface, so it makes the code clearer.
Change-Id: Idc3f9a508cd670914236bce603e1d5202787a46c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7103
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Fri, 3 Aug 2012 16:59:09 +0000 (12:59 -0400)]
tmf: Fold IStateSystemQuerier2 back into IStateSystemQuerier
Let's make use of the API break to re-simplify those interfaces.
Also dropped one of the range query methods, it is covered by
the new one.
Change-Id: If473d55983604b0cb52182009d1e79d4b9809eb7
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7102
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Mathieu Denis [Fri, 27 Jul 2012 23:19:06 +0000 (19:19 -0400)]
tmf: Add a column in the statistics view
Bug 383246: Add a column for statistics only in the visible window
Change-Id: Ic619c3297f815052e6c90fee7bc87097986fe6ef
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/6984
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>
Alexandre Montplaisir [Fri, 3 Aug 2012 15:51:52 +0000 (11:51 -0400)]
Merge branch 'master' into lttng-kepler
Alexandre Montplaisir [Thu, 2 Aug 2012 17:21:11 +0000 (13:21 -0400)]
tmf: Fold StateHistorySystem back into StateSystem
At first, a distinction was made to differentiate state systems
that would have a history backend, and those that would not.
In practice, history-less systems are never used, and wouldn't
even work since some recent refactoring.
If we ever need to implement a history-less statesystem, it would be
cleaner to simply use a dummy backend which discards all the
intervals, and returns null or similar on all past queries.
Change-Id: I5c04f9514236878f6f53190f862347a5b19308f4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7070
Bernd Hufmann [Fri, 3 Aug 2012 13:04:08 +0000 (09:04 -0400)]
Partially revert commit "Drop unused dependencies from tmf..."
Added missing Required-Bundle org.eclipse.ui.navigator.resources
to TMF UI MANIFEST.MF.
Change-Id: I715a500b3383f628253d481dffb26f4ad4a970f8
Reviewed-on: https://git.eclipse.org/r/7098
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Tue, 31 Jul 2012 20:27:34 +0000 (16:27 -0400)]
lttng: Handle the statedump events
Back when the state provider was first developed, LTTng did
not support the statedump (dummy events that show the current
state of all the running processes).
This support was added to upstream LTTng since then, so the
TMF viewer should make good use of this information!
Change-Id: I194fa8f31051b5755ed35e1594d33e47dcceec7a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7032
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 2 Aug 2012 19:29:22 +0000 (15:29 -0400)]
tmf: Handle state changes ending after the trace ends
Since it's possible to add states ending in the future, we
have to handle the case where a state would end past the
trace's end time (and the history's end time). We simply
discard it in this case.
Change-Id: Ic0c525aece776cb4e742d8829e420d50570b36a0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7077
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Mon, 30 Jul 2012 20:59:27 +0000 (16:59 -0400)]
Drop unused dependencies from tmf,lttng2,ctf packages
Change-Id: I7d17f254f5e4a5073501ede6bd723db6f9f75dfa
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7022
Alexandre Montplaisir [Mon, 30 Jul 2012 20:30:52 +0000 (16:30 -0400)]
lttng: Change external dependencies to imported packages
The external dependencies for ctf and lttng2 (RSE and Antlr) were
set as "required bundles". This means the exact plugin must be
present in the current installation when building the workspace
from within Eclipse.
This commit changes those to Imported Packages, which relaxes the
origin of the package. This allows distribution-installed plugins
to fulfill the build dependency.
Change-Id: Ie20d19959d819fc834dc045ec0520285fae2cf2d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7021
Mathieu Denis [Thu, 26 Jul 2012 19:48:21 +0000 (15:48 -0400)]
tmf: formatting of tmf.ui.statistics
- Remove trailing whitespaces;
- Replace tabs for spaces;
- Remove html tags;
- Format blocks;
- Correct warnings.
Change-Id: I560b7d9c66e2ed23c3850ecf9e74ccc4ffaf8779
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/7005
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Mon, 18 Jun 2012 16:50:43 +0000 (12:50 -0400)]
Fix the fallout of the generics-removal in legacy LTTng
Change-Id: If21e98b5fa81eaeced24d1bcd507103e923546b4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6970
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>
Alexandre Montplaisir [Tue, 5 Jun 2012 21:47:03 +0000 (17:47 -0400)]
tmf: Drop generics from ITmfTrace and TmfExperiment
Most of the generics are redundant now that we have interfaces.
In this case, the ITmfEvent type is always implied.
Lots of lines affected, but most of it is just removing the
stuff in brackets.
Fixes bug #382905
Change-Id: Ic857457d3ecea6ba4e369c79e9b24255572bfa77
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6969
Alexandre Montplaisir [Thu, 26 Jul 2012 21:47:48 +0000 (17:47 -0400)]
tmf: Bump plugins version to 2.0 for Kepler branch
Since 1.2 is not yet released, we have to fake all the existing
"@since 1.2" methods to "@since 2.0".
When we merge this branch back into master (which should be after
the 1.2 release), these should be reverted to "@since 1.2".
Change-Id: I5b74bd4c021424aecdf62014147b2ef4ff0d0b6b
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6968
Reviewed-by: Mathieu Denis <mathieu.denis55@gmail.com>
Alexandre Montplaisir [Fri, 27 Jul 2012 23:43:12 +0000 (19:43 -0400)]
tmf: Also bump the version number in pom.xml's
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Thu, 26 Jul 2012 21:28:59 +0000 (17:28 -0400)]
tmf: Update master branch against the 1.1 baseline
With a baseline installation updated with Linux Tools 1.1, one can now
track which APIs were actually part of 1.1, and which ones should require
bumps to 1.2/2.0.
Some protected fields in CtfTmfEventField were actually not part of 1.1,
so this adjusts their annotations and plugin versions correctly.
v2: Bump the test plugins too.
Change-Id: Id9155fe95594b4844e82e550ab0ca8563a74cdb0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6994
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>
Bernd Hufmann [Fri, 27 Jul 2012 18:38:09 +0000 (14:38 -0400)]
Fix more compiler/javadoc warnings as per new project specific settings
See also bug 385535 for the set of settings.
Change-Id: I76b5e8a78113908379cb9d73bbbbfae6bf1006a6
Reviewed-on: https://git.eclipse.org/r/7006
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Thu, 26 Jul 2012 20:42:40 +0000 (16:42 -0400)]
ctf: Fix remaining warnings the CTF plugins
Change-Id: If61709478cde0258e86761be8060e3ede0ca7f0e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6992
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Thu, 26 Jul 2012 18:27:21 +0000 (14:27 -0400)]
Fix TMF Core JUnit tests
Change-Id: I30595c0a1d190421649d079235c27fa3fbb26932
Reviewed-on: https://git.eclipse.org/r/6987
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Thu, 26 Jul 2012 18:09:38 +0000 (14:09 -0400)]
tmf: Correctly print HTInterval in its toString()
The ASCII value of '[' would get added to the start time,
instead of doing the expected string concatenation.
Changed the whole thing to use a StringBuilder instead.
Change-Id: Iea7f2b409c7c177a4a0b35494294fca7258835a1
Reported-by: Patrick Tassé <patrick.tasse@gmail.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6985
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Francois Chouinard [Wed, 25 Jul 2012 18:28:34 +0000 (14:28 -0400)]
Fix another pile of Javadoc warnings
Change-Id: I324c129736499c3cc4892898f9a0121e47fb7ac7
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Francois Chouinard [Wed, 25 Jul 2012 17:13:58 +0000 (13:13 -0400)]
Fix a pile of Javadoc warnings
Change-Id: I5f8cec0642346b863f058d56d56406a1e8b7fd77
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Alexandre Montplaisir [Fri, 20 Jul 2012 20:25:17 +0000 (16:25 -0400)]
Use project-specific Save Actions settings
The actions to execute on Save are:
- Remove trailing whitespaces on all lines
- Always use braces for control blocks (if, for, etc.)
Other save actions could be interesting, but they can be tracked
with compiler warnings instead.
refs bug #385535
v2: Removed the "Make private fields final if possible" option
Change-Id: If97f311a934739957586c76b83ce0538d733456d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6906
Alexandre Montplaisir [Fri, 20 Jul 2012 20:24:25 +0000 (16:24 -0400)]
Use project-specific formatter settings
The settings are the same as the Eclipse default settings, except:
- Use Spaces only for indentation
- Disable qualified invocations wrapping
(so we don't get myClass\n.get())
refs bug #385535
Change-Id: I773dbea89d24916cb82ca8ad93f2ee05ba8181dd
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6905
This page took 0.046341 seconds and 5 git commands to generate.