Alexandre Montplaisir [Tue, 12 Feb 2013 16:37:52 +0000 (11:37 -0500)]
Disable CTF/TMF unit tests that depend on external traces
Temporarily disable the unit tests using CTF traces, at least
until bug 400473 is fixed.
Before re-enabling them, they should be made to run only if the
traces are present, and skipped if they are not. That way it
should not show unit test failures if the download failed.
Change-Id: I87cd4220be36f7b0b853050186b5ca7bd64dd1ed
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10320
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Mon, 11 Feb 2013 18:59:31 +0000 (13:59 -0500)]
ctf: Avoid re-downloading the test traces
Do not download the test traces if they are already present
on the file system (skipexisting="true").
The extraction was also moved to a conditional task, so that if
the traces cannot be downloaded for some reason, at least it
doesn't fail the complete build. Some unit tests will probably fail,
but that's the lesser of the two evils.
References bug 400459.
Change-Id: I69d7cb1525005cf6426f7aa42c45ecbb4c92cdff
Reviewed-on: https://git.eclipse.org/r/10286
Tested-by: Hudson CI
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
IP-Clean: Alexander Kurtakov <akurtako@redhat.com>
Tested-by: Alexander Kurtakov <akurtako@redhat.com>
Patrick Tasse [Fri, 8 Feb 2013 19:44:54 +0000 (14:44 -0500)]
Show increasing progress for indexing job
Periodically update the job name with the current number of events and
the task name with the current indexing rate.
Change-Id: I229b7ba92b9528a927f79c232d38e2cf62bb41ba
Reviewed-on: https://git.eclipse.org/r/10088
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Thu, 7 Feb 2013 19:22:56 +0000 (14:22 -0500)]
tmf: Make CtfLocation extend TmfLocation
We save one field, but more interestingly we don't need to
duplicate the equals() and hashCode() methods.
refs bug 387929
Change-Id: I4c23d6e80cc860470453963a2d559066a811fbc1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10240
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Thu, 7 Feb 2013 19:06:01 +0000 (14:06 -0500)]
tmf: Rename CtfLocationData to CtfLocationInfo
to be consistent with the base classes.
Change-Id: I4df517752773d7ceb0d1a5444832ab178464bace
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10239
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Fri, 18 Jan 2013 20:21:35 +0000 (15:21 -0500)]
tmf: Make CtfTmfEvent extend TmfEvent
instead of re-implementing the interface.
Part of bug 387929.
For clarity's sake, moved all the instantiation-related code
into a new CtfTmfEventFactory.
Change-Id: Icb3d122acc3a23de3134d8209aa0be5ed4f705f0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10053
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Wed, 6 Feb 2013 16:43:07 +0000 (11:43 -0500)]
tmf: Remove Cloneable from (I)TmfCheckpoint
It was not used anywhere, except in tests, and the object isn't
made to be modified already.
Change-Id: I36330f3bf6b3c20e37ab2be88aa90984cbd2a05f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10215
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Tue, 29 Jan 2013 22:02:22 +0000 (17:02 -0500)]
tmf: CtfTmfContext rename
Renamed from CtfTmfLightweighContext (there are no heavyweight
contexts anymore) + fixed the clone() method.
After much experimentation, I gave up trying to not make those
extend TmfContext (sorry bug 387929). It seems the iterator
manager depends on CtfTmfContext.equals() to not be overriden.
Fixing this behavior (by making the manager track the locations
instead of the contexts, for example) works, but then reading
events becomes unbearably slow.
I think it's better to not touch this until a proper iterator
API comes to TMF, at which point we can use that directly.
Change-Id: I57cedac2702d0b70950687bdfa7a681ac7582be8
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10194
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexander Kurtakov [Tue, 5 Feb 2013 22:49:32 +0000 (00:49 +0200)]
Remove maven assembly plugin configs.
The plugins are more interconnected now and that results in separate tarballs not being useful separately. CGit also provides tarballs for the the entire project. Noone objected to this on the mailing list.
Change-Id: Idff1e6a380ca1af6116935faaebd79748e8983ee
Reviewed-on: https://git.eclipse.org/r/10190
Tested-by: Hudson CI
Reviewed-by: Camilo Bernal <cabernal@redhat.com>
IP-Clean: Camilo Bernal <cabernal@redhat.com>
Tested-by: Camilo Bernal <cabernal@redhat.com>
Alexandre Montplaisir [Fri, 1 Feb 2013 22:21:19 +0000 (17:21 -0500)]
tmf: Make TmfEvent immutable
The immediate benefit of immutable events is that we can avoid
doing copies in many places in the framework (for indexing,
checkpoints, et al.). It also alleviates many potential
concurrency issues.
For specific sub-classes that need to have mutable (non-final)
fields, the recommended - hopefully transitional - approach is to
re-define the fields in question and override the getters to make
sure the extended class's versions are used.
This was done for CustomEvent in this patch.
Change-Id: I6a9ec635eaa68b03d1c5a6875f60ece7d47cb024
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10123
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Fri, 1 Feb 2013 16:46:28 +0000 (11:46 -0500)]
tmf/lttng: Explicitely depend on JUnit4
"org.junit4" shouldn't be used anymore, according to
http://wiki.eclipse.org/Eclipse/Testing/JUnit4_Changes
Change-Id: I4d9c44f603411adafcb6291f2971e77244a454b8
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10120
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Tue, 29 Jan 2013 18:20:37 +0000 (13:20 -0500)]
tmf: Port tmf.ui unit tests to JUnit4
Last part of bug 393449.
Split up some Sequence Diagram unit test methods in separate
test cases, now that we can use @BeforeClass.
Change-Id: I7416241ccb82b4825f6c790e655b276b5c1655ef
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10119
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Thu, 31 Jan 2013 20:55:08 +0000 (15:55 -0500)]
tmf: Enable the ctfadaptor and statistics unit tests
The CTF parser tests now download the CTF test traces, so we
should be able to run those on the build server.
In a separate commit, so it's easier to revert in case of
massive breakage...
Change-Id: I663c1cd7e83a7a501da0701dfb1ddd76ad421082
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10118
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Fri, 25 Jan 2013 22:25:57 +0000 (17:25 -0500)]
tmf: Update tmf.core unit tests to JUnit4
Refs bug 393449.
Also added missing dispose() calls in TmfExperimentCheckpointIndexTest.
Not doing those would fail subsequent tests in TmfTraceTest (not sure
why this wasn't needed with JUnit3).
Change-Id: Id6bb29067fadf1bee6b30955520ce376b1ac01aa
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10117
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Wed, 30 Jan 2013 21:06:12 +0000 (16:06 -0500)]
tmf: Decouple tmf.core unit tests from TmfEvent
Make sure the TMF unit tests use the ITmfEvent interface
as much as possible (this is the behavior we want to have
in the core framework).
Change-Id: I242a5265c716498392f2b1414785db03f302540d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10051
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Francis Giraldeau [Fri, 1 Feb 2013 20:25:03 +0000 (15:25 -0500)]
Register the control flow as selection provider
In order to signal the selection of a task in the control flow view,
register the tree view in the selection service. It allows other
plug-ins to listen for selection change.
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Change-Id: I5294e12c660c60a8e01f1b76c3e993da6e6534af
Reviewed-on: https://git.eclipse.org/r/10115
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Fri, 25 Jan 2013 16:52:04 +0000 (11:52 -0500)]
ctf: Clean up the test suites
* Order the test names alphabetically.
* Enable IOstructgenTest, which was not running.
* Drop the main() methods, probably an artifact from CodePro.
Change-Id: I139351bced74638d702cfb7245db38481545424a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10055
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Wed, 30 Jan 2013 21:31:40 +0000 (16:31 -0500)]
Merge entries with same TID in Control Flow view
Separate entries are no longer created when a thread changes its exec
name over time. A single entry is used, and its name is set to the last
exec name of the thread. If the thread is terminated and reused, a
separate entry will be created with a different name and birth time.
Change-Id: I97d06adf8c68f9f56594059bc51a38fa78e36842
Reviewed-on: https://git.eclipse.org/r/10049
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Thu, 31 Jan 2013 20:04:03 +0000 (15:04 -0500)]
lttng: Fix control model unit tests for the new API
The .init() and .dispose() were done in the now-unused TestSetup.
Move those the the @Before and @After classes in the tests
themselves.
Change-Id: I9d782a3192e5ced2ee65b916aaa5a1dce50f801d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10081
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Fri, 25 Jan 2013 20:05:20 +0000 (15:05 -0500)]
lttng: Port unit tests to JUnit4
Refs bug 393449.
Change-Id: I84d3f62d0e1dd1b8bd1d0ad00f3347cc86df6ad2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10056
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Mon, 21 Jan 2013 20:34:26 +0000 (15:34 -0500)]
tmf: Make CtfTmfEventField extend TmfEventField
Part of bug 387929.
Also swapped the (name, value) parameter order in the
constructors to match the superclass.
Change-Id: I71de4d41e6d22cb31262e8b0ccb63a8a910b4dbf
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10054
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Xavier Raynaud [Tue, 29 Jan 2013 11:12:34 +0000 (12:12 +0100)]
o.e.l.tmf.ui: Utils.findEvent no longer return null when previous ITimeEvent has duration=0
Change-Id: Ife4698c556a7e78595115bc4b9a834183d57c82d
Reviewed-on: https://git.eclipse.org/r/9998
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Alexandre Montplaisir [Thu, 17 Jan 2013 20:55:12 +0000 (15:55 -0500)]
tmf: Make TmfEventField immutable
This required some minor adjustment in CustomEventContent.
Those can still extend TmfEventField, but it requires creating
a new Content object if you want to change its values.
Change-Id: I1fe951fe60d505f4ad9564dea559af522a86ac9f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9806
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Mon, 28 Jan 2013 21:13:44 +0000 (16:13 -0500)]
lttng: Add missing javadoc comment to LTTngControlService
Change-Id: I2a2f2588bde494f77072f805484291933933765e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9976
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Mon, 28 Jan 2013 21:08:14 +0000 (16:08 -0500)]
tmf: Add missing since tag in
77d30f4
Change-Id: Ia05329a9e19e93df9136b04039209e1086f9d5f1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9975
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Fri, 25 Jan 2013 22:58:48 +0000 (17:58 -0500)]
Use Traces folder trace element when creating experiment from editor
When an experiment is created from the TmfEventsEditor.init method from
a FileEditorInput (ie. on platform restart or on open from bookmark),
the trace element from the Traces folder should be used. This is
required so that any plug-in extension that stores a persistent property
on the trace resource can access it when an experiment is created this
way.
Change-Id: I321a2cf3af91a7c898eb9800ce7f03fbbf34b9e4
Reviewed-on: https://git.eclipse.org/r/9940
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Fri, 25 Jan 2013 23:06:28 +0000 (18:06 -0500)]
Fix event table selection handling
A SelectionChangedEvent should be fired when the selection changes due
to a Search match.
The selected rank should be updated when the selection changes due to
the gotoMarker() handling.
Change-Id: Iaec404049edf126f43ee6d049cdc8263f4e1c5db
Reviewed-on: https://git.eclipse.org/r/9941
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Fri, 25 Jan 2013 23:14:53 +0000 (18:14 -0500)]
Add trace type property tester
Add a trace type property tested that plug-in extensions can use to
enable/disable commands and menu items based on the specific trace type
of the current selection.
Change-Id: Id23455ed672af6c044b699847428213bd0397970
Reviewed-on: https://git.eclipse.org/r/9939
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Matthew Khouzam [Fri, 25 Jan 2013 16:42:04 +0000 (11:42 -0500)]
[TMF] Allow custom iterators by making the traces the iterator factories
Change-Id: Ib744ad63228a1c070f38d4710936481420739d06
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/9931
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Thu, 24 Jan 2013 22:09:07 +0000 (17:09 -0500)]
Add entry filter support for TimegraphCombo via dialog
Change-Id: I56d714f5a7bcb1b849fda463821dccb525478745
Signed-off-by: François Rajotte <francois.rajotte@polymtl.ca>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6874
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 24 Jan 2013 22:08:48 +0000 (17:08 -0500)]
Add multi-column tree selection dialog
Change-Id: If4e8453b7826ee3777a92a5b82226a8b71860e04
Signed-off-by: François Rajotte <francois.rajotte@polymtl.ca>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6873
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Mon, 14 Jan 2013 20:37:55 +0000 (15:37 -0500)]
tmf: Add a new package for state history backends
Added two new simple backends:
- Null backend, which discards all intervals it receives.
- In-memory backend, which is like a full history but keeps
everything in RAM. For use with small state systems only!
Also renamed the existing *.historytree package to
*.backends.historytree.
Change-Id: Ia32285ce2162d5315616dd2546fa18549b38da22
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9594
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Mon, 21 Jan 2013 15:53:45 +0000 (10:53 -0500)]
tmf: Update interface name in commit
1433bda1
Change-Id: Ibf732cee48428492774259b2256590dcd1887ebd
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9807
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Mon, 21 Jan 2013 15:30:22 +0000 (10:30 -0500)]
tmf: Fix regression in event requests
The following commits introduced a regression, where event
requests for partial ranges would stop working for trace
types that don't define event ranks:
4ca3bebf55c097f872185ac53e18eba4dc88745b
f08203da275a49739af94f6dc1532116d67af593
42eaaef87cf60a5129d64bead5698a84d3d43349
8ed1afa7534fa011991dee35874910f8de01758a
b341bd59ed80f4e848039acc6477ce5711318841
88b2d8d9a2114b2580a1f62c51752754fad39cec
Revert them out of master until they get more testing.
Change-Id: Iee00ba9f1e619737c0406222e607b994301c0ff9
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Matthew Khouzam [Thu, 17 Jan 2013 19:16:42 +0000 (14:16 -0500)]
[CTF] fix support for traces with per-event contexts
Change-Id: I11afb20264b6c4a20c4e44132bdc49cec6d653ca
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/9741
Patrick Tasse [Thu, 17 Jan 2013 21:14:44 +0000 (16:14 -0500)]
Fix deadlock in TmfUml2SDSyncLoader
Prevent deadlock in TmfUml2SDSyncLoader between the object's
reentrant lock and request synchronization by moving request
cancellations outside of the reentrant lock's scope.
Change-Id: Idc04b4f1a56904e718841db5a33eafb2970cea8a
Reviewed-on: https://git.eclipse.org/r/9744
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Ansgar Radermacher [Wed, 16 Jan 2013 17:19:54 +0000 (18:19 +0100)]
tmf: Support the model URI of a trace event
Fixes bug 396956.
Change-Id: I03cc2b1b34760fe3d9f9c9139cd4c0dca77a6670
Reviewed-on: https://git.eclipse.org/r/9699
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Ansgar Radermacher <ansgar.radermacher@cea.fr>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Michel Dagenais [Tue, 8 Jan 2013 16:53:35 +0000 (11:53 -0500)]
lttng: State of processes from LTTng kernel traces
Separate WAIT_FOR_CPU and WAIT_BLOCKED states, and display
them in different colors in the Control Flow View.
Change-Id: I327c868841a45b411537d7e4d9e525d30d40ceab
Reviewed-on: https://git.eclipse.org/r/9540
Tested-by: Hudson CI
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Thu, 10 Jan 2013 23:06:14 +0000 (18:06 -0500)]
tmf: Fix TmfStateInterval.toString()
The char value of ' ' would get added to the interval end time,
instead of appending a space as was intented...
Change-Id: Iead539d1ddbc2d299554d1968c83bc5c9cf46134
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9606
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Thu, 10 Jan 2013 19:47:09 +0000 (14:47 -0500)]
Improve performance of event cache when scrolling up
When an event index is requested that is outside of the cache, the cache
population request always starts at the requested index and the cache
contains the following 'cache size' events. Therefore when scrolling up
outside of the cache boundaries, a new cache population request is
triggered at every scroll event.
This patch changes the behavior of the cache to increase the cache to
two blocks of 'cache size', and ajust the cache population request so
that the cache is centered on the requested index.
Change-Id: I890324a2f6d8afec5956ae73d66683eefc98d828
Reviewed-on: https://git.eclipse.org/r/9601
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Fri, 21 Dec 2012 18:45:28 +0000 (13:45 -0500)]
Add support for filter feature of LTTng Tools 2.1
- Retrieve filter information from target
- Display filter information in Properties View
- Add support for filter configuration for enable-events (UST)
- Display UST event fields in Properties View
- Update JUnit tests
Change-Id: Ibd341bb51059d60027ff9f2722ff15e4d275e9cf
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/9362
Tested-by: Hudson CI
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 10 Jan 2013 16:41:22 +0000 (11:41 -0500)]
ctf: Bump CTF feature plugin to 2.0
Change-Id: Ic23e6901099435be173d01460f567c00ace7c370
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9588
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Wed, 9 Jan 2013 21:19:27 +0000 (16:19 -0500)]
Fix NullPointerException in command handlers
The active part can be null if all perspectives are closed. The handlers
isEnabled() method can then be invoked when using the workbench main
menu (e.g. File > Exit).
Change-Id: I76df9320238ef5e02aa0ee56a4b12dbb494cfe79
Reviewed-on: https://git.eclipse.org/r/9570
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Francois Chouinard [Thu, 10 Jan 2013 16:39:45 +0000 (11:39 -0500)]
Fix some Findbugs findings
Change-Id: If185d9ac542f14d2ff947058c2e6c7000cf7b79a
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/9587
Tested-by: Hudson CI
Matthew Khouzam [Fri, 4 Jan 2013 19:01:39 +0000 (14:01 -0500)]
CTF: Add support for custom attributes in an event
Use IEventDeclaration now to create a proper API.
Fix potential NPE.
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Change-Id: I398cb479e087ec5bdec54933702b6cc8ecdfc805
Reviewed-on: https://git.eclipse.org/r/9288
Francois Chouinard [Wed, 9 Jan 2013 23:43:32 +0000 (18:43 -0500)]
Add a trace filter to the set of event filters in TmfRequests
Change-Id: I789199d1f9b6d83060ee6a43426d8885e552268d
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/9577
Tested-by: Hudson CI
Francois Chouinard [Wed, 9 Jan 2013 17:02:02 +0000 (12:02 -0500)]
Add Iterator support to TMF traces
Change-Id: I11d1e8c33fa5f3a39ff842807a2934cf04d8fcfe
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/9559
Tested-by: Hudson CI
Francois Chouinard [Wed, 9 Jan 2013 20:30:58 +0000 (15:30 -0500)]
Improved fix for the failed unit test
Change-Id: Ib16a748e631a93b8faf440394be86db0bc6d0b06
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/9567
Tested-by: Hudson CI
Francois Chouinard [Wed, 9 Jan 2013 19:00:50 +0000 (14:00 -0500)]
Temporary fix for the failed unit test
Change-Id: I31f7d98e625b12078db318b561c4224a5eb5185a
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/9563
Tested-by: Hudson CI
Francois Chouinard [Tue, 8 Jan 2013 23:55:18 +0000 (18:55 -0500)]
Refactor TmfRequest
Change-Id: I72480990880adae6036e5d5c74966f250a46a6c2
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/9501
Tested-by: Hudson CI
Matthew Khouzam [Mon, 7 Jan 2013 21:52:04 +0000 (16:52 -0500)]
TMF: Fix for displaying arrays in the events properties
Change-Id: Icf87b2b4e64b2d16a30c15a1463844cf3daf608f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/9509
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Mon, 7 Jan 2013 22:52:57 +0000 (17:52 -0500)]
tmf: Remove the TmfStateSystemBuildCompleted signal
Views should now use ITmfStateSystem.waitUntilBuild() instead.
Its behavior is much more predictable, both if the state history
is already built or not.
This also removes the need to pass the ID when building a new
state history. Only the trace will know the ID->statesystem
matching.
Change-Id: Ie9b5d98b0e674d607b34ae1984342030a5668b19
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9505
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Fri, 4 Jan 2013 20:58:44 +0000 (15:58 -0500)]
lttng/tmf: Enable and fix parameter assignment warnings
FindBugs also warns for these, so might as well have them
enabled straight within Eclipse.
Change-Id: I1318a26c22e1bb379b5af02e1fc4840c2cd39093
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9472
Tested-by: Hudson CI
Alexandre Montplaisir [Fri, 4 Jan 2013 20:28:12 +0000 (15:28 -0500)]
tmf: Fix remaining Java warnings in tmf.ui
Change-Id: I02cc52ad3dca97512c29aa7d92c2ce32005e8e73
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9467
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Thu, 3 Jan 2013 23:20:39 +0000 (18:20 -0500)]
tmf: Add missing Javadoc to tmf.ui
This goes a long way into fixing the remaining warnings!
This commit contains only documentation and formatting fixes,
no actual code changes. Except for some protected fields in
TmfEventsTable, which were changed to private to remove them
from the API.
Change-Id: I6c524c9e9b91f0efafad739cec62aa7d60429972
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9463
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Thu, 3 Jan 2013 21:34:22 +0000 (16:34 -0500)]
Update bookmarks file API, link to editor and delete & rename handlers
- Implement different methods in trace element and experiment element to
get the bookmarks file with or without creating it.
- Update TmfEditorLinkHelper to use the new methods to get the bookmarks
file from trace or experiment element.
- Update TmfEditorLinkHelper to no longer activate the found editor
part. Doing so would make the Project Explorer view lose focus.
- Update TmfEventsEditor to also broadcast TmfTraceSelectedSignal when
part is brought to top without being activated. Selected flag is added
to ensure the signal is sent only once as long as the same trace is
selected.
- Fix equals() method of TmfProjectModelElement. Path is used for
equality check. Using name and location would return true when comparing
a trace element and a link to the same trace under an experiment, which
would confuse the Project Explorer tree navigator model. Update
hashCode() to only use path.
- Fix rename trace handler to propagate rename to experiment traces
based on trace name since the equals method no longer matches for the
different trace element under Traces folder and under an experiment.
- Fix delete trace handler to propagate deletion to experiment traces
based on trace name. Using location could unnecessarily remove trace
from an experiment which was a different linked trace to the same
location as the deleted trace.
- Dispose temporary trace used in validate() of CtfTmfTrace and
CtfKernelTrace. This allows deletion soon after import.
Change-Id: Ib2624732d7c8d9a2677a15d8709e27d99f76e880
Reviewed-on: https://git.eclipse.org/r/9435
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Thu, 3 Jan 2013 15:56:28 +0000 (10:56 -0500)]
tmf: Add missing @since annotations in Utils.TimeFormat
Change-Id: I3fa5f684ebcc206e7e021291849e828d374d5f56
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9431
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Thu, 3 Jan 2013 15:54:18 +0000 (10:54 -0500)]
tmf: Remove unused import in TmfTimestampFormat
Change-Id: I8aa86e5f20ca620cde3492bcac3a137f5cd65d2e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9430
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Xavier Raynaud [Fri, 14 Dec 2012 09:15:25 +0000 (10:15 +0100)]
lttng/tmf: add a "unit-less" representation of time in timechart
Change-Id: Ia2c2b9a55a1d380f7656c473c535b775553c4bf1
Reviewed-on: https://git.eclipse.org/r/8204
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Patrick Tasse [Wed, 2 Jan 2013 21:48:21 +0000 (16:48 -0500)]
Add missing @since tags
Change-Id: I208ad218b914d0087754449d44845d04874b539e
Reviewed-on: https://git.eclipse.org/r/9424
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Patrick Tasse [Thu, 20 Dec 2012 22:47:11 +0000 (17:47 -0500)]
Close trace and improve error handling on delete and rename commands
- Close trace or experiment editor on delete and rename commands, to
dispose the trace(s) and release file resources to allow the file
operations to succeed
- Show message dialog to user on delete error
- Fix message dialog for rename error
- Move creation of bookmarks file to trace or experiment element
- Fix leaking of project model elements
Change-Id: I585df4fd4b3547dc4b71735ebbd47184585c0eef
Reviewed-on: https://git.eclipse.org/r/9339
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Fri, 21 Dec 2012 18:26:54 +0000 (13:26 -0500)]
Implement dispose of CTF traces
Dispose method is implemented for CtfTmfTrace and its contained objects.
File streams are closed and references to MappedByteBuffer objects are
cleared. The trace manager is cleared when a trace is removed from the
iterator manager and the trace iterators are disposed.
Change-Id: I6a5f8cc73ef5157842c67bb5dd0e7a2cb38a23ff
Reviewed-on: https://git.eclipse.org/r/9338
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Fri, 21 Dec 2012 18:22:14 +0000 (13:22 -0500)]
Fix endless loop in Resources view when trace is disposed
Change-Id: Ia030dd809de82af07eff8e7de78f0eb45e6c2b2a
Reviewed-on: https://git.eclipse.org/r/9361
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI
Bernd Hufmann [Thu, 20 Dec 2012 15:17:01 +0000 (10:17 -0500)]
Adjust list kernel events handling due to new output format
lttng-tools 2.1 has a different string output for command
lttng list -k if no kernel tracer is available. This fix
adjust the command output parsing to ignore this case correctly.
Change-Id: Ibfc8fd19609b6489e5ef9fd31ba75058ea0f6631
Reviewed-on: https://git.eclipse.org/r/9328
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Mon, 17 Dec 2012 20:29:20 +0000 (15:29 -0500)]
Clear text controls and labels when histogram is empty
- Do not display default time (epoch) for text controls and
start/end labels when histogram is initialized or when last trace is
closed
- Prevent user update of text controls when histogram is empty
- Fix layout problem on time format update
Change-Id: I9285853b127e0dca0fa0c2035fea1c414390a759
Reviewed-on: https://git.eclipse.org/r/9273
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Tue, 18 Dec 2012 01:37:43 +0000 (20:37 -0500)]
Add support for link with editor in tracing projects
- Extend extension org.eclipse.ui.navigator.linkHelper
- Add implementation of ILinkHelper interface
- Implement getParent() in TmfNavigatorContentProvider
Change-Id: I6e37bff9b7891866a61f2a0960e789d8bfbc5fa5
Reviewed-on: https://git.eclipse.org/r/9246
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Fri, 14 Dec 2012 16:30:15 +0000 (11:30 -0500)]
Fix trace not indexed on reuse of editor
Change-Id: I9c6e62c6081bb7d1ea1bf3c2552fddb1cc0c1c7a
Reviewed-on: https://git.eclipse.org/r/9244
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI
Patrick Tasse [Thu, 13 Dec 2012 20:51:12 +0000 (15:51 -0500)]
Update LTTng user guide and remove trailing spaces
Change-Id: Ica7fea78df7e230f54caceddf1b0aeef0ada61ab
Reviewed-on: https://git.eclipse.org/r/9235
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Thu, 13 Dec 2012 20:49:45 +0000 (15:49 -0500)]
Move Manage Custom Parsers view menu item to tracing context menu
- The Manage Custom Parsers... command is removed from the Project
Explorer view menu, and added to the Traces folder context menu and to
the trace's Select Trace Type... context sub-menu.
- A bullet icon is added to the selected trace type's category menu item
in the Select Trace Type... context sub-menu.
Change-Id: I77156a8de320264c0fac3db623a2c9cf7831718e
Reviewed-on: https://git.eclipse.org/r/9233
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Thu, 13 Dec 2012 20:16:41 +0000 (15:16 -0500)]
Add process and syscall labels to Control Flow and Resources views
Change-Id: I9fd570da4f5acce1f03098a7a2f20e2baccd20f0
Reviewed-on: https://git.eclipse.org/r/9172
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Tue, 11 Dec 2012 22:16:06 +0000 (17:16 -0500)]
ctf: Fix API inconsistencies
Some API methods would return or take as parameter classes
that were not part of the API themselves. This little rework
seems to fix the problem, mainly by exporting BitBuffer, Stream
and StreamInput.
Change-Id: I3bac3619426d51c1a1484a6a0a336ec93e700175
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9173
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Tue, 11 Dec 2012 21:31:51 +0000 (16:31 -0500)]
tmf: Correctly export all packages in runtime plugins
The API tools need the packages to be correctly exported
(even the internal ones, they should be explicitely set to
"hidden from all plug-ins except: <nothing>").
This patch enables the project-specific settings to warn for
missing exported packages, exports the missing ones, and fixes
a missing annotation.
Change-Id: Id63e1e6a586eddc66dc3f14e6b58ec6bc3bd9dfe
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9168
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Tue, 11 Dec 2012 20:42:46 +0000 (15:42 -0500)]
ctf: Enable the API tool on the CTF plugins
Bump the plugin version to 2.0.0, as needed, and add missing
annotations.
Change-Id: I182ad7187be62130b12cdf5785adef36f53aa3cb
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9164
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Jeff Johnston [Tue, 11 Dec 2012 18:52:06 +0000 (13:52 -0500)]
Bump up Linux Tools master snapshot release to 2.0.0.
Change-Id: I5b9ab2cf7a5408714a33626d20aca0b06bfbf8fc
Reviewed-on: https://git.eclipse.org/r/9162
Tested-by: Hudson CI
Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
IP-Clean: Roland Grunberg <rgrunber@redhat.com>
Tested-by: Roland Grunberg <rgrunber@redhat.com>
Alexandre Montplaisir [Tue, 11 Dec 2012 18:41:11 +0000 (13:41 -0500)]
tmf: Bring back "@since 1.2" annotations in master
Those were temporarily bumped to 2.0 in lttng-kepler, but
were actually part of the 1.2 release.
Change-Id: I30027dd9b0e3f1a86f55de9ebb5b5c9d900b77c2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9159
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Tue, 11 Dec 2012 18:00:37 +0000 (13:00 -0500)]
Merge branch 'lttng-kepler'
Bernd Hufmann [Mon, 10 Dec 2012 17:21:48 +0000 (12:21 -0500)]
Fix order of execution in CTF JUnit tests.
The order of test case within a JUnit tests file doesn't ensure the
order of execution. So, each test case within a file have to be
self-contained.
Change-Id: Ie7cdff17f4c176062a4eabd038de3870e44834de
Reviewed-on: https://git.eclipse.org/r/9146
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Bernd Hufmann [Mon, 10 Dec 2012 16:36:03 +0000 (11:36 -0500)]
Include CTF and Kernel state system JUnit tests to maven build
Change-Id: I3429e28f98606031c9238adf699a3a839ef1c2be
Reviewed-on: https://git.eclipse.org/r/9145
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Mon, 19 Nov 2012 20:40:48 +0000 (15:40 -0500)]
tmf: Consolidate all state systems in ITmfTrace
In the initial design, a trace would have only one single
state system. ITmfTrace.getStateSystem() would do the job.
Then, the need for different state systems for different trace
types arose. Up until now, we've used a hybrid approach, where
we keep the interface method the same, but a given user/view
could access a specific state system by casting the trace
in the specific type. So far so good.
But now, we are reaching the point where we can need to define
*many* state systems for a single trace type (ie, Matthew's
CPU usage view). I think we now need to centralize all of a
trace's state systems in the ITmfTrace interface itself.
This patch changes ITmfTrace's getStateSystem() to add the
state's ID as parameter (state systems already define a unique
ID, so we can reuse that one). It also adds a listStateSystems()
method to list the current registered ones for this trace.
The implementation in TmfTrace uses a HashMap. It's very simple,
and gives a maximum amount of flexibility ; sub-classes can
decide to overwrite a superclass' state history, decide to run
them or not, etc.
Change-Id: I6c819ad8987767015543dc54b613ec3cdc6ea50d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8767
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Xavier Raynaud [Thu, 29 Nov 2012 13:56:32 +0000 (14:56 +0100)]
lttng/o.e.l.tmf.ui/.../TimeGraphScale.java: avoid "java.lang.ArithmeticException: / by zero": _timeDelta can no longer be Zero
Change-Id: Ibce7df7bffd3ceb72b9541ef19a24636520d32f3
Reviewed-on: https://git.eclipse.org/r/8932
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Patrick Tasse [Wed, 5 Dec 2012 23:54:13 +0000 (18:54 -0500)]
Fix histogram current event and time stamp format parsing
The parsing of date format is updated to use the time stamp format's
time zone.
DAY_OF_YEAR field is not copied from the reference time as setting it
also updates the MONTH and DATE, causing premature break out of the
field-copying loop.
HOUR_OF_DAY field is used to copy from the reference time instead of
the HOUR field, as the latter only uses a 12-hour clock.
The current event text control now uses the current event time value as
a reference time for parsing, instead of the trace start time. This
allows a time stamp format preference, which contains insufficient date
and time fields to fully represent the whole trace range, to be usable
in the text control. The non-visible date and time fields are assumed to
be set equal to those of the current event.
Change-Id: I25c67787c20aa26a0f267f8d460b441b74185122
Reviewed-on: https://git.eclipse.org/r/9051
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Thu, 6 Dec 2012 15:07:02 +0000 (10:07 -0500)]
tmf: Add missing @since annotation
Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Change-Id: Id2c182e7731e952f129a3c1efee4cb0c52e89b53
Reviewed-on: https://git.eclipse.org/r/9078
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI
Patrick Tasse [Wed, 5 Dec 2012 23:32:08 +0000 (18:32 -0500)]
Fix corrupted cache when clear interrupts cache population request
Change-Id: Ifebd1362ebfdaafcf0d13140c927680400580aed
Reviewed-on: https://git.eclipse.org/r/9052
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Patrick Tasse [Wed, 5 Dec 2012 16:17:09 +0000 (11:17 -0500)]
Fix mouse wheel zoom in time range histogram
Change-Id: I4739526671a7835fdb420313bbdb9f8e81e79b5f
Reviewed-on: https://git.eclipse.org/r/9026
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI
Bernd Hufmann [Wed, 5 Dec 2012 14:37:16 +0000 (09:37 -0500)]
Add notification for reset of time scale in TimeGrapViewer
A recent change removed the notification of reset time scale
in the TimeGraphViewer. The ResoucesView and ControlFlowView
was affected by that. This update adds the notification
when executing the reset scale action.
Change-Id: Ic822157d4617ed7ce81a67e8640ac8b62eedc694
Reviewed-on: https://git.eclipse.org/r/9036
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Tue, 4 Dec 2012 23:25:49 +0000 (18:25 -0500)]
Fix deleting of supplementary files on remove of trace from experiment
Change-Id: I84bd7694a4836dbfaf03eb40fb134c803b3514ca
Reviewed-on: https://git.eclipse.org/r/9029
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Matthew Khouzam [Fri, 30 Nov 2012 18:00:57 +0000 (13:00 -0500)]
Update Documentation to better reflect branch
* Describe time stamp formatting
* Update descriptions of event views to editors
* Update images to reflect better timestamps
* Add description of events properties view
* Update Description of statistics view
* Recompress images
Change-Id: Ia00b76353ed6fb9fa8f81c819d2ff39ad3b78608
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/8946
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI
Patrick Tasse [Mon, 3 Dec 2012 21:57:45 +0000 (16:57 -0500)]
Add support for filters in Time Chart view
Change-Id: I6c096f0af66918429e77ad7f0ea6119ae4b7b4cd
Reviewed-on: https://git.eclipse.org/r/9013
Tested-by: Hudson CI
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Mon, 3 Dec 2012 20:46:18 +0000 (15:46 -0500)]
Add synchronization to TmfTimestampFormat
SimpleDateFormat is not synchronized. Therefore users of that
class have to ensure synchronization.
Change-Id: Icbf51e3df816bf40747827a46245981043cec3ef
Reviewed-on: https://git.eclipse.org/r/9012
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Xavier Raynaud [Mon, 19 Nov 2012 13:43:45 +0000 (14:43 +0100)]
lttng/o.e.l.tmf.ui:TmfVirtualTable.java: add a getter for the Table menu, so getter and setter are consistent
Change-Id: I285314981d6981001571774ca616802afc4c6119
Reviewed-on: https://git.eclipse.org/r/8764
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Bernd Hufmann [Fri, 30 Nov 2012 20:26:37 +0000 (15:26 -0500)]
No range updated signal from TimeGraphControl for selection
Only send range updated signal when the mouse was dragged and
not when selection was done without moving the mouse.
Change-Id: I6707c10625b1ff5f816a3284e9a137fc78bfec53
Reviewed-on: https://git.eclipse.org/r/8984
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Bernd Hufmann [Fri, 30 Nov 2012 21:18:02 +0000 (16:18 -0500)]
Fix time scaling problem in Histogram View
If scale of TmfTimestamps of a trace is not nano-seconds
the start and end time of a trace have to be scaled when comparing
with entered time values.
Additionally, a NPE was fixed that was happening when clearing
the histogram while executing asyncExec() to update the display
Change-Id: I39dd3ed3e375ee520678f1de9cb45ee5fccf77d5
Reviewed-on: https://git.eclipse.org/r/8985
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Francois Chouinard [Fri, 30 Nov 2012 19:46:26 +0000 (14:46 -0500)]
Make lower priority requests pre-emptible
The current request priority handling is based on splitting lower
priority requests into chunks of a fixed size that don't take too long
to process. If a higher priority request is issued (e.g. as the result
of a user action), it is simply put in front of the request queue i.e.
before the next low-priority chunk.
This patch modifies the TmfRequestExecutor to use 2 queues (one for each
priority) and implements a pre-emption scheme to make higher priority
requests run immediately.
This is the first step in a more comprehensive overhaul of the TMF
Request Model.
Change-Id: I6413cbbd69985d88b3fd5b5375a0b7ec59104682
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8983
Tested-by: Hudson CI
Bernd Hufmann [Fri, 30 Nov 2012 15:51:11 +0000 (10:51 -0500)]
Implement TmfTimestampDelta for deltas of timestamps
The toString() method of this class returns the timestamp string
formatted with TmfTimestampFormat.DefaultIntervalFormat() and
also considers negative values correctly.
The getDelta() method of TmfTimestamp and TmfSimpleTimestamp
returns now an instance of TmfTimestampDelta.
This also fixes the incorrect display of timestamps deltas in
the Sequence Diagram view.
Change-Id: I249ab9ac7a5f4170f86f038bc89d419dcce9514a
Reviewed-on: https://git.eclipse.org/r/8944
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Bernd Hufmann [Thu, 29 Nov 2012 16:40:27 +0000 (11:40 -0500)]
Handle concurrent seek and dispose in CtfTmfTrace properly
Change-Id: I097f7f062e5c301fe9f00bab52f709b7afebb376
Reviewed-on: https://git.eclipse.org/r/8938
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Thu, 29 Nov 2012 16:49:00 +0000 (11:49 -0500)]
Fix for column width problem in Linux
Change-Id: Ib439b88740fd8585fa32a8ebaf263bb41c031817
Reviewed-on: https://git.eclipse.org/r/8933
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Thu, 29 Nov 2012 00:00:36 +0000 (19:00 -0500)]
Fix time range synchronization issues
- Histogram view, Control Flow view and Resources view ignore synch to
time range outside of trace range
- Histogram view updates time range to intersection of requested range
and trace range on synch to time range
- Fix Histogram view update of time range from Window Span text entry
Change-Id: I668db769452535272a7d3ee52144c8d7d2a1a6b8
Reviewed-on: https://git.eclipse.org/r/8924
Tested-by: Hudson CI
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Wed, 28 Nov 2012 20:48:11 +0000 (15:48 -0500)]
Fix SWT widget disposed Exception in Sequence diagram view
Additionally:
- Fix typo in OpenTraceHandler
- Add check for file existence in CTFTrace
Change-Id: I88d7da6003c4fc587fb09ad5023ee0c72d61a845
Reviewed-on: https://git.eclipse.org/r/8916
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Wed, 28 Nov 2012 12:58:53 +0000 (07:58 -0500)]
Add handling of initial range offset in experiments
Change-Id: I3eb8353c183747eaac3e1b39816efcfe29bd3864
Reviewed-on: https://git.eclipse.org/r/8914
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Mon, 26 Nov 2012 14:04:56 +0000 (09:04 -0500)]
Change LTTng help plugin generation
The generation of the LTTng help plugin used to be done from
a wiki stored at Eclipse.org. This wiki matches the latest
delivered source code. However, when developing new features
or updating existing features it is required to document the
new or updated feature. But this cannot be done on the wiki
web page. This causes that the writing of documentation
is often postponed before the next official release.
This commit changes the way the help plugin is build. The source
wiki text file along with the relevant images as part of are
stored as part of the git repository. The build-helper.xml was
updated to build the help from the local wiki file. This allows
the designer to update the documentation along with the feature
implementation. Note, that the local wiki can be edited with the
MyLyn wiki text editor.
When a release to open source is done and these new or updated
feature are part of it, then the open source wiki at Eclipse.org
needs to be aligned to the wiki which is stored in the git
repository.
How to know if someone updated the open source wiki independent to
the one in the git repository? For that, the build-helper.xml file
also builds the help plugin files as it used to be done. After a
Ant build with the build-helper.xml file the changes will show
as changes in the git repository. Knowing what changed, it can be
easily transfered to the local wiki stored in git.
Note that the legacy help files were removed from the repository.
Change-Id: Iba1b140a78a5e4aaa2b2a7ffbdb0cf852f9b6030
Reviewed-on: https://git.eclipse.org/r/8794
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
This page took 0.049096 seconds and 5 git commands to generate.