Mathieu Desnoyers [Sat, 13 Feb 2016 16:18:27 +0000 (11:18 -0500)]
Fix: filter tests now accept "." in identifiers
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 9 Feb 2016 20:16:49 +0000 (15:16 -0500)]
Fix: Don't notify agent of non-app context addition
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 9 Feb 2016 20:16:38 +0000 (15:16 -0500)]
Create agent on channel creation
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 9 Feb 2016 20:12:33 +0000 (15:12 -0500)]
Introduce application contexts to session configuration schema
Session configuration schema version is bumped to 2.8.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 9 Feb 2016 20:11:32 +0000 (15:11 -0500)]
Fix typos in error descriptions
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 5 Feb 2016 22:10:41 +0000 (17:10 -0500)]
Enable agent application contexts if filter has such dependencies
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 3 Feb 2016 23:51:29 +0000 (18:51 -0500)]
Compare provider and context names in trace_ust_match_context
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Tue, 26 Jan 2016 15:14:17 +0000 (10:14 -0500)]
Allow $app.provider:ctxname in filter, enum, variant identifiers
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Mon, 18 Jan 2016 22:22:25 +0000 (17:22 -0500)]
Add variant type support to ust registry and metadata
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 28 Jan 2016 21:39:33 +0000 (16:39 -0500)]
Notify java agent of enabled application contexts
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 28 Jan 2016 00:01:50 +0000 (19:01 -0500)]
Add app context support to lttng client
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 26 Jan 2016 16:46:48 +0000 (11:46 -0500)]
Enforce const-correctness in UNIX socket wrappers
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 26 Jan 2016 16:46:17 +0000 (11:46 -0500)]
Remove superflous domain check in context_ust_add
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 26 Jan 2016 16:45:42 +0000 (11:45 -0500)]
Remove superflous domain check in add_uctx_to_channel
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 26 Jan 2016 16:44:12 +0000 (11:44 -0500)]
Use lttng_domain_type enum instead of bare integer
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 26 Jan 2016 16:42:45 +0000 (11:42 -0500)]
Add application context support to lttng-ctl lttng_add_context
Forward the provider and context names of app contexts to the
session daemon.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 22 Jan 2016 21:23:43 +0000 (16:23 -0500)]
Cleanup comments in lttng-ctl.c
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 12 Feb 2016 21:41:49 +0000 (16:41 -0500)]
Tests fix: source utils.sh before using conf_proc_count
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 12 Feb 2016 16:19:22 +0000 (11:19 -0500)]
Tests: use configured processor count in getcpu override tests
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 12 Feb 2016 16:17:42 +0000 (11:17 -0500)]
Tests: use configured processor count in snapshot tests
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 12 Feb 2016 16:17:18 +0000 (11:17 -0500)]
Tests: Introduce conf_proc_count()
Tests are using the nproc utility which return the number of
_available_ CPUs. The distinction between online, available and
configured CPUs is subtle, but important.
The number of "online" CPUs can change at runtime as CPUs are
hot-plugged. This could happen during a test and result in
unexpected results.
The number of "configured" CPUs includes any CPU which may be
offline at the time.
The number of "available" CPUs, which is what is returned by the
nproc utility, may differ from both "online" and "configured"
counts. This is the case in containers which are assigned to a
subset of configured CPUs.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 12 Feb 2016 15:40:50 +0000 (10:40 -0500)]
Tests: print a more precise test description in snapshot tests
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Mon, 8 Feb 2016 22:13:26 +0000 (17:13 -0500)]
clock offset: print negative value in metadata for lttng-ust metadata
In the upcoming 2.8, we can print the negative value of clock offset in
the metadata, and expect users to update their viewers to correct any
bug that could prevent them from handling those negative values.
This happens only in cases where the system sets CLOCK_REALTIME to 0
after boot, thus leading to a negative clock offset value between
realtime and monotonic clocks.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Mon, 8 Feb 2016 22:13:25 +0000 (17:13 -0500)]
Fix: handle negative clock offset for lttng-ust metadata
In the unlikely situation where a system sets its hardware clock
(CLOCK_REALTIME) to 0 (Epoch) after boot, the difference
monotonic - realtime
becomes negative.
Fixup this situation by returning a 0 offset in this case.
This ensures that trace viewer implementations (e.g. babeltrace) which
currently cannot handle the negative offset (known bug) still work with
the generated traces.
This patch should be applied to master and stable-2.7.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 14 Jan 2016 20:08:22 +0000 (15:08 -0500)]
Fix: test: append to LD_LIBRARY_PATH
The overwriting of LD_LIBRARY_PATH can cause failure of tests when lttng-ust is
not installed in the default path and location is passed via LD_LIBRARY_PATH.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 14 Jan 2016 18:40:42 +0000 (13:40 -0500)]
Fix: test: use load_path instead of $1
$1 is used for tap condition checking not the load path.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 14 Jan 2016 16:08:53 +0000 (11:08 -0500)]
Bump lttng-ust protocol version to 6.1
The introduction of enumerations in lttng-ust forces the protocol
to accomodate a new command which will only be used by lttng-ust
2.8+.
This is not a breaking change in the protocol since lttng-tools
does not _need_ to receive this command for normal operation, nor
does it issue it.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Sun, 10 Jan 2016 16:50:47 +0000 (11:50 -0500)]
Add CTF enum type support for UST registry
Derived from initial implementation by:
Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 13 Jan 2016 20:41:44 +0000 (15:41 -0500)]
Cleanup __lttng_print macro indentation
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Mon, 11 Jan 2016 22:32:14 +0000 (17:32 -0500)]
Fix: do not print error and bug messages when quiet (-q) is present
Conform to the lttng man page
fixes #988
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Mon, 11 Jan 2016 00:13:24 +0000 (19:13 -0500)]
Fix: test_ust-dl requires bash
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Mon, 11 Jan 2016 00:10:53 +0000 (19:10 -0500)]
Fix: test script requires bash
The test baddr statedump script requires bash. It fails to run on
systems where /bin/sh is not an alias to bash.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 6 Jan 2016 17:31:42 +0000 (12:31 -0500)]
Fix: missing $ in SED variable
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 2 Dec 2015 16:56:41 +0000 (11:56 -0500)]
Tests: fix make targets using objcopy
Add detection for objcopy using AC_CHECK_TOOL and use dedicated make
targets for each file.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 1 Dec 2015 20:19:01 +0000 (15:19 -0500)]
Build: fallback to AC_CHECK_LIBS when looking for popt and uuid
Not all distro ship .pc so fallback to basic libs searching if necessary.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Samuel Martin [Tue, 1 Dec 2015 23:36:45 +0000 (00:36 +0100)]
tests/unit: fix object files' location
Referring to *.o files under a .libs/ directory is not recommended
because this belongs to libtool's innards.
Indeed, libtool decides to place the *.o files in an
implementation-specific location:
- PIC *.o files go into a .libs/ directory;
- non-PIC *.o files are generated along side to their corresponding
source files.
Using PIC objects to build executable is legit, thought it may
introduce some minor overhead at runtime.
However, hard-coding these PIC object files in the Makefile.am to build
executables breaks the build in case of static only build.
In this case, no PIC object files is generated, so the linker will not
found some of the needed objects files.
Changing these dependencies' path fixes the static build, keeping the
shared one ok, though the non-PIC object files are now always built.
Fixes #983.
Fix tested on git master and v2.6 with no change needed.
Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Samuel Martin [Sun, 22 Nov 2015 22:38:00 +0000 (23:38 +0100)]
configure.ac: fix static build
For static build, some extra LDFLAGS may be needed.
Using PKG_CHECK_MODULES instead of AC_CHECK_LIB for librairy detection
allows to get all these flags. Then, the LIBS variable can be extended
with everything that is needed.
So, use PKG_CHECK_MODULES for popt and uuid detection; which both depend
on libintl.
This changes fixes build failures triggered with Buildroot, e.g.:
http://autobuild.buildroot.net/results/0f1/
0f1e015a0c5a5ac2beeb5011d31a1e0058a32a0d/build-end.log
Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Fri, 27 Nov 2015 21:24:28 +0000 (16:24 -0500)]
Tests: fix tracefile count when page_size is > 4k
Set the tracefile size according to the platform page_size and increase
the number of iterations to properly test the rotation.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Samuel Martin [Sun, 22 Nov 2015 22:38:01 +0000 (23:38 +0100)]
configure.ac: use $withval with AC_ARG_WITH
Fixes #980
Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 27 Nov 2015 20:47:01 +0000 (15:47 -0500)]
Fix: close indexes when rotating the trace files in mmap mode
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Julien Desfossez [Fri, 27 Nov 2015 17:12:44 +0000 (12:12 -0500)]
Fix: close indexes when rotating the trace files in splice mode
The consumer needs to close the old index file when doing a file
rotation before opening a new one.
The relay does not have this problem (handled with refcounts).
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 19 Nov 2015 17:26:37 +0000 (12:26 -0500)]
Clarify error message on "add context" failure
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 19 Nov 2015 17:07:56 +0000 (12:07 -0500)]
Fix: Don't spam session daemon logs on invalid UST context
Fixes #976
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 12 Nov 2015 23:56:29 +0000 (18:56 -0500)]
Tests: getcpu_override: use event delay when launching with wrapper
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 12 Nov 2015 21:54:48 +0000 (16:54 -0500)]
Tests: getcpu: no events shall be emitted at the same timestamp
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 12 Nov 2015 21:43:12 +0000 (16:43 -0500)]
Tests: Switch test apps to use usleep_safe()
usleep_safe() ensures that usleep honors its timing guarantees
(which it, according to the man pages, does not strictly enforce).
Some tests need to make ensure no events are emitted at the same
timestamp since Babeltrace does not define an ordering which can
be relied upon in such a case.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 12 Nov 2015 21:42:05 +0000 (16:42 -0500)]
Tests: Add a test utils library
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 12 Nov 2015 21:41:33 +0000 (16:41 -0500)]
Fix: redefinition of _GNU_SOURCE
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 12 Nov 2015 20:01:59 +0000 (15:01 -0500)]
Tests: only call usleep if the test in configured to wait
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Tue, 4 Aug 2015 21:55:12 +0000 (17:55 -0400)]
Test: add UST dl helper test
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Antoine Busque [Mon, 3 Aug 2015 20:16:37 +0000 (16:16 -0400)]
Test: add UST baddr statedump test
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Sat, 5 Sep 2015 18:50:46 +0000 (14:50 -0400)]
lttng: add status command
The status command is the equivalent of:
lttng [general-options] list <current-session-name>
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Sat, 5 Sep 2015 18:15:21 +0000 (14:15 -0400)]
lttng: factor out declaration of commands
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Tue, 1 Sep 2015 02:32:11 +0000 (22:32 -0400)]
make check: add warning when LTTng processes are running
This patch adds a warning when running LTTng/test processes are
detected at the beginning of make check. It offers a convenient
way to kill them and warns the user that some tests could fail
if the processes are kept alive.
The check can be disabled by setting
$LTTNG_TOOLS_TESTS_DISABLE_WARN_LTTNG_PROCESSES to 1
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Julien Desfossez [Wed, 11 Nov 2015 02:21:14 +0000 (21:21 -0500)]
Missing cpu id kernel context in the kernel tracer ABI
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 11 Nov 2015 19:54:17 +0000 (14:54 -0500)]
Use --without-lttng-ust in error message
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Tue, 20 Oct 2015 18:57:24 +0000 (14:57 -0400)]
Use --with/--without for lttng-ust support
Fixes #956
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 22 Oct 2015 20:11:18 +0000 (16:11 -0400)]
Only compare "bison -y" to the basename of YACC variable
In the event that the YACC variable is set to a full path
this test fail even if it should not.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 4 Nov 2015 23:45:04 +0000 (18:45 -0500)]
Tests: Add debug output to getcpu_override
Adds debug output to the getcpu_override test and split its
two tests into two distinct functions. This ensures that we
output two separate traces without overwriting the previous one.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 4 Nov 2015 23:24:48 +0000 (18:24 -0500)]
Tests: Change description of clock-override test
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 26 Aug 2015 06:26:42 +0000 (02:26 -0400)]
Add event exclusion test for identical names
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 26 Aug 2015 22:13:23 +0000 (18:13 -0400)]
Warn when exclusion names are truncated
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 26 Aug 2015 22:11:46 +0000 (18:11 -0400)]
Truncate exclusion names to have a terminal '\0'
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 26 Aug 2015 05:47:15 +0000 (01:47 -0400)]
Ignore exclusion names order when matching events
In other words:
lttng enable-event -u -a --exclude a,b,c,d -> passes
lttng enable-event -u -a --exclude a,c,d,b -> fails (same event)
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 26 Aug 2015 05:26:10 +0000 (01:26 -0400)]
sessiond-comm.h: fix whitespaces
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 26 Aug 2015 05:24:02 +0000 (01:24 -0400)]
Disallow duplicate event exclusion names
This patch makes the session daemon disallow event
exclusion names sharing the same name when creating an
UST event, e.g.:
lttng enable-event -u -a a,b,c,d -> allowed
lttng enable-event -u -a a,b,a,d -> disallowed
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 26 Aug 2015 05:20:24 +0000 (01:20 -0400)]
Add LTTNG_EVENT_EXCLUSION_NAME_AT() helper macro
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Wed, 26 Aug 2015 05:05:13 +0000 (01:05 -0400)]
Fix: lay out names in exclusion structure correctly
This:
char names[0][LTTNG_SYMBOL_NAME_LEN];
means that accessing
->names[0][i]
will return the i-th character of the first name.
So doing:
lttng enable-event -u -a --exclude hello,a,b,c,d
lttng save
would result in a saved session XML file containing
this:
<exclusion>hello</exclusion>
<exclusion>ello</exclusion>
<exclusion>llo</exclusion>
<exclusion>lo</exclusion>
<exclusion>o</exclusion>
This is great art, but not what is expected.
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 2 Nov 2015 22:51:04 +0000 (17:51 -0500)]
Fix: Check for NULL hash tables on relay daemon teardown
The relay daemon will log any "leaked" object on exit. However,
some errors encountered early-on during the daemon's
initialization may result in the teardown being executed with
uninitialized hash tables.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 2 Nov 2015 16:39:59 +0000 (11:39 -0500)]
Fix: Verify directory's existence before calling mkdir
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 2 Nov 2015 21:46:16 +0000 (16:46 -0500)]
Clean-up: declare variables at beginning of scope
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Fri, 23 Oct 2015 23:36:04 +0000 (19:36 -0400)]
Load x86-exceptions lttng-modules probe
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Fri, 23 Oct 2015 22:47:11 +0000 (18:47 -0400)]
Load x86-irq-vectors lttng-modules probe
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 23 Oct 2015 21:14:55 +0000 (17:14 -0400)]
Agent: Make the agent protocol consistently network endian
Considering the Agent Protocol is bumped to v2.0 as of 2.8.x,
this patch revisits the unfortunate decision of communicating
in host-endianness from the session daemon to the agents, and
in big endian from the agents to the session daemon.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 23 Oct 2015 01:38:08 +0000 (21:38 -0400)]
Clean-up: Remove unused variables from default.c
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 23 Oct 2015 01:37:54 +0000 (21:37 -0400)]
Fix: Unchecked NULL string in logging statement
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Alexandre Montplaisir [Fri, 11 Sep 2015 22:38:52 +0000 (18:38 -0400)]
Fix: include the filter expression in agent events' primary key
Similar fix to
a931962, but for filter expressions this time.
UST events's key already includes the filter bytecode, so adding the
string itself should not be needed.
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Alexandre Montplaisir [Wed, 9 Sep 2015 23:40:19 +0000 (19:40 -0400)]
Add the filter expression to the enable_event agent protocol message
The filter expression is part of an event rule, so should be sent
along with the event name and log level.
This bumps the protocol version to 2.0, and will require UST agents
to be updated.
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Alexandre Montplaisir [Fri, 11 Sep 2015 04:06:55 +0000 (00:06 -0400)]
Add some IDE project files to the gitignore
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mikael Beckius [Wed, 21 Oct 2015 19:48:29 +0000 (15:48 -0400)]
Fix live timer calculation error
There is an calculation error for live timer. Variable
switch_timer_interval is based on microsecond, and it is not
right to assign switch_timer_interval mod
1000000 to var tv_nsec
which is based on nanosecond.
Signed-off-by: Mikael Beckius <mikael.beckius@windriver.com>
Signed-off-by: Jianchuan Wang <jianchuan.wang@windriver.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 20 Oct 2015 15:08:54 +0000 (11:08 -0400)]
Don't initialize defaults in library constructor
This is done so lttng-tools has no dependency on constructors
being run, such as in the case of a static build.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 20 Oct 2015 14:45:28 +0000 (10:45 -0400)]
Initialize lttng_ht_seed on hashtable creation
This is done to get rid of the need for constructors to be executed
such as in the case of a static build.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 20 Oct 2015 14:01:57 +0000 (10:01 -0400)]
Cleanup: Missing space after cast operator
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 19 Oct 2015 23:14:12 +0000 (19:14 -0400)]
Build: Switch from tar v7 to posix archive format
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 19 Oct 2015 22:00:42 +0000 (18:00 -0400)]
Fix: Retry poll on interruption
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 19 Oct 2015 21:37:27 +0000 (17:37 -0400)]
Port: Explicitly allocate realpath() resolved buffer
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Fri, 16 Oct 2015 23:08:29 +0000 (19:08 -0400)]
Select which binaries/extras to build at configure time
Introduce new flags to the configure script to select what to build:
* By default everything is built *
--disable-bin-lttng
Do not build anything under src/bin/lttng.
--disable-bin-lttng-consumerd
Do not build anything under src/bin/lttng-consumerd.
--disable-bin-lttng-crash
Do not build anything under src/bin/lttng-crash.
--disable-bin-lttng-relayd
Do not build anything under src/bin/lttng-relayd.
--disable-bin-lttng-sessiond
Do not build anything under src/bin/lttng-sessiond.
--disable-extras
Do not build anything under extras.
Only the necessary libs (from src/lib and src/common) are built.
libcommon and libconfig are always built since they are used by every
target.
If any lttng-* binaries are disabled, 'tests' will not be built.
On ./configure a warning is shown to the user.
Also 'make check' and 'make checkinstall' only return a warning when 'tests'
are not built.
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 15 Oct 2015 20:47:34 +0000 (16:47 -0400)]
Move libconsumer under common/consumer/
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Thu, 15 Oct 2015 20:45:30 +0000 (16:45 -0400)]
Fix: There is more tests than the plan
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Wed, 14 Oct 2015 20:20:40 +0000 (16:20 -0400)]
Remove dead check from configure.ac
The consumerd_only variable was removed here [1].
[1]
4f061d4cf16d6625ed8649095ee6df6922b5262a
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 21:06:12 +0000 (17:06 -0400)]
Fix: Silence warning by casting *sin_addr to *sockaddr
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Fri, 16 Oct 2015 14:23:46 +0000 (10:23 -0400)]
Port: fix 'ERR' conflict with Solaris regset.h
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 15 Oct 2015 20:47:14 +0000 (16:47 -0400)]
Relay protocol: check string lengths
Ensure that string lengths are not longer than what the protocol
supports on both send and receive. Ensure that path lengths fit in the
local filename length limits on the receive side. Ensure that strings
exchanged in the relay protocol are zero-terminated.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Oct 2015 21:05:05 +0000 (17:05 -0400)]
Fix: Silence warning of function having no return value
Some compilers complain that codepaths which assert have
no return value. This is valid since assertions could
be compiled-out, resulting in an undefined return value.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Oct 2015 21:01:34 +0000 (17:01 -0400)]
Fix: Silence warnings when using uid_t and pid_t with printf
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Oct 2015 18:55:40 +0000 (14:55 -0400)]
Port: Add compat for platforms with no MSG_NOSIGNAL or SO_NOSIGPIPE
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Oct 2015 18:18:15 +0000 (14:18 -0400)]
Port: Add Solaris compat to sessiond-comm/unix.c
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Thu, 15 Oct 2015 16:17:43 +0000 (12:17 -0400)]
Port: Add Solaris compat for netdb
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 21:05:53 +0000 (17:05 -0400)]
Fix: Silence warning formating pid_t as int
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Michael Jeanson [Wed, 14 Oct 2015 21:05:24 +0000 (17:05 -0400)]
Port: Add Solaris dirent compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.044541 seconds and 5 git commands to generate.