Mathieu Desnoyers [Wed, 17 Sep 2014 18:56:04 +0000 (14:56 -0400)]
Fix: align objstack on 8 bytes
Architectures such as sparc32 have 32-bit pointers, but require
alignment on 8 bytes multiples for 64-bit integers.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Mon, 18 Aug 2014 22:33:33 +0000 (18:33 -0400)]
Fix Python: Add a comment warning about an API limitation
Add a comment warning about a possible misuse of the events()
API. The objects returned by this function shall not be copied
as they become invalid as soon as the next event is accessed.
It is also invalid to access an event after its generator has
gone out of scope.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 7 Aug 2014 19:58:21 +0000 (15:58 -0400)]
Replace usages of limits.h with the compatibility header
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 7 Aug 2014 16:28:46 +0000 (12:28 -0400)]
Tests: Return from main instead of calling exit()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 7 Aug 2014 16:25:35 +0000 (12:25 -0400)]
Use BABELTRACE_HOST_NAME_MAX in test_ctf_writer.c
This fixes the build on FreeBSD.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 7 Aug 2014 16:24:45 +0000 (12:24 -0400)]
Add limits compatibility header
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 16 Jul 2014 14:58:48 +0000 (10:58 -0400)]
Fix: don't perform unaligned integer read/writes
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Tue, 29 Jul 2014 20:51:51 +0000 (16:51 -0400)]
Add stream packet header accessors
Stream packet contexts may now be modified to contain custom
fields. The events_discarded field is now handled like a generic
packet context field.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 29 Jul 2014 20:57:21 +0000 (16:57 -0400)]
Reuse previously allocated string when setting value
bt_ctf_field_string_set_value() frees and reallocates a new
g_string object if the value is changed. This change ensures
that the previous string is used if possible.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 29 Jul 2014 20:55:36 +0000 (16:55 -0400)]
Fix: bt_ctf_field_type_structure_add_field argument validation
bt_ctf_field_type_structure_add_field is not setting the return
value to a negative value if the parameter validation fails. The
function would abort while appearing to have succeeded.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Julien Desfossez [Mon, 14 Jul 2014 21:11:31 +0000 (17:11 -0400)]
Fix: mmap trace read the stream_id from the first packet
We were hardcoding the stream_id as 0 for mmap traces, causing a
problem for live traces with multiple channels.
A fix enters in lttng-tools v2.4.2 to send the CTF stream id in the beacon
packets, but until then, we cannot support traces with multiple CTF
streams (LTTng channels).
Fixes: #811
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Mon, 14 Jul 2014 21:11:30 +0000 (17:11 -0400)]
Fix: check the lttng-relayd protocol version
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Mon, 14 Jul 2014 21:11:29 +0000 (17:11 -0400)]
Fix: don't update the trace collection if no new streams were received
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Wed, 2 Jul 2014 17:30:01 +0000 (13:30 -0400)]
Remove logically dead code
Fixes Coverity warning
** CID
1224341: Logically dead code (DEADCODE)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 27 Jun 2014 20:03:24 +0000 (16:03 -0400)]
Add Python bindings for CTF-IR stream getters
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 27 Jun 2014 19:44:12 +0000 (15:44 -0400)]
Tests: Add stream getter tests
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 27 Jun 2014 19:43:30 +0000 (15:43 -0400)]
Implement CTF-IR stream getters
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 27 Jun 2014 17:55:34 +0000 (13:55 -0400)]
Move CTF-Writer stream to CTF-IR
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 27 Jun 2014 17:21:26 +0000 (13:21 -0400)]
Add Python bindings for CTF-IR stream class getters
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 26 Jun 2014 18:20:59 +0000 (14:20 -0400)]
Tests: Add stream class getter tests
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 12 Jun 2014 19:00:39 +0000 (15:00 -0400)]
Implement CTF-IR stream class getters
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 12 Jun 2014 17:35:01 +0000 (13:35 -0400)]
Add Python bindings for CTF-IR event getters
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 10 Jun 2014 18:24:53 +0000 (14:24 -0400)]
Tests: Add event getter tests
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 10 Jun 2014 00:51:16 +0000 (20:51 -0400)]
Implement CTF-IR event getters
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 10 Jun 2014 21:29:36 +0000 (17:29 -0400)]
Fix: Set the stream class' id in the packet header
The stream id was used in the packet header whereas the
stream class' id should be used.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 2 Jun 2014 19:18:24 +0000 (15:18 -0400)]
Remove unecessary linking on libbabeltrace-ctf-text
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 30 May 2014 21:40:28 +0000 (17:40 -0400)]
Add Python bindings for CTF-IR event-types getters
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 22 May 2014 16:58:17 +0000 (12:58 -0400)]
Tests: Add an array type and field test
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 21 May 2014 16:19:26 +0000 (12:19 -0400)]
Tests: Add event types getter tests
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 16 May 2014 15:10:44 +0000 (11:10 -0400)]
Implement CTF-IR field types getters
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 16 May 2014 15:10:02 +0000 (11:10 -0400)]
Clean-up: Remove unecessary line break
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 1 May 2014 15:31:31 +0000 (11:31 -0400)]
Add Python bindings for CTF-IR event-field getters
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 27 Apr 2014 12:10:29 +0000 (08:10 -0400)]
Update CTF-Writer and CTF-IR copyrights
Changed the copyrights to stay remain in line with our usual
politic of authors retaining their copyright on the code they
contribute.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 23 Apr 2014 08:26:40 +0000 (04:26 -0400)]
Tests: Test CTF-IR event-field's getters
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 17 Apr 2014 14:51:51 +0000 (10:51 -0400)]
Docs: CTF-IR sequence's length field must be unsigned
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 22 May 2014 19:02:02 +0000 (15:02 -0400)]
Implement CTF-IR event fields getters
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 21 May 2014 17:32:43 +0000 (13:32 -0400)]
Fix: Check that enumeration container types are integers
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 21 May 2014 16:15:36 +0000 (12:15 -0400)]
Add bt_ctf_field_type_enumeration private search functions
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 16 Apr 2014 22:03:27 +0000 (18:03 -0400)]
Add Python bindings for CTF-IR clock's getters
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 16 Apr 2014 22:03:00 +0000 (18:03 -0400)]
Tests: Test CTF-IR Clock's getters
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 16 Apr 2014 22:02:28 +0000 (18:02 -0400)]
Implement CTF-IR Clock getters
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 15 Apr 2014 20:56:21 +0000 (16:56 -0400)]
Split the CTF-Writer implementation in IR and Writer parts
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 21 Mar 2014 19:05:02 +0000 (15:05 -0400)]
Split the CTF-Writer API into IR and Writer-specific parts
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 21 Mar 2014 17:36:15 +0000 (13:36 -0400)]
Split ctf-writer's stream.h into stream.h and stream-class.h
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 26 Jun 2014 14:42:00 +0000 (10:42 -0400)]
Fix (Python bindings): Return a string if a sequence's element are chars
An AttributeError exception was raised when accessing the value property
of a sequence that contains a string.
Reported-by: Yiyang Dai <daiyiyang@hotmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Sebastian Andrzej Siewior [Tue, 27 May 2014 08:08:13 +0000 (10:08 +0200)]
Fix: don't use a return code in _bt_ctf_stream_append_discarded_events
That function is defined as void:
| File "/usr/lib/python3/dist-packages/babeltrace.py", line 2284, in
| append_discarded_events
| if ret < 0:
| TypeError: unorderable types: NoneType() < int()
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 21 May 2014 15:38:08 +0000 (11:38 -0400)]
Fix: Report the sequence's length field's value as length
bt_ctf_get_field_list currently returns the underlying array's
size which is always the highest element count encountered to
date.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Fredrik Markström [Fri, 16 May 2014 02:10:38 +0000 (10:10 +0800)]
Fix: Align buffers from objstack_alloc on sizeof(void *)
The buffers from objstack_alloc will store pointers, so they must
be aligned on a pointer's size, or else it will cause issues on the
CPUs which do not support unaligned addresses access.
Signed-off-by: Fredrik Markstrom <fredrik.markstrom@gmail.com>
Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jesper Derehag [Wed, 23 Apr 2014 15:45:26 +0000 (17:45 +0200)]
Add fallback for betoh/htobe if they do not exist
For older systems endian.h may not contain the betoh/htobe macros.
If they are missing, add them and make sure that any user of
htobe/betoh uses the compat/endian.h
Signed-off-by: Jesper Derehag <jderehag@hotmail.com>
Tested-by: Jesper Derehag <jderehag@hotmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Fri, 25 Apr 2014 13:22:33 +0000 (09:22 -0400)]
Fix: Variable name typo in SequenceField and Event classes
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Julien Desfossez [Tue, 15 Apr 2014 18:28:23 +0000 (14:28 -0400)]
Fix python: remove weird char at the end of line
There was the character \xc2 at the end of one line that caused an
import error on some ubuntu distros.
Reported-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Amit Margalit [Tue, 8 Apr 2014 07:51:00 +0000 (10:51 +0300)]
Added bt_ctf_get_decl_event_id() API function.
Signed-Off-By: Amit Margalit <amitm@il.ibm.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Tue, 18 Mar 2014 17:53:03 +0000 (13:53 -0400)]
Fix: add missing files to gitignore
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 15 Mar 2014 16:31:47 +0000 (12:31 -0400)]
Fix: ctf-text: add missing double-quotes around enum tag
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Lars Persson [Wed, 12 Mar 2014 09:05:17 +0000 (10:05 +0100)]
Use autoconf AM_MAINTAINER_MODE
Give distribution maintainers the option to skip rebuilding
autoconf and automake generated files. The default behaviour
is still to have the rebuild rules enabled.
Signed-off-by: Lars Persson <larper@axis.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Lars Persson [Wed, 12 Mar 2014 07:12:46 +0000 (08:12 +0100)]
Fix: Support out of tree builds in babeltrace
Signed-off-by: Lars Persson <larper@axis.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Mon, 10 Mar 2014 22:03:24 +0000 (18:03 -0400)]
Fix: Add missing lttng_live_should_quit checks
Missing should_quit checks can cause the live plugin to
report errors on exit.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 10 Mar 2014 18:11:07 +0000 (14:11 -0400)]
Fix: Report errors occuring in lttng_live_read
The lttng-live plugin does not return an error code when trying
to open a live trace that is already opened by another client.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 5 Mar 2014 23:19:56 +0000 (18:19 -0500)]
Add README to dist_doc_DATA
This ensures the README is available to users when installed.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 4 Mar 2014 16:49:57 +0000 (11:49 -0500)]
Remove outdated Python binding documentation
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 3 Mar 2014 16:27:29 +0000 (11:27 -0500)]
Fix: Accept an input port in the live URL when no session is provided
Fixes a regression introduced @
2a6d197b310 which causes Babeltrace
to not list sessions if the live URL contains a port and complain
that a port number is not provided after the ":" delimiter.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Fri, 28 Feb 2014 18:12:39 +0000 (13:12 -0500)]
Version 1.2.0
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 28 Feb 2014 13:08:29 +0000 (08:08 -0500)]
Fix: lttng-live parse url port check
Ensure there is a port number after the ':' delimitor.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 27 Feb 2014 17:53:58 +0000 (12:53 -0500)]
Version 1.2.0-rc2
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 25 Feb 2014 22:36:11 +0000 (17:36 -0500)]
Fix: events discarded timing inaccuracy
Introduce babeltrace_ctf_console_output too, to ensure we only print
discarded events when a text output is used.
Fixes #589
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Tue, 25 Feb 2014 20:47:39 +0000 (15:47 -0500)]
Fix: Move offset endianness conversion to get_data_packet
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 25 Feb 2014 20:40:42 +0000 (15:40 -0500)]
Fix: Remove negative comparison to unsigned value
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 25 Feb 2014 20:13:18 +0000 (15:13 -0500)]
Fix: Uninitialized scalar variable
Defect Reported-by: Coverity Scan
** CID
1187497: Uninitialized scalar variable (UNINIT)
/formats/lttng-live/lttng-live-comm.c: 753 in get_data_packet()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 24 Feb 2014 15:30:50 +0000 (10:30 -0500)]
Fix: Don't assert on metadata generation failure
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Tue, 25 Feb 2014 16:26:14 +0000 (11:26 -0500)]
Fix: add missing SIGTERM and SIGINT handler
Handle expected signals gracefully: stop processing at cancellation
points expected by the protocol, so the relay daemon does not print
error messages when clients quit gracefully.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 25 Feb 2014 16:08:54 +0000 (11:08 -0500)]
Fix: Reverse incorrect error message argument order
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 25 Feb 2014 16:25:25 +0000 (11:25 -0500)]
Cleanup: add brackets to lttng-live-plugin.c
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 25 Feb 2014 15:53:47 +0000 (10:53 -0500)]
Cleanup lttng-live: add brackets in lttng_live_read()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 25 Feb 2014 15:51:43 +0000 (10:51 -0500)]
Cleanup lttng-live: 80 columns wrapping
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 25 Feb 2014 15:48:13 +0000 (10:48 -0500)]
Fix: handle new streams in get_data_packet()
- don't skip ask_new_streams() if new metadata _and_
new streams are available.
- goto retry after getting new streams.
- Add missing "ret = 0" assignment at the end of the function. Takes
care of "possible use of uninitialized variables" warnings in the
caller given by gcc.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 24 Feb 2014 18:23:54 +0000 (13:23 -0500)]
Fix: accept empty metadata on append
"Append" should accept receiving metadata packets that contain exactly 0
byte of metadata payload. This kind of flush can happen on trace
teardown.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 24 Feb 2014 17:54:03 +0000 (12:54 -0500)]
Fix: lttng-live: 100ms active poll delay
Do a 100ms delay before retry intead of 1s delays (slightly too long in
terms of user experience) and instead of actively hogging the CPU (too
fast).
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 24 Feb 2014 17:24:54 +0000 (12:24 -0500)]
Fix: lttng-live await metadata
Expect at least _some_ metadata in get_new_metadata. Retry until we
receive some metadata.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 24 Feb 2014 16:49:03 +0000 (11:49 -0500)]
Fix: lttng-live recv() and send() flags, partial recv()
Introduce lttng_live_recv() and lttng_live_send():
- Enforce MSG_NOSIGNAL flag for send(),
- Continue recv() after partial message is received.
- Handle EINTR within those wrappers.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Mon, 24 Feb 2014 18:34:01 +0000 (13:34 -0500)]
Fix: missing little endian conversion for one index field
Locked-step with lttng-tools commit :
Fix: missing big endian conversion for one index field
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 21 Feb 2014 15:17:22 +0000 (10:17 -0500)]
Cleanup: remove logically dead code
CID
1021557 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line:
Execution cannot reach this statement "goto end;".
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 21 Feb 2014 13:58:02 +0000 (08:58 -0500)]
Fix: untrusted value as argument
Fix coverity:
CID
1132646 (#1 of 1): Untrusted value as argument (TAINTED_SCALAR)8.
tainted_data: Passing tainted variable "index_hdr.packet_index_len" to a
tainted sink.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 21 Feb 2014 02:49:31 +0000 (21:49 -0500)]
Fix: off by one in lttng-live path length check
Does not account for final \0.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 20 Feb 2014 22:01:55 +0000 (17:01 -0500)]
Fix: fclose return value unchecked
** CID
1181988: Unchecked return value (CHECKED_RETURN)
/formats/lttng-live/lttng-live-comm.c: 900 in get_new_metadata()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Thu, 20 Feb 2014 05:50:27 +0000 (00:50 -0500)]
Fix: call to append metadata when new metadata is added
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Thu, 20 Feb 2014 05:50:26 +0000 (00:50 -0500)]
Fix: use memstream instead of tmp file for live metadata
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Thu, 20 Feb 2014 05:50:25 +0000 (00:50 -0500)]
Fix: assign a trace handle to every live trace
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Thu, 20 Feb 2014 05:50:24 +0000 (00:50 -0500)]
Fix: get_new_metadata receive all the metadata
Instead of doing the loop in the caller, let get_new_metadata fetch all
the metadata required. Also, call this function when get_packet detects
that we need to refresh the metadata.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Thu, 20 Feb 2014 06:12:01 +0000 (01:12 -0500)]
Fix: Coverity warning CWE-457: Use of Uninitialized Variable
ret is uninitialized if no streams are declared in the trace
descriptor.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 20 Feb 2014 03:20:43 +0000 (22:20 -0500)]
Revert "Fix: get_new_metadata receive all the metadata"
This reverts commit
bb17fa55a7694db83af6f00b16b3e545712662f7.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 20 Feb 2014 03:20:18 +0000 (22:20 -0500)]
Revert "Fix: assign a trace handle to every live trace"
This reverts commit
42423b0a691fb4b2efbb5a45eb7eefa5f350ec30.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Wed, 19 Feb 2014 23:23:53 +0000 (18:23 -0500)]
Fix: assign a trace handle to every live trace
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Wed, 19 Feb 2014 23:23:52 +0000 (18:23 -0500)]
Fix: get_new_metadata receive all the metadata
Instead of doing the loop in the caller, let get_new_metadata fetch all
the metadata required. Also, call this function when get_packet detects
that we need to refresh the metadata.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 19 Feb 2014 00:19:26 +0000 (19:19 -0500)]
CTF: Support incremental metadata append
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 19 Feb 2014 01:40:40 +0000 (20:40 -0500)]
Fix: ctf.c fscanf missing integer length check
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 19 Feb 2014 01:25:02 +0000 (20:25 -0500)]
Bump soname version to 1.0.0
Since there were ABI changes since 0.0.0.
Also add missing -Wl,--no-as-needed to lttng-live plugin.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 18 Feb 2014 23:01:55 +0000 (18:01 -0500)]
Move scanner allocation/free outside of ctf_open_trace_metadata_read
In preparation for incremental metadata parsing.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 18 Feb 2014 22:44:37 +0000 (17:44 -0500)]
CTF parser: prepare for incremental metadata parsing
Associate the file pointer to ctf_scanner_append_ast() rather than to
ctf_scanner_alloc().
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jérémie Galarneau [Tue, 18 Feb 2014 07:04:22 +0000 (02:04 -0500)]
Python bindings: return char arrays as strings in value()
Implement the same logic as in ctf-text to return a string when
value() is called on an array of elements that are encoded as ASCII
or UTF8 and 8-bits long.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 18 Feb 2014 07:03:01 +0000 (02:03 -0500)]
Python bindings: sched_switch example clean-up
Remove unecessary while loop to handle event skipping.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.040447 seconds and 4 git commands to generate.