Annotate Arrays.stream() methods

They all return a real, possibly empty, Stream which
is effectively @NonNull.

Change-Id: I3602bc1b879dd88e9ab05ff1d734fcc88ff45ae5
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59426
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

Annotate StringBuilder.toString()

Always returns a new String, so is effectively @NonNull.

Again, this applies to this class only and not all Object#toString()
implementations!

Change-Id: I748fd7cc6cc627266733632b9e251f87569369db
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59425
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Augment annotation to Map.entrySet()

We already annotated Map.entrySet() to return a

  @NonNull Set<Map.Entry<K, V>>

But actually, the returned Set should not contain any null elements,
since then entry objects will always exist, even if the key and/or
value is null. So we could augment the annotation to:

  @NonNull Set<@NonNull Map.Entry<K, V>>

K and V in this case need to remain unannotated, their type should
match the Map's declaration.

Change-Id: Id436fd3cfc4f679198070e5efdbb9d2d3ce478ae
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59422
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Annotate some static Collections methods

Annotate all the following methods to return @NonNull collections:

.singleton*()
.synchronized*()
.unmodifiable*()

Change-Id: Iffa8743784c68611dcd4262c526afce0509ef155
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59328
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: reduce cyclomatic complexity of StreamInputPacketIndexEntry

Change-Id: I8b717fca910b67e1a3150dba5010ca8d062fa5e9
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44609
Reviewed-by: Hudson CI

tmf: Fix remote test failing on Windows

IFileInfo.getSize() returns 0 for directories on Windows. "For
directories, the return value is unspecified" so the right thing to do
is to add an isDirectory check.

Change-Id: I6112287adc6cef8fcd7c609edab5bbdfbd933ba3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60756
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf : Replace String() by an empty string "" in getHelpText

Replace the creation of an empty string using new String() with ""
instead.

Change-Id: Iebbe8dfc48eb5f963dda8d196eaa57e5f32258d3
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60949
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf : Remove literals duplication in TmfXmlReadWriteStateValue

Change-Id: I4b1a8f7323d6f47344565a0cb3a1f8d9854b4d41
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60831
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: Introduce IPacketReader

Introduce the IPacketReader api to allow better decoupling between the
streaminputreader and the packet reader. This allows for more packet
reader types in the future, such as an InMemoryPacketReader for streamed
in RAM traces.

The IPacketReader is currently implemented by 2 classes:
    * a NullPacketReader, if there is no data to read
    * a CTFPacketReader, the typical packet reader

The CTFPacketReader is quite different from the CTFStreamPacketReader. The
SPR holds on to a FileChannel and maps segments as it needs. This results in
a fast but complex sliding window like reader. On the other hand, the
CTFPacketReader will only read one packet of a stream, a new one needs to
be created for each packet. This makes it wrap a single BitBuffer. As
FileChannels are resources but Bit(Byte)Buffers are not, this means a
CTFPacketReader is NOT autoclosable.

It should be noted that ByteBuffers can hold onto a system file handle. They
are released on GC. Also, ByteBuffers as they have their handle, will not
require the fileChannel to be opened all the time, so resources can be
dynamically closed when running low on file handles.

This patch also fixes some bugs in the tests relating to uninitialized traces
and lost event locations that were hidden due to "event.equals" not working as
well as it should.

The reason this patch does two things at the same time is that the interface
required a major re-write of the packet reader. This resulted in several bugs
being highlighted and fixed. To fix them in a separate patch before would
be very time consuming, and fixing them after would mean deliberately writing
a buggy packet reader to fix it in a subsequent patch.

This change will allow the following changes down the road:
    * In memory ctf reading (network streams)
    * Encrypted ctf stream reading
    * Compressed ctf stream reading
    * Multi-threaded stream reading
    * A power set of the previous elements

Change-Id: Id45b69bb0dac7a1f74f50cd732cd92064595f737
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53284
Reviewed-by: Hudson CI

tmf : Remove duplicate literals in TmfRawEventViewer

Change-Id: I342db238daa4d6ed7579042279548f543b6149d6
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60835
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf : Refactoring the comments in TmfRawEventViewer

Removing dead code and moving some comments

Change-Id: Ieecd757fca6839019265f03e146d52f36184e4cd
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60834
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: log when an error message is displayed in a MessageBox

Provide vital information to external tools such as [1] for testing
purpose. Also allow sharing of error messages a lot more easily.

[1] https://www.eclipse.org/rcptt/

Change-Id: I2dfa6da59c566b0f6a5d55a1d092699c9afcbb26
Signed-off-by: Jonathan Rajotte <jonathan.r.julien@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60860
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf : Use Arrays.asList() instead of a loop

Use Arrays.asList() instead of a loop in TraceValidateAndImportOperation

Change-Id: If2ccf771fe6701164c2ee6f402da780fff9875e4
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60750
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: make FileOffsetMapper try-with-resources in #getOutputFromCommand

Change-Id: I8c1dc1e1f81ddd4c4f442af11f91450d73142741
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59055
Reviewed-by: Hudson CI

tmf: Add check for ineffective setters in AbstractTimeGraphView

If these setters are called after the part control has been created,
they have no effect.

Change-Id: I34bab27624a98df122efd08546d1740d5d672fd8
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60940
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Make call stack view extend AbstractTimeGraphView

Change-Id: I43c472c0512486e806bc1aa1db034d6268face5e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60667
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Annotate often-used Collectors method

We commonly end a Stream with

  .collect(Collectors.toList());

However the returned List is not null-annotated, which means it gives a
warning if we want to save it to a @NonNull List<> reference.

It could be tempting to annotate Stream.collect() directly, however that
would be wrong: there is no guarantee that some shoddy Collector does
not return a null value.

Instead, annotate Collectors.toList(), toSet() and toCollection(), which
should cover for most common use cases.

Change-Id: I8adaf55579bf5b1cc66c5fbb122acc416a4870dc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59327
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

common: Add a checkNotNull method to check contents of a Stream

Change-Id: I7473a5df08a20396d7716bd986a1e1f4e1e0ef27
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59325
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Call synchingToTime in AbstractTimeGraphView when switching traces

When switching traces (or opening a trace for the first time) the method
synchingToTime should be called with the selection begin time, to
perform view-specific handling for the new selected time.

Change-Id: Ia1eaa248b7e6d9616bfc20375276dcc83527fb28
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60736
Reviewed-by: Hudson CI

tmf: Allow AbstractTimeGraphView subclass to set filter content provider

Change-Id: I4127bff23d3a76bb0f23758568d1211eaaa1f60f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60666
Reviewed-by: Hudson CI

tmf: Make entry comparator apply recursively in AbstractTimeGraphView

Also update ControlFlowView's comparator so that it applies correctly to
non-root child process entries.

Change-Id: If02011789f53c12ef14e128651fdcaf0daedcc8b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60665
Reviewed-by: Hudson CI

lttng: make the field names compliant with the code style.

Change-Id: I15705a4eb0b4291fd86d09170d1a7aa58215e47a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59056
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis: clean up KernelStateProvider

Change-Id: I39273c94aad9454fccbd4b353780863ca431b4ac
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60924
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: simplify search

The search now uses a java binary search instead of a house binary
search. This simplifies code a bit.

Change-Id: I9d9da2fff303f2492df502eeb856936ad94d5206
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46286
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Fix wrong time for synchingToTime in AbstractTimeGraphView

It was incorrectly changed to the window start time instead of the
selection begin time in patch https://git.eclipse.org/r/55670.

Change-Id: I083a2e0d7cdc9843e0c2a0e65119a566b5a0ab1b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60664
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI

tmf: Increase visibility of startZoomThread in AbstractTimeGraphView

This will allow subclasses to trigger the zoom thread when implementing
their own actions, for example.

Change-Id: I798327e044e786064ae2170ded415c2a2ea2e756
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60663
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI

lttng: add NON-NLS to string

Change-Id: I698429469932fd1412c8a56840a75d0fd77a685c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60925
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

analysis: Split up KernelStateProvider

Right now, the cpu number and threadid is looked up for each
event, this new architecture will only read the information
as need be. This should accelerate trace reading by about 5%,
also it is more intuitive, as each event has one file
describing what it does.

Change-Id: I0a2c4480b1532536727783e5470acb545f0a705b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47150
Reviewed-by: Hudson CI

tmf: Introduce resolveIntEventAspectOfClassForEvent

This pattern of getting an integer aspect is used a lot,
it could be moved to one place.

Change-Id: I8ca1cf09c70457ec116f0b46bfba3654f91a013f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60662
Reviewed-by: Hudson CI

Update 4.5 target with Mars.1 update sites

Change-Id: If6208c04c826c8f562eef8eaa0e617f1fa6ae99e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59786
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: move custom parser tests from tmf.ui.tests to tmf.core.tests

Change-Id: Ib1d54ad5ad91fe315a68d77ab41d68802fe98178
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60737
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: enable and fix o.e.tc.tmf.ui.tests.trace test cases

Change-Id: I19aa42577be1d1c7056299d8d29d7e9fa768257f
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60733
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Fix some null warnings

Change-Id: Ibb291421d2625ab80151e4f193cc09eb8febe747
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59129
Reviewed-by: Hudson CI

tmf: Make CustomText/Xml test wait until wizard shell is active

Change-Id: I097f47d121613f282d60d057fe1b3a30abd62840
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60671
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: Restore the downloading of the ctf-testsuite

When we migrated to using the tracecompass-test-traces, we also stopped
downloading the ctf-testsuite using git. However those are not part of
tracecompass-test-traces. Oops!

Somehow the tests didn't complain so far, but it'd be better if they
actually ran.

Change-Id: Id6b81698bf8e85d840819db8505a95f57a51685c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59438
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf : remove duplicated lines in TimeGraphScale.java

add of the method drawAbsHeader() with a SimpleDateFormat parameter

Change-Id: I0b65c18e5b367e232e221ea3bc5fe1f2a11e3bdb
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60548
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Define some Sonar properties to skip unwanted classes and modules

Those are defined in our Hudson job right now but it's nicer to
have them as a default. For example, when running locally.

Change-Id: I2224a5573162454197be5459bdabcbebb6a8349c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60674
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Make Import/Export package test wait until wizard shell is active

Change-Id: I158a2328a4d534eb2a6a861d25c47d586156cc4a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60572
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Annotate Long.valueOf() to return @NonNull

Change-Id: I889546810f6012ea88f34e704bf6d58221f4ac93
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59424
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Fix alignment SWTBot test at low resolution

The test now runs at 640x480.

Make sure the views have enough space otherwise they might not be
painted at all and they won't react to the sash being dragged.

Change-Id: Ib7feb329e9d2fe99fc5ecf02dba122b8324eb950
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60553
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Annotate parameters of Immutable collections copyOf() of()

Those methods will throw NPEs if null is passed.
Also fix a few warnings that were introduced by these new annotations.

Change-Id: I73efaa5507b1dfcf9da41c86dc93bbd8ea8b3c27
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60568
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Annotate Guava Immutable collections

The following methods in Immutable{List|Set|Map} are all used
to create new collections and never return null values:

builder()
Builder.build()
copyOf()
of()

They can all be annotated as @NonNull.

Change-Id: I7149f488d2905c5def7b7b39993e9584642a4b0a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59326
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: add NON-NLS annotations to Lttng27EventLayout

Change-Id: Ieef1cd4c22f5747748e7fc4e69c1bd633e934ce4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60547
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

gdbtrace : remove occurrences of literals

Change-Id: I337dc2efba794ec3a8b12adec65c76a6c2d1a1e4
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60551
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf : use of StringBuilder.append() instead of operator + for strings

Change-Id: Ia0156a18fb2e81db4a375d8c36d34e3ced09d55b
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60536
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

statesystem: Remove ITmfStateInterval.getViewerEndTime

Nothing calls it and its semantics are not well defined.
Also, it makes little sense that the state system would have knowledge
about what views want.

Change-Id: Idff4d0bf24c4173c8cd8a67ac18753dcd6fb4ff4
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59785
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

tmf: Fix SWTBot test on Windows related to short temp path

On Windows, the system property for the temorary path looks like this:
java.io.tmpdir=C:\Users\MARC-A~1\AppData\Local\Temp\

Which is a "short path". When used in comparison with full, canonical
paths, it fails.

Change-Id: I3a90f792791e6983c2eab60d54b1e0694ed98dab
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60273
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf: Fix trace markers with experiments in AbstractTimeGraphView

The key of the marker event sources map should always be the view trace.

Change-Id: Iecb458fd291c3ae1b62a5fed9f9954306f41a09a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60138
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: Fix CtfTmfLostEvent time range does not use timestamp transform

When a timestamp transform or trace offset was set on the trace, the
lost event time range end time was not transformed, but the timestamp
and time range start time were.

Change-Id: Ie2e79b5e90e900bdaf2e7e8391868132bd632332
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60136
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Add workspace/ to the gitignore

A top-level workspace/ directory gets created by the Maven build now.
It should not be tracked in Git.

Change-Id: If8a7e0bce1c99d36f9727d642dbebf95bb11da90
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59879
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Rename orphaned relayd test to TestApplication

This file is a test application that is not intented to be tested as a Junit
test but it is written as such for convenience. We use this while developping
the Live feature.

Change-Id: I705f5a9fdfcb5b01b9478fe5402b48587a4c871c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59441
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

tmf: Add Lost Events marker event source and factory

A marker event source factory for Lost Events is enabled for all traces.

The marker event source can reuse a previously returned marker list if
the requested parameters are identical to the previous request.

The event types statistics state system is updated to add a new
attribute which is used to compute the time ranges that are covered by
at least one lost event time range.

Change-Id: I2479afc3f07deb363f5847f4816940010bae3e9e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59389
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Add TmfTraceAdapterFactory

Base class for a trace adapter factory. The factory creates a single
instance of each adapter type per trace, and disposes the adapter when
the trace is closed, if it is an instance of IDisposableAdapter.

Change-Id: Ieec69d17d0cff037f2df0c8dded14eef91db6f97
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59388
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Support adjustment of time graph window range on range selection

When the selection range is modified and 'ensureVisible' is true, then
the window range will be centered on either the selection begin time (if
it has changed) otherwise on the selection end time, if that time is
outside of the current window.

This adjustment is now enabled in time graph views when the
TmfSelectionRangeUpdatedSignal is received.

Change-Id: I8b5ec885b00009be05222db02acd745218759131
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59758
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: CallStackView sets wrong bounds

Apply the same changes that were done in patch
https://git.eclipse.org/r/#/c/55593 for the AbstractTimeGraphView.

Change-Id: I3f1bf9b8cc8dc017e60d92b079e74c892e3b8530
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59856
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Add keyboard shortcuts for Next/Previous Marker

Support '.' for Next Marker and ',' for Previous Marker.

Support Shift key for extending the selection, both with the keyboard
shortcut and with the action button.

Update the status line when Next/Previous Marker changes the selection.

Clarify the marker event source API to indicate that the previous and
next markers should be included in the marker list.

Change-Id: I1f435e9620030809f10f3788eca40521c8a745a9
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59512
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis: Fix missing setItemCount in AbstractSegmentStoreTableViewer

When the last trace is closed, the table viewer input is set to null.
Its item count should also be set to 0. Otherwise this can later cause a
NullPointerException in the TableViewer.

Change-Id: Ic1d482fd5e4ee64f7969375b1fe4d8b626fa31e0
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59781
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf : Change the order of modifiers of reinitializeCharts() in TmfPieChartViewer

Change-Id: I122d2706472dd5a421ee3e2da1c7277f90959783
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/57109
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

rcp: Add compile-time dependency to jdt.annotation

The rcp.ui plugin will indirectly depend on the null annotations
due to upcoming new external annotations.

Change-Id: Ief9a2635187cf3fe8ad998810a765b0bbc58176d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59419
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

common: Rectify some annotations in NonNullUtils

In-line genereic type definitions should not have @Nullable/@NonNull
annotations. These should be only on the "real" parameter and/or return
types.

Change-Id: Iba75a9cf6eb9cbe4662eec25089fa91ffa079728
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59324
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Remove discriminator part when parsing addr2line output

Remove discriminator part, for example: /build/buildd/glibc-2.21/elf/dl-object.c:78 (discriminator 8)
This fixed a NumberFormatException

Change-Id: I92682bee4106d64dcf2964dc98823a80597df3fa
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59298
Reviewed-by: Hudson CI

Upgrade to Tycho 0.24.0

See https://wiki.eclipse.org/Tycho/Release_Notes/0.24
The immediate improvement is that it uses JDT from Mars.1 to compile.

Change-Id: Id66030216ad242996c20dbc37c8409f617838fc2
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/58819
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: update and add HR timer related events and fields

Change-Id: I87b3e1ac4a79059a2c70b1b3ef7e07be6baa4f10
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59011
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: Don't run latency analysis automatically

This reverts an unintentional change.

Change-Id: I5e4a9b1b8e8a2f54aac7924b78d1200f831497e6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59017
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: Fix simple Javadoc warning

Change-Id: I2bd8c9de68a4b10de1e751da38d4ed061c1f3a18
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59420
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ss: Replace some asserts by IllegalStateExceptions

Change-Id: I692279143582c78b629d973107ec65e40f850793
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/56014
Reviewed-by: Hudson CI

ss: Fix a bug where depth of history tree increases at each new node

When adding a sibling after a new root, there was one too many levels.

Change-Id: I19f460347cbba91c5c1f70d9ee4566a3cb164f37
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/59076
Reviewed-by: Hudson CI

TMF: Fix behavior of XML time graph views with experiments

Expected behavior:
* Show the content of analyses when the trace contains those analyses.
* If experiment, show the content of analyses if any of the trace or
the experiment itself contains those analyses.
* Empty if no trace contains the required analyses.

Change-Id: Id04c2f9d4f1ecd9c8c466a9a0536e1b07277ea1f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/35490
Reviewed-by: Hudson CI

ss: Fix wrong calculation of string size in history tree

The strings size was calculated twice in the node size. The nodes were
therefore not used at full capacity.

Change-Id: Iea15dfd701859deaaea7857de83c36c3455eefb9
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/52755
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

ss: Add AttributeTreeTest unit test

Change-Id: I7a67d33ad694370393fa2789e2508233ec570877
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/45686
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: pack columns in latency table

Change-Id: I18855e0e4d728aca681bcd39229ca156e45cedb8
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/58062
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis: rename latency to segment store for statistics

Change-Id: I1bd00e238843e9256d0ffcab38c1752ac0f35180
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59134
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

analysis: avoid division by 0 in latency statistics

Change-Id: Iaa30a5989517777b37aa4b7b21b5c4da025dcec9
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59133
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis: Add null check for dependent analysis

This fixes a NPE and also avoids execution the statistics analysis on
other trace types than LTTng Kernel when the view is open.

Change-Id: I6583dcbb80044586f25067f32a5fbd9f28c7d4ed
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59045
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis: Rename latency related classes to System Call Analysis

Change-Id: I16393568ca9453768f4d95f4e4bbef8edae85327
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/58988
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis: Allow segment table viewer/provider to accept ISegment[] input

This makes it easier to use a subset of a segmentstore as input.

Change-Id: I39b453805b9dc9f612bc0d72372ebde3c8cc4774
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59155
Reviewed-by: Hudson CI

lttng: Fix AttributeNotFoundException when dealing with event before state dump

Change-Id: I6fcd21928d1430f1e450dede276eefa3820493fe
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59297
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

common: Add external annotations to NavigableSet

The following methods in NavigableSet:

ceiling()
floor()
higher()
lower()

can all return null if there is no corresponding element in the set,
independently of the container type declaration. They should be
marked @Nullable.

Change-Id: I66b9cd5ba8b6eafc69032fb0ae27a9d1ce9e464c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59296
Reviewed-by: Hudson CI

common: Annotate some methods in String

All variants of:

copyValueOf()
format()
intern()
toString()*
valueOf()

return a non-null value, so can be marked as such.

* Do not confound with Object.toString()! That one has no nullness
  guarantees.

Change-Id: Ia739dab7ab294e0c32156bd3b756f4241e97a4a1
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59163
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

lttng: Do not throw exception if callsite binary is missing

If a trace with debug information is opened on a different machine
than the one where it was taken, it's very possible for the referred
binary files to not be present. In such a case it should not throw
an exception, but simply return that no source callsite information
is available.

The (upcoming) "binary callsite" information should still be available
in such cases though.

Change-Id: I5c3c77d9086b1445b8a1b11e8bb312929321d7f3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/58883
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Replace instances of FluentIterable with Java 8 Streams

Guava's FluentIterable was already used in some places to make use of
functional idioms. Now that we have moved to Java 8 we can replace
those with base Java Streams.

Change-Id: I41bce430327020837b6fb3cc053405ab231801ab
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/58882
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

releng: Transition to jdt.annotation 2.0

The new o.e.jdt.annotation 2.0 annotations (based on Java 8
Type Annotations [1]) can now apply on generic type declarations,
allowing things like "List<@NonNull String>".

The @NonNullByDefault annotation, already in use, will now apply
to these locations. This required some code changes to eliminate
compilation errors, notably in places where null checks were
previously made and were not needed, or where some existing
declarations had to be specified as @Nullable.

Another relatively important change is the new syntax for []
arrays. Before, only "@NonNull String[]" was allowed, which meant
"a non-null reference to an array of unspecified Strings". Now, it
instead means "an unspecified reference to an array of non-null
Strings".

It is still possible to specify the array reference itself, but by
doing: "String @NonNull []". Both locations can be annotated
independently.

[1] See https://docs.oracle.com/javase/tutorial/java/annotations/type_annotations.html

Change-Id: I4cb0a3266928c24cfd7f8ed442c93556132f892c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/57252
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Add null checks for methods missing them

In preparation of annotation-enforced @Nullable Map.get() etc.

Change-Id: I81385aba7007baf8ad94fc1519689621f1945493
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/58880
Reviewed-by: Hudson CI

tmf: Add drop-down to Next Marker action to set navigation enablement

The Next Marker action now has the AS_DROP_DOWN_MENU style. The menu
items allow to disable navigation of markers by category.

The Next/Previous Marker actions now skip markers of disabled
categories.

The marker list is cleared immediately when switching traces in the
abstract time graph view. If the trace was not a supported trace for
that specific view, the marker list would never get updated.

The marker actions now disabled if the time graph has no content (empty
time bounds).

The enablement/disablement of the Next/Previous Marker actions based on
current time selection that was requested and implemented in
https://git.eclipse.org/r/57135 is reverted for the following reasons:

- It would now require to go through the list of markers and comparing
each marker category against the set of disabled categories, just to set
the action enabled state, whenever the time selection changes.

- It would make the Next Marker drop down menu inaccessible if the
current time selection is after the last marker.

Change-Id: Idd8361ccc6a00c0bb19749019965e5389aa2692a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59171
Reviewed-by: Hudson CI

tmf: Add Show Markers menu for time graph viewer

Support the dynamic Show Markers menu in time graph viewer that contains
a checked action for each of: Bookmarks category, view-specific marker
categories, and trace-specific marker categories for the current trace.

Add the menu to the abstract time graph view's view menu.

Hide markers of categories that are unchecked in the Show Markers menu.
This will also make them ignored in Next/Previous Marker navigation.

Change-Id: I31c0ee983c217a149070f8628a162fc7420222d6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59072
Reviewed-by: Hudson CI

tmf: Support navigation for all markers in time graph viewer

The time graph viewer now stores both the bookmark list and the marker
list. The time graph control's marker list is the sorted union of both.

The Next/Previous Bookmark actions are renamed to Next/Previous Marker,
and now apply to all markers in the merged list.

Change-Id: Idf2b14394726885753a926c1424ce7e0d315610b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59064
Reviewed-by: Hudson CI

tmf: Support marker event categories

Change-Id: Ic60590932a23e21d39b800a7e3893ea0661d16d9
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59063
Reviewed-by: Hudson CI

lttng: Remove outdated comment

The return type was changed already.

Change-Id: I3106689d272359af2c0ff0f0ab7fbda8656361e2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/58881
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Link all plugins to the external annotation location

Change-Id: I329f7bc22a8509534540b97ef3451fd21840094d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/57251
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

common: Annotate some static methods in Collections and Arrays

The following methods and static fields can be marked as @NonNull:

Arrays.asList()
Collections.empty{Map|List|Set}()
Collections.EMPTY_{MAP|LIST|SET}

Change-Id: I6a36ac288441099219de19b1ec7793ed5cfd2a01
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59165
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

common: Annotate java.util.Formatter

Annotate both Formatter.format() methods to return a @NonNull formatter
(they return the formatter object itself).

Change-Id: I8f18f439d6db909f10c0f54fd4793665c4966a6b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59164
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

common: Update external Map annotations

Make entrySet() return a @NonNull Set (if the map exists, the entrySet
necessarily does).

Change-Id: I08dc06455239701a45ad6f6d9c678f811af73c0f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59162
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

common: Add external annotations for Guava's Table#get

Just like Map.get(), Table.get() can return a null value to
indicate that the key is not present in the table, independently
of the declaration of the type V.

Guava Tables are now used in the graph/critical path classes, so
this is also required.

Slightly harder to add annotations to Guava classes atm due to
https://bugs.eclipse.org/bugs/show_bug.cgi?id=480462
but one can still write the .eea files manually.

Change-Id: Id5cc1bdea73bafe62af60df0fdf7f3e9c5f40796
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/58776
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

common: Add external annotations for IAdaptable/IAdapterFactory

Change-Id: I0a35aa77392ae57602e7171d68b490fb9fe6411f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/57250
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

common: Add external annotations for Map.get()/.remove()

Even if one declares a Map<Object, @NonNull Object>, Map.get()
can return a null to indicate "there is no value for this key".
Same applies to .remove() too.

Since the base methods are not annotated, we either have to
supply our own annotation, or make sure to always use @Nullable
keys. The former is less error-prone, so let's do that.

See http://stackoverflow.com/a/25371836/4227853 .

Change-Id: I3bb7395d7dca053d354f2f418d8529696edd0346
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/57249
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

control: Add LTTng profile save dialog

Change-Id: I42ab05d707369d5082f2503f0ef04993d4193cf3
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/57685
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

control: Add support for downloading profiles after saving of sessions

Change-Id: Ie42d8d2d408f52fd093780193859015cb0907613
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/57684
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

control: Add support for saving session

This commit adds support for saving one or more session in
default location and force overwrite

Change-Id: I6996415456c86b9bc82df6504af04ee1a13f1440
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/57683
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

control: Add LTTng profile preference page

Change-Id: Iaf8f420eadf4747866a8eee2b3b9a9bc723d7396
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/57682
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

control: Add enhanced support for loading of sessions

Change-Id: I68df4fba7eb53542cd9eca4cf15e161cc679d782
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/57681
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>