lttng.control: Adding support for the LOG4J domain in the Control view

Adding the controls for the org.apache.log4j (LOG4J) loggers in the
Control view. Also implemented the visualization of those loggers in the
Control view.

Change-Id: Ia73bab1279ea4cc72527e8bee96d16d39aab9745
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77796
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis.lami: Do not validate extra arguments (anything is valid)

Change-Id: I744eb779d246e778fdb7a1f59ea07babf05c354c
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74336
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

analysis.lami: use ShellUtils in execute() to split arguments

Change-Id: Ice0c0ef04794b0299537e4b007ee5ad474e2b404
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74335
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

analysis.lami: check if command is executable, and support relative paths

This patch makes LamiAnalysis check if a given executable name
is indeed executable, not just existing.

It also adds support for relative paths. For example, if your
current working directory is /tmp/hello, and there's an analysis
at /tmp/hello/my-analysis, then creating a custom external
analysis starting with `./my-analysis` finds the executable
file/link.

Change-Id: I7a6ba4bbd95a9c190296c07f0f04c87aca2ecf34
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74334
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

analysis.lami: support LAMI 1.0 data objects

This patch adds support for the LAMI 1.0 protocol in the data
object layer, keeping backward compatibility with the pre-1.0
LAMI (parsing behaviour before this patch).

The main differences between LAMI pre-1.0 and 1.0 are:

* Integer and number classes are merged as the number class
* Number objects can have low and high bounds of uncertainty
* The ratio, timestamp, duration, size, and bitrate objects
  inherit the number object (i.e. they can all have a
  range of values in which it is guaranteed that the real
  value falls)
* The time range object is a composition of two timestamp objects
* There are no more "loose" JSON values in the cells of
  result tables: all the data objects are JSON objects with
  a class property

Change-Id: I728503672648a2be6c6a9310c29a49c209110f86
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74333
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.ui: move optimization algorithm out into its own file.

This also adds a bit more javadoc explaining how the algorithm works.

Change-Id: I74f5bdb163e7cfa1aee7181a9b3a4b30c0cc86d7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78399
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI

linux.ui: simplify optimizer with multiset

Replace the patterns of getx, put(x+1) with a multiset.
Replace large stream operation with simple built-in function.

Change-Id: I2697de79929ffcc4998cac8ed220c549fc577fbf
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77874
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI

timing: Fix CallGraphAnalysisTest

Change-Id: I6ff6bf31d8a96000d9808ca5afbf0929b40c7f97
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/78400
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

linux.ui: Add tests for control flow view optimizer

This test suite is overridable and defines the contract
of the optimizer function.

Change-Id: I7bfa6b9c18c64620a9663b8c663b5f5bb4b0bd1c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77909
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

Timing: Fix call stack state value bug in CallGraphAnalysis

The CallGraphAnalysis works only if the state value is a long.
Now it'll work if the state value is a long,integer or a string.

Change-Id: I119f47bd7c81d3c8ede6253bae1f8712aba2229d
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78026
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

linux.ui: extract control flow view optimizer

The control flow view optimizer algorithm is now extracted into
a Function<>, this allows for better testing of the code and
improves modularity.

To change the optimizer behaviour, one needs to override the
getUpdatedSchedulingColumn() function to return another algorithm.
Consider ILinkEvents to be edges in a graph where the vertices are
the entries.

Change-Id: I2a8cb686e2c31589873006d1fca2f489ad724b33
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77871
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

lttng.control: Remove "exclusions" node in the pre MI 3 test config file

The "exclusions" node what introduced in the third version of the MI,
before that only "<exclusion>true</exclusion>" was available. There is a
separated file for the third version of the MI
(LTTngServiceMi3Test.cfg).

Change-Id: I9df6100ef2de816fb2a88678c1fc5f12ca01298a
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78281
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng.control: Bug 486658: Improve the enable event handler

With the right-click enable event in the Control view, it is now
possible to enable/disable the same event with different loglevels
(having a single event enabled multiple times with different loglevels).
It is also possible to enable disabled kernel dynamic probe and function
probe.

Change-Id: I35194310b2332f3c4f74084f8189c3325729bad7
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76547
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

lttng.control: Add support for enabling syscall by name

Add a tree in the Enable Event dialog for enabling System call event.
Also update tests and documentation concerning this feature.

Change-Id: I7ddbdc2e33b4bcc782d1eb45598252e04c6cd486
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76972
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

lttng: Bug 498066: Update test file to verify bug fix

Change-Id: I07e3600503982cda35d241182161a762cce0496f
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78269
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ss: Replace hard-coded sizes by their types' sizes

Change-Id: Iefbafd41654a2dbead75333cbd34bf45022a405d
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Reviewed-on: https://git.eclipse.org/r/78267
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>

lttng: bug 498529, use event layout in VM analysis

Change-Id: Id29c600d4345e5d66a46a2551ad85cec6f985cf8
Signed-off-by: Abder Benbachir <anis.benbachir@gmail.com>
Reviewed-on: https://git.eclipse.org/r/78000
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: override kvm events for LTTng27

kvm event have been changed in the lttng-modules 2.7
due to naming clash.
Those events were hardcoced in the VM Analysis,
now it will be possible for the analysis to use
layout.

Change-Id: I9e23b43111479066a5035a94c03ea53f9740247c
Signed-off-by: Abder Benbachir <anis.benbachir@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77999
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

linux.core: add kvm entry/exit events to IKernelAnalysisEventLayout

Change-Id: I2d0242a150e2c0eb78bce2eac91d3d4e3c8a6fd4
Signed-off-by: Abder Benbachir <anis.benbachir@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77998
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

lttng.control: Improve the enable logger handler

With the right-click enable logger in the Control view, it is now
possible to enable/disable the same logger with different loglevels
(having a single logger enabled multiple times with different
loglevels). Before, there was a command error because the loggers had
the same name.

Also added a work-around for an LTTng bug with the enabling and
disabling of JUL events. The bug is now fixed, and will probably be in
LTTng 2.8.1.

Change-Id: If7e5107846a2495d7835e8d1d6e0d22462a786c3
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76360
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

common.core: move saturated math to common core

As overflow problems are more and more common, it is justified
to make saturated (clamped) math available to all packages.

Test coverage is 100%, the code has to be rigourously tested as
this is part of the base of trace compass now.

Change-Id: Icf9771162230b8ff0371015ed0f39cc5ff07a06f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78107
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Support dynamic marker event sources

The signal TmfMarkerEventSourceUpdatedSignal is added to notify
components that a marker event source has changed and that markers and
marker categories need to be refreshed.

The zoom threads in abstract time graph views are changed to update the
marker categories along with the marker lists, to ensure they match.

Change-Id: I2c6fb2443a474d01d9d37ae5b6b8fc13a1ee7457
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77415
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf.ui: add second unit to timegraph scale

This adds seconds in the time units to make it clear what unit
the time is in.

Change-Id: Ide467c2e1738c6e2f8aadbe7e06e64a15d2ae71b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78016
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

doc: update documentation to reflect preserved aspect of the events editor

Show the user the changes in saving the state of the events editor.

Change-Id: I6442ac1074238b2916c0903481bc2fddd1586f43
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78095
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Change getTracesToBuild trace parameter to be @Nullable

The default implementation already handles a null trace, and
VirtualMachineView overrides it as @Nullable.

This allows subclasses to call the method with the return value of
getTrace(), which can be null, without needing a null check and get an
empty list back.

Change-Id: Ie7cb5c79bb841796be4e20fcafedb43ad8b2c839
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/78104
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

timing: Add Tests for the callStack segment store

This tests the segment store created by the callGraphAnalysis

Change-Id: I4b5d71be752653d4bd5ee49640e0591531336a64
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77636
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

lttng.control : Adding support for the JUL domain in the Control view

Adding the controls for the java.util.logging (JUL) loggers in the
Control view. Also implemented the visualization of those loggers in the
Control view.

Change-Id: I6ee97902eb166fa251415df21ec26a3e5d85049b
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75428
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Change warnings to errors in build.properties

Missing entries in those files result in build failures so they should
be reported as errors.

Change-Id: Ib8df4c9baf062e9eadcdd6b9593abfd7aef38fc0
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77784
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Do not persist width of auto-expanded last event table column

Change-Id: I9a9e7e1ab72d8bf443590df4a7b1bb252fd5a472
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77933
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: Add a lttng 2.9 event layout and update network events/fields

Change-Id: Idc388cad9f9117ed2f0b4c4b1f7450c2c296fb05
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/78007
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

xml: Fix behavior of time graph view for experiment analyses

Reverts part of commit f3dac92a8f96850f47c1be3279cdab71b8857b65 which was
reverting another commit

When an XML analysis is for an experiment, the time graph view remains empty
because the view is never built with the experiment, only with its children

Change-Id: Ib3d12fc6765cdd66a5846950b032240e1add7496
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77984
Reviewed-by: Hudson CI
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

tmf.ui: add test for persisting column hiding.

This tests that hiding a column is preserved from one open to the next.

Change-Id: I22aded548ccc5c8841acae0eb175182145096c05
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77611
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf.ui: make table columns persist their size and visibility

This allows the configuration to remain after closing and
re-opening a given trace.

Change-Id: I93dd11e8ccc5c8bf5078a95b45e47fc02b74a99c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76395
Reviewed-by: Hudson CI

tmf: Update tests for default timestamp output format in custom parsers

Change-Id: I188c68511a38364ba31b50645bebb125243bed22
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77865
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Update unit tests for custom event type by text line or XML element

Change-Id: Ie97c63b72dcc5b9483b9f25faa1c5a51c54400e7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77859
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Fix ControlFlowViewTest on Mac

Going to the top of a tree is Option-Up instead of Home. Use the new
SWTBotUtils method.

Change-Id: I77a5d88b84d529c6ae0bf3739ae5eed19438a974
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77105
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Remove function name from ITmfCallsite

It just so happens today that the UST Debug-info analysis makes
use of addr2line to retrieve the source code location AND the
function names, but those two are completely separate concepts.

Since "function name" is not relevant for source lookup, it
should be removed from the concept of what is a call site.
ISymbolProvider should be the sole provider of function names,
especially now that it has been decoupled from ITmfCallsite.

While at it, add a new version of #getLineNumber() which returns
a "@Nullable Long", since it's very possible for callsites to
have a file name but no line number available.

Change-Id: I9b7407876166d9cc1e174804145937388306137d
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/77554
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

lttng.control: Improve regular expression recognition for pre-MI LTTng

Changed the regular expression matcher that detects if a session has
exclusions and is using a filter.There was some weird behavior when
those two things were enabled at the same time.

Also updated some tests to make sure the functionality works properly.

Change-Id: I407b6ad9b701e593a963e67c52dcc90eb7f185a9
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76393
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng.control: Add filtering to the Control view

There is now a FilteredTree that is using the TreeView. It is now
possible to filter the Control view tree.

Change-Id: I75a0af123623658d2407c3a6b63b8972a758f74e
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77349
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

linux.core: Add network events and fields to the kernel layout

Event matching definitions can then make use of those events and fields

Change-Id: I0a71de243f74519241ebd2eebbb8ea5a7313bd35
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77799
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

tmf: Fix PatternScatterChartViewTest intermittent failure

It is possible that the test tries to open the scatter chart view
before it's actually available under the Project Explorer. This is
because the trace hasn't fully opened and the analysis outputs haven't
been determined yet.

To reproduce the issue, go to TmfOpenTraceHelper.openTraceFromElement
and add Thread.sleep(5000) right before the asyncExec call. The test
should fail with:
WidgetNotFoundException:Could not find node with text: Latency vs Time

The fix is to wait until tree nodes are available in the tree before
proceeding. The tree util methods have been augmented to handle using
a tree item as the root to find other items from. It will also now
wait before children items are present before expanding, this is to
cover the case where children are not yet created.

Change-Id: Ib9070b20effb8e409d69f70513500ea5ff478778
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77800
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

lttng.kernel: remove getX86IrqVectorsEntry/Exit

Use getIPIIrqVectorsEntry/Exit instead. This solves the downcast issues
in BaseHandler.

Change-Id: I362712eb4e38d661d5f3066e15f5046a5de749aa
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77782
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

linux.core: Support IPIs in kernel analysis (Bug 498215)

Interprocessor interrupts (IPIs) are special types of interrupts by
which one processor will interrupt another in a multi-core system. They
are typically used for

* cache flushes
* shutdowns

They are not logged with standard events, but rather events looking like
"x86_irq_vectors_thermal_apic_exit".

This patch makes them register as IRQs (which they are) in the control
flow view and resources view.

Change-Id: I5380b6bc2d18f2ee98f7675eb1918794a78a71b3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77731
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Tested-by: Francis Giraldeau <francis.giraldeau@gmail.com>

ss: Improve attribute tree encoding to disk

The attribute tree used to be encoded as a list of full attribute
paths.

This patch improves the encoding by replacing common subpaths from
one attribute to the next by "*".

For example, if the previous attribute was "Threads/42/Status", and the
current attribute is "Threads/42/Prio", we encode the current
attribute as "*/*/Prio".

On common Kernel Analysis State Systems, the Attribute Tree is 1 MiB
per 50k attributes, with this patch the Attribute Tree size on disk
is reduced by 75%.

Change-Id: I53b119eba760c10b720e9a3c173ed2996c02c2a2
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72213
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>

releng: Update outdated Maven plugins

Change-Id: Ibe9af7134d99c788e9466371714c2650ddded277
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77825
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

timing: show callStack segments in a density view

This creates a segment store for the callstack view and populates it.
Then the segments are used to fill a density view.

The segments are special segments with links to their children. This
effectively is a callgraph that can then be used for other analyses.

Examples of these analyses are:

* Flame graphs
* Tree maps
* Caller trees
* Call statistcs

These views will allow trace compass to work better as a profiler
on an application level.

Change-Id: I0a1e8eda192e0646dd02bc4134c672a392231208
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76369
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

ss: Use a factory to create SHTs

This is a first step to allow different history tree types to coexist in this
plugin.

Change-Id: I411d2a1a6de06258d98090ce418eeb24e80303a1
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/77006
Reviewed-by: Hudson CI

ss: Add a unit tests for history tree integrity check

Change-Id: I38f18b243925a711a472636daf78e16f965c4588
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/70891
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI

ss: Mark HistoryTreeBackend#getSHT() to be @NonNull

Was already taken for granted, just not explicitly annotated.

Change-Id: Ib0ea170583da6a08c8c27d9cfae327735341117c
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/77728
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

ctf: Add a constant to get the currently selected field for variant types

Variants typically have only 1 struct fields per choice and its name is the
tag. Many possible choices may have the same fields in the struct so it should
be possible to use one lookup to check in every possible choice. This patch
adds a constant to use to get the currently selected field no matter its name.

Use case for this: network packets in LTTng traces have a network_header
variant field that contains a transport_header variant field. But the various
network_header choices have the same transport_header field. We want to be
able to query the { network_header, ANY, transport_header } field and not, as
previously { network_header, ipv4, transport_header } or { network_header,
ipv6, transport_header }.

Change-Id: I74b1e0494a43eae9a9f91dca575d5419f3907168
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77172
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf.core/ui: Introduce CallStackAnalysis

This class moves the core of the call stack to tmf.core. It
decouples core logic from UI.

Change-Id: I3d393a9663a4d79817d1867f4759bdb1df2ccfed
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77643
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: Remove ITmfCallsite from ISymbolProvider

We should let ISymbolProvider focus on function/symbol names,
and use a separate interface for source code locations.

Change-Id: Iab4bbe0945f8ab1f633eadb862885a86dccde708
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/77553
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.xml: Use LinkedHashMap instead of HashMap

The order in which the FSM are declared in the XML is important. Here,
we use a LinkedHashMap instead of a HashMap to conserve this order when
iterating through the FSMs.

Change-Id: I68837e8f8296741f20d1271d92c43b03ef90c986
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77273
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

tmf.xml: Fix validate event in TmfXmlBasicTransition

Previously, if the user do not specify an event in a transition, the
validation always yields false, which is not true. This patch returns
true instead.

Change-Id: I2ec0afb344c3e4fb51366168cca8ebac6c7cb30f
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77272
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

doc: Add user documentation for JUL logging

Change-Id: I44118045ba1bee20f2a0d9964130caf07688e1fd
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77183
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

tmf: Support default timestamp output format in custom parsers

The timestamp output format can now be left blank to use the default
Time Format preference. In that case the Timestamp base aspect will be
used.

When the default format is used, the Timestamp is no longer stored as a
content field, as it is already stored in the event's timestamp.

Change-Id: I1e6f83ffb35f44be7828e3d25ee43f87fa8a97e1
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77497
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

timing: Use sub-second formatter for duration in table viewer

A formatter makes the duration clearer, especially for large durations when
it's hard to figure the number of numbers in the string

Change-Id: I8b71ccc18c905809530df148d63881aced09c916
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/73802
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf.ui: introduce TmfTableColumnUtils

This class adds more functions and removes it from the API.

TmfTraceColumnManager now calls functions from this internal class. This
allows more functionality to be added without bumping the API version
number.

Change-Id: Id8a53f9cbe1f7b7adb72e59482971efbaaf22599
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76394
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

doc: Update user guide for custom parser event type

Change-Id: I3910ac6ae754d9fb2981d42956fc028ce8ab2e8d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/76870
Reviewed-by: Hudson CI

tmf: Bug 497347: Custom event aspects incorrect in mixed experiments

Change the custom event aspects to use TmfContentFieldAspect with the
field name. In a mixed experiment, fields from different custom trace
types with the same name will be combined in a single aspect.

Use the base aspect for the Event type if specified as a custom parser
output.

Remove the internal column data array in custom event, as its
information is stored in the event content.

Do not store the custom event type name as a content field, as it is
already stored in the custom event type.

Change-Id: Ic8b39672f0b6f27439774262791d249e6ecf24b1
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/76640
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Bug 497038: Custom parser field names conflict with built-in tags

A new Tag enum is added as part of the custom parser definition model.

The 'tag' attribute is added to the XML definition.

For backward compatibility if the 'tag' attribute is not present when
loading a definition from XML, the Tag is determined from the 'name'
attribute.

In the internal payload data map of the custom event, the map's key is
changed from a String to an Object that can either be the Tag, a String,
or an enum constant, to ensure there is no conflict of keys.

If the tag is OTHER, the wizards should ensure that the user-entered
name does not conflict with one of the built-in tag labels.

Change-Id: If9bf65fb32d646cda4f24f28bf41941f1f5c85f6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/76257
Reviewed-by: Hudson CI

tmf: Bug 497413: Abstract time graph view JUL logger incorrectly enabled

The time graph view abstract classes are changed to use their own class
when getting the logger so that they are in their own namespace and
inherit the Trace Compass parent logger's log level.

Change-Id: If117f307d8c12e601f26f97c57e6a26ba77311a6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77347
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

ctf: fix npe in size() if trace is not inited

This is a race condition that can appear when bulk openning 5-6
ctf traces at onces.

Change-Id: I8f64d373674e6b1b925a43e607763c518f866ccb
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77361
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Bug 498083: Fix sys call entry matching in I/O analysis

Change-Id: I30bf823530b8613f2db58e4e1bd4a8550b76bf4f
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77485
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

lttng: Bug 498066: Check if field ret exists in syscall exit handler

Change-Id: I25dbd7534cafc20b0ad96e9dc73933d4ae71ab51
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77477
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: Bug 497994: Hide Table action does not layout properly

Change-Id: I8b1f2c741203434b80ea5165d430b01d16514225
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77418
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Rename tag name label in custom XML parser wizard

Change-Id: I51215a25d07a8eb00b3bd5cac834964f1114e653
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/76256
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf: Fix incorrect zoom thread time bounds when time graph view is empty

When the time graph view is empty because none of its build threads have
started yet, the time bounds still have the initial values set to [+INF,
-INF].

If a zoom thread is started at that moment, the requested start and end
time of the zoom thread are clamped to the time graph view's bounds and
are consequently set to [-INF, +INF].

This is changed so that the zoom thread does not clamp the requested
start and end time when the time graph view's bounds are not set.

Change-Id: I6c751641dab8eb4d1389adabf89c3c5a614e6b90
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/77279
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

tmf: Add support for custom event type by text line or XML element

The text line or XML element can have an associated event type that will
override the definition name as the default event type.

If a custom event field or attribute is defined to set the event type,
it will override that default.

Change-Id: I9e38a0cdb5dc1b4442ca8028bbbbee220dc6001c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/75892
Reviewed-by: Hudson CI

linux.ui: Add Operating System Overview Perspective

When solving a problem, one must locate it before they can
identify it.

The current LTTng Kernel perspective is very good at identifying
problems but its views are mostly useful when a user is zoomed in.

This perspective, allows users to locate problem using metrics that
they are used to: CPU usage, Memory usage and IO usage, just like
system monitors in Linux[1] and Windows[2].

This perspective is intended to be used in tandem with the LTTng
Kernel perspective as this one can hone in on an issue and the
Kernel perspective can figure out the problem.

[1] http://static.thegeekstuff.com/wp-content/uploads/2009/10/system-monitor-resources.png
[2] http://www.windows7library.com/blog/wp-content/uploads/2011/04/Resource-Monitor.jpg

Change-Id: I0465b5bd61dc6cca6e8b6f78adbf2969df6f5481
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72303
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: bug 495897 Keep last good formula on failed synchronization

When trace synchronization fails, the last known good formula should be kept
and the traces synchronized. It is a better approximation than to keep the
traces unsynchronized

Change-Id: I35a4b2627fcaf0e7e64e9a77516758944959ca6a
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/75176
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

releng: Switch to RCPTT 2.1.0

We previously used 2.1.0-SNAPSHOT, which doesn't exist anymore
since actual 2.1.0 was released.

Change-Id: If0cb7d6e0003a743514c799ec265b003c1461241
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/77330
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf/ctf: Show trace read progress in the progress bar

This patch adds an interface : ITmfTraceKnownSize. This interface
has two methods:
- size()
- progress()

If a tracetype implements these methods, the progress will show a scrolling
bar instead of the night-rider/battlestar galactica style slider of an
unknown progress bar.

Change-Id: If1b61957f26c2dec26543f64cfb42e12b127391c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67779
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

control: Bug 492041: Add new channel properties from LTTng 2.8

LTTng 2.8 adds new attributes regarding the channels information. There
are now two new fields: "discarded_events" and "lost_packets". They are
now visible in the Property view when using LTTng 2.8 or greater.

Change-Id: Ifceb78916fac501802e98c34faab88ba69540ca0
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76539
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fix intermittent failure in ProjectExplorerTraceActionsTest

To reproduce the issue:

In TmfTraceElement.delete, add a Thread.sleep(5000); right after the
syncExec that calls closeEditors.

Run ProjectExplorerTraceActionsTest.test4_05Delete then
test4_09BringToTop (you can create a new test method and call them in
that order).

The problem is that the delete test waits until the delete dialog and
the editor are closed but there is no guarantee that the file will
actually be deleted right away. While the file is still there, it is
possible that the next test will start and begin the process of
opening the same existing trace. But then the file gets deleted and
the trace doesn't validate properly (or other exceptions depending on
the timing of when the trace gets deleted).

We should make sure that the file is deleted before proceeding.

Bug: 497035
Change-Id: I33d0b45732bdde6061112736f2f1f7e46d55864e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76249
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

lttng: Fix ControlFlowViewFindTest and ResourcesViewFindTest on Mac

Some keyboard shortcuts were wrong on Mac. Going to the top of a tree
is Option-Up instead of Home and Ctrl-F should be Command-F.

Change-Id: Ic10243095ed47d0c9dd2a81b2d7cdda010ec9578
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77104
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

tmf: Ellipse function names that don't fit in CallStackView

Add "..." to function names that get cut due to short rectangles
in the call stack view, and avoid printing anything if at least
1 character + the "..." won't fit.

Also, instead of starting from the full string length and going
down to find a fitting string, start from 1 and work our way
up. This will better handle the worst case, which is lots of
very small states in a view that all want to print very long
strings.

Bug: 497111

Change-Id: I94ccca31fb890923063f75359ff714721a8b6f68
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76401
Reviewed-by: Hudson CI

tmf: Cache CallStackEvent names

This will avoid calling the symbol provider repeatedly, which
equates to a state system query + calling an external process
for LTTng-UST traces, for examples.

Change-Id: I798c0d253b2ba83529c98b99b70481430ea1a613
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76400
Reviewed-by: Hudson CI

linux.core: add help for Context Switch analysis

This can be seen by right clicking on the analysis and selecting "help".

Change-Id: Ief8e3046405b9cb850f0441888423959f2aaa6c2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77253
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

linux.core: add help message for TID analysis

This explains the role of this analysis

Change-Id: I0fa5adecb4dc3c5db03ff8af818b2c1970243eb1
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77251
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

lttng.control: Fix typo in the SnapshotHandler class

Rename the SnapshotHandler class to fix a typo (it was SnaphshotHandler
before).

Change-Id: Ife2cb875a53d13ec9d55482c7fefa34787c13afe
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77065
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng.ust: Use correct Activator in MemoryUsageViewer

It was importing tmf.core's Activator! :O

Change-Id: I9b7edce8c59f9638292bf20b2f3ecc4253b8c4c4
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76783
Reviewed-by: Hudson CI

lttng.ust: Catch TimeRangeException in UstDebugInfoAnalysisModule

This exception may happen if the statesystem was not fully built
due to using pre-release traces that do not have all the
expected event fields.

Since there are such traces out in the wild, this situation can
happen sometimes.

Bug: 497863

Change-Id: Id8c14e36f9dcfe1858628f96298ed3959c0a58f5
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/77263
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

lttng.ust: Replace multiple single queries by one full query

To update data in MemoryUsageViewer, the State System would be
queried once per thread.
This patch replaces multiple single queries by a single full
state query and reads to the result.

Change-Id: I5fbb6d80a498898342db34f8278a85f02e1c6736
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70875
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Bug 496219: Fix incorrect time graph bounds when no time events

When calculating the default bounds from time graph entries, if none of
the entries have time events, the bounds should be set to SWT.DEFAULT.

Change-Id: I5973319c66e3e31059304e628f9bd416a593b326
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/75354
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

lttng.ust: Update lib load/unload events for LTTng 2.9

LTTng 2.9 adds new "lttng_ust_lib:{load|unload|build_id|debug_link}"
events, which should be used instead of the lttng_ust_dl:* events
to track library loading and unloading.

See https://bugs.lttng.org/issues/1035

Bug: 497351

Change-Id: I3a7631afd1ea6701e5bc7e2a5b24919a4ec7eee6
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/77177
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Add plugins for custom charts

This plugin will contain code to build custom charts from various analysis
data. The functionality is based on the LAMI charts that are in the *.lami.*
plugins.

Change-Id: I9c2240733d086fddb002e0904324cedb63b97c6e
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Reviewed-on: https://git.eclipse.org/r/76713
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Bug 496479: Fix ClassCastException in Call Stack view

The exception occurs when using the Select Previous/Next Event action
with a trace that does not define thread entries. The parent of a
CallStackEntry is not necessarily a ThreadEntry.

Change-Id: Ibb24bd4e67174fc0fa4b5125754eca38df97a169
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/75650
Reviewed-by: Hudson CI

analysis: Add totals to latency statistics view

Having the total is useful to know how much time was spent in a given
segment type.

For example, I have a Maven output analysis that computes the beginning
and end of each goal. By having the total, I can quickly see which type
of goal took the longest and then I can drill down to single instances.

Change-Id: Id59a81191726ad926821f7a250d56f4fbc622f7a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73770
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Early-exit event search methods if monitor is cancelled

Prevents from sending a request at all if the job is already
cancelled when the methods get called.

Fixes a spurious test failure, but also covers for the case
where the job could be cancelled very quickly.

Change-Id: I7dd17fd32663ad6985ad4572541e896e9173dc7d
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/77106
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

lttng.ust: Add logging to FileOffsetMapper

Should help identify requests and cache hits/misses more easily.

Change-Id: I80eb4b405ad0ceb61e6a8386d397d110729badd0
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76399
Reviewed-by: Hudson CI

tmf.swtbot: Add additional javadoc to the project explorer tests.

These tests are well documented in the test spec. this is a simple
copy paste to repeat the testing contract.

Change-Id: I7c389f1b2ca9e219845f2487303ff3331981fbfb
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75786
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng.ust: Improve debug-info binary tracking

This patch improves the tracking of binary loading/unloading using the
LTTng statedump and dl events.

It changes the layout of the attributes in the state system to be this:

  Key                      Value
  /vpid                    -
  /vpid/<baddr>            <active>, 1 if active, null otherwise
  /vpid/<baddr>/build_id   <buildid>, e.g. "0123456789abcdef"
  /vpid/<baddr>/debug_link <debug_link>, e.g. "/usr/lib/libhello.so.debug"
  /vpid/<baddr>/memsz      <memsz>, e.g. 2127280
  /vpid/<baddr>/path       <path>, e.g. "/usr/lib/libhello.so"
  /vpid/<baddr>/is_pic     <is_pic>, 1 or 0

which is organized a bit more logically than the current approach.

Currently, the code expects the binaries to have a build id.  If this is
not the case for a particular binary, it will stay forever in the map of
pending binaries.  This patch checks the has_build_id to know whether or
not we should wait for such a corresponding build_id event.  While at
it, we do the same for debug link and propagate its value (although
nothing useful is done with it currently).

The "statedump start" event is now handled, which is required to
invalidate all the mappings for a certain vpid.

More tests are added, using the new synthetically generated traces from
CtfTestTrace.

Change-Id: I48c9de963129040dbd90ea492fe58eba441b28f3
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/73639
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

common: Deprecate NonNullUtils#equalsNullable

java.util.Objects#equals does the same thing and provides
some advantages:

1- It is tested/supported by Oracle
2- It is almost binary compatible upon inspecting the code
3- It is more likely that the compiler will receive
   optimizations for their libs than some that are
   _almost_ binary equivalent.
4- It is industry standard, people can understand the code
   better.

Change-Id: Ica0371deee5876f4cbf42f2b6b521d07a8010067
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76919
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI

tmf.ui: Convert EventsTable Listener into Lambda

This converts the listener from a generic one to a
menudetectlistener with a lambda.

Change-Id: Id26dce3dfa6031919a4d2cfdfe16fe3da7305af2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76341
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

os.linux: Add Next/Previous TID event action in CFV

Expose actions in the Control Flow View to navigate to the
previous or next trace event for a given row/thread.

Unlike the "Go to state change" action, this action will stop
on all trace events related to that thread. To do so, we need
to stop on every trace event to test if they match. Since this
operation is unbounded in terms of number of events to read,
it is deferred to a separate Job.

Change-Id: Ie0f4f7dc3f2d0c6e3f2d0111fa95f265dfcdf75f
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/75362
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Rename "Next/Previous Event" action to "Next/Previous State Change"

The "Select Next/Previous Event" action in time graph views
semantically selects the next state change, not necessarily
the next event. Rectify the name of the action accordingly.

Change-Id: I3ba52210f11d437f48cf9385945d4d380eff19d1
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>

tmf: Open XML editor when clicking Edit in XML analysis manager

This change adds an Edit button the the XML analysis manager dialog
which opens a simple XML editor (from WTP). Dependencies are included
in the RCP on a per-plugin basis but work is being done to make a
feature containing the minimum set of plugins for a simple XML editor
(see bug 480141). Once this feature is available, the RCP will be
updated to use that instead, for better maintainability.

Change-Id: I6fef003210b3457815de0ce15b22e81be2eb2f9f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70200
Reviewed-by: Hudson CI

doc: update "shift-left-click" behavior

Change-Id: Ic2aebdbc55528f9c6d03f58830615095b1c45c53
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76908
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI

tmf: Add possibilty to cancel search event requests

By passing an optional monitor (that will probably come from an
Eclipse job anyway), we can allow the potentially long requests
to be cancelled.

Change-Id: Id8e7d8abf670edd333fc393cfd8d3c1465662a1c
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76227
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>