Patrick Tasse [Mon, 22 Oct 2012 17:07:14 +0000 (13:07 -0400)]
Fix for bug 392591: ArrayIndexOutOfBoundsException in virtual table.
Change-Id: Ie7f6e36765b5b0a111ba6a63e867f0ac99864fb8
Reviewed-on: https://git.eclipse.org/r/8329
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Wed, 17 Oct 2012 16:56:05 +0000 (12:56 -0400)]
LTTng: Handle cancellation of login gracefully (bug 392197)
Change-Id: I1d2ae0e5f852f7350956f39648f20eac6c25c410
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8258
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Xavier Raynaud [Wed, 12 Sep 2012 15:18:04 +0000 (17:18 +0200)]
TMF: add support for popup menu in time chart widgets
Change-Id: I4c546a73f23ea596978cff3aa7920a481b81bdae
Reviewed-on: https://git.eclipse.org/r/8202
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Bernd Hufmann [Thu, 11 Oct 2012 20:48:47 +0000 (16:48 -0400)]
Fix removal of filter in SDView (Bug 391714)
Change-Id: I312a64127a8a35fbf152de8fe023df17c0d136cc
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8175
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Bernd Hufmann [Thu, 11 Oct 2012 19:59:42 +0000 (15:59 -0400)]
Fix ArrayIndexOutOfBoundsException for sync signals (Bug 391716)
Change-Id: I4be9c4fec22f25b2ff77a918f692fb7b41e788b7
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8174
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Bernd Hufmann [Wed, 10 Oct 2012 18:22:05 +0000 (14:22 -0400)]
Initialize dialog member variable (bug 391589)
Change-Id: Iff6450210c88b237ad0abf1971220dff79ce7dc0
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8151
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Fri, 5 Oct 2012 21:54:34 +0000 (17:54 -0400)]
Fix for bug 391277: Rounding error in seekEvent by ratio.
Change-Id: I4fda9f56d5aaf199abcc59c3a9dacabeb681c9b8
Reviewed-on: https://git.eclipse.org/r/8069
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Patrick Tasse [Wed, 3 Oct 2012 19:32:53 +0000 (15:32 -0400)]
Fix for bug 390841: Experiment does not dispose trace contexts.
Change-Id: Ib2ac07efc2f4b4efbb15971bbaa48401997fa215
Reviewed-on: https://git.eclipse.org/r/8002
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Tue, 2 Oct 2012 21:02:07 +0000 (17:02 -0400)]
Convert Windows line delimiters to Unix.
Change-Id: Idb33e8cc17d49436d2ed3edd49869cf965c86d13
Alexandre Montplaisir [Mon, 24 Sep 2012 20:21:09 +0000 (16:21 -0400)]
ctf: Handle traces with unknown event attributes
Instead of blowing up when it sees an attribute is doesn't know,
the parser should just ignore it. This is quite important,
since CTF allows for custom attributes and the parser can't
know in advance about all possible ones.
Ideally, we should also log whenever an unkown attribute is seen.
Unfortunately there is no logging in place in the ctf.core plugins
yet.
Change-Id: I45aba769205060cdcac6935cecc1479b026a5bc0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7904
Bernd Hufmann [Thu, 27 Sep 2012 12:53:09 +0000 (08:53 -0400)]
Fix for NPE in Sequence diagram when closing Eclipse (Bug 390552)
Change-Id: I132cb8085c44ff5e6af0bf7aa8d2e58c9ebb8310
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7959
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Wed, 26 Sep 2012 18:02:00 +0000 (14:02 -0400)]
Fix for bug 390472: ArrayIndexOutOfBoundsException in TmfEventsCache.
Change-Id: I1025ec36868837a9e027399f13d02266c24a152e
Reviewed-on: https://git.eclipse.org/r/7936
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Tue, 25 Sep 2012 13:09:04 +0000 (09:09 -0400)]
Remove Linux Tools URL from LTTng category.xml file
Change-Id: I7dc18cfcd14f6cec9c0b07b66528d9833d6a687c
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7915
Tested-by: Hudson CI
Patrick Tasse [Wed, 19 Sep 2012 15:12:45 +0000 (11:12 -0400)]
Fix for bug 389907: Mouse drag zoom and other time graph mouse fixes.
Change-Id: Ib7ad84872ff680c1ea1cfdd27d8996a55a64b013
Reviewed-on: https://git.eclipse.org/r/7831
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Patrick Tasse [Fri, 24 Aug 2012 17:52:57 +0000 (13:52 -0400)]
Fix for bug 387934: Single event experiment not shown in events table.
Change-Id: Ic0984c905f2f7d5b7ca60734eda9e2b54f692243
Reviewed-on: https://git.eclipse.org/r/7386
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>
Matthew Khouzam [Fri, 7 Sep 2012 18:20:15 +0000 (14:20 -0400)]
ctf: Correctly handle big-endian traces
Fixes the opening of big-endian traces, coming from PowerPC systems
for example.
Closes bug 389002.
Change-Id: I1bd85b80931b8a7c61e6dd2b4b575e8608195bb6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7655
Tested-by: Hudson CI
Alexandre Montplaisir [Tue, 11 Sep 2012 20:30:06 +0000 (16:30 -0400)]
ctf: Fix feature.xml to allow building with pde-build
When trying to build the CTF feature with pde-build, it currently
fails because of unsatisfied dependencies.
We need to:
- Remove the e.o.l.ctf.parser dep completely (the feature ships
this plugin, it cannot depend on it before it's built!)
- Change the order of the plugins so .parser is built first, since
the .core depends on it.
Side note, this .parser plugin is the only one (apart from the help
plugin) that does not get put into a jar when built. I really have
no idea why...
Change-Id: Id520ba5fe4b2aa064f0850748774e14a6b83e49b
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7716
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Xavier Raynaud [Wed, 12 Sep 2012 15:15:12 +0000 (17:15 +0200)]
oups, revert last commit
Xavier Raynaud [Wed, 12 Sep 2012 15:01:10 +0000 (17:01 +0200)]
TMF: add support for popup menu in time chart widgets
Patrick Tasse [Tue, 11 Sep 2012 20:23:58 +0000 (16:23 -0400)]
Fix for bug 389300: Events table does not synchronize on search.
Change-Id: Ic403e97022f665278059f356b71ef33976242c66
Reviewed-on: https://git.eclipse.org/r/7715
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Fri, 7 Sep 2012 15:16:20 +0000 (11:16 -0400)]
Add null check of the current event in initTrace() (Bug 389064)
Change-Id: I7d3212370e46b481ae16660997b9fc6810e11c53
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7662
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Fri, 7 Sep 2012 12:18:32 +0000 (08:18 -0400)]
Allow LTTng Control to connect to LTTng 2.x.y nodes (Bug 388545)
Commit includes
- Support of remote nodes that have LTTng Tools 2.x.y installed
- Display of LTTng Tools version in Properties View
- Update JUnit tests
Change-Id: I3dd19cf8ded4ffd74a2ff9f92fbd55c8e1b38c4c
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7584
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Wed, 5 Sep 2012 21:22:15 +0000 (17:22 -0400)]
Fix time graph scale absolute tick format and tick calculation.
Change-Id: I9b5bb44c860ac08f298a8213b6961d8dcbe949f5
Reviewed-on: https://git.eclipse.org/r/7629
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Patrick Tasse [Wed, 5 Sep 2012 17:26:06 +0000 (13:26 -0400)]
Add thousands space separator for nanosecond timestamp output.
Change-Id: I76de73c1cc9ce0319b97a0be9b2cc8ca454e1615
Reviewed-on: https://git.eclipse.org/r/7623
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Wed, 29 Aug 2012 19:09:27 +0000 (15:09 -0400)]
Add support pin in TmfView base class (Bug 388372)
Change-Id: I8d5710ab56165b9db296629a4eeb73982995fad5
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7500
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>
Bernd Hufmann [Fri, 31 Aug 2012 14:11:19 +0000 (10:11 -0400)]
Add support for UST-only nodes in Control View (Bug 388477)
- Updated command parser for "lttng list -k"
- Disable Kernel in Enable Channel and Enable Events on session
level if no kernel is available
- Add JUnit tests
Change-Id: If6dd01df26a1bcc5cf237b1f9c39d2246dd8a324
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7529
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Tue, 28 Aug 2012 14:58:16 +0000 (10:58 -0400)]
Add support for displaying of CTF context info in TMF (Bug 385494)
Change-Id: Ib1ca3094b7d203ac4207fb027d48629028571de4
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7456
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 23 Aug 2012 21:21:12 +0000 (17:21 -0400)]
Save the encoding type as project settings
To better deal with contributors on different platforms
*cough* Patrick *cough*
Change-Id: Id3b02751f166594891c72941d3e5e5912a423caa
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7387
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Francois Chouinard [Thu, 9 Aug 2012 18:57:45 +0000 (14:57 -0400)]
Fix a sporadic distribution problem in the TMF coalesced requests
When a data/event provider receives a set of requests during the
processing of a signal, it will do its best to coalesce these requests
in order to minimize the number of physical accesses that need to be
performed on the back-end traces.
The coalesced request, itself being a request, also has a data type. By
default, its data type is determined by the first sub-request coalesced
by the data/event provider. Afterwards, when it receives data from the
back-end, it dispatches the data/events to the appropriate sub-request.
This works fine for homogeneous experiments (same trace/event types).
However, when dealing with heterogeneous traces or even with different
event types during a given session, the coalesced event type, being
determined by the first sub-request, can in fact hide the data/events
for sub-requests whose data type is not an extension of the base type.
This fix forces the data type of the coalesced request to ITmfEvent
therefore ensuring that the data meant for the sub-requests is not
inadvertently filtered out.
Change-Id: I2862f7ca30d38c968968dd6cd41f6cc04bbcd9a4
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7171
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Francois Chouinard [Thu, 9 Aug 2012 17:55:31 +0000 (13:55 -0400)]
Add a generic 'lost events' event to TMF
Change-Id: Ic7d1189e3bca397a4bb7a775e7b1757dfde00926
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7100
Bernd Hufmann [Wed, 8 Aug 2012 14:23:38 +0000 (10:23 -0400)]
Update Sonar version in LTTng pom.xml
Change-Id: Ia6b451f22ce8418e3f1726f8f42125ce87d4023c
Reviewed-on: https://git.eclipse.org/r/7141
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Tue, 7 Aug 2012 14:01:38 +0000 (10:01 -0400)]
Added destination parameter for LTTng specific releng site
With this commit it is possible to specify the destination directory
of the LTTng update site when building profile lttngPackage from
Maven command line. Use "-DlttngPackageDestination=<path>"
Change-Id: I89224d438dbea373655ff3b5d4c94150caa854bb
Reviewed-on: https://git.eclipse.org/r/7133
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Thu, 2 Aug 2012 17:21:11 +0000 (13:21 -0400)]
tmf: Fold StateHistorySystem back into StateSystem
At first, a distinction was made to differentiate state systems
that would have a history backend, and those that would not.
In practice, history-less systems are never used, and wouldn't
even work since some recent refactoring.
If we ever need to implement a history-less statesystem, it would be
cleaner to simply use a dummy backend which discards all the
intervals, and returns null or similar on all past queries.
Change-Id: I5c04f9514236878f6f53190f862347a5b19308f4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7070
Bernd Hufmann [Fri, 3 Aug 2012 13:04:08 +0000 (09:04 -0400)]
Partially revert commit "Drop unused dependencies from tmf..."
Added missing Required-Bundle org.eclipse.ui.navigator.resources
to TMF UI MANIFEST.MF.
Change-Id: I715a500b3383f628253d481dffb26f4ad4a970f8
Reviewed-on: https://git.eclipse.org/r/7098
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Tue, 31 Jul 2012 20:27:34 +0000 (16:27 -0400)]
lttng: Handle the statedump events
Back when the state provider was first developed, LTTng did
not support the statedump (dummy events that show the current
state of all the running processes).
This support was added to upstream LTTng since then, so the
TMF viewer should make good use of this information!
Change-Id: I194fa8f31051b5755ed35e1594d33e47dcceec7a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7032
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 2 Aug 2012 19:29:22 +0000 (15:29 -0400)]
tmf: Handle state changes ending after the trace ends
Since it's possible to add states ending in the future, we
have to handle the case where a state would end past the
trace's end time (and the history's end time). We simply
discard it in this case.
Change-Id: Ic0c525aece776cb4e742d8829e420d50570b36a0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7077
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Mon, 30 Jul 2012 20:59:27 +0000 (16:59 -0400)]
Drop unused dependencies from tmf,lttng2,ctf packages
Change-Id: I7d17f254f5e4a5073501ede6bd723db6f9f75dfa
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7022
Alexandre Montplaisir [Mon, 30 Jul 2012 20:30:52 +0000 (16:30 -0400)]
lttng: Change external dependencies to imported packages
The external dependencies for ctf and lttng2 (RSE and Antlr) were
set as "required bundles". This means the exact plugin must be
present in the current installation when building the workspace
from within Eclipse.
This commit changes those to Imported Packages, which relaxes the
origin of the package. This allows distribution-installed plugins
to fulfill the build dependency.
Change-Id: Ie20d19959d819fc834dc045ec0520285fae2cf2d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7021
Alexandre Montplaisir [Fri, 27 Jul 2012 23:43:12 +0000 (19:43 -0400)]
tmf: Also bump the version number in pom.xml's
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Thu, 26 Jul 2012 21:28:59 +0000 (17:28 -0400)]
tmf: Update master branch against the 1.1 baseline
With a baseline installation updated with Linux Tools 1.1, one can now
track which APIs were actually part of 1.1, and which ones should require
bumps to 1.2/2.0.
Some protected fields in CtfTmfEventField were actually not part of 1.1,
so this adjusts their annotations and plugin versions correctly.
v2: Bump the test plugins too.
Change-Id: Id9155fe95594b4844e82e550ab0ca8563a74cdb0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6994
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>
Bernd Hufmann [Fri, 27 Jul 2012 18:38:09 +0000 (14:38 -0400)]
Fix more compiler/javadoc warnings as per new project specific settings
See also bug 385535 for the set of settings.
Change-Id: I76b5e8a78113908379cb9d73bbbbfae6bf1006a6
Reviewed-on: https://git.eclipse.org/r/7006
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Thu, 26 Jul 2012 20:42:40 +0000 (16:42 -0400)]
ctf: Fix remaining warnings the CTF plugins
Change-Id: If61709478cde0258e86761be8060e3ede0ca7f0e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6992
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Thu, 26 Jul 2012 18:27:21 +0000 (14:27 -0400)]
Fix TMF Core JUnit tests
Change-Id: I30595c0a1d190421649d079235c27fa3fbb26932
Reviewed-on: https://git.eclipse.org/r/6987
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Thu, 26 Jul 2012 18:09:38 +0000 (14:09 -0400)]
tmf: Correctly print HTInterval in its toString()
The ASCII value of '[' would get added to the start time,
instead of doing the expected string concatenation.
Changed the whole thing to use a StringBuilder instead.
Change-Id: Iea7f2b409c7c177a4a0b35494294fca7258835a1
Reported-by: Patrick Tassé <patrick.tasse@gmail.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6985
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Francois Chouinard [Wed, 25 Jul 2012 18:28:34 +0000 (14:28 -0400)]
Fix another pile of Javadoc warnings
Change-Id: I324c129736499c3cc4892898f9a0121e47fb7ac7
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Francois Chouinard [Wed, 25 Jul 2012 17:13:58 +0000 (13:13 -0400)]
Fix a pile of Javadoc warnings
Change-Id: I5f8cec0642346b863f058d56d56406a1e8b7fd77
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Alexandre Montplaisir [Fri, 20 Jul 2012 20:25:17 +0000 (16:25 -0400)]
Use project-specific Save Actions settings
The actions to execute on Save are:
- Remove trailing whitespaces on all lines
- Always use braces for control blocks (if, for, etc.)
Other save actions could be interesting, but they can be tracked
with compiler warnings instead.
refs bug #385535
v2: Removed the "Make private fields final if possible" option
Change-Id: If97f311a934739957586c76b83ce0538d733456d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6906
Alexandre Montplaisir [Fri, 20 Jul 2012 20:24:25 +0000 (16:24 -0400)]
Use project-specific formatter settings
The settings are the same as the Eclipse default settings, except:
- Use Spaces only for indentation
- Disable qualified invocations wrapping
(so we don't get myClass\n.get())
refs bug #385535
Change-Id: I773dbea89d24916cb82ca8ad93f2ee05ba8181dd
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6905
Matthew Khouzam [Tue, 24 Jul 2012 19:38:15 +0000 (15:38 -0400)]
Genericized CTF parser and events handling.
Add support for enums in trace fields.
Add support for broken end timestamped traces. (experimental)
Add support for variant free id/timestamp pairings (non-lttng)
Add support for non-CPU based traces (dsp/gpu/fpga...)
Change-Id: I2e49f798ae5e2fefda0316631dbbb74609ba36aa
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/6951
Matthew Khouzam [Tue, 24 Jul 2012 21:59:38 +0000 (17:59 -0400)]
Fix issues with CTF parser.
* When an enum is declared in a different scope than it is defined in.
* When there is no stream ID the trace does not generate NPEs.
* When there is no clock offset, a 0 offset is created. (not often)
Change-Id: Ie0e0e09168aa2d91ac52d49e94bc10e1e9ba691f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/6949
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Mon, 16 Jul 2012 18:46:28 +0000 (14:46 -0400)]
tmf: Add missing javadoc in tmf.core.signal
Change-Id: I562a1b1de353ec5ccd9107afdea5fb6c3aa67475
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6867
Alexandre Montplaisir [Mon, 16 Jul 2012 18:46:23 +0000 (14:46 -0400)]
tmf: Fix some javadoc warnings in tmf.core
Change-Id: I580d39a0eb71dc4cc81fd0c7cdd9626504aefcba
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6866
Alexandre Montplaisir [Mon, 16 Jul 2012 18:46:18 +0000 (14:46 -0400)]
tmf: Enable project-specific compiler settings
refs bug #385535
Change-Id: Ifcb0abfe34cf70d5f0379040acd4db53224a4073
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6865
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>
Alexandre Montplaisir [Mon, 16 Jul 2012 18:46:14 +0000 (14:46 -0400)]
lttng: Fix most compiler warnings as per the new settings
Change-Id: I056b02cd61daa38e8d19f2e36a49f3015bc08263
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6864
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Mon, 16 Jul 2012 18:46:09 +0000 (14:46 -0400)]
lttng: Enable project-specific compiler settings
refs bug #385535
Change-Id: Ic5b5fdb6e418566d6b0a67cc9145c2ed336d8526
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6863
Alexandre Montplaisir [Mon, 16 Jul 2012 18:46:00 +0000 (14:46 -0400)]
ctf: Enable project-specific compiler settings
refs bug #385535
Change-Id: Ie7df540057dd3be916d9f1a53240dd90bb0a73aa
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6862
François Rajotte [Fri, 20 Jul 2012 20:07:56 +0000 (16:07 -0400)]
lttng: Add CPU field in control flow view tooltip
References bug #385656
Change-Id: I101d05b4d4150e2b071e9f9005d5a475d106f8af
Signed-off-by: François Rajotte <francois.rajotte@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/6903
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Matthew Khouzam [Thu, 19 Jul 2012 19:12:58 +0000 (15:12 -0400)]
Fix negative timestamp seek bug.
Change-Id: Ic0e77da05419261ff082103d0e232723b51a3be1
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/6871
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Mathieu Denis <mathieu.denis55@gmail.com>
Matthew Khouzam [Thu, 19 Jul 2012 17:54:46 +0000 (13:54 -0400)]
Fix trace and experiment seeking performance bug
Change-Id: I6c59ac7ba52d80ab4bab597da93ea7adb950158d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/6817
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Thu, 19 Jul 2012 21:47:04 +0000 (17:47 -0400)]
Fix for bug 385432: Missed events in coalesced requests.
In addition to commit
04e0f4e84ffe07a23975f3d6e06849681f3afedf
Change-Id: If53b5b322ef819d25f3fcf2ed7a3d542db124794
Reviewed-on: https://git.eclipse.org/r/6869
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>
Patrick Tasse [Thu, 19 Jul 2012 18:06:14 +0000 (14:06 -0400)]
Fix for bug 385437: Control Flow view's "Previous event" button skips
over state transition.
Change-Id: Id78590a2cf5c1398ee10d3894b56436db4732081
Reviewed-on: https://git.eclipse.org/r/6868
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Thu, 19 Jul 2012 17:11:40 +0000 (13:11 -0400)]
Merge "tmf: Update the ctfadaptor tests for the new formatting"
Alexandre Montplaisir [Thu, 19 Jul 2012 14:31:19 +0000 (10:31 -0400)]
Merge "lttng: Drop the current node arrays in the the event handler"
Francois Chouinard [Wed, 18 Jul 2012 20:14:16 +0000 (16:14 -0400)]
Add test cases for Bug385432
Change-Id: I29602c425b71a81fa51633b4317b062266c8a56b
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Alexandre Montplaisir [Wed, 18 Jul 2012 19:20:04 +0000 (15:20 -0400)]
tmf: Update the ctfadaptor tests for the new formatting
Since
9dc3ba9, the .toString() method for integer CTF fields
will correctly format the value as per the formatting info
in the metadata.
Some unit tests have to be updated to cope with the new values,
for octal and hex integers.
Change-Id: I0aa8e7c919bbc8227cf7d9c5cc286561b172ece6
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Wed, 18 Jul 2012 18:52:30 +0000 (14:52 -0400)]
lttng: Drop the current node arrays in the the event handler
Since we now use "common locations" shortcuts for commonly used
attributes in the tree, we don't really save much by caching
the quarks for all CPUs and all current running threads. This
was initally done as a performance optimization.
This commit drops the current*Nodes arrays that were populated
as new CPUs were seen while reading the trace. We will now get
the "current" pointers by doing standard state system queries.
If there is a performance impact, it's unnoticeable. I think it's
worth keeping this file as easy to understand as possible, since
it's often used as example for building an event handler.
Change-Id: Iedb3a13da837f3676c72f3c91edbd2e6960879a1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Wed, 18 Jul 2012 18:42:28 +0000 (14:42 -0400)]
Fix for bug 385432: Missed events in coalesced requests.
Change-Id: I71eb6782113043c41ad275a0dabb8969dbd6978d
Patrick Tasse [Wed, 18 Jul 2012 15:25:21 +0000 (11:25 -0400)]
Fix for bug 385419: Streaming issues with legacy LTTng traces.
Francois Chouinard [Tue, 17 Jul 2012 21:32:51 +0000 (17:32 -0400)]
Fix test project dependencies.
Change-Id: Ia493a73c46d51fedc003696977fa92e5e89cc078
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Francois Chouinard [Tue, 17 Jul 2012 21:30:08 +0000 (17:30 -0400)]
Fix for Bug383047
Change-Id: Ib311436f740c382d4d828713a4f2d762d63c326d
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Alexandre Montplaisir [Tue, 17 Jul 2012 21:33:35 +0000 (17:33 -0400)]
Merge "lttng: Correctly validate traces of kernel type"
Patrick Tasse [Tue, 17 Jul 2012 20:43:42 +0000 (16:43 -0400)]
Merge "Fix for bug 385323: HistogramView should normalize more timestamps."
Alexandre Montplaisir [Tue, 17 Jul 2012 19:39:28 +0000 (15:39 -0400)]
lttng: Correctly validate traces of kernel type
Fixes bug #385340
Change-Id: I29d72d78076fb63c18d636a7d0471522c1eb2dd2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Francois Chouinard [Tue, 17 Jul 2012 19:34:06 +0000 (15:34 -0400)]
Normalize current event timestamp (Bug3984982)
Change-Id: If0fa17f9203ffb234514f86353c065c894fdac8b
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Patrick Tasse [Mon, 16 Jul 2012 21:44:32 +0000 (17:44 -0400)]
Fix for bug 384402: Import trace validation check ignored.
Change-Id: Ic46c2c3588287b6ee5ce99c45f9e32af4fb82453
Patrick Tasse [Tue, 17 Jul 2012 14:47:24 +0000 (10:47 -0400)]
Fix for bug 385323: HistogramView should normalize more timestamps.
Change-Id: I79f4781f79b8b4b056841c67fc8cd9e0409fad90
Francois Chouinard [Mon, 16 Jul 2012 21:34:12 +0000 (17:34 -0400)]
Final fix for Bug384878
Change-Id: I21f95490799461eb8ac161fea48e527dbba27892
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Patrick Tasse [Mon, 16 Jul 2012 18:14:32 +0000 (14:14 -0400)]
Fix for bug 385222: Canvas border hides histogram data.
Change-Id: I837170b70f0d3737746ac882004ac893d7589039
Patrick Tasse [Mon, 16 Jul 2012 20:42:59 +0000 (16:42 -0400)]
Fix for bug 384501: Partial statistics when opening view during
indexing.
Change-Id: I33a4a0f706c61b078c6e3ac5eed9b22e9d3639fc
Patrick Tasse [Mon, 16 Jul 2012 20:31:25 +0000 (16:31 -0400)]
Merge "Fix for bug 384417: Incorrect range displayed in histogram tool tip."
Alexandre Montplaisir [Mon, 16 Jul 2012 19:19:39 +0000 (15:19 -0400)]
Merge "Fix for bug 384406: Delete trace propagation not working in Windows."
Alexandre Montplaisir [Mon, 16 Jul 2012 15:11:08 +0000 (11:11 -0400)]
tmf: Print CTF integer fields in the correct base
We have the information about the base of integers in CTF, so
we should use this information to print the field correctly,
at least for standard bases (2, 8, 10, 16).
Fixes bug #384983
Change-Id: I66882dd8d5e15473fb3690311c4c170bb22dc8a0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Mon, 16 Jul 2012 17:03:37 +0000 (13:03 -0400)]
Fix for bug 384417: Incorrect range displayed in histogram tool tip.
Change-Id: Id0c40656476118844eb34863a885b5bd015fe2da
Alexandre Montplaisir [Fri, 13 Jul 2012 21:50:05 +0000 (17:50 -0400)]
tmf: Use macro-style definitions for CTF field types
The annotations will have to be updated to "@since 1.2"
if this doesn't make the 1.1 release.
Change-Id: I3a66cef0394bb3dd5f3b1e074ad55579c1a8730f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Fri, 13 Jul 2012 21:41:19 +0000 (17:41 -0400)]
tmf: Javadoc update in CtfTmfEventField
...and other aesthetics changes. That file sure got ugly over time!
Change-Id: I8e171bd065634ac93e3582533eca8837b2058460
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Fri, 13 Jul 2012 20:40:57 +0000 (16:40 -0400)]
Fix for bug 384406: Delete trace propagation not working in Windows.
Change-Id: I3800cce187a50206577e2899500d59d23fa64973
Matthew Khouzam [Fri, 13 Jul 2012 18:55:17 +0000 (14:55 -0400)]
Fix lost events to work after multiple reloads
Change-Id: If086a2c99d6276b8b4b19b55124526f3ee468f70
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Fri, 13 Jul 2012 17:15:23 +0000 (13:15 -0400)]
Fix for bug 384637: NullPointerException in ControlFlowView on disposed
experiment during state system build.
Change-Id: I26b66db4650404ea06fa1586cf348b0aefd78656
Patrick Tasse [Fri, 13 Jul 2012 17:17:36 +0000 (13:17 -0400)]
Merge "tmf: Close the state history files before deleting them"
Patrick Tasse [Fri, 13 Jul 2012 17:17:16 +0000 (13:17 -0400)]
Merge "tmf: Do not broadcast signal if request is cancelled"
Patrick Tasse [Fri, 13 Jul 2012 13:42:30 +0000 (09:42 -0400)]
Fix for bug 385055: Time graph selection prevents trace garbage
collection.
Change-Id: Iae8db7c5e1f6ae90afd87b36dc7dc0d28347167c
Matthew Khouzam [Wed, 4 Jul 2012 19:45:27 +0000 (15:45 -0400)]
Fix minor bugs with histogram time range entry.
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Francois Chouinard [Thu, 12 Jul 2012 19:56:08 +0000 (15:56 -0400)]
Check TS boundary in HV Current Event control (Bug384982)
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Alexandre Montplaisir [Thu, 12 Jul 2012 13:29:11 +0000 (09:29 -0400)]
tmf: Close the state history files before deleting them
When a state history construction gets cancelled, we delete the
partial files, so we are not stuck with an incomplete file that
looks exactly like a complete and valid one.
However, we should close the file descriptors before attempting the
deletion. On Linux, lsof would still report the descriptors to the
deleted files after we stopped using them. On Windows it was even
worse, the deletion would fail because the file lock was still taken.
Change-Id: I29d0bf39621bdf6713bb2c3fe908e16f8d4f2bcc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Francois Chouinard [Thu, 12 Jul 2012 18:06:30 +0000 (14:06 -0400)]
Re-work the zoom function in Histogram View (fix for Bug384977)
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Patrick Tasse [Wed, 11 Jul 2012 21:36:54 +0000 (17:36 -0400)]
Fix for bug 383935: Disappearing tool tip in time graph and other
issues.
Francois Chouinard [Thu, 12 Jul 2012 13:43:47 +0000 (09:43 -0400)]
Fix for Bug384878 - Add ending separator to folders in trace comparison
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Alexandre Montplaisir [Mon, 9 Jul 2012 20:00:24 +0000 (16:00 -0400)]
tmf: Do not broadcast signal if request is cancelled
The state system builder should not send the StateSystemBuildCompleted
signal if the request was cancelled, since the history was never
really built.
refs bug #384637
Change-Id: Ie6f872b5149e4c022ad65c99e68202f8ef74f808
Otavio Pontes [Fri, 6 Jul 2012 17:53:37 +0000 (14:53 -0300)]
Renaming version to 1.2 in master branch
Change-Id: If9b07241d8072b474835123100ff0657b573b492
Francois Chouinard [Thu, 14 Jun 2012 20:13:02 +0000 (16:13 -0400)]
Fix seekEvent() problem and augment TmfExperimentTest
This page took 0.043624 seconds and 5 git commands to generate.