Alexandre Montplaisir [Tue, 13 Aug 2013 18:01:47 +0000 (14:01 -0400)]
lttng: Temporary lttng-luna annotation update
Change-Id: I639a022ccba71e3484ff4d1e6b44f12dc4ba571d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Tue, 13 Aug 2013 17:55:10 +0000 (13:55 -0400)]
Merge branch 'master' into lttng-luna
Conflicts:
lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomXmlTrace.java
Change-Id: I27e699fdbbe30dc669601ec8e25cce7fd37b83e4
Alexandre Montplaisir [Mon, 12 Aug 2013 21:00:46 +0000 (17:00 -0400)]
tmf: Make sure the request scheduler threads end gracefully
Upon disposing a trace, the timer thread for the request executor
was not being stopped. While this was not a problem for normal Eclipse
usage, it becomes a problem when trying to run headless methods in the
tree that use the request scheduler: since some user threads were still
running, the JVM would not close and stay there waiting forever.
Additionally, mark the timer thread as a daemon thread. This is a safeguard
in case a trace is never disposed. This will let the JVM shutdown correctly
even if there are any of those threads still running.
As per the Thread.setDaemon() Javadoc:
Marks this thread as either a daemon thread or a user thread. The Java
Virtual Machine exits when the only threads running are all daemon threads.
Change-Id: I04e628cfd444ee86293f262017c948642619f661
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/15387
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Wed, 31 Jul 2013 17:56:08 +0000 (13:56 -0400)]
tmf: Add time graph viewer option to AbstractTimeView
The AbstractTimeView is modified to add the possibility to be used with
a time graph viewer only, when the time graph combo and tree viewer are
not needed.
The Resources view is also updated to use the time graph viewer option.
Change-Id: I95b557070c9fb412649d56428ae314731ec165aa
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15022
Tested-by: Hudson CI
Patrick Tasse [Mon, 5 Aug 2013 19:02:08 +0000 (15:02 -0400)]
lttng: Add arrows in Control Flow view
Show arrows to follow CPU execution in Control Flow view.
Implement a Hide Arrows toggle action to the time graph control.
Change-Id: Ic6e5020f8a7895e482bda9e45c8333dde79e7022
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15147
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Patrick Tasse [Fri, 9 Aug 2013 18:18:11 +0000 (14:18 -0400)]
tmf: Don't change event table selection on right-click
When right-clicking on a item that is within the selection range, the
selection should not be changed to the clicked item. This would prevent
any context menu actions from operating on a selection range.
Change-Id: I3eb06471a3dd80cc3683fcdc965fd36a67ce86a8
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15298
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Matthew Khouzam [Tue, 18 Jun 2013 01:40:41 +0000 (21:40 -0400)]
lttng rcp: add tracing rcp "file->open" buttons
there are two buttons added:
* File-> Open Trace File...
* File-> Open Trace Directory...
The traces will be opened into the default directory and
automatically select the trace type. If the trace viewer is
ambiguous, it will pop-up a window to help.
The trace is then opened.
The reason that we have open file and open directory is since
some traces are directories.
Also, the code path of regular trace file opening has been re-routed
through this patch to unify code.
Change-Id: I28df30745bf47b64ce0ab0f15a8d425fef4dd91a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13863
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Matthew Khouzam [Tue, 30 Jul 2013 22:03:35 +0000 (18:03 -0400)]
tmf: improve validation for custom parsers
text: is the file a file, readable and have at least 1 byte of data.
xml: validate the xml. Added some XML validation tests.
Change-Id: If2144f15abb564156f8a84cfcdee9497a6f418cd
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/14997
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Wed, 7 Aug 2013 20:04:04 +0000 (16:04 -0400)]
tmf: Remove redundant tests in TmfTraceTest
Since the consolidation of constructors, some of these tests now
do the exact same thing as others, so they can be removed.
Change-Id: I0bd4db596b45e4f4662d19226448e294e99fdefa
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/15225
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Fri, 2 Aug 2013 20:38:44 +0000 (16:38 -0400)]
tmf: Make time graph combo item heights dynamically linked
The height of items in the time graph control are dynamically linked to
the height of their corresponding tree items. This ensures alignment
when tree items have different heights due to custom fonts or images.
Change-Id: I84a2394f6d5673bec1af9a2858cc0a31a76f2753
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15107
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Wed, 7 Aug 2013 20:23:54 +0000 (16:23 -0400)]
Fix extra merge conflict from previous merge
Change-Id: Id679bf9185b2aadc39c1bfc8a61e92011a5e8d57
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Wed, 7 Aug 2013 19:52:30 +0000 (15:52 -0400)]
Temporary lttng-luna annotation update
Change-Id: I271cfce16e2f22e277be95b63e5dc104c7ed6ddf
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Wed, 7 Aug 2013 19:45:05 +0000 (15:45 -0400)]
Merge branch 'master' into lttng-luna
Conflicts:
lttng/org.eclipse.linuxtools.ctf.parser/META-INF/MANIFEST.MF
lttng/org.eclipse.linuxtools.ctf.parser/pom.xml
lttng/org.eclipse.linuxtools.gdbtrace.core.tests/META-INF/MANIFEST.MF
lttng/org.eclipse.linuxtools.gdbtrace.core.tests/pom.xml
lttng/org.eclipse.linuxtools.gdbtrace.core/META-INF/MANIFEST.MF
lttng/org.eclipse.linuxtools.gdbtrace.core/pom.xml
lttng/org.eclipse.linuxtools.gdbtrace.help/META-INF/MANIFEST.MF
lttng/org.eclipse.linuxtools.gdbtrace.help/pom.xml
lttng/org.eclipse.linuxtools.gdbtrace.ui.tests/META-INF/MANIFEST.MF
lttng/org.eclipse.linuxtools.gdbtrace.ui.tests/pom.xml
lttng/org.eclipse.linuxtools.gdbtrace.ui/META-INF/MANIFEST.MF
lttng/org.eclipse.linuxtools.gdbtrace.ui/pom.xml
lttng/org.eclipse.linuxtools.gdbtrace/feature.xml
lttng/org.eclipse.linuxtools.gdbtrace/pom.xml
lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/trace/TmfTraceTest.java
Change-Id: Iccbebfaa9e02141429f46e0bf7d973b1e6120779
Alexandre Montplaisir [Fri, 2 Aug 2013 21:29:39 +0000 (17:29 -0400)]
lttng: Adjust the file name of the RCP archives
Add the build date/time to the file name and remove the SNAPSHOT part
of the version number for (and only for) tracing.rcp.product. This will
be used as the versioning for builds made from the Git tree.
Also added the location of the archive files to the README.
Change-Id: I5a2e24fb1f82b0de05f36168bbbbeffec919e250
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/15109
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Geneviève Bastien [Mon, 5 Aug 2013 18:51:32 +0000 (14:51 -0400)]
TMF: Add utility class for common UI functionalities
The displayErrorMsg(...) function has been moved to this class to avoid having
to rewrite it in every class needing it.
Change-Id: Icea4be2af3fbb5312417c92de7f24b235e1cf675
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/15144
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 27 Jun 2013 18:39:40 +0000 (14:39 -0400)]
tmf: Consider compilation warnings to be errors in tmf.core
Now that we have eliminated all compiler warnings in the code,
we could turn on "-Werror" to make sure no new warnings are
introduced (Hudson CI would fail building any Gerrit patch that
has warnings).
NLS warnings remain as warnings, so that they can be suppressed
in Messages or constants classes.
"rawtype" and "unchecked" warnings for generic types remain as
warnings. Fixing some of those would require an API break.
Additionally, one of those warnings would require a major refactoring
of the ITmfLocation's, so this might remain as-is for the forseeable
future.
Finally, "Unecessary thrown exception" had to remain as a warning
because of TmfTrace.buildStateSystem(). The fix would require an API
break (but this is already fixed in the 3.0 branch, see commit
e27acc1).
Change-Id: I810762a82ed4d0da2241ae943b1da1c2e96888d0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14998
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Thu, 27 Jun 2013 21:52:46 +0000 (17:52 -0400)]
tmf: Consider compilation warnings to be errors in tmf.ui
Now that we have eliminated all compiler warnings in the code,
we could turn on "-Werror" to make sure no new warnings are
introduced (Hudson CI would fail building any Gerrit patch that
has warnings).
NLS warnings remain as warnings, so that they can be suppressed in
Messages or constants classes.
This patch landed one week too late to prevent deprecation warnings
from entering the code... so usage of deprecated methods methods remain
as warnings in tmf.ui.
Change-Id: I9bea653ef2cef3435273647e6de249076a64478a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14207
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 27 Jun 2013 18:13:51 +0000 (14:13 -0400)]
lttng: Consider compilation warnings to be errors
Now that we have eliminated all compiler warnings in the code,
we could turn on "-Werror" to make sure no new warnings are
introduced (Hudson CI would fail building any Gerrit patch that
has warnings).
Only the NLS warnings remain as warnings, so that they can be
suppressed in Messages or constants classes.
Change-Id: I53394af9add34f3757f726ab773d445c92d8523e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14206
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Thu, 27 Jun 2013 17:55:22 +0000 (13:55 -0400)]
ctf: Update project compiler settings
Now that we have eliminated all compiler warnings in the code,
we could turn on "-Werror" to make sure no new warnings are
introduced (Hudson CI would fail building any Gerrit patch that
has warnings).
NLS warnings remain as warnings, so that they can be
suppressed in Messages or constants classes.
This only applies to ctf.core and ctf.core.tests. For ctf.parser,
since Maven also looks at generated code, we have relaxed the settings
to ignore any error/warning coming from the generated Antlr code,
over which we have no control.
Change-Id: I31422d54af59bd96f75d2c2ff130a58c8e9ad5f6
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14205
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Roland Grunberg [Thu, 1 Aug 2013 20:33:45 +0000 (16:33 -0400)]
lttng: Partially revert 9017d8.
Plugin/Feature versions cannot change major version number on a
non-major release. Revert all plugins that went from 1.0.0 to 2.1.0.
Change-Id: Id3ff0976c381cb92e3d58a0128a24c5838def8ae
Reviewed-on: https://git.eclipse.org/r/15069
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Tue, 6 Aug 2013 14:09:43 +0000 (10:09 -0400)]
lttng: change root folder name of RCP to traceviewer
Change-Id: Ia0865358429211196780490a95a207bbfae9e1fc
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/15169
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Mon, 5 Aug 2013 22:21:20 +0000 (18:21 -0400)]
lttng: Only build the RCP on architectures that matter in 2013
Drop the Solaris and PowerPC builds. This leaves us with:
- Windows 32/64
- Linux 32/64
- Mac 64 (Cocoa)
Change-Id: Ie6af27a1c75bb6a7bfcdad6b328d66cb06dc8d92
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/15150
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Tue, 30 Jul 2013 19:07:47 +0000 (15:07 -0400)]
tmf: Clean up constructors in TmfTraceStub
It also fixes some of those constructors not behaving as expected,
like having unused parameters and such.
Change-Id: I1aec63d90427ea43fd4e9edb3f9eb499e79488e2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14995
Tested-by: Hudson CI
Alexandre Montplaisir [Wed, 17 Jul 2013 21:33:35 +0000 (17:33 -0400)]
tmf: Clean up tmf.core.trace package
Move some notions out of this packages and into their own:
- tmf.core.trace.indexer (for the ITmfTraceIndexer interface)
- tmf.core.trace.indexer.checkpoint (for the checkpoint indexer)
- tmf.core.trace.location (for ITmfLocation and its gang)
This will prepare the grounds for the upcoming on-disk B-tree indexer.
Change-Id: I48bee4b30ddd17d32f4d7373e6391c248a9687e9
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14634
Tested-by: Hudson CI
Alexandre Montplaisir [Mon, 5 Aug 2013 20:34:20 +0000 (16:34 -0400)]
lttng: More luna annotation updates
This builder only runs when it feels like it, so it's hard to
catch them all at once...
Change-Id: I4c9265a09bda5f561ea8893078d03b894b21f3e3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Fri, 2 Aug 2013 20:12:05 +0000 (16:12 -0400)]
tmf: Fix failing unit test after merge
The worst part is that this will conflict again when we merge the
patch to remove the ExecutionType from the API...
Change-Id: Id89504d192f310a33ff701aaa10a28d7cea34c14
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/15104
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Thu, 1 Aug 2013 17:04:37 +0000 (13:04 -0400)]
tmf: Use TmfNanoTimestamp instead of CtfTmfTimestamp
Change-Id: Ia996c87c1504be4cdc31943cc69d2fd980da85ea
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15046
Tested-by: Hudson CI
Geneviève Bastien [Wed, 10 Jul 2013 15:07:41 +0000 (11:07 -0400)]
TMF: Add vertical events (links) to time graph view
Add a new interface ILinkEvent and class TimeLinkEvent, for events that occur
between two entries instead of in one entry only.
Add the getLinkList method to AbstractTimeGraphView to get the links for a
given zoom level and other methods to propagate those changes to the time graph
control
Change-Id: I5be30c4a27a10645a57ebfc13b4d1c71a55e06bd
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/15105
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Fri, 2 Aug 2013 19:47:54 +0000 (15:47 -0400)]
lttng: Temporary lttng-luna annotation update
Change-Id: Icbe5485f28c8adcbf59a718547d0c7a7893a2251
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Fri, 2 Aug 2013 19:44:40 +0000 (15:44 -0400)]
Merge branch 'master' into lttng-luna
Conflicts:
lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/request/TmfCoalescedDataRequestTest.java
lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/request/TmfCoalescedEventRequestTest.java
lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/request/TmfDataRequestTest.java
lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/request/TmfEventRequestTest.java
lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/request/TmfCoalescedDataRequest.java
lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/request/TmfCoalescedEventRequest.java
lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/request/TmfDataRequest.java
lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/request/TmfEventRequest.java
Change-Id: Ia68c066bf257571861d97403d8b6ae4270c47b70
Alexandre Montplaisir [Thu, 1 Aug 2013 22:09:04 +0000 (18:09 -0400)]
tmf: Avoid throwing exception in TmfTrace.buildStatistics()
Replace the exception with an IStatus return value, similar to what was
done with .buildStateSystem().
Also handle the actual values that are returned in the caller (the
traceOpened signal handler) so that any eventual errors are logged.
Change-Id: Ia3b84aa6b195dc897193971e780058411050b59f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/15072
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Wed, 31 Jul 2013 18:24:14 +0000 (14:24 -0400)]
tmf: Fix formatting of negative time stamp values
Change-Id: I3a3313d2477507dd0380c77bdee4aa3de5fe49bd
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/15026
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Mon, 29 Jul 2013 20:12:09 +0000 (16:12 -0400)]
lttng: Add a README file with build instructions
Users might want to build the RCP version manually, and the commands
are not documented anywhere yet.
Change-Id: I45f61a1c80fdc081941f2e2c980fd704f7621cf9
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14942
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Fri, 26 Jul 2013 21:33:32 +0000 (17:33 -0400)]
tmf: Add TmfNanoTimestamp
Change-Id: Iff7693286f0968fc6da03de7e796e390f9b8241d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/14900
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Simon Delisle [Tue, 30 Jul 2013 20:02:46 +0000 (16:02 -0400)]
LTTng: Show the buffer type in the domain property view
Change-Id: I518cdb438c2e2fc6a853fe0e012c3776e41e4459
Signed-off-by: Simon Delisle <simon.delisle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/15017
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 26 Jun 2013 19:10:18 +0000 (15:10 -0400)]
ctf: Fix buffer overflow traces from crashing batch import
Buffer overflows are caused here by synthetic traces that aim to
behave maliciously. The parser already handles these attacks, but
the BufferOverflowException will cause the batch import trace wizard
to stop scanning. This fix catches buffer overflows in the validation
and warns that the error is serious.
Change-Id: Ie9156cfaac0944763e3d1dc798c42f1d64753560
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/14088
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Tue, 30 Jul 2013 17:17:52 +0000 (13:17 -0400)]
tmf: Remove the concept of block size in event requests
This hasn't been used in a while, so we can remove all references
to it.
Change-Id: I62cc5626836c4ec7a81980e1b284c3e3fa402da0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14984
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Tue, 30 Jul 2013 15:18:49 +0000 (11:18 -0400)]
tmf: Consolidate constructors in coalesced requests
And some formatting fixes.
Change-Id: I9c8b51694ee82b4b55aa0d98b873cfda17625cf2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14978
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Tue, 25 Jun 2013 15:37:24 +0000 (11:37 -0400)]
tmf: Consolidate constructors in TmfEventRequest
Change-Id: Ic456b7c5c77fe300f9e4716235cf4f0df05dcaa4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14947
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Fri, 26 Jul 2013 20:35:06 +0000 (16:35 -0400)]
tmf: Add missing plugin.xml to build.properties
plugin.xml was added in
8714534.
Change-Id: I2eb74a9c4d6fd8809b1c38779a1c80cae1645dd3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14897
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Mon, 22 Jul 2013 22:16:13 +0000 (18:16 -0400)]
tmf: Improved toString methods for debugging
Change-Id: Idbc64d3d9e2d4870618978122e35d0acd6b8be9d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/14761
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Tue, 25 Jun 2013 15:37:16 +0000 (11:37 -0400)]
tmf: Consolidate constructors in TmfDataRequest
Also removed the copy constructor, which was not a copy
constructor at all.
Change-Id: I44570e3b7ac6b4e710b3049bc5178d919896e2db
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14946
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Mon, 29 Jul 2013 22:07:19 +0000 (18:07 -0400)]
tmf: Make TmfTrace.buildStateSystem() return an IStatus
This removes the need for the SuppressWarnings("unused"), since
every implementation can now return an IStatus (or simply a
Status.OK_STATUS if everything went fine) instead of throwing
an exception.
Change-Id: I23f644988420bbfb4a26caf5e0099c4e26e37072
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14630
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Mon, 29 Jul 2013 22:19:06 +0000 (18:19 -0400)]
lttng: Update UST plugins version to 3.0
Local Maven builds don't seem to care about this, but Hudson does.
Change-Id: Ib271037e30d31c00df6932c4e8094ce172ed503a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14951
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Simon Delisle [Wed, 26 Jun 2013 15:58:39 +0000 (11:58 -0400)]
LTTng: Support for LTTng Tools 2.2
Change-Id: Ib87e9e5598f8b7caad42b1e780f8cddb8aeee4d2
Signed-off-by: Simon Delisle <simon.delisle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/14203
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Mon, 15 Jul 2013 21:38:21 +0000 (17:38 -0400)]
Update LTTng User Guide for time range and event range selection
Change-Id: If9bb40cf2428f3ab84c34f1592ab3ce48ce713d7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/14579
Tested-by: Hudson CI
Patrick Tasse [Fri, 12 Jul 2013 20:36:17 +0000 (16:36 -0400)]
tmf: Add support for event table range selection
TmfVirtualTable:
- Support the SWT.MULTI style
- Support Shift-click and Shift-key for event range selection
- Update API to support selection range
- Prevent Select All from modifying selection
- Inhibit Ctrl and Command key modifiers
TmfEventsTable:
- Create table with SWT.MULTI style
- Support selection time range
- Update status line manager with time range delta
TmfEventsEditor:
- Provide status line manager to events table
Change-Id: I16aa44f444bd1288c93b964b40e77cb04158b46d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/14522
Tested-by: Hudson CI
Patrick Tasse [Thu, 4 Jul 2013 22:09:47 +0000 (18:09 -0400)]
tmf: Add support for time range selection
Time graph:
- Add time data provider interface extension to set and get selection
range
- Support left-button drag and Shift-left-click to set selection range
- Support middle-button and Ctrl-left-button drag to move the view left
or right
- Update cursors for mouse operations
- Add support for status line display of time coordinates of cursor
position and selection range
- Update time graph time listener event for selection range
- Remove right-mouse-drag support for setting zoom range in time graph
scale
- Add interface between time graph scale and control to display drag
range decorators in scale
Signals:
- Remove current time from TmfRangeSynchSignal
- Replace current time with begin and end time in TmfTimeSynchSignal
Trace Manager:
- Update trace manager for selection range
Views:
- Update statistics viewer to use selection range instead of view range
- Update Call Stack view for selection range
- Update Histogram view for selection range
- Support Shift-click in histogram
- Update Time Chart view for selection range
- Update abstract time graph view for selection range
Change-Id: I30b215f6c6b2ed2623978e83d3b96e117eff586c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/14292
Tested-by: Hudson CI
Alexandre Montplaisir [Thu, 25 Jul 2013 20:35:24 +0000 (16:35 -0400)]
Temporary lttng-luna annotation update
Change-Id: Ie4171245af2fde9aabe14b88958959c851f33158
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Thu, 25 Jul 2013 20:31:02 +0000 (16:31 -0400)]
Merge branch 'master' into lttng-luna
Alexandre Montplaisir [Tue, 25 Jun 2013 19:03:35 +0000 (15:03 -0400)]
ctf: Rename internal CTFStrings to MetadataStrings
Rename an internal interface used for CTF Metadata so that it
doesn't clash with the upcoming public CTFStrings for use in
other plugins.
Change-Id: I4e29a6d42db4994df7a757ac27d0121367911779
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14053
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Wed, 17 Jul 2013 01:31:17 +0000 (21:31 -0400)]
tmf: Remove the Environment Variables view
The trace properties were moved to the Properties View in master
(see bug #407756), so this view is now redundant.
Change-Id: I234759618bd8edde7803ac55fa62bcd96a77ae12
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14609
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Thu, 9 May 2013 22:04:22 +0000 (18:04 -0400)]
Add timezones to preference page
Change-Id: I88281ba937889b816d846ac60a1e7c46d04ff34e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12700
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Fri, 19 Jul 2013 19:50:58 +0000 (15:50 -0400)]
tmf: Avoid a string copy when reading state intervals
HTInterval's constructor calls computeStringsEntrySize(), which
does a string copy (getBytes()) to get the real size of the string.
When reading an interval from disk, we already have this size since
it's written in the file, so we can avoid this extra copy.
Change-Id: I9f70c861ec3e94b00c9060825933826d2244bb59
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14715
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Mon, 17 Jun 2013 21:28:59 +0000 (17:28 -0400)]
tmf: Add unit tests for CTF event contexts
This required adding a new trace "kernel_vm" to the set of
downloaded traces, since we didn't have a trace with event
contexts.
Change-Id: Iee56b26b29088c3d6d017a4adcdf6e9f53bb8688
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/13991
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Tue, 2 Jul 2013 11:36:15 +0000 (07:36 -0400)]
lttng rcp: Add Trace Viewer Help plug-in
Change-Id: I2e670902c63b022fc6dd6768273accc3f1c41a2d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14238
François Rajotte [Fri, 12 Jul 2013 15:08:03 +0000 (11:08 -0400)]
Modify LTTng state provider to ignore scheduler wakeups on already-running processes
Change-Id: I537caf33c348833de65a2836138f694d80a0c4fe
Signed-off-by: François Rajotte <francois.rajotte@polymtl.ca>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14518
Tested-by: Hudson CI
Bernd Hufmann [Fri, 28 Jun 2013 20:11:38 +0000 (16:11 -0400)]
lttng: Add workspace location handling
The workspace will be created in ${user.home}/.traceviewer
instead of the default directory of an RCP.
Change-Id: Ib5b038371ffa9aa599f0ff1ec02567894060e901
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/14148
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Genevieve Bastien [Fri, 14 Jun 2013 16:22:24 +0000 (12:22 -0400)]
TMF: Add the concept of host id to a trace
This patch adds the concept of a host to a trace. By default, the host is the
name of the trace itself (so 1 trace => 1 host). For CTF traces, the clock
uuid is used to uniquely identify the host (boot session) the trace was taken
from.
Change-Id: Ie35725bc24be4ea5678c94d5ab5680e67892f4be
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/14052
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Tue, 16 Jul 2013 17:48:57 +0000 (13:48 -0400)]
tmf: Remove old event requests test
Remove an old test that was depandent on the previous scheduler
behavior (and currently fails). The new tests introduced in
cac6bb9
cover the same use cases, so the old one is now obsolete.
Change-Id: Ie7bc879599ceb981406ddf9e33729e86138bf661
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14598
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Wed, 3 Jul 2013 20:24:39 +0000 (16:24 -0400)]
lttng: Add plugins and trace type for UST traces
These plugins add support for a new "CTF : LTTng UST" trace type, which
are generated by the LTTng-UST library (and not the kernel tracer).
For now this type will be pretty much identical to the Genric CTF Trace
type, but it will allow us to eventually add UST-specific features, like
specific Events view, Statistics view, state systems, and whatnot.
Change-Id: Ic9cfc57fce8122128916444022529bc66eb84ad5
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12370
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Jean-Christian Kouamé [Wed, 10 Jul 2013 14:54:54 +0000 (10:54 -0400)]
tmf : show environment variables of traces under Experiments
Fixes bug 407756
Change-Id: Ia3576e9ad95a397ce4725d1a72eec8f8310119d6
Signed-off-by: Jean-Christian Kouamé <kadjo.gwandy.jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/14463
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Simon Delisle [Wed, 5 Jun 2013 20:20:41 +0000 (16:20 -0400)]
tmf: Introduce a scheduler for event requests
The request scheduler will increase the responsiveness of user actions.
It works with 5 slots with a specific time. It has 4 slots for
foreground
requests and 1 slot for background requests, and it passes through all
the
slots (foreground first and background after).
Example: if we have one foreground and one background request, the
foreground
request will be executed four times more often than the background
request.
Change-Id: I82dc1da60eaad92c47e015e052a69473119d7a43
Signed-off-by: Simon Delisle <simon.delisle@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/13882
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Thu, 27 Jun 2013 15:47:17 +0000 (11:47 -0400)]
tmf: Add getSubField() method to ITmfEventField
This function allows to directly get a subfield, recursively for struct and
variant fields with many levels of embedded fields. Null is returned if
any level of field is not available.
Change-Id: I46691f62036f4e9826ee5f704efda74e71725acc
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/14281
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Neil Guzman [Wed, 10 Jul 2013 13:46:18 +0000 (09:46 -0400)]
Fix sonar violations for RPM and lttng
Violations such as duplicate literals, string to string,
anon inner length, collapsible if statements, etc..
o Amend1: use NLS, fix if conditional
Change-Id: I47ac5320bfead822bc1ac470a1a80094ac063edc
Signed-off-by: Neil Guzman <nguzman@redhat.com>
Reviewed-on: https://git.eclipse.org/r/14446
Tested-by: Hudson CI
Reviewed-by: Camilo Bernal <cabernal@redhat.com>
IP-Clean: Camilo Bernal <cabernal@redhat.com>
Tested-by: Camilo Bernal <cabernal@redhat.com>
Alexandre Montplaisir [Thu, 11 Jul 2013 15:55:50 +0000 (11:55 -0400)]
lttng: Fix more API annotations
Change-Id: I5fa467efa3a53456255bb91423649e8e99bdfbf8
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14477
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Florian Wininger [Wed, 22 May 2013 23:14:44 +0000 (19:14 -0400)]
tmf: Add filtering and highlighting to the State System Explorer
Highlight on state changes.
Add a filter button to filter out non-changes completely.
Add a column with the value's type.
Change-Id: I0d206ef15e84707d9556c609ca86eda606689ff1
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/13366
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Fri, 5 Jul 2013 15:00:51 +0000 (11:00 -0400)]
tmf: Fix NPE when zooming out to full trace
Blame Sonar!
Change-Id: I85d895f564984c221c588108b0400cb7af6f0b1d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/14319
Tested-by: Hudson CI
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Fri, 5 Jul 2013 22:50:28 +0000 (18:50 -0400)]
lttng: Temporarily update @since annotations for luna
As was done during the previous cycle (
a55a176d, etc.), fake all current
@since 2.x annotations to 3.0. This will ensure that the lttng-luna branch
will keep compiling.
When we ultimately merge this branch back into a 3.0 master, we should get
API errors to indicate where the APIs are actualy 2.x.
Change-Id: I68242175132387783fc36755f8360fcff9665793
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Fri, 5 Jul 2013 22:32:21 +0000 (18:32 -0400)]
Merge branch 'master' into lttng-luna
Conflicts:
lttng/org.eclipse.linuxtools.ctf.core.tests/META-INF/MANIFEST.MF
lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFTrace.java
lttng/org.eclipse.linuxtools.ctf/feature.xml
lttng/org.eclipse.linuxtools.gdbtrace/feature.xml
lttng/org.eclipse.linuxtools.lttng2.kernel.core.tests/META-INF/MANIFEST.MF
lttng/org.eclipse.linuxtools.lttng2.kernel.core/META-INF/MANIFEST.MF
lttng/org.eclipse.linuxtools.lttng2.kernel.ui/META-INF/MANIFEST.MF
lttng/org.eclipse.linuxtools.lttng2.kernel/feature.xml
lttng/org.eclipse.linuxtools.lttng2.ui/META-INF/MANIFEST.MF
lttng/org.eclipse.linuxtools.lttng2/feature.xml
lttng/org.eclipse.linuxtools.tmf.core.tests/META-INF/MANIFEST.MF
lttng/org.eclipse.linuxtools.tmf.ui.tests/META-INF/MANIFEST.MF
lttng/org.eclipse.linuxtools.tmf/feature.xml
Change-Id: Ia2f059338062068ca4d5b7cc25d6b2ac447ebba3
Bernd Hufmann [Mon, 17 Jun 2013 12:40:57 +0000 (08:40 -0400)]
lttng: Add Trace Viewer RCP application
This commit contains 3 new projects:
- org.eclipse.linuxtools.tracing.rcp.product for the product
definition
- org.eclipse.linuxtools.tracing.rcp.ui for RCP specific UI including
branding
- org.eclipse.linuxtools.tracing.rcp feature that defines the plug-in
dependencies of the RCP
Also, the maven build has been updated to be able to build the
Trace Viewer RCP for multiple platforms.
Change-Id: I1a1cd9cfd8fa2c1adab732d1f8b9c59ada9895b9
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13849
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Wed, 3 Jul 2013 21:46:53 +0000 (17:46 -0400)]
lttng: Add a meta-plugin to run all the unit tests
Do not mention the new plugin in pom.xml's, this is for use from
within Eclipse only.
This also required changing many test plugins from fragments to
singletons, so that they can be accessed by the new separate plugin.
Change-Id: I3101e63e531dd91c9d56dc8d77175faf8645ebb1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14242
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Tue, 2 Jul 2013 14:25:46 +0000 (10:25 -0400)]
tmf : Add test to StateSystemTest
This new test will check if the very first interval gets set correctly
in certain cases. This exposed a bug with in-memory backends, which
was fixed in
9898079defaa94bc3f0cf60dc89b1e863ac304da.
Change-Id: I2c79530091eae5f761fa945214b9f46e1cc4457b
Signed-off-by: Jean-Christian Kouamé
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14116
Tested-by: Hudson CI
Jean-Christian Kouamé [Fri, 17 May 2013 16:04:01 +0000 (12:04 -0400)]
CTF : Handle traces with events without eventID
Bug 387039 : First, the eventID was set to null when the event was
created. We change it for -2 as default value when not set. Then, we
must change the way to look for packetIndexEntry to adapt it to the
particular case where there are many packetIndexEntry with the same
timestamp.
Change-Id: Ia3bf16cc1013e41c18b5305978d1b99c30624bdc
Signed-off-by: Jean-Christian Kouame
Reviewed-on: https://git.eclipse.org/r/12949
Tested-by: Hudson CI
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Simon Delisle [Thu, 9 May 2013 16:58:54 +0000 (12:58 -0400)]
Ctf: Callsite bug fix when position is negative (binarySearch)
Change-Id: Id1fdb06c717299f7b0fa8ad0576485d35003ce2b
Signed-off-by: Simon Delisle <simon.delisle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/14109
Tested-by: Hudson CI
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Jean-Christian Kouamé [Tue, 14 May 2013 22:03:57 +0000 (18:03 -0400)]
ctf: Move integer pretty-printing to IntegerDefinition
Fixes bug 408046.
Change-Id: I4836f2026c70969a1d479cea2c66ef846cc95752
Signed-off-by: Jean-Christian Kouame
Reviewed-on: https://git.eclipse.org/r/14089
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Roland Grunberg [Mon, 24 Jun 2013 16:55:10 +0000 (12:55 -0400)]
Remove unused sourceTemplateFeature folder from projects.
Change-Id: I0d21d891f61096e024a2c40607fa4a1dfd7e31df
Reviewed-on: https://git.eclipse.org/r/14239
Tested-by: Hudson CI
Reviewed-by: Camilo Bernal <cabernal@redhat.com>
IP-Clean: Camilo Bernal <cabernal@redhat.com>
Tested-by: Camilo Bernal <cabernal@redhat.com>
Alexandre Montplaisir [Wed, 3 Jul 2013 19:07:37 +0000 (15:07 -0400)]
Revert "tmf: Add null annotations to tmf.core.statevalue"
This reverts commit
ba0b892f5a0ec84996f4ef3ed9faa09a034c542d.
This breaks compatibility with Eclipse < 3.8, which we'd like to have for a bit. Revert it temporarily until we can deal with it better.
Change-Id: I900a45d80f1c97aef9cc638db15afac212802b6d
Reviewed-on: https://git.eclipse.org/r/14237
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Roland Grunberg [Mon, 24 Jun 2013 16:15:03 +0000 (12:15 -0400)]
Provide necessary licensing files in features using license-feature.
Create org.eclipse.linuxtools.license.feature which packages
epl-v10.html and license.html files. Reference this feature using
'license-feature' in other features to have the necessary files appear
in binary/source features.
Change-Id: I2fd6ea0bbe47b290625920c0bf5edd35c5d360c4
Reviewed-on: https://git.eclipse.org/r/14014
Tested-by: Hudson CI
Reviewed-by: Camilo Bernal <cabernal@redhat.com>
IP-Clean: Camilo Bernal <cabernal@redhat.com>
Tested-by: Camilo Bernal <cabernal@redhat.com>
Bernd Hufmann [Fri, 28 Jun 2013 12:45:55 +0000 (08:45 -0400)]
Fix warnings about deprecated parameter in ant tasks of POM files
Change-Id: I6d50ee19547e7e40d4f57d9eca6fb88b0a29a0e4
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/14132
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Wed, 29 May 2013 21:01:01 +0000 (17:01 -0400)]
tmf: Add null annotations to tmf.core.statevalue
Introduce the use of the new amazingly-useful JDT Null Analysis
annotations. See http://wiki.eclipse.org/JDT_Core/Null_Analysis
Let's start by something small and isolated, like the TMF state
values.
Change-Id: I8ab350352ba330e8bd55d1da3a7f8c0f9db2edc8
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14084
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jean-Christian Kouamé [Fri, 17 May 2013 20:14:02 +0000 (16:14 -0400)]
tmf: Show trace environment variables in the Properties view
Fixes bug 407756
Change-Id: Ie90a3094ea8adc335a82182127d7bc0e3b727616
Signed-off-by: Jean-Christian Kouame
Reviewed-on: https://git.eclipse.org/r/12829
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Geneviève Bastien [Wed, 1 May 2013 18:34:21 +0000 (14:34 -0400)]
TMF: Consolidate some view code into the AbstractTimeGraphView
This new view is a base view for all views using the TimeGraphCombo widget.
As a first step, the lttng2 kernel Control flow view and Resources view have
been modified to extend this abstract view.
Mostly all of the interface management code (build thread, zoom thread, signal
handling, etc) is in the base class. Final views need only implement to code
to fill the entries' list and events.
This patch includes:
- The abstract view class that all new time graph views may extend. The default
weight of each sash can be set in the child view.
- A TimeGraphEntry class that can be used as is if the view does not require
extra data of its entries
- Modification of the TimeEvent class to add a value to it.
- Added a ITimeGraphDrawingHelper interface to pass to the presentation
providers to help them get the information they need to know where to draw
some things (see ResourcesPresentationProvider)
It is a first step before adding new features to the time graph views. Some
more abstraction may need to be done as well as other reorganizing of the
code.
Also updated for the 2.1 API, added a ITimeGraphPresentationProvider2 interface
to avoid API breakage.
Change-Id: I73c9f1b4bf8ec265f1b02804fa7f819bd2b8dd7a
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/12423
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Jean-Christian Kouame [Fri, 28 Jun 2013 19:06:35 +0000 (15:06 -0400)]
tmf : Fix binary search end time in InMemoryBackend
first interval was not always considered in memory backend request
Change-Id: I3741d182d362da835a08a1771fa87421744c9fff
Signed-off-by: Jean-Christian Kouame
Reviewed-on: https://git.eclipse.org/r/14117
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Wed, 26 Jun 2013 18:17:30 +0000 (14:17 -0400)]
tmf: Fix fake event problem in AbstractTmfStateProvider
For a given state provider, if the last event modifies the state
AND the user calls .waitForEmptyQueue() right before closing the
tree manually, the resulting history would have an incorrect end
time and it would be impossible to query at the timestamp of the
last event.
This was due do a "fake" synchronization event being set as the
provider's current event, so when closing the history it would
use its time stamp which is effectively 0.
Remedy this by using an internal event class explicitely for this.
Thanks to J.-C. Kouamé for finding this one!
Change-Id: I06227ca656a67991966b1d1dd15330cb97754fbe
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/14080
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Geneviève Bastien [Fri, 17 May 2013 20:11:33 +0000 (16:11 -0400)]
TMF: Add functions to verify if events are present in a CTF Trace
These functions verify whether one, some or all events are present in the
metadata of a CTF trace. It is useful to verify the presence of events
before doing an analysis that requires them.
Change-Id: Ieed7f9bcd905bf354aa5550b10c6304e534e5728
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/12952
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Simon Delisle [Tue, 21 May 2013 19:22:27 +0000 (15:22 -0400)]
ctf: Fix formatting in CTFTrace
Change-Id: I416204b08281e0bb66b5c1389a4ec03b247a2828
Signed-off-by: Simon Delisle <simon.delisle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13032
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Matthew Khouzam [Fri, 21 Jun 2013 20:02:36 +0000 (16:02 -0400)]
ctf: Fix seek bug with multi-threaded access
Store the map of event definitions per stream reader, not per
trace. This allows multiple parallel stream readers to work
correctly (same with multiple CtfIterator's).
Fixes bug #405411.
Change-Id: I43e4e05b5d8313410905e90cb23badbd1d54b9f8
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/13994
Matthew Khouzam [Tue, 25 Jun 2013 21:51:40 +0000 (17:51 -0400)]
ctf: Fix race condition in ctfiterator
You could advance an event while seeking, that is no longer possible
performance droped from 78000 events/s reading to 75000 events/s.
Potential hazard, threads can access the iterator and advance and seek
concurently. This is allowed by design, it's an iterator, it should be
wrapped in a safer candy coated shell so it doesn't melt in you hands.
Change-Id: I4df50389728f075f15312107f44847d61343366e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/14060
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Fri, 21 Jun 2013 21:37:57 +0000 (17:37 -0400)]
lttng: Update plugins version to 3.0 for the Luna branch
Change-Id: I5b50cea6f0d0005a673e58b4cc8dba69c671dfe4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Thu, 20 Jun 2013 17:26:26 +0000 (13:26 -0400)]
lttng: Update plugins version to 2.1
(Pushed manually because Hudson CI was broken and veto-ing
any patch coming in...)
Change-Id: I60239715e771d6028ac0d7faa27aca7e30ac5d4a
Reviewed-on: https://git.eclipse.org/r/13962
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Roland Grunberg [Fri, 21 Jun 2013 18:18:37 +0000 (14:18 -0400)]
Revert "Bug 410367 - Add 'about.html' to 'src.includes'"
This reverts commit
398abd136aed831685ffca11ae2d6eba944e3a4b.
Jeff Johnston [Wed, 19 Jun 2013 19:54:22 +0000 (15:54 -0400)]
Bug 410367 - Add 'about.html' to 'src.includes'
- Fix feature source templates to get epl and license files included too.
- Fix tools.launch.ui, libhover.newlib, and rdt.proxy plugins to include
about.html with binary jar.
Change-Id: I39a122a2cd74c7244ea3635f80cf14346dbe5ae6
Reviewed-on: https://git.eclipse.org/r/13960
Tested-by: Hudson CI
Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
IP-Clean: Roland Grunberg <rgrunber@redhat.com>
Tested-by: Roland Grunberg <rgrunber@redhat.com>
Alexandre Montplaisir [Thu, 20 Jun 2013 15:51:06 +0000 (11:51 -0400)]
tmf: Removed unused import
Change-Id: I93c22dbcd3b46ceba99e752dc8edf05f8ae34a8f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Tue, 18 Jun 2013 19:05:11 +0000 (15:05 -0400)]
Set JavaSE-1.6 Execution Environment in project Java Build Path
Change-Id: Ifebefd7070db0f2b9a364c2e4d75748ad6918a11
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/13881
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Jeff Johnston [Tue, 18 Jun 2013 20:49:47 +0000 (16:49 -0400)]
Bug 410367 - Add 'about.html' to 'src.includes'.
Change-Id: Id599a09aa6d1c3dfae20164a3200c88ea732e26f
Reviewed-on: https://git.eclipse.org/r/13885
Tested-by: Hudson CI
Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
IP-Clean: Roland Grunberg <rgrunber@redhat.com>
Tested-by: Roland Grunberg <rgrunber@redhat.com>
Bernd Hufmann [Fri, 7 Jun 2013 20:43:15 +0000 (16:43 -0400)]
tmf: Add guide about optional trace type attributes
Change-Id: Ic348fef1ead049688d819a51fdea6bb95f6ec01c
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13661
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Matthew Khouzam [Fri, 7 Jun 2013 21:31:05 +0000 (17:31 -0400)]
tmf: Update batch import wizard messages
Change-Id: I591682a1f0785f2a310a62c9d00e59bccce5b043
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/13663
Patrick Tasse [Fri, 7 Jun 2013 20:02:00 +0000 (16:02 -0400)]
Fix description of tracetype defaultEditor id attribute
Change-Id: I1f3dd838c3d0e3c92300d87fc262593beee030b3
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/13659
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Patrick Tasse [Fri, 7 Jun 2013 15:58:01 +0000 (11:58 -0400)]
Rename TMF User Guide to Developer Guide and reorder sections
Change-Id: I6ebb946009c1396aaf15685a709c4aadf0ea6c2a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/13655
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
This page took 0.046496 seconds and 5 git commands to generate.