Mark Kettenis [Wed, 1 Mar 2000 00:45:18 +0000 (00:45 +0000)]
2000-03-01 Mark Kettenis <kettenis@gnu.org>
* MAINTAINERS: Correct my own mail address.
Andrew Cagney [Wed, 1 Mar 2000 00:28:35 +0000 (00:28 +0000)]
Identify maintainers caught up in a paper trail.
H.J. Lu [Tue, 29 Feb 2000 19:52:31 +0000 (19:52 +0000)]
2000-02-29 H.J. Lu <hjl@gnu.org>
* Makefile.am (check-DEJAGNU): Also pass LIBS="$(LIBS)".
Set LC_COLLATE and LC_ALL to null and export them. It is for
sort which expects the C locale.
Add $(LIBS) to all $(HOSTING_LIBS).
* Makefile.in: Rebuild.
Andrew Cagney [Tue, 29 Feb 2000 13:53:59 +0000 (13:53 +0000)]
From Peter Schauer: Fix Solaris/x86 threads by copying linux code.
Andrew Cagney [Tue, 29 Feb 2000 13:38:55 +0000 (13:38 +0000)]
From Peter Schauer: Define Solaris/x86 MERGEPID.
Andrew Cagney [Tue, 29 Feb 2000 13:28:24 +0000 (13:28 +0000)]
From J.T.: Convert i386 to updated frame_saved_regs.
Andrew Cagney [Tue, 29 Feb 2000 12:58:51 +0000 (12:58 +0000)]
From Peter Schauer - fix mmalloc bitrot.
Andrew Cagney [Tue, 29 Feb 2000 08:16:40 +0000 (08:16 +0000)]
From Eli. Bring go32 target up-to-date with recent GDB i386 changes.
Andrew Cagney [Tue, 29 Feb 2000 07:45:13 +0000 (07:45 +0000)]
From Eli. Warning fixes.
Andrew Cagney [Tue, 29 Feb 2000 07:23:02 +0000 (07:23 +0000)]
Include <ctype.h> for isupper().
Andrew Cagney [Tue, 29 Feb 2000 07:17:15 +0000 (07:17 +0000)]
Add more checks for no stack frame.
Alan Modra [Tue, 29 Feb 2000 05:53:53 +0000 (05:53 +0000)]
GCC warning fix: Add missing NULL initialiser for find_potential_libraries.
Andrew Cagney [Tue, 29 Feb 2000 05:10:04 +0000 (05:10 +0000)]
Read 2 byte (16 bit addresses) when needed.
Christopher Faylor [Tue, 29 Feb 2000 04:11:24 +0000 (04:11 +0000)]
Fix a typo.
Jim Blandy [Tue, 29 Feb 2000 03:29:27 +0000 (03:29 +0000)]
*** empty log message ***
Jim Blandy [Tue, 29 Feb 2000 03:28:57 +0000 (03:28 +0000)]
* ldgram.y (exclude_name_list): Don't require a comma to separate
list entries; the lexer considers commas to be valid part of a
filename, so in something like `foo, bar' the comma is considered
part of the first filename, `foo,'.
* ld.texinfo: Update section on EXCLUDE_FILE lists.
Jim Blandy [Mon, 28 Feb 2000 23:17:16 +0000 (23:17 +0000)]
*** empty log message ***
Scott Bambrough [Mon, 28 Feb 2000 20:51:08 +0000 (20:51 +0000)]
Update copyright date in file.
Scott Bambrough [Mon, 28 Feb 2000 20:28:10 +0000 (20:28 +0000)]
2000-02-28 Scott Bambrough <scottb@netwinder.org>
* config/arm/linux.mh (NATDEPFILES): Removed core-regset.o.
Not used. Required to get GDB to build on glibc 2.1.3.
* config/arm/tm-linux.h (LOWEST_PC): Undefine LOWEST_PC
before redefining. Gets rid of compiler warning.
Scott Bambrough [Mon, 28 Feb 2000 20:17:16 +0000 (20:17 +0000)]
2000-02-28 Scott Bambrough <scottb@netwinder.org>
* arm-linux-nat.c (fetch_nw_fpe_*):
Renamed to fetch_nwfpe_* to use the same naming convention
as in the Linux kernel. Modified prototype to get rid of
unused parameters.
(store_nw_fpe_*): Renamed to store_nwfpe_* to use the same
naming convention as in the Linux kernel. Fixed calls to
fetch_nwfpe_*.
(store_fpregs): Fixed calls to store_nwfpe_*. Removed
unused variable.
Nick Clifton [Mon, 28 Feb 2000 18:57:53 +0000 (18:57 +0000)]
Defone {MIPS|SH}_PE_MAGIC
Nick Clifton [Mon, 28 Feb 2000 18:56:11 +0000 (18:56 +0000)]
Add WinCE support.
Nick Clifton [Mon, 28 Feb 2000 17:57:40 +0000 (17:57 +0000)]
Replace 'flags' with 'signed_overflow_ok_p'
Andrew Cagney [Mon, 28 Feb 2000 07:27:52 +0000 (07:27 +0000)]
Oops. Fix e-mail address.
Andrew Cagney [Mon, 28 Feb 2000 07:26:14 +0000 (07:26 +0000)]
Transfer d30v to David Taylor.
Christopher Faylor [Mon, 28 Feb 2000 06:43:20 +0000 (06:43 +0000)]
* win32-nat.c: Remove unneeded header.
* wince.c: Ditto.
Christopher Faylor [Mon, 28 Feb 2000 06:34:14 +0000 (06:34 +0000)]
Eliminate debugging argument.
Christopher Faylor [Mon, 28 Feb 2000 06:31:36 +0000 (06:31 +0000)]
Correct copyright.
Andrew Cagney [Mon, 28 Feb 2000 05:03:09 +0000 (05:03 +0000)]
Include "gdb_wait.h" instead of "wait.h".
Ian Lance Taylor [Mon, 28 Feb 2000 04:31:30 +0000 (04:31 +0000)]
2000-02-27 Loren J. Rittle <ljrittle@acm.org>
* configure.host: Added HOSTING_CRT0, HOSTING_LIBS for
host "i[3456]86-*-freebsdelf*".
Ian Lance Taylor [Mon, 28 Feb 2000 04:20:22 +0000 (04:20 +0000)]
2000-02-27 Andreas Jaeger <aj@suse.de>
* configure.in: Add entry for mips*-*-linux*, move catch all
*-*-*linux* entry below this one.
Ian Lance Taylor [Mon, 28 Feb 2000 04:17:36 +0000 (04:17 +0000)]
2000-02-27 Thomas de Lellis <tdel@windriver.com>
* config/obj-elf.c (elf_frob_symbol): Remove code which when
TC_PPC was defined forced the type of a symbol with no other type
to be BSF_OBJECT.
Ian Lance Taylor [Mon, 28 Feb 2000 04:08:32 +0000 (04:08 +0000)]
2000-02-27 Hans-Peter Nilsson <hp@axis.com>
* doc/internals.texi (CPU backend): Mention that
line_separator_chars do not break up comments. Fix typos for
LEX_AT and LEX_NAME descriptions. Document operands for
TC_EQUAL_IN_INSN, md_operand and md_section_align. Correct
description of md_create_short_jump usage. Document argument for
md_undefined_symbol.
Ian Lance Taylor [Mon, 28 Feb 2000 03:55:16 +0000 (03:55 +0000)]
2000-02-27 Mark Elbrecht <snowball3@bigfoot.com>
* scripttempl/i386go32.sc: Move misplaced semicolons.
Ian Lance Taylor [Mon, 28 Feb 2000 03:51:32 +0000 (03:51 +0000)]
2000-02-27 Jakub Jelinek <jakub@redhat.com>
* config/tc-sparc.c (OPTION_UNDECLARED_REGS): New option.
(md_parse_option): Handle it.
(md_show_usage): Document it.
Ian Lance Taylor [Mon, 28 Feb 2000 03:50:32 +0000 (03:50 +0000)]
2000-02-27 Jakub Jelinek <jakub@redhat.com>
* elf32-sparc.c (elf32_sparc_merge_private_bfd_data): Don't bump
architecture if the object causing the bump is dynamic.
* elf64-sparc.c (sparc64_elf_merge_private_bfd_data): Likewise,
and also don't it for memory ordering.
(sparc64_elf_write_relocs): Take src_rela out of the loop.
Ian Lance Taylor [Mon, 28 Feb 2000 03:39:28 +0000 (03:39 +0000)]
* dwarf2.c (read_abbrevs): Use _raw_size directly rather than
calling bfd_get_section_size_before_reloc.
(decode_line_info): Likewise.
(_bfd_dwarf2_find_nearest_line): Likewise.
Ian Lance Taylor [Mon, 28 Feb 2000 03:31:50 +0000 (03:31 +0000)]
From Brad Lucier <lucier@math.purdue.edu>:
* readelf.c (process_dynamic_segment): Add cast to make sure
argument to %* is int.
Ian Lance Taylor [Mon, 28 Feb 2000 03:25:35 +0000 (03:25 +0000)]
* config/tc-alpha.c (md_assemble): Accept `1' and `9' in an
opcode, for the instruction `pal19'. From Andrea Arcangeli
<andrea@suse.de>.
Andrew Cagney [Mon, 28 Feb 2000 00:22:03 +0000 (00:22 +0000)]
Add MAINTAINERS file to mmalloc directory - part of GDB and maintained
by GDB's Host maintainers.
H.J. Lu [Sun, 27 Feb 2000 18:59:40 +0000 (18:59 +0000)]
2000-02-27 H.J. Lu (hjl@gnu.org)
* lib/ld-lib.exp (default_ld_link): Added "$LIBS" to libs.
Ian Lance Taylor [Sun, 27 Feb 2000 17:08:06 +0000 (17:08 +0000)]
2000-02-27 Eli Zaretskii <eliz@is.elta.co.il>
* Makefile.am (stamp-lib): Use $(LIBTOOL) --config to get the
name of the libtool directory.
* Makefile.in: Rebuild.
Ian Lance Taylor [Sun, 27 Feb 2000 16:55:52 +0000 (16:55 +0000)]
rebuild with current tools
Ian Lance Taylor [Sun, 27 Feb 2000 16:46:19 +0000 (16:46 +0000)]
* ltconfig, ltmain.sh: Update to libtool 1.3.4.
Mark Kettenis [Sat, 26 Feb 2000 15:04:30 +0000 (15:04 +0000)]
2000-02-26 Mark Kettenis <kettenis@gnu.org>
* gnu-nat.c: Include "gdbthread.h". Include <hurd.h>.
Reorder headers a bit. Overall cleanup and minor reformatting.
(MIG_SERVER_DIED): Remove define.
(proc_update_sc): Add braces to silence compiler warning.
(proc_steal_exc_port): Initialize err to zero.
(make_proc): Add braces to silence compiler warning.
(inf_validate_task_sc): Add cast to silence compiler warning.
(inf_set_traced): Reorganize a bit to silence compiler warning.
(inf_validate_procs): Use mach_msg_type_number_t for all thread
numbers and add braces to silence compiler warning.
(gnu_wait): Add prototypes for server functions and add braces to
silence compiler warnings.
(S_exception_raise_request): Pass subcode to inf_debug call.
(gnu_write_inferior): Remove unused variable `protection_changed'.
(gnu_xfer_memory): Remove unused variable `result'.
(set_sig_thread_cmd): Remove unused varible `tid'.
(set_signals_cmd): Remve unused variable `trace'.
(add_task_commands): Provide complete prototype. Reformat help
strings a bit to make sure the first line is a full sentence.
Call info_port_rights_cmd instead of info_send_rights_cmd for the
"info port-rights" command.
(add_thread_commands): Provide complete prototype. Make static.
Reformat help strings a bit to make sure the first line is a full
sentence.
(_initialize_gnu_nat): Provide complete prototype.
Mark Kettenis [Sat, 26 Feb 2000 13:57:35 +0000 (13:57 +0000)]
2000-02-26 Mark Kettenis <kettenis@gnu.org>
Make cross-compilation for the Hurd more friendly.
From Jeff Bailey <jbailey@gnu.org>:
* configure.in: Use AC_CHECK_TOOL to find MiG.
* Makefile.in (MIG): New variable.
* config/i386/i386gnu.mh (MIG): Remove.
* configure: Regenerated.
Mark Kettenis [Sat, 26 Feb 2000 13:46:56 +0000 (13:46 +0000)]
2000-02-26 Mark Kettenis <kettenis@gnu.org>
Make cross-compilation for the Hurd more friendly.
From Jeff Bailey <jbailey@gnu.org>:
* configure.in: Use AC_CHECK_TOOL to find MiG.
* Makefile.in (MIG): New variable.
* config/i386/i386gnu.mh (MIG): Remove.
* configure: Regenerated.
Kevin Buettner [Sat, 26 Feb 2000 09:30:30 +0000 (09:30 +0000)]
Changes to skip_prologue for PPC architecture.
Kevin Buettner [Sat, 26 Feb 2000 09:25:50 +0000 (09:25 +0000)]
Add comment explaining ppc_linux_memory_remove_breakpoint ().
Andrew Cagney [Sat, 26 Feb 2000 06:20:56 +0000 (06:20 +0000)]
Jim Blandy has always been the trace stuff maintainer. Extend Chris
Faylor's reponsibilities to cover most Windows platforms.
Alan Modra [Sat, 26 Feb 2000 04:00:13 +0000 (04:00 +0000)]
Catch some more cases where we can represent a 16 bit immediate operand as
8 bit sign extended.
Ian Lance Taylor [Sat, 26 Feb 2000 03:38:18 +0000 (03:38 +0000)]
* Makefile.am (ALL_EMULATIONS): Remove ehppaelf.o.
(ALL_64_EMULATIONS): Remove eelf64hppa.o.
(eelf64hppa.c, ehppaelf.c): Remove targets.
* Makefile.in: Rebuild.
Ian Lance Taylor [Sat, 26 Feb 2000 03:28:41 +0000 (03:28 +0000)]
rebuild
Jeff Law [Sat, 26 Feb 2000 01:48:35 +0000 (01:48 +0000)]
* doc/c-mips.texi (MIPS Opts): Fix typo in last patch.
Jeff Law [Sat, 26 Feb 2000 01:45:22 +0000 (01:45 +0000)]
* som.c (SOM_HOWTO): Define.
(som_hppa_howto_table): Use it.
H.J. Lu [Sat, 26 Feb 2000 00:59:51 +0000 (00:59 +0000)]
2000-02-25 H.J. Lu <hjl@gnu.org>
* configure.in (AC_SEARCH_LIBS): Pass m, not -lm.
H.J. Lu [Sat, 26 Feb 2000 00:49:27 +0000 (00:49 +0000)]
2000-02-25 H.J. Lu <hjl@gnu.org>
* gas/i386/general.l: Support a.out and coff.
H.J. Lu [Sat, 26 Feb 2000 00:47:52 +0000 (00:47 +0000)]
2000-02-25 H.J. Lu <hjl@gnu.org>
* configure.in (AC_SEARCH_LIBS): Pass lm, not -lm.
Alexandre Oliva [Fri, 25 Feb 2000 19:43:12 +0000 (19:43 +0000)]
* configure.tgt (targ_extra_ofiles): Enable elf64_sparc on
GNU/Linux/sparc, but keep the default as 32.
Alexandre Oliva [Fri, 25 Feb 2000 19:39:00 +0000 (19:39 +0000)]
* config.bfd: Enable 64 bit support for GNU/Linux/sparc.
Alexandre Oliva [Fri, 25 Feb 2000 19:30:22 +0000 (19:30 +0000)]
* configure.tgt: Enable elf64_sparc on Solaris7+/sparc. And make
it default if sparcv9 or sparc64.
Alexandre Oliva [Fri, 25 Feb 2000 19:18:17 +0000 (19:18 +0000)]
* config.bfd: Enable 64 bit support for Solaris7+/sparc.
Fernando Nasser [Fri, 25 Feb 2000 16:37:32 +0000 (16:37 +0000)]
2000-02-25 Fernando Nasser <fnasser@cygnus.com>
From: Thomas Zenker <thz@Lennartz-electronic.DE>
* rdi-share/hsys.c: to compile under 4.4BSD derived systems (FreeBSD,
NetBSD...) sys_errlist should not be declared in hsys.c.
NEED_SYSERRLIST is set already by configure, so we can use it.
* rdi-share/unixcomm.c: 4.4BSD derived systems define BSD, but are
posix compliant and we should not work with the old compatibility
stuff. Because of that I undef BSD in case of FBSD etc and include
sys/ioctl to get the flags.
* rdi-share/unixcomm.c: If the TIOCEXCL flags exists set serial line
for exclusive use.
Alan Modra [Fri, 25 Feb 2000 11:55:50 +0000 (11:55 +0000)]
Fix silly thinko in gas/i386/intel.s Mention i386.exp in ChangeLog
Alan Modra [Fri, 25 Feb 2000 11:41:12 +0000 (11:41 +0000)]
Extend the i386 gas testsuite to do some tests for intel_syntax. Fix all
the errors exposed by this addition. These were intel mode
"fi... word ptr", "fi... dword ptr", "jmp Imm seg, Imm offset", "out dx,al".
The failure with intel "out dx,al" was also present in att "out al,dx".
Extend testsuite to catch this case too.
Nick Clifton [Thu, 24 Feb 2000 23:58:52 +0000 (23:58 +0000)]
Add functions to modify/examine the signed_overflow_ok_p field in cpu_desc.
Nick Clifton [Thu, 24 Feb 2000 23:57:23 +0000 (23:57 +0000)]
Rename 'flags' to 'signed_overflow_ok_p'
Kevin Buettner [Thu, 24 Feb 2000 23:06:48 +0000 (23:06 +0000)]
Shared library, function calling fixes for GNU/Linux PPC port.
Andrew Haley [Thu, 24 Feb 2000 21:56:53 +0000 (21:56 +0000)]
2000-02-24 Andrew Haley <aph@cygnus.com>
* cgen.h (CGEN_INSN_MACH_HAS_P): New macro.
(CGEN_CPU_TABLE): flags: new field.
Add prototypes for new functions.
Nick Clifton [Thu, 24 Feb 2000 21:49:15 +0000 (21:49 +0000)]
fix typo in previous delta
Christopher Faylor [Thu, 24 Feb 2000 21:39:15 +0000 (21:39 +0000)]
Windows CE support.
Nick Clifton [Thu, 24 Feb 2000 21:20:57 +0000 (21:20 +0000)]
Add support for an OS of "wince"
Nick Clifton [Thu, 24 Feb 2000 19:49:18 +0000 (19:49 +0000)]
Add support for WinCE targeted toolchains.
Nick Clifton [Thu, 24 Feb 2000 19:37:32 +0000 (19:37 +0000)]
Add support for WinCE targeted toolchains.
Nick Clifton [Thu, 24 Feb 2000 17:53:12 +0000 (17:53 +0000)]
Add support for WinCE based toolchains.
Andrew Haley [Thu, 24 Feb 2000 16:19:36 +0000 (16:19 +0000)]
2000-02-23 Andrew Haley <aph@cygnus.com>
* m32r-asm.c, m32r-desc.c, m32r-desc.h, m32r-dis.c,
m32r-ibld.c,m32r-opc.h: Rebuild.
Alan Modra [Thu, 24 Feb 2000 15:26:57 +0000 (15:26 +0000)]
Yet more .intel_syntax fixes.
Catherine Moore [Thu, 24 Feb 2000 13:41:02 +0000 (13:41 +0000)]
* som.c (som_misc_symbol_info): Add field
secondary_def.
(som_bfd_derive_misc_symbol_info): Initialize
secondary_def.
(som_build_and_write_symbol_table): Keep track
of secondary_def field.
(som_slurp_symbol_table): Set BSF_WEAK symbol flag
if secondary_def field is set.
(som_bfd_ar_write_symbol_stuff): Initialize
secondary_def.
Catherine Moore [Thu, 24 Feb 2000 13:37:02 +0000 (13:37 +0000)]
* config/obj-som.c (obj_pseudo_table): Add "weak".
(obj_som_weak): New routine.
Alan Modra [Thu, 24 Feb 2000 12:41:54 +0000 (12:41 +0000)]
Forgot Changelog for last i386.h change.
Alan Modra [Thu, 24 Feb 2000 12:40:45 +0000 (12:40 +0000)]
Correct intel_syntax fsub* and fdiv* handling. Oh, how I'd like to be rid
of UNIXWARE_COMPAT.
Andrew Cagney [Thu, 24 Feb 2000 08:55:15 +0000 (08:55 +0000)]
Include "gdb_wait.h" instead of <wait.h>.
Alan Modra [Thu, 24 Feb 2000 08:18:20 +0000 (08:18 +0000)]
config/tc-i386.c (struct _i386_insn): Combine disps, imms, regs into
a union. Use throughout file. Delete TC_RELOC macro.
Andrew Cagney [Thu, 24 Feb 2000 08:16:26 +0000 (08:16 +0000)]
Only install GDBtk files when GDBtk is being built.
Andrew Cagney [Thu, 24 Feb 2000 07:27:51 +0000 (07:27 +0000)]
* configure.in (SUBDIR_MI_CFLAGS): Fix typo, wrong brace.
Andrew Cagney [Thu, 24 Feb 2000 05:38:51 +0000 (05:38 +0000)]
* config.guess, config.sub: Updated to match config's 2000-02-15
version.
Christopher Faylor [Thu, 24 Feb 2000 03:31:45 +0000 (03:31 +0000)]
* configure.tgt: Add arm, mips, sh wince targets.
* config/arm/tm-wince.h: New file.
* config/arm/wince.mt New file.
* config/sh/tm-wince.h: New file.
* config/sh/wince.mt New file.
* config/mips/tm-wince.h: New file.
* config/mips/wince.mt New file.
* wince.c: New file.
* wince-stub.c: New file.
* wince-stub.h: New file.
* sh-tdep.c: Use correct register names for Windows CE.
Alan Modra [Thu, 24 Feb 2000 01:56:31 +0000 (01:56 +0000)]
Remove dead code when not TC_M68K.
Alan Modra [Thu, 24 Feb 2000 01:40:42 +0000 (01:40 +0000)]
Mention IBM 370 support
Richard Henderson [Thu, 24 Feb 2000 00:43:29 +0000 (00:43 +0000)]
* config/tc-i386.c (md_assemble): When swapping operands for
intel_syntax, assume everything that's not Imm or Disp is a
register.
Nicholas Duffek [Thu, 24 Feb 2000 00:04:03 +0000 (00:04 +0000)]
* top.c (SIGJMP_BUF, SIGSETJMP, SIGLONGJMP): Update comments.
(error_return, quit_return): Merge into catch_return pointer.
(return_to_top_level): Update comment. Longjmp to *catch_errors,
and communicate reason to catch_errors via setjmp return value.
(catch_errors): Always catch both quit and error, and if a catch
wasn't requested by caller, throw it to the next catch_error.
Replace dual longjmp buffer memcpy with single pointer change.
Add FIXME for possibly adding new interface to tell caller what
event was caught. Add extensive comments.
* defs.h (enum return_reason): Reserve 0 for use as initial
setjmp() return value.
(RETURN_MASK): New public macro to generate RETURN_MASK_* from
enum return_reason.
(RETURN_MASK_QUIT, RETURN_MASK_ERROR): Define using RETURN_MASK.
Richard Henderson [Wed, 23 Feb 2000 23:38:47 +0000 (23:38 +0000)]
* scripttempl/elfd10v.sc: Remove dynamic linking hooks.
Add and use memory regions.
Alan Modra [Wed, 23 Feb 2000 23:19:46 +0000 (23:19 +0000)]
Teach get_osabi_name about Linux
Nick Clifton [Wed, 23 Feb 2000 22:29:38 +0000 (22:29 +0000)]
fix typo in previous delta
Nick Clifton [Wed, 23 Feb 2000 22:27:55 +0000 (22:27 +0000)]
Accept 16-bit addresses.
Jim Blandy [Wed, 23 Feb 2000 22:11:07 +0000 (22:11 +0000)]
Doc fix.
Jim Blandy [Wed, 23 Feb 2000 19:46:25 +0000 (19:46 +0000)]
*** empty log message ***
Jim Blandy [Wed, 23 Feb 2000 19:45:45 +0000 (19:45 +0000)]
* gdbint.texinfo (FUNCTION_START_OFFSET): Document.
Timothy Wall [Wed, 23 Feb 2000 16:01:21 +0000 (16:01 +0000)]
Add new feature notices for changes made on 2/8 and 2/10/00.
Fernando Nasser [Wed, 23 Feb 2000 15:53:33 +0000 (15:53 +0000)]
2000-02-23 Fernando Nasser <fnasser@cygnus.com>
* infcmd.c (run_stack_dummy): Do not pop frame on random signal.
* valops.c (_initialize_valops): Add command "set unwindonsignal".
(hand_function_call): Test for unwind_on_signal and act accordingly.
This page took 0.038529 seconds and 4 git commands to generate.